Skip to contentSkip to conversation

be2net: Fix memory leak in be_cmd_get_profile_config()

PATCH Applied Petr Oros 3 participants 3 messages Sep 5, 2018

Subsystems (3)
lore
Share & tools
lore

Petr Oros

author
#0 lore raw

PATCH 1/1 be2net: Fix memory leak in be_cmd_get_profile_config()

DMA allocated memory is lost in be_cmd_get_profile_config() when we call it with non-NULL port_res parameter.

---
 drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/emulex/benet/be_cmds.c +1 -1
index ff92ab1daeb8..1e9d882c04ef 100644
@@ -4500,7 +4500,7 @@ int be_cmd_get_profile_config(struct be_adapter *adapter,
 				port_res->max_vfs += le16_to_cpu(pcie->num_vfs);
 			}
 		}
-		return status;
+		goto err;
 	}
 
 	pcie = be_get_pcie_desc(resp->func_param, desc_count,
Signature · 1 line
2.16.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Petr Oros

DMA allocated memory is lost in be_cmd_get_profile_config() when we call it with non-NULL port_res parameter.

---
 drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/emulex/benet/be_cmds.c +0 -0
index ff92ab1daeb8..1e9d882c04ef 100644

drivers/net/ethernet/emulex/benet/be_cmds.c int be_cmd_get_profile_config(struct be_adapter *adapter, · line 4506

Quoted 8 lines
drivers/net/ethernet/emulex/benet/be_cmds.c +1 -1
@@ -4500,7 +4500,7 @@ int be_cmd_get_profile_config(struct be_adapter *adapter,
 				port_res->max_vfs += le16_to_cpu(pcie->num_vfs);
 			}
 		}
-		return status;
+		goto err;
 	}
 
 	pcie = be_get_pcie_desc(resp->func_param, desc_count,

Good catch, Petr.