perf: make perf stat print user provided full event names

PATCH New Stephane Eranian 1 participant 1 message Feb 16, 2011 perf events

Share & tools

Stephane Eranian

author

2011-02-16 14:17 UTC #0 lore raw

PATCH 1/1 perf: make perf stat print user provided full event names

This patch changes the way perf stat prints event names at the end of a run. Until now, it was trying to reconstruct the event name from its encoding. The problem is that it would only print generic events without their modifiers (u, k, pp).

This patch saves the event name as passed by the user in the evsel struct and uses it to print the final event name.

This would also work in case perf is linked with a library (such as libpfm4) which provides full PMU event tables.

$ perf stat -e cycles:u,cycles:k date
Wed Feb 16 14:58:52 CET 2011

Performance counter stats for 'date':

            568600 cycles:u                
           2779715 cycles:k                

        0.001908182  seconds time elapsed

Signed-off-by Stephane Eranian <[email protected]>

---

tools/perf/util/evsel.c +1 -0

index 211063e..5f1f364 100644
@@ -85,6 +85,7 @@ void perf_evsel__exit(struct perf_evsel *evsel)
 void perf_evsel__delete(struct perf_evsel *evsel)
 {
 	perf_evsel__exit(evsel);
+	free(evsel->name);
 	free(evsel);
 }

tools/perf/util/evsel.h +1 -0

index eecdc3a..c32b348 100644
@@ -45,6 +45,7 @@ struct perf_evsel {
 	struct perf_counts	*counts;
 	int			idx;
 	void			*priv;
+	char			*name;
 };
 
 struct cpu_map;

tools/perf/util/parse-events.c +10 -0

index cf082da..80a3dd5 100644
@@ -268,6 +268,9 @@ const char *event_name(struct perf_evsel *evsel)
 	u64 config = evsel->attr.config;
 	int type = evsel->attr.type;
 
+	if (evsel->name)
+		return evsel->name;
+
 	return __event_name(type, config);
 }

@@ -782,8 +785,10 @@ int parse_events(const struct option *opt, const char *str, int unset __used)
 	struct perf_evlist *evlist = *(struct perf_evlist **)opt->value;
 	struct perf_event_attr attr;
 	enum event_result ret;
+	const char *ostr;
 
 	for (;;) {
+		ostr = str;
 		memset(&attr, 0, sizeof(attr));
 		ret = parse_event_symbols(opt, &str, &attr);
 		if (ret == EVT_FAILED)

@@ -798,6 +803,11 @@ int parse_events(const struct option *opt, const char *str, int unset __used)
 			if (evsel == NULL)
 				return -1;
 			perf_evlist__add(evlist, evsel);
+
+			evsel->name = calloc(str - ostr + 1, 1);
+			if (!evsel->name)
+				return -1;
+			strncpy(evsel->name, ostr, str - ostr);
 		}
 
 		if (*str == 0)