Skip to contentSkip to conversation

package/linux-firmware: add options for Broadcom BCM4366

PATCH New Rafał Miłecki 2 participants 3 messages May 18, 2020 – Oct 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/linux-firmware: add options for Broadcom BCM4366

From: Rafa? Mi?ecki <[email protected]>

There are two groups of chipsets in the BCM4366 family requiring two different firmware files. Each is quite big (over 1 MiB) so use separated options for them.

---
Yann, Yegor: my previous e-mail didn't reach ML because I wasn't subscribed thus I'm resending it.

---
 package/linux-firmware/Config.in         | 10 ++++++++++
 package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
 2 files changed, 22 insertions(+)
package/linux-firmware/Config.in +10 -0
index eba58014b6..3746f6f463 100644
@@ -128,6 +128,16 @@ config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XXX
 	help
 	  Firmware files for the Broadcom bcm43xxx, SoftMAC and FullMAC.
 
+config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366B1
+	bool "Broadcom 4366b1"
+	help
+	  Firmware file for the Broadcom 4366b1 FullMAC chip.
+
+config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366C0
+	bool "Broadcom 4366c0"
+	help
+	  Firmware file for the Broadcom 4366c0 FullMAC chip.
+
 config BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160
 	bool "Intel iwlwifi 3160"
 	help
package/linux-firmware/linux-firmware.mk +12 -0
index cbad8d592a..a80eafaf14 100644
@@ -546,6 +546,18 @@ LINUX_FIRMWARE_FILES += \
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366B1),y)
+LINUX_FIRMWARE_FILES += \
+	brcm/brcmfmac4366b-pcie.bin brcm/brcmfmac4366b-pcie.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
+endif
+
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366C0),y)
+LINUX_FIRMWARE_FILES += \
+	brcm/brcmfmac4366c-pcie.bin brcm/brcmfmac4366c-pcie.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
+endif
+
 # ql2xxx
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QLOGIC_2XXX),y)
 LINUX_FIRMWARE_FILES += \
Signature · 1 line
2.26.1
#1 lore raw

PATCH 1/1 package/linux-firmware: add options for Broadcom BCM4366

Hi,

Quoted 10 lines · Rafa? Mi?ecki

From: Rafa? Mi?ecki <[email protected]>

There are two groups of chipsets in the BCM4366 family requiring two different firmware files. Each is quite big (over 1 MiB) so use separated options for them.

---
Yann, Yegor: my previous e-mail didn't reach ML because I wasn't subscribed thus I'm resending it.

Can someone review/accept my patch, please?

#2 lore raw

PATCH 1/1 package/linux-firmware: add options for Broadcom BCM4366

In reply to Rafał Miłecki
Quoted 6 lines · On Mon, 18 May 2020 10:33:05 +0200 Rafa? Mi?ecki <[email protected]> wrote:

From: Rafa? Mi?ecki <[email protected]>

There are two groups of chipsets in the BCM4366 family requiring two different firmware files. Each is quite big (over 1 MiB) so use separated options for them.

Quoted 8 lines

---
Yann, Yegor: my previous e-mail didn't reach ML because I wasn't subscribed thus I'm resending it.

---
 package/linux-firmware/Config.in         | 10 ++++++++++
 package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
 2 files changed, 22 insertions(+)

I've slightly tweaked the option names to be a bit more consistent with existing option names, and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com