Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
PATCH 1/1 Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
From: Alex <[email protected]>
Package patch 0000-disableIPV6-config is needed to explicity disable IPV6 support, this is actually recomeneded by the library developer but for some reason the --enable-ipv6 still shows up. Without this the package fails build.
Included hash for license files.
--- package/liblo/0000-disableIPV6-config.patch | 24 ++++++++++++++++++++++++ package/liblo/liblo.hash | 10 +++++++--- package/liblo/liblo.mk | 2 +- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 package/liblo/0000-disableIPV6-config.patch
package/liblo/0000-disableIPV6-config.patch new file +24 -0
@@ -0,0 +1,24 @@ +--- a/configure 2017-08-11 17:37:13.000000000 +0200 ++++ b/configure 2018-02-08 13:54:16.002048928 +0100 +@@ -3233,15 +3233,15 @@ + + # disable support for ipv6. + # Check whether --enable-ipv6 was given. +-if test "${enable_ipv6+set}" = set; then : +- enableval=$enable_ipv6; want_ipv6=$enableval +-fi +- +-if test "$want_ipv6" = "yes"; then +- +-$as_echo "#define ENABLE_IPV6 1" >>confdefs.h +- +-fi ++# if test "${enable_ipv6+set}" = set; then : ++# enableval=$enable_ipv6; want_ipv6=$enableval ++# fi ++# ++# if test "$want_ipv6" = "yes"; then ++# ++# $as_echo "#define ENABLE_IPV6 1" >>confdefs.h ++# ++# fi
package/liblo/liblo.hash +7 -3
@@ -1,3 +1,7 @@ -# From http://sourceforge.net/projects/liblo/files/liblo/0.26/ -sha1 21942c8f19e9829b5842cb85352f98c49dfbc823 liblo-0.26.tar.gz -md5 5351de14262560e15e7f23865293b16f liblo-0.26.tar.gz +# From http://sourceforge.net/projects/liblo/files/liblo/0.29/ +sha1 6aa69456787d3d6ef915281b4a0f8f2c79548ce3 liblo-0.29.tar.gz +md5 b0e70bc0fb2254addf94adddf85cffd3 liblo-0.29.tar.gz + +# Locally computed +sha1 caeb68c46fa36651acf592771d09de7937926bb3 COPYING +md5 fbc093901857fcd118f065f900982c24 COPYING
package/liblo/liblo.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -LIBLO_VERSION = 0.26 +LIBLO_VERSION = 0.29 LIBLO_SITE = http://downloads.sourceforge.net/project/liblo/liblo/$(LIBLO_VERSION) LIBLO_LICENSE = LGPL-2.1+
--
2.7.4
PATCH 1/1 Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
Hi Alex,
Thanks for your contribution! Unfortunately it cannot be applied as is. Here
are some comments.
First of all, the commit message should start with a single short summary line
(the "Subject line"):
liblo: bump version to 0.29
The sentence "C++ wrappers for this lib started appearing in 0.28 so I think
this is valid." isn't appropriate for the commit message, especially since you make no changes relevant to this. Perhaps:
"
Starting from version 0.28, C++ wrappers are provided as well. The configure script appropriately detects the availability of a C++ compiler so no Buildroot changes are needed for this.
"
Quoted 3 lines · Alex B
From: Alex <[email protected]>
Package patch 0000-disableIPV6-config is needed to explicity disable
explicitly
Quoted 1 line
IPV6 support, this is actually recomeneded by the library developer but
recommended
Quoted 1 line
for some reason the --enable-ipv6 still shows up. Without this the
Indeed, Buildroot will pass --enable-ipv6 to configure by default, since for
almost all packages we do want to enable ipv6 support.
Patching the package is not the correct approach, however. Could you try to add
the following to liblo.mk and see if that fixes the issue?
LIBLO_CONF_OPTS += --disable-ipv6
Quoted 4 lines
package fails build.>
Included hash for license files.Signed-off-by Alex <[email protected]>
Your Signed-off-by line should have your full name
Quoted 72 lines
--- package/liblo/0000-disableIPV6-config.patch | 24 ++++++++++++++++++++++++ package/liblo/liblo.hash | 10 +++++++--- package/liblo/liblo.mk | 2 +- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 package/liblo/0000-disableIPV6-config.patchpackage/liblo/0000-disableIPV6-config.patch new file +24
-0@@ -0,0 +1,24 @@ +--- a/configure 2017-08-11 17:37:13.000000000 +0200 ++++ b/configure 2018-02-08 13:54:16.002048928 +0100 +@@ -3233,15 +3233,15 @@ + + # disable support for ipv6. + # Check whether --enable-ipv6 was given. +-if test "${enable_ipv6+set}" = set; then : +- enableval=$enable_ipv6; want_ipv6=$enableval +-fi +- +-if test "$want_ipv6" = "yes"; then +- +-$as_echo "#define ENABLE_IPV6 1" >>confdefs.h +- +-fi ++# if test "${enable_ipv6+set}" = set; then : ++# enableval=$enable_ipv6; want_ipv6=$enableval ++# fi ++# ++# if test "$want_ipv6" = "yes"; then ++# ++# $as_echo "#define ENABLE_IPV6 1" >>confdefs.h ++# ++# fipackage/liblo/liblo.hash +7
-3@@ -1,3 +1,7 @@ -# From http://sourceforge.net/projects/liblo/files/liblo/0.26/ -sha1 21942c8f19e9829b5842cb85352f98c49dfbc823 liblo-0.26.tar.gz -md5 5351de14262560e15e7f23865293b16f liblo-0.26.tar.gz +# From http://sourceforge.net/projects/liblo/files/liblo/0.29/ +sha1 6aa69456787d3d6ef915281b4a0f8f2c79548ce3 liblo-0.29.tar.gz +md5 b0e70bc0fb2254addf94adddf85cffd3 liblo-0.29.tar.gz + +# Locally computed +sha1 caeb68c46fa36651acf592771d09de7937926bb3 COPYING +md5 fbc093901857fcd118f065f900982c24 COPYINGpackage/liblo/liblo.mk +1
-2@@ -4,7 +4,7 @@ # ################################################################################ -LIBLO_VERSION = 0.26 +LIBLO_VERSION = 0.29 LIBLO_SITE = http://downloads.sourceforge.net/project/liblo/liblo/$(LIBLO_VERSION) LIBLO_LICENSE = LGPL-2.1+ --2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
Sorry, I accidentally sent this while it was only half-finished...
On 08-02-18 17:45, Arnout Vandecappelle wrote:
[snip]
Quoted 4 lines
Quoted 2 lines
Signed-off-by Alex <[email protected]Your Signed-off-by line should have your full name
Your Signed-off-by line should have your full name, and it should match the
Author tag of the patch. That's because this is a legal statement: it is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See http://elinux.org/Developer_Certificate_Of_Origin
for more details.
Quoted 7 lines
Quoted 7 lines
--- package/liblo/0000-disableIPV6-config.patch | 24 ++++++++++++++++++++++++ package/liblo/liblo.hash | 10 +++++++--- package/liblo/liblo.mk | 2 +- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 package/liblo/0000-disableIPV6-config.patch
Quoted 6 lines
package/liblo/0000-disableIPV6-config.patch
Quoted 6 lines
package/liblo/0000-disableIPV6-config.patch new file +0
-0@@ -0,0 +1,24 @@
Patches should have a descriptive message and an additional Signed-off-by line
(this time asserting that you are entitled to contribute the patch under the license of the project, in this case LGPL-2.1+).
Since upstream is a git repository, we prefer git-formatted patches (i.e. clone
the upstream repo, make your changes, test with LIBLO_OVERRIDE_SRCDIR=..., commit including a Signed-off-by, and create the patch with git format-patch -N).
Quoted 2 lines
package/liblo/0000-disableIPV6-config.patch line 2
Quoted 2 lines
package/liblo/0000-disableIPV6-config.patch new file +2
-0+--- a/configure 2017-08-11 17:37:13.000000000 +0200 ++++ b/configure 2018-02-08 13:54:16.002048928 +0100
We prefer to patch configure.ac instead, and regenerate configure with
# 0000-disableIPV6-config.patch touches configure.ac LIBLO_AUTORECONF = YES
(But all that is of course no longer relevant if you can get away with just
passing --disable-ipv6 in _CONF_OPTS.)
Quoted 25 lines
Quoted 25 lines
package/liblo/0000-disableIPV6-config.patch new file +22
-0+@@ -3233,15 +3233,15 @@ + + # disable support for ipv6. + # Check whether --enable-ipv6 was given. +-if test "${enable_ipv6+set}" = set; then : +- enableval=$enable_ipv6; want_ipv6=$enableval +-fi +- +-if test "$want_ipv6" = "yes"; then +- +-$as_echo "#define ENABLE_IPV6 1" >>confdefs.h +- +-fi ++# if test "${enable_ipv6+set}" = set; then : ++# enableval=$enable_ipv6; want_ipv6=$enableval ++# fi ++# ++# if test "$want_ipv6" = "yes"; then ++# ++# $as_echo "#define ENABLE_IPV6 1" >>confdefs.h ++# ++# fipackage/liblo/liblo.hash +0
-1--- a/package/liblo/liblo.hash
Quoted 8 lines
package/liblo/liblo.hash line 3
Quoted 8 lines
+++ b/package/liblo/liblo.hash
package/liblo/liblo.hash +3
-3@@ -1,3 +1,7 @@ -# From http://sourceforge.net/projects/liblo/files/liblo/0.26/ -sha1 21942c8f19e9829b5842cb85352f98c49dfbc823 liblo-0.26.tar.gz -md5 5351de14262560e15e7f23865293b16f liblo-0.26.tar.gz +# From http://sourceforge.net/projects/liblo/files/liblo/0.29/ +sha1 6aa69456787d3d6ef915281b4a0f8f2c79548ce3 liblo-0.29.tar.gz +md5 b0e70bc0fb2254addf94adddf85cffd3 liblo-0.29.tar.gz
While you're at it, could you add a locally computed sha256?
Quoted 4 lines
package/liblo/liblo.hash line 7
Quoted 4 lines
package/liblo/liblo.hash +4
-0+ +# Locally computed +sha1 caeb68c46fa36651acf592771d09de7937926bb3 COPYING +md5 fbc093901857fcd118f065f900982c24 COPYING
Just use a sha256 here, not sha1 and md5. Also, please add
# License files
above the license files. In this case it's obvious, but sometimes it's no so obvious.
Care to make these changes and resubmit the patch? When you do, please pass -v2
or --subject-prefix='PATCH v2' to git format-patch, and add a changelog to the commit message, under your Signed-off-by, separated with ---.
For now, I've marked your patch as "Changes Requested" in our patchwork, so
unless you resend it we will forget about it.
Thanks a lot!
Arnout
Quoted 21 lines
Quoted 20 lines
package/liblo/liblo.mk +1
-2@@ -4,7 +4,7 @@ # ################################################################################ -LIBLO_VERSION = 0.26 +LIBLO_VERSION = 0.29 LIBLO_SITE = http://downloads.sourceforge.net/project/liblo/liblo/$(LIBLO_VERSION) LIBLO_LICENSE = LGPL-2.1+ --2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
In reply to Arnout VandecappelleThanks for the corrections Arnout, I will go about ammeding them for the next patch submission.
As to :
LIBLO_CONF_OPTS += --disable-ipv6
I am doubtfull if this will work (i will try anyway!), there only seems to be an option to enable ipv6. If this --enable-ipv6 is not provided then liblo assumes you do not want it. Is there a way to remove options for a specific package?
Alex
Quoted 134 lines · Arnout Vandecappelle
Hi Alex,
Thanks for your contribution! Unfortunately it cannot be applied as is.
Here
are some comments.First of all, the commit message should start with a single short summary
line
(the "Subject line"):liblo: bump version to 0.29
The sentence "C++ wrappers for this lib started appearing in 0.28 so I
think
this is valid." isn't appropriate for the commit message, especially since you
make no changes relevant to this. Perhaps:"
Starting from version 0.28, C++ wrappers are provided as well. The configure
script appropriately detects the availability of a C++ compiler so no Buildroot
changes are needed for this.
"Quoted 3 lines · Alex B
From: Alex <[email protected]>
Package patch 0000-disableIPV6-config is needed to explicity disable
explicitly
Quoted 1 line
IPV6 support, this is actually recomeneded by the library developer but
recommended
Quoted 1 line
for some reason the --enable-ipv6 still shows up. Without this the
Indeed, Buildroot will pass --enable-ipv6 to configure by default, since
for
almost all packages we do want to enable ipv6 support.Patching the package is not the correct approach, however. Could you try
to add
the following to liblo.mk and see if that fixes the issue?
LIBLO_CONF_OPTS+= --disable-ipv6Quoted 4 lines
package fails build.>
Included hash for license files.Signed-off-by Alex <[email protected]>Your Signed-off-by line should have your full name
Quoted 2 lines
--- package/liblo/0000-disableIPV6-config.patch | 24++++++++++++++++++++++++
Review
Quoted 6 lines
package/liblo/liblo.hash | 10 +++++++--- package/liblo/liblo.mk | 2 +- 3 files changed, 32 insertions(+), 4 deletions(-) create mode 100644 package/liblo/0000-disableIPV6-config.patch(quoted diff) +0
-0
b/package/liblo/0000-disableIPV6-config.patchQuoted 49 lines
new file mode 100644
index 0000000..cf3503cpackage/liblo/0000-disableIPV6-config.patch new file +24
-0@@ -0,0 +1,24 @@ +--- a/configure 2017-08-11 17:37:13.000000000 +0200 ++++ b/configure 2018-02-08 13:54:16.002048928 +0100 +@@ -3233,15 +3233,15 @@ + + # disable support for ipv6. + # Check whether --enable-ipv6 was given. +-if test "${enable_ipv6+set}" = set; then : +- enableval=$enable_ipv6; want_ipv6=$enableval +-fi +- +-if test "$want_ipv6" = "yes"; then +- +-$as_echo "#define ENABLE_IPV6 1" >>confdefs.h +- +-fi ++# if test "${enable_ipv6+set}" = set; then : ++# enableval=$enable_ipv6; want_ipv6=$enableval ++# fi ++# ++# if test "$want_ipv6" = "yes"; then ++# ++# $as_echo "#define ENABLE_IPV6 1" >>confdefs.h ++# ++# fipackage/liblo/liblo.hash +7
-3@@ -1,3 +1,7 @@ -# From http://sourceforge.net/projects/liblo/files/liblo/0.26/ -sha1 21942c8f19e9829b5842cb85352f98c49dfbc823 liblo-0.26.tar.gz -md5 5351de14262560e15e7f23865293b16f liblo-0.26.tar.gz +# From http://sourceforge.net/projects/liblo/files/liblo/0.29/ +sha1 6aa69456787d3d6ef915281b4a0f8f2c79548ce3 liblo-0.29.tar.gz +md5 b0e70bc0fb2254addf94adddf85cffd3 liblo-0.29.tar.gz + +# Locally computed +sha1 caeb68c46fa36651acf592771d09de7937926bb3 COPYING +md5 fbc093901857fcd118f065f900982c24 COPYINGpackage/liblo/liblo.mk +0
-0package/liblo/liblo.mk line 5
Quoted 2 lines
package/liblo/liblo.mk +0
-0@@ -4,7 +4,7 @@ # ################################################################################
package/liblo/liblo.mk
Quoted 4 lines
package/liblo/liblo.mk +1
-1-LIBLO_VERSION = 0.26 +LIBLO_VERSION = 0.29 LIBLO_SITE = http://downloads.sourceforge.net/project/liblo/liblo/$(
LIBLO_VERSION)Quoted 9 lines
package/liblo/liblo.mk +0
-1LIBLO_LICENSE = LGPL-2.1+ --2.7.4
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Quoted 8 lines
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180208/32379ac4/attachment.html>
PATCH 1/1 Bumping liblo from 0.26 to 0.29. C++ wrappers for this lib started appearing in 0.28 so I think this is valid.
Hi Alex,
[Please avoid top-posting, instead reply in-line like I do below.]
Quoted 2 lines · Alex Baldwin
Thanks for the corrections Arnout, I will go about ammeding them for the next patch submission.
Thanks!
Quoted 7 lines
As to :
LIBLO_CONF_OPTS+= --disable-ipv6I am doubtfull if this will work (i will try anyway!), there only seems to be an option to enable ipv6.
It should work. autoconf will interpret the --enable- and --disable- options
and will set $enableval to "yes" or "no" depending on what is given. In fact, --disable-ipv6 is equivalent to --enable-ipv6=no (but in Buildroot we have the convention to use --disable- options, not --enable-=no). So, by passing --disable-ipv6, $enableval will be set to "no", so $want_ipv6 is "no", so ENABLE_IPV6 will not be defined.
Quoted 2 lines
If this --enable-ipv6 is not provided then liblo assumes
you do not want it. Is there a way to remove options for a specific package?
Nope, but autoconf allows to override all options you give to it with a later
option, and that's what we do here.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF