Skip to contentSkip to conversation

toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP

PATCH New Fabrice Fontaine 3 participants 4 messages Oct 28, 2019 – Feb 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP

This toolchain does not support -fstack-protector-strong:
SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level

As there is no way to add a !BR2_SSP_STRONG dependency without creating a Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP

Fixes:
- http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a

---
 .../toolchain-external-codesourcery-arm/Config.in                | 1 -
 1 file changed, 1 deletion(-)
toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in +0 -1
index bdbe2acaea..f80e54ff06 100644
@@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
 	depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
 	depends on !BR2_STATIC_LIBS
 	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
-	select BR2_TOOLCHAIN_HAS_SSP
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_INSTALL_LIBSTDCPP
 	select BR2_HOSTARCH_NEEDS_IA32_LIBS
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP

Hi Fabrice,

Quoted 10 lines · Fabrice Fontaine

This toolchain does not support -fstack-protector-strong:
SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level

As there is no way to add a !BR2_SSP_STRONG dependency without creating a Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP

Fixes:
- http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a

I've tried applying this patch against autobuilder's buildroot but Buildroot recognizes that this toolchain is still capable of SSP and gives this error:
"SSP support available in this toolchain, please enable BR2_TOOLCHAIN_EXTERNAL_HAS_SSP"

The same is with your patch on top of master branch.

Can you please verify and dig into this problem?

Thank you very much
Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 17 lines
---
  .../toolchain-external-codesourcery-arm/Config.in                | 1 -
  1 file changed, 1 deletion(-)
toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in +0 -1
index bdbe2acaea..f80e54ff06 100644
@@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
  	depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
  	depends on !BR2_STATIC_LIBS
  	select BR2_TOOLCHAIN_EXTERNAL_GLIBC
-	select BR2_TOOLCHAIN_HAS_SSP
  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
  	select BR2_INSTALL_LIBSTDCPP
  	select BR2_HOSTARCH_NEEDS_IA32_LIBS
#2 lore raw

PATCH 1/1 toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP

Hi Giulio,

Le ven. 20 d?c. 2019 ? 17:33, Giulio Benetti
<[email protected]> a ?crit :

Quoted 21 lines

Hi Fabrice,

Quoted 10 lines · Fabrice Fontaine

This toolchain does not support -fstack-protector-strong:
SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level

As there is no way to add a !BR2_SSP_STRONG dependency without creating a Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP

Fixes:
- http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a

I've tried applying this patch against autobuilder's buildroot but Buildroot recognizes that this toolchain is still capable of SSP and gives this error:
"SSP support available in this toolchain, please enable BR2_TOOLCHAIN_EXTERNAL_HAS_SSP"

Quoted 3 lines

The same is with your patch on top of master branch.

Can you please verify and dig into this problem?

Indeed, this patch does not fix the issue as toolchain/helpers.mk raises an error because it detects that -fstack-protector is supported through:

    __HAS_SSP=`echo 'void main(){}' | $${__CROSS_CC} -Werror

-fstack-protector -x c - -o $(BUILD_DIR)/.br-toolchain-test.tmp

Quoted 1 line

/dev/null 2>&1 && echo y` ; \

if [ "$(BR2_TOOLCHAIN_HAS_SSP)" != "y" -a "$${__HAS_SSP}" = "y" ] ; then \
echo "SSP support available in this toolchain, please enable

BR2_TOOLCHAIN_EXTERNAL_HAS_SSP" ; \
        exit 1 ; \
    fi ; \

So I assume the correct way to fix this autobuilder failure is to patch utils/genrandconfig to avoid this configuration setup with this toolchain.
The quickest solution would be to update the fixup_config function to reject BR2_SSP_STRONG with BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM but this does not seem very generic.

Quoted 6 lines

Thank you very much
Best regards
--
Giulio Benetti
Benetti Engineering sas

Best Regards,

Fabrice

Quoted 19 lines
Quoted 18 lines
---
  .../toolchain-external-codesourcery-arm/Config.in                | 1 -
  1 file changed, 1 deletion(-)
toolchain/toolchain-external/toolchain-external-codesourcery-arm/Config.in +0 -1
index bdbe2acaea..f80e54ff06 100644
@@ -8,7 +8,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
      depends on !BR2_cortex_a12 && !BR2_cortex_a17 && !BR2_ARM_CPU_ARMV8A
      depends on !BR2_STATIC_LIBS
      select BR2_TOOLCHAIN_EXTERNAL_GLIBC
-     select BR2_TOOLCHAIN_HAS_SSP
      select BR2_TOOLCHAIN_HAS_NATIVE_RPC
      select BR2_INSTALL_LIBSTDCPP
      select BR2_HOSTARCH_NEEDS_IA32_LIBS
#3 lore raw

PATCH 1/1 toolchain/toolchain-external/toolchain-external-codesourcery-arm: disable SSP

In reply to Fabrice Fontaine

Hello Fabrice,

Quoted 10 lines · On Mon, 28 Oct 2019 14:08:38 +0100 Fabrice Fontaine…

This toolchain does not support -fstack-protector-strong:
SSP option -fstack-protector-strong not available in this toolchain, please select another SSP level

As there is no way to add a !BR2_SSP_STRONG dependency without creating a Kconfig recursive dependency, just remove BR2_TOOLCHAIN_HAS_SSP

Fixes:
- http://autobuild.buildroot.net/results/78dc6428ffaa529fdad8e9c8aaec49ded5f0209a

I have submitted a different patch series, implementing a different solution for this issue:

http://patchwork.ozlabs.org/project/buildroot/list/?series=159621

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com