Skip to contentSkip to conversation

m68k: q40: prefer 'unsigned int' to bare use of 'unsigned'

PATCH In review [email protected] 2 participants 2 messages Jul 8, 2023 – Jul 24, 2023 1 message not in the archive m68k architecture

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 m68k: q40: prefer 'unsigned int' to bare use of 'unsigned'

Fix the following warnings reported by checkpatch:

./arch/m68k/q40/q40ints.c:172: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' ./arch/m68k/q40/q40ints.c:211: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 arch/m68k/q40/q40ints.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/m68k/q40/q40ints.c +2 -2
index 127d7ecdbd49..9605d7b6cb30 100644
@@ -169,7 +169,7 @@ void q40_sched_init (void)
  *
 */
 
-struct IRQ_TABLE{ unsigned mask; int irq ;};
+struct IRQ_TABLE { unsigned int mask ; int irq ; };
 #if 0
 static struct IRQ_TABLE iirqs[]={
   {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
@@ -208,7 +208,7 @@ static int aliased_irq;        /* how many times inside handler ?*/
 /* got interrupt, dispatch to ISA or keyboard/timer IRQs */
 static void q40_irq_handler(unsigned int irq, struct pt_regs *fp)
 {
-    unsigned mir, mer;
+    unsigned int mir, mer;
     int i;
 
 //repeat:
#2 lore raw

Hi Zhenggang,

Quoted 8 lines · On Sat, Jul 8, 2023 at 6:06 PM <[email protected]> wrote:

Fix the following warnings reported by checkpatch:

./arch/m68k/q40/q40ints.c:172: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
./arch/m68k/q40/q40ints.c:211: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Thanks for your patch!

But obviously you forgot to run scripts/checkpatch.pl on your own patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From:
[email protected]' != 'Signed-off-by: Zhenggang Xuan <[email protected]>'

Quoted 16 lines
arch/m68k/q40/q40ints.c +1 -1
@@ -169,7 +169,7 @@ void q40_sched_init (void)
   *
  */
 
-struct IRQ_TABLE{ unsigned mask; int irq ;};
+struct IRQ_TABLE { unsigned int mask ; int irq ; };
  #if 0
  static struct IRQ_TABLE iirqs[]={
    {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
@@ -208,7 +208,7 @@ static int aliased_irq;        /* how many times

inside handler ?*/
/* got interrupt, dispatch to ISA or keyboard/timer IRQs */ static void q40_irq_handler(unsigned int irq, struct pt_regs *fp) {

arch/m68k/q40/q40ints.c static int aliased_irq; /* how many times inside handler ?*/ · line 211

Quoted 2 lines
arch/m68k/q40/q40ints.c +1 -1
-    unsigned mir, mer;
+    unsigned int mir, mer;

This part is white-space damaged, and thus fails to apply.

Quoted 3 lines
      int i;

//repeat:

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds