Skip to contentSkip to conversation

drivers: message: fusion: Replacing snprintf with scnprintf

PATCH New [email protected] 1 participant 1 message Jun 14, 2023 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 drivers: message: fusion: Replacing snprintf with scnprintf

Fix the following coccicheck warning:

drivers/message/fusion/mptscsih.c:3146:8-16: WARNING: use scnprintf or sprintf

---
 drivers/message/fusion/mptscsih.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/message/fusion/mptscsih.c +3 -3
index 2bc17087d17d..f79a22f130b1 100644
@@ -3045,7 +3045,7 @@ mptscsih_version_fw_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;
 
-    return snprintf(buf, PAGE_SIZE, "%02d.%02d.%02d.%02d\n",
+    return scnprintf(buf, PAGE_SIZE, "%02d.%02d.%02d.%02d\n",
         (ioc->facts.FWVersion.Word & 0xFF000000) >> 24,
         (ioc->facts.FWVersion.Word & 0x00FF0000) >> 16,
         (ioc->facts.FWVersion.Word & 0x0000FF00) >> 8,
@@ -3061,7 +3061,7 @@ mptscsih_version_bios_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;
 
-    return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n",
+    return scnprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n",
         (ioc->biosVersion & 0xFF000000) >> 24,
         (ioc->biosVersion & 0x00FF0000) >> 16,
         (ioc->biosVersion & 0x0000FF00) >> 8,
@@ -3077,7 +3077,7 @@ mptscsih_version_mpi_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;
 
-    return snprintf(buf, PAGE_SIZE, "%03x\n", ioc->facts.MsgVersion);
+    return scnprintf(buf, PAGE_SIZE, "%03x\n", ioc->facts.MsgVersion);
 }
 static DEVICE_ATTR(version_mpi, S_IRUGO, mptscsih_version_mpi_show, 

NULL);

@@ -3090,7 +3090,7 @@ char *buf)

     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%s\n", ioc->prod_name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", ioc->prod_name);
}
static DEVICE_ATTR(version_product, S_IRUGO,

     mptscsih_version_product_show, NULL);
@@ -3104,7 +3104,7 @@ mptscsih_version_nvdata_persistent_show(struct device *dev,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%02xh\n",
+ return scnprintf(buf, PAGE_SIZE, "%02xh\n",

         ioc->nvdata_version_persistent);
 }
 static DEVICE_ATTR(version_nvdata_persistent, S_IRUGO,
@@ -3118,7 +3118,7 @@ mptscsih_version_nvdata_default_show(struct device *dev,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%02xh\n",ioc->nvdata_version_default);
+ return scnprintf(buf, PAGE_SIZE, "%02xh\n", ioc->nvdata_version_default);
}
static DEVICE_ATTR(version_nvdata_default, S_IRUGO,

     mptscsih_version_nvdata_default_show, NULL);
@@ -3131,7 +3131,7 @@ mptscsih_board_name_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%s\n", ioc->board_name);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", ioc->board_name);
}
static DEVICE_ATTR(board_name, S_IRUGO, mptscsih_board_name_show,
NULL);

@@ -3143,7 +3143,7 @@ mptscsih_board_assembly_show(struct device *dev,

     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%s\n", ioc->board_assembly);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", ioc->board_assembly);
}
static DEVICE_ATTR(board_assembly, S_IRUGO,

     mptscsih_board_assembly_show, NULL);
@@ -3156,7 +3156,7 @@ mptscsih_board_tracer_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%s\n", ioc->board_tracer);
+ return scnprintf(buf, PAGE_SIZE, "%s\n", ioc->board_tracer);
}
static DEVICE_ATTR(board_tracer, S_IRUGO,

     mptscsih_board_tracer_show, NULL);
@@ -3169,7 +3169,7 @@ mptscsih_io_delay_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%02d\n", ioc->io_missing_delay);
+ return scnprintf(buf, PAGE_SIZE, "%02d\n", ioc->io_missing_delay);
}
static DEVICE_ATTR(io_delay, S_IRUGO,

     mptscsih_io_delay_show, NULL);
@@ -3182,7 +3182,7 @@ mptscsih_device_delay_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%02d\n", ioc->device_missing_delay);
+ return scnprintf(buf, PAGE_SIZE, "%02d\n", ioc->device_missing_delay);
}
static DEVICE_ATTR(device_delay, S_IRUGO,

     mptscsih_device_delay_show, NULL);
@@ -3195,7 +3195,7 @@ mptscsih_debug_level_show(struct device *dev, struct device_attribute *attr,
     MPT_SCSI_HOST    *hd = shost_priv(host);
     MPT_ADAPTER *ioc = hd->ioc;

- return snprintf(buf, PAGE_SIZE, "%08xh\n", ioc->debug_level);
+ return scnprintf(buf, PAGE_SIZE, "%08xh\n", ioc->debug_level);
}
static ssize_t
mptscsih_debug_level_store(struct device *dev, struct device_attribute
*attr,