trace: Do not try to include QMP commands in user emulation binaries
PATCH 1/1 trace: Do not try to include QMP commands in user emulation binaries
QMP is not available on user emulation; there is not monitor. Besides, since commit a0e61807a3 ("qapi: Remove QMP events and commands from user-mode builds") we don't generate the qapi-commands-trace.h header in a user-emulation-only build.
Remove the QMP trace commands from qemu-user binaries.
--- trace/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
trace/meson.build +3 -1
@@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends') trace_ss.add(files('ftrace.c')) endif trace_ss.add(files('control.c')) -trace_ss.add(files('qmp.c')) +if have_system or have_tools or have_ga + trace_ss.add(files('qmp.c')) +endif
Signature · 1 line
2.38.1
Quoted 17 lines · Philippe Mathieu-Daudé
QMP is not available on user emulation; there is not monitor. Besides, since commit
a0e61807a3("qapi: Remove QMP events and commands from user-mode builds") we don't generate theqapi-commands-trace.hheader in a user-emulation-only build.Remove the QMP trace commands from qemu-user binaries.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- trace/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)trace/meson.build +0
-0
trace/meson.build if 'ftrace' in get_option('trace_backends') · line 91
Quoted 5 lines
trace/meson.build +1
-1@@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends') trace_ss.add(files('ftrace.c')) endif trace_ss.add(files('control.c')) -trace_ss.add(files('qmp.c')) +if have_system or have_tools or have_ga
Maybe this pattern deserves adding a variable similar to:
have_monitor = have_system or have_tools or have_ga
Quoted 2 lines
trace/meson.build +2
-0+ trace_ss.add(files('qmp.c')) +endif
Quoted 11 lines · Philippe Mathieu-Daudé
QMP is not available on user emulation; there is not monitor. Besides, since commit
a0e61807a3("qapi: Remove QMP events and commands from user-mode builds") we don't generate theqapi-commands-trace.hheader in a user-emulation-only build.Remove the QMP trace commands from qemu-user binaries.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>--- trace/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
r~
Quoted 13 lines
trace/meson.build +3
-1@@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends') trace_ss.add(files('ftrace.c')) endif trace_ss.add(files('control.c')) -trace_ss.add(files('qmp.c')) +if have_system or have_tools or have_ga + trace_ss.add(files('qmp.c')) +endif