TI LMU rework

Modify the ramp-up/down property and add the property description to the binding.

Signed-off-by Dan Murphy <[email protected]>

---
 .../devicetree/bindings/mfd/ti-lmu.txt        | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

Documentation/devicetree/bindings/mfd/ti-lmu.txt +13 -7

index 980394d701a7..d9d529de6dc1 100644
@@ -25,6 +25,12 @@ Required properties:
 
 Optional property:
   - enable-gpios: A GPIO specifier for hardware enable pin.
+  - ramp-up-ms: Current ramping from one brightness level to
+		the a higher brightness level.
+		Range from 2048 us - 117.44 s
+  - ramp-down-ms: Current ramping from one brightness level to
+		  the a lower brightness level.
+		  Range from 2048 us - 117.44 s
 
 Required node:
   - backlight: All LMU devices have backlight child nodes.

@@ -90,7 +96,7 @@ lm3631@29 {
 
 		lcd_bl {
 			led-sources = <0 1>;
-			ramp-up-msec = <300>;
+			ramp-up-ms = <300>;
 		};
 	};
 };

@@ -152,15 +158,15 @@ lm3633@36 {
 		main {
 			label = "main_lcd";
 			led-sources = <1 2>;
-			ramp-up-msec = <500>;
-			ramp-down-msec = <500>;
+			ramp-up-ms = <500>;
+			ramp-down-ms = <500>;
 		};
 
 		front {
 			label = "front_lcd";
 			led-sources = <0>;
-			ramp-up-msec = <1000>;
-			ramp-down-msec = <0>;
+			ramp-up-ms = <1000>;
+			ramp-down-ms = <0>;
 		};
 	};
 

@@ -212,8 +218,8 @@ lm3697@36 {
 
 		lcd {
 			led-sources = <0 1 2>;
-			ramp-up-msec = <200>;
-			ramp-down-msec = <200>;
+			ramp-up-ms = <200>;
+			ramp-down-ms = <200>;
 		};
 	};
 

Quoted 2 lines · Dan Murphy

Modify the ramp-up/down property and add the property description to the binding.

This is the 'what', but where is the 'why'?

Create a TI LMU common framework for TI LMU devices that share common features.

Currently the runtime ramp and brightness setting have been identified as common features with common register settings.

This work is derived from Milo Kims TI LMU MFD code.

Signed-off-by Dan Murphy <[email protected]>

The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED directory as a dedicated LED driver and not as a MFD device. The device does have common brightness and ramp features and those can be accomodated by a TI LMU framework.

The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated LED dt binding needs to be added. The new LM3697 LED dt binding will then reside in the Documentation/devicetree/bindings/leds directory and follow the current LED and general bindings guidelines.

Signed-off-by Dan Murphy <[email protected]>

---
  .../devicetree/bindings/leds/leds-lm3697.txt  | 77 +++++++++++++++++++
  .../devicetree/bindings/mfd/ti-lmu.txt        | 26 +------
  2 files changed, 78 insertions(+), 25 deletions(-)

create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +24 -0

new file mode 100644
index 000000000000..a780f11acd38
@@ -0,0 +1,77 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for display and keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3697"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : GPIO pin to enable/disable the device
+	- vled-supply : LED supply
+
+Required child properties:
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources : Indicates which HVLED string is associated to which
+			control bank.  This is a zero based property so

Hi Dan,

Thank you for the patch.

You need Lee Jones on CC for this series.

One more comment below.

Quoted 51 lines · Dan Murphy

The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED directory as a dedicated LED driver and not as a MFD device.  The device does have common brightness and ramp features and those can be accomodated by a TI LMU framework.

The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated LED dt binding needs to be added.  The new LM3697 LED dt binding will then reside in the Documentation/devicetree/bindings/leds directory and follow the current LED and general bindings guidelines.

Signed-off-by Dan Murphy <[email protected]>

---
  .../devicetree/bindings/leds/leds-lm3697.txt  | 77 +++++++++++++++++++ .../devicetree/bindings/mfd/ti-lmu.txt        | 26 +------

  2 files changed, 78 insertions(+), 25 deletions(-)

  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +28 -0

new file mode 100644
index 000000000000..a780f11acd38
@@ -0,0 +1,77 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for display and keypad Lighting
+
+Required properties:
+    - compatible:
+        "ti,lm3697"
+    - reg :  I2C slave address
+    - #address-cells : 1
+    - #size-cells : 0
+
+Optional properties:
+    - enable-gpios : GPIO pin to enable/disable the device
+    - vled-supply : LED supply
+
+Required child properties:
+    - reg : 0 - LED is Controlled by bank A
+        1 - LED is Controlled by bank B
+    - led-sources : Indicates which HVLED string is associated to which
+            control bank.  This is a zero based property so
+            HVLED1 = 0, HVLED2 = 1, HVLED3 = 2.
+            Additional information is contained
+            in Documentation/devicetree/bindings/leds/common.txt
+

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 34

Quoted 6 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +6 -0

+Optional child properties:
+    - max_brightness - This determines whether to use 8 bit brightness mode
+               or 11 bit brightness mode.  If this value is not
+               set the device is defaulted to the preferred 8bit
+               brightness mode per 7.3.4.1 of the data sheet.
+               The values are 255 (8bit) or 2047 (11bit).

We should use led-max-microamp for that, if possible.

Jacek

Quoted 6 lines · Jacek Anaszewski

Hi Dan,

Thank you for the patch.

You need Lee Jones on CC for this series.

Yes I saw I missed Lee.

Quoted 54 lines

One more comment below.

Quoted 51 lines · Dan Murphy

The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED directory as a dedicated LED driver and not as a MFD device.  The device does have common brightness and ramp features and those can be accomodated by a TI LMU framework.

The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated LED dt binding needs to be added.  The new LM3697 LED dt binding will then reside in the Documentation/devicetree/bindings/leds directory and follow the current LED and general bindings guidelines.

Signed-off-by Dan Murphy <[email protected]>

---
   .../devicetree/bindings/leds/leds-lm3697.txt  | 77 +++++++++++++++++++
   .../devicetree/bindings/mfd/ti-lmu.txt        | 26 +------
   2 files changed, 78 insertions(+), 25 deletions(-)

  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +28 -0

new file mode 100644
index 000000000000..a780f11acd38
@@ -0,0 +1,77 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for display and keypad Lighting
+
+Required properties:
+    - compatible:
+        "ti,lm3697"
+    - reg :  I2C slave address
+    - #address-cells : 1
+    - #size-cells : 0
+
+Optional properties:
+    - enable-gpios : GPIO pin to enable/disable the device
+    - vled-supply : LED supply
+
+Required child properties:
+    - reg : 0 - LED is Controlled by bank A
+        1 - LED is Controlled by bank B
+    - led-sources : Indicates which HVLED string is associated to which
+            control bank.  This is a zero based property so
+            HVLED1 = 0, HVLED2 = 1, HVLED3 = 2.
+            Additional information is contained
+            in Documentation/devicetree/bindings/leds/common.txt
+

Quoted 9 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 34

Quoted 6 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +6 -0

+Optional child properties:
+    - max_brightness - This determines whether to use 8 bit brightness mode
+               or 11 bit brightness mode.  If this value is not
+               set the device is defaulted to the preferred 8bit
+               brightness mode per 7.3.4.1 of the data sheet.
+               The values are 255 (8bit) or 2047 (11bit).

We should use led-max-microamp for that, if possible.

Actually I was thinking this property could move to common.txt LM3697 would use it and it is also defined in leds-pwm.txt leds-netxbig.txt

But I could rename it to led-max-microamp and figure out an algo to convert to max brightness

Dan

Dan,

Quoted 76 lines · Dan Murphy

Jacek

Quoted 6 lines · Jacek Anaszewski

Hi Dan,

Thank you for the patch.

You need Lee Jones on CC for this series.

Yes I saw I missed Lee.

Quoted 54 lines

One more comment below.

Quoted 51 lines · Dan Murphy

The LM3697 is a single function LED driver. The single function LED driver needs to reside in the LED directory as a dedicated LED driver and not as a MFD device.  The device does have common brightness and ramp features and those can be accomodated by a TI LMU framework.

The LM3697 dt binding needs to be moved from the ti-lmu.txt and a dedicated LED dt binding needs to be added.  The new LM3697 LED dt binding will then reside in the Documentation/devicetree/bindings/leds directory and follow the current LED and general bindings guidelines.

Signed-off-by Dan Murphy <[email protected]>

---
   .../devicetree/bindings/leds/leds-lm3697.txt  | 77 +++++++++++++++++++ .../devicetree/bindings/mfd/ti-lmu.txt        | 26 +------

   2 files changed, 78 insertions(+), 25 deletions(-)

   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +28 -0

new file mode 100644
index 000000000000..a780f11acd38
@@ -0,0 +1,77 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for display and keypad Lighting
+
+Required properties:
+    - compatible:
+        "ti,lm3697"
+    - reg :  I2C slave address
+    - #address-cells : 1
+    - #size-cells : 0
+
+Optional properties:
+    - enable-gpios : GPIO pin to enable/disable the device
+    - vled-supply : LED supply
+
+Required child properties:
+    - reg : 0 - LED is Controlled by bank A
+        1 - LED is Controlled by bank B
+    - led-sources : Indicates which HVLED string is associated to which
+            control bank.  This is a zero based property so
+            HVLED1 = 0, HVLED2 = 1, HVLED3 = 2.
+            Additional information is contained
+            in Documentation/devicetree/bindings/leds/common.txt
+

Quoted 9 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 34

Quoted 6 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +6 -0

+Optional child properties:
+    - max_brightness - This determines whether to use 8 bit brightness mode
+               or 11 bit brightness mode.  If this value is not
+               set the device is defaulted to the preferred 8bit
+               brightness mode per 7.3.4.1 of the data sheet.
+               The values are 255 (8bit) or 2047 (11bit).

We should use led-max-microamp for that, if possible.

Quoted 2 lines

Actually I was thinking this property could move to common.txt LM3697 would use it and it is also defined in leds-pwm.txt leds-netxbig.txt

It was considered back in 2014 when I was working on LED flash class framework. It was then assessed inappropriate for describing physical property of a device. It needs to be kept in mind that it was in the context of flash LEDs, where currents are much higher than for common LEDs. Since then we have been always using led-max-microamp.

With max-brightness in Device Tree there is also another problem - we don't know what it really means - greater allowed current or greater resolution.

Why not allow for maximum available brightness resolution for ti-lmu always when the amperage is not an issue?

Quoted 5 lines

But I could rename it to led-max-microamp and figure out an algo to convert to max brightness

Dan

Maybe I should rename this to ti,brightness-resolution with the same values. or ti,brightness-res for short hand.

Or I could try to figure out the max-microamp but it really does not describe the hardware or the configuration.

Quoted 12 lines

Quoted 4 lines

Quoted 1 line

Actually I was thinking this property could move to common.txt LM3697 would use it and it is also defined in leds-pwm.txt leds-netxbig.txt

It was considered back in 2014 when I was working on LED flash class framework. It was then assessed inappropriate for describing physical property of a device. It needs to be kept in mind that it was in the context of flash LEDs, where currents are much higher than for common LEDs. Since then we have been always using led-max-microamp.

Quoted 7 lines

With max-brightness in Device Tree there is also another problem - we don't know what it really means - greater allowed current or greater resolution.

Why not allow for maximum available brightness resolution for ti-lmu always when the amperage is not an issue?

Remove support for the LM3697 from the ti-lmu

driver in favor of a dedicated LED driver.

Signed-off-by Dan Murphy <[email protected]>

---
 drivers/leds/Kconfig                |  2 +-
 drivers/mfd/Kconfig                 |  2 +-
 drivers/mfd/ti-lmu.c                | 17 -----------
 include/linux/mfd/ti-lmu-register.h | 44 -----------------------------
 include/linux/mfd/ti-lmu.h          |  1 -
 5 files changed, 2 insertions(+), 64 deletions(-)

Quoted 1 line · Dan Murphy

Remove support for the LM3697 from the ti-lmu

Bit of an odd place to insert a line feed.

Quoted 10 lines

driver in favor of a dedicated LED driver.

Signed-off-by Dan Murphy <[email protected]>

---
 drivers/leds/Kconfig                |  2 +-
 drivers/mfd/Kconfig                 |  2 +-
 drivers/mfd/ti-lmu.c                | 17 -----------
 include/linux/mfd/ti-lmu-register.h | 44 -----------------------------
 include/linux/mfd/ti-lmu.h          |  1 -
 5 files changed, 2 insertions(+), 64 deletions(-)

I'm fine with the patch.

Can you edit drivers/leds/Kconfig as part of a separate patch please? Keeping this in sync with this change is not critical and would add a whole bunch of process which we can really do without.

Quoted 1 line · Dan Murphy

Remove support for the LM3697 from the ti-lmu

Bit of an odd place to insert a line feed.

Quoted 10 lines

driver in favor of a dedicated LED driver.

Signed-off-by Dan Murphy <[email protected]>

---
 drivers/leds/Kconfig                |  2 +-
 drivers/mfd/Kconfig                 |  2 +-
 drivers/mfd/ti-lmu.c                | 17 -----------
 include/linux/mfd/ti-lmu-register.h | 44 -----------------------------
 include/linux/mfd/ti-lmu.h          |  1 -
 5 files changed, 2 insertions(+), 64 deletions(-)

I'm fine with the patch.

Can you edit drivers/leds/Kconfig as part of a separate patch please? Keeping this in sync with this change is not critical and would add a whole bunch of process which we can really do without.

Introduce the lm3697 LED driver for
backlighting and display.

Datasheet location:
http://www.ti.com/lit/ds/symlink/lm3697.pdf

Signed-off-by Dan Murphy <[email protected]>

---
 drivers/leds/Kconfig       |   8 +-
 drivers/leds/Makefile      |   1 +
 drivers/leds/leds-lm3697.c | 401 +++++++++++++++++++++++++++++++++++++
 3 files changed, 409 insertions(+), 1 deletion(-)
 create mode 100644 drivers/leds/leds-lm3697.c

drivers/leds/Kconfig +3 -0

index 735009e73414..688bb9a6f275 100644
@@ -776,9 +776,15 @@ config LEDS_NIC78BX
 	  To compile this driver as a module, choose M here: the module
 	  will be called leds-nic78bx.
 
+config LEDS_LM3697
+	tristate "LED driver for LM3697"
+	depends on LEDS_TI_LMU_COMMON

drivers/leds/Kconfig +14 -0

+static int lm3697_init(struct lm3697 *priv)
+{
+	struct lm3697_led *led;
+	int i, ret;
+
+	if (priv->enable_gpio) {
+		gpiod_direction_output(priv->enable_gpio, 1);
+	} else {
+		ret = regmap_write(priv->regmap, LM3697_RESET, LM3697_SW_RESET);
+		if (ret) {
+			dev_err(&priv->client->dev, "Cannot reset the device\n");
+			goto out;
+		}
+	}

Quoted 22 lines · Dan Murphy

Introduce the lm3697 LED driver for
backlighting and display.

Datasheet location:
http://www.ti.com/lit/ds/symlink/lm3697.pdf

Signed-off-by Dan Murphy <[email protected]>

---
 drivers/leds/Kconfig       |   8 +-
 drivers/leds/Makefile      |   1 +
 drivers/leds/leds-lm3697.c | 401 +++++++++++++++++++++++++++++++++++++
 3 files changed, 409 insertions(+), 1 deletion(-)
 create mode 100644 drivers/leds/leds-lm3697.c

drivers/leds/Kconfig +0 -0

index 735009e73414..688bb9a6f275 100644
@@ -776,9 +776,15 @@ config LEDS_NIC78BX
 	  To compile this driver as a module, choose M here: the module
 	  will be called leds-nic78bx.
 

drivers/leds/Kconfig config LEDS_NIC78BX · line 790

Quoted 13 lines

drivers/leds/Kconfig +7 -1

+config LEDS_LM3697
+	tristate "LED driver for LM3697"
+	depends on LEDS_TI_LMU_COMMON
+	help
+	  Say Y to enable the LM3697 LED driver for TI LMU devices.
+	  This supports the LED device LM3697.
+
 config LEDS_TI_LMU_COMMON
 	tristate "LED driver for TI LMU"
-	depends on REGMAP
 	help
           Say Y to enable the LED driver for TI LMU devices.
           This supports common features between the TI LM3532, LM3631, LM3632,

Is deleting "depends on REGMAP" intentional? AFAICT you are using it.

Plus we'd normally expect "COMMON" first and then specific driver. Not sure if Kconfig can handle it out-of-order...

Quoted 18 lines

drivers/leds/Kconfig +18 -0

+static int lm3697_init(struct lm3697 *priv)
+{
+	struct lm3697_led *led;
+	int i, ret;
+
+	if (priv->enable_gpio) {
+		gpiod_direction_output(priv->enable_gpio, 1);
+	} else {
+		ret = regmap_write(priv->regmap, LM3697_RESET, LM3697_SW_RESET);
+		if (ret) {
+			dev_err(&priv->client->dev, "Cannot reset the device\n");
+			goto out;
+		}
+	}
+
+	ret = regmap_write(priv->regmap, LM3697_CTRL_ENABLE, 0x0);
+	if (ret) {
+		dev_err(&priv->client->dev, "Cannot write ctrl enable\n");

drivers/leds/Kconfig

Quoted 6 lines

drivers/leds/Kconfig +6 -0

+		goto out;
+	}
+
+	ret = regmap_write(priv->regmap, LM3697_OUTPUT_CONFIG, priv->bank_cfg);
+	if (ret)
+		dev_err(&priv->client->dev, "Cannot write OUTPUT config\n");

Missing goto out?

drivers/leds/Kconfig

Quoted 10 lines

drivers/leds/Kconfig +9 -0

+	for (i = 0; i < LM3697_MAX_CONTROL_BANKS; i++) {
+		led = &priv->leds[i];
+		ret = ti_lmu_common_set_ramp(&led->lmu_data);
+		if (ret)
+			dev_err(&priv->client->dev, "Setting the ramp rate failed\n");
+	}
+out:
+	return ret;
+}

Pavel

Quoted 22 lines

Quoted 22 lines

drivers/leds/Kconfig +7 -1

index 735009e73414..688bb9a6f275 100644
@@ -776,9 +776,15 @@ config LEDS_NIC78BX
 	  To compile this driver as a module, choose M here: the module
 	  will be called leds-nic78bx.
 
+config LEDS_LM3697
+	tristate "LED driver for LM3697"
+	depends on LEDS_TI_LMU_COMMON
+	help
+	  Say Y to enable the LM3697 LED driver for TI LMU devices.
+	  This supports the LED device LM3697.
+
 config LEDS_TI_LMU_COMMON
 	tristate "LED driver for TI LMU"
-	depends on REGMAP
 	help
           Say Y to enable the LED driver for TI LMU devices.
           This supports common features between the TI LM3532, LM3631, LM3632,

Quoted 2 lines

Plus we'd normally expect "COMMON" first and then specific driver. Not sure if Kconfig can handle it out-of-order...

OK. Should I rename the ti_lmu file to leds-common-ti-lmu?

This keeps the naming convention the same in the leds directory as well.

FYI I will not add your acked-by on the LMU patch that introduced the code unless you approve. Since you found issues with the kconfig

Quoted 22 lines

Quoted 22 lines

Quoted 22 lines

drivers/leds/Kconfig +7 -1

index 735009e73414..688bb9a6f275 100644
@@ -776,9 +776,15 @@ config LEDS_NIC78BX
 	  To compile this driver as a module, choose M here: the module
 	  will be called leds-nic78bx.
 
+config LEDS_LM3697
+	tristate "LED driver for LM3697"
+	depends on LEDS_TI_LMU_COMMON
+	help
+	  Say Y to enable the LM3697 LED driver for TI LMU devices.
+	  This supports the LED device LM3697.
+
 config LEDS_TI_LMU_COMMON
 	tristate "LED driver for TI LMU"
-	depends on REGMAP
 	help
           Say Y to enable the LED driver for TI LMU devices.
           This supports common features between the TI LM3532, LM3631, LM3632,

...

Quoted 4 lines

Quoted 2 lines

Plus we'd normally expect "COMMON" first and then specific driver. Not sure if Kconfig can handle it out-of-order...

OK. Should I rename the ti_lmu file to leds-common-ti-lmu?

Oh, no, that is not what I meant.

You have

config B
depends on A

config A

above. We really want

config A

config B
depends on A

Quoted 4 lines

This keeps the naming convention the same in the leds directory as well.

FYI I will not add your acked-by on the LMU patch that introduced the code unless you approve. Since you found issues with the kconfig

I did not review it in great detail, so no acked-by's, yet :-).

Pavel

All

I know that it has been a long time but I put some additional effort into this code. The TI LMU common code right now handles brightness and ramp up/down setting for the LM3697. This so far are the common features I could find.

The LM3697 driver has the ability to assign HVLED strings to specific control banks as well as assigning different max brightnesses to these strings.

Fault monitoring was removed as the data sheet indicates that this is for production tests only.

I have plans to add additional LED drivers to use the TI LMU but I figured trying to add all of them at once would be a daunting review and probably wrought with problems.

Dan

Dan Murphy (5):
dt-bindings: mfd: Update the ramp up/down property
leds: TI LMU: Add common code for TI LMU devices
dt-bindings: ti-lmu: Modify dt bindings for the LM3697
mfd: ti-lmu: Remove support for LM3697
leds: lm3697: Introduce the lm3697 driver

 .../devicetree/bindings/leds/leds-lm3697.txt  |  77 ++++
 .../devicetree/bindings/mfd/ti-lmu.txt        |  42 +-
 drivers/leds/Kconfig                          |  14 +
 drivers/leds/Makefile                         |   2 +
 drivers/leds/leds-lm3697.c                    | 401 ++++++++++++++++++
 drivers/leds/ti-lmu-led-common.c              | 131 ++++++
 drivers/mfd/Kconfig                           |   2 +-
 drivers/mfd/ti-lmu.c                          |  17 -
 include/linux/mfd/ti-lmu-register.h           |  44 --
 include/linux/mfd/ti-lmu.h                    |   1 -
 include/linux/ti-lmu-led-common.h             |  44 ++
 11 files changed, 682 insertions(+), 93 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
 create mode 100644 drivers/leds/leds-lm3697.c
 create mode 100644 drivers/leds/ti-lmu-led-common.c
 create mode 100644 include/linux/ti-lmu-led-common.h

Hello

Quoted 9 lines · Dan Murphy

All

I know that it has been a long time but I put some additional effort into this code. The TI LMU common code right now handles brightness and ramp up/down setting for the LM3697. This so far are the common features I could find.

The LM3697 driver has the ability to assign HVLED strings to specific control banks as well as assigning different max brightnesses to these strings.

Quoted 7 lines

Fault monitoring was removed as the data sheet indicates that this is for production tests only.

I have plans to add additional LED drivers to use the TI LMU but I figured trying to add all of them at once would be a daunting review and probably wrought with problems.

I have a new device I need to add to the TI LMU code LM36274.
This will use the MFD ti-lmu code and I will need to create the backlight and regulator drivers.

I need to know how to proceed. I can base the work off of the LM3532 patchset or use what is in mainline or base it off this patchset. The LM36274 would use the ti-lmu-led-common code for brightness setting but the ramping times are different.

Please let me know how to proceed.