cfq-iosched: reduce write depth only if sync was delayed
PATCH 1/1 cfq-iosched: reduce write depth only if sync was delayed
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
--- block/cfq-iosched.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
block/cfq-iosched.c +1 -1
@@ -284,7 +284,7 @@ struct cfq_data {*/ struct cfq_queue oom_cfqq; -unsigned long last_end_sync_rq; +unsigned long last_delayed_sync;/* List of cfq groups being managed on this device*/ struct hlist_head cfqg_list;
@@ -2264,7 +2264,7 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd,
struct cfq_queue *cfqq)
* based on the last sync IO we serviced */
if (!cfq_cfqq_sync(cfqq) && cfqd->cfq_latency) {
- unsigned long last_sync = jiffies - cfqd->last_end_sync_rq;
+ unsigned long last_sync = jiffies - cfqd->last_delayed_sync;
unsigned int depth;
depth = last_sync / cfqd->cfq_slice[1];
@@ -3272,7 +3272,8 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq)
if (sync) {
RQ_CIC(rq)->last_end_request = now;
- cfqd->last_end_sync_rq = now;
+ if (time_after(rq->start_time + cfqd->cfq_fifo_expire[1], now))
+ cfqd->last_delayed_sync = now;
}
/*
@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q)
cfqd->cfq_latency = 1;
cfqd->cfq_group_isolation = 0;
cfqd->hw_tag = -1;
- cfqd->last_end_sync_rq = jiffies;
+ cfqd->last_delayed_sync = jiffies - HZ;
return cfqd;
}
Signature · 1 line
1.6.2.5
Quoted 34 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
Signed-off-by Corrado Zoccolo <[email protected]>---
block/cfq-iosched.c | 9 +++++----1 files changed, 5 insertions(+), 4 deletions(-)block/cfq-iosched.c +2
-2@@ -284,7 +284,7 @@ struct cfq_data {*/ struct cfq_queue oom_cfqq; - unsigned long last_end_sync_rq; + unsigned long last_delayed_sync; /* List of cfq groups being managed on this device*/ struct hlist_head cfqg_list;@@ -2264,7 +2264,7 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd,struct cfq_queue *cfqq) * based on the last sync IO we serviced */ if (!cfq_cfqq_sync(cfqq) && cfqd->cfq_latency) { - unsigned long last_sync = jiffies - cfqd->last_end_sync_rq; + unsigned long last_sync = jiffies - cfqd->last_delayed_sync; unsigned int depth;depth =
last_sync/ cfqd->cfq_slice[1];
block/cfq-iosched.c static void cfq_completed_request(struct request_queue · line 3277
Quoted 7 lines
block/cfq-iosched.c +2
-1@@ -3272,7 +3272,8 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq) if (sync) { RQ_CIC(rq)->last_end_request = now; - cfqd->last_end_sync_rq = now; + if (time_after(rq->start_time + cfqd->cfq_fifo_expire[1], now)) + cfqd->last_delayed_sync = now;
Sorry, the check be reversed (!time_after).
Quoted 18 lines
block/cfq-iosched.c +0
-0}/*
block/cfq-iosched.c +1
-2@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ; return cfqd; } --1.6.2.5
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1.
Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it
for fast hardware like yours, so you should not be seeing the slowdown any more.
Thanks,
Corrado
Quoted 64 lines · Corrado Zoccolo
Quoted 34 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
Signed-off-by Corrado Zoccolo <[email protected]>---
block/cfq-iosched.c | 9 +++++----1 files changed, 5 insertions(+), 4 deletions(-)block/cfq-iosched.c +2
-2@@ -284,7 +284,7 @@ struct cfq_data {*/ struct cfq_queue oom_cfqq; - unsigned long last_end_sync_rq; + unsigned long last_delayed_sync; /* List of cfq groups being managed on this device*/ struct hlist_head cfqg_list;@@ -2264,7 +2264,7 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd,struct cfq_queue *cfqq) * based on the last sync IO we serviced */ if (!cfq_cfqq_sync(cfqq) && cfqd->cfq_latency) { - unsigned long last_sync = jiffies - cfqd->last_end_sync_rq; + unsigned long last_sync = jiffies - cfqd->last_delayed_sync; unsigned int depth;depth =
last_sync/ cfqd->cfq_slice[1];block/cfq-iosched.c static void cfq_completed_request(struct request_queue · line 3277
Quoted 7 lines
block/cfq-iosched.c +2
-1@@ -3272,7 +3272,8 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq) if (sync) { RQ_CIC(rq)->last_end_request = now; - cfqd->last_end_sync_rq = now; + if (time_after(rq->start_time + cfqd->cfq_fifo_expire[1], now)) + cfqd->last_delayed_sync = now;Sorry, the check be reversed (!time_after).
Quoted 18 lines
block/cfq-iosched.c +0
-0}/*
block/cfq-iosched.c +1
-2@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ; return cfqd; } --1.6.2.5
Signature · 10 lines
__________________________________________________________________________ dott. Corrado Zoccolo mailto:[email protected] PhD - Department of Computer Science - University of Pisa, Italy -------------------------------------------------------------------------- The self-confidence of a warrior is not the self-confidence of the average man. The average man seeks certainty in the eyes of the onlooker and calls that self-confidence. The warrior seeks impeccability in his own eyes and calls that humbleness. Tales of Power - C. Castaneda
Jens Axboe
AppliedQuoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.
I queued this up for post inclusion into 2.6.33, with the time_after() fixed.
The patch was word-wrapped, btw.
Signature · 1 line
Jens Axboe
Quoted 9 lines · Jens Axboe
Quoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.
Quoted 4 lines
I queued this up for post inclusion into 2.6.33, with the
time_after()fixed.The patch was word-wrapped, btw.
So in what branch can I find this fix? Once I know that I can queue up some tests.
Cheers,
Jeff
Quoted 11 lines · Jeff Moyer
Quoted 9 lines · Jens Axboe
Quoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.
Quoted 7 lines
Quoted 4 lines
I queued this up for post inclusion into 2.6.33, with the
time_after()fixed.The patch was word-wrapped, btw.
So in what branch can I find this fix? Once I know that I can queue up some tests.
It's in next-2.6.33
Signature · 1 line
Jens Axboe
Quoted 15 lines · Jens Axboe
Quoted 14 lines · Jeff Moyer
Quoted 12 lines · Jens Axboe
Quoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.I queued this up for post inclusion into 2.6.33, with the
time_after()fixed.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
The patch was word-wrapped, btw.
So in what branch can I find this fix? Once I know that I can queue up some tests.
It's in next-2.6.33
next-2.6.33 won't boot for me:
general protection fault: 0000 [#1] SMP
async/0 used greatest stack depth: 4256 bytes left
last sysfs file: /sys/class/firmware/timeout
CPU 1
Modules linked in: ata_piix pata_acpi libata sd_mod scsi_mod ext3 jbd mbcache uh ci_hcd ohci_hcd ehci_hcd Pid: 729, comm: async/1 Not tainted 2.6.32 #1 ProLiant DL320 G5p RIP: 0010:[<ffffffff81199cee>] [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP: 0018:ffff8801251b1d48 EFLAGS: 00010002 RAX: ffff880126dcdd28 RBX: ffff8801251fa158 RCX: 0000000000170001 RDX: ffff880125556700 RSI: ffff8801251fa158 RDI: 6b6b6b6b6b6b6b6b RBP: ffff8801251b1d70 R08: ffff8801255a0448 R09: 000000000000005a R10: ffff8801255a0448 R11: ffffffff818d6210 R12: ffff880126dcdb18 R13: ffff880126dcdb50 R14: 0000000000000286 R15: ffff880125556760 FS: 0000000000000000(0000) GS:ffff88002f200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000000000 CR3: 00000001256a5000 CR4: 00000000000006a0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process async/1 (pid: 729, threadinfo ffff8801251b0000, task ffff880125556770) Stack: ffffffff8119a856 0000000000000002 ffff880126dcdb18 ffff8801251fa158 <0> ffff880125210000 ffff8801251b1d90 ffffffff8119a9e5 ffff8801251f80d0 <0> ffff880126dcdb18 ffff8801251b1db0 ffffffff8119aa62 ffff880126dcdb18 Call Trace: [<ffffffff8119a856>] ? cfq_put_queue+0xfa/0x102 [<ffffffff8119a9e5>] cfq_exit_cfqq+0x99/0x9e [<ffffffff8119aa62>] __cfq_exit_single_io_context+0x78/0x85 [<ffffffff8119aaa9>] cfq_exit_single_io_context+0x3a/0x52 [<ffffffff8119aa6f>] ? cfq_exit_single_io_context+0x0/0x52 [<ffffffff8119b27b>] call_for_each_cic+0x56/0x7c [<ffffffff8119b225>] ? call_for_each_cic+0x0/0x7c [<ffffffff8119b2b1>] cfq_exit_io_context+0x10/0x12 [<ffffffff81192d3b>] exit_io_context+0x93/0xbc [<ffffffff81192d03>] ? exit_io_context+0x5b/0xbc [<ffffffff810474e5>] do_exit+0x71a/0x747 [<ffffffff810628f1>] ? async_thread+0x0/0x1fa [<ffffffff8105cd9e>] kthread_stop+0x0/0xb3 [<ffffffff81033fa6>] ? complete+0x1c/0x4b [<ffffffff8100cafa>] child_rip+0xa/0x20 [<ffffffff8103d667>] ? finish_task_switch+0x0/0xe3 [<ffffffff8100c4bc>] ? restore_args+0x0/0x30 [<ffffffff8105ccf8>] ? kthreadd+0xdf/0x100 [<ffffffff8105cd19>] ? kthread+0x0/0x85 [<ffffffff8100caf0>] ? child_rip+0x0/0x20 Code: 48 c7 43 38 00 00 00 00 48 c7 43 40 00 00 00 00 48 89 3e 48 8b 73 48 e8 fd 9e 00 00 eb 08 48 c7 43 48 00 00 00 00 5b 41 5c c9 c3 <8b> 87 d8 01 00 00 55 48 89 e5 85 c0 7f 04 0f 0b eb fe 48 8d 87 RIP [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP <ffff8801251b1d48> ---[ end trace ac909576caca45e8 ]---
Quoted 29 lines · Jeff Moyer
Quoted 15 lines · Jens Axboe
Quoted 14 lines · Jeff Moyer
Quoted 12 lines · Jens Axboe
Quoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.I queued this up for post inclusion into 2.6.33, with the
time_after()fixed.Quoted 6 lines
Quoted 4 lines
Quoted 1 line
The patch was word-wrapped, btw.
So in what branch can I find this fix? Once I know that I can queue up some tests.
It's in next-2.6.33
next-2.6.33 won't boot for me:
general protection fault: 0000 [#1] SMPasync/0 used greatest stack depth: 4256 bytes left
Quoted 7 lines
last sysfs file:
/sys/class/firmware/timeout
CPU 1Modules linked in: ata_piix pata_acpi libata sd_mod scsi_mod ext3 jbd mbcache uh ci_hcd ohci_hcd ehci_hcd Pid: 729, comm: async/1 Not tainted 2.6.32 #1 ProLiant DL320 G5p RIP: 0010:[<ffffffff81199cee>] [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP: 0018:ffff8801251b1d48 EFLAGS: 00010002
Thanks Jeff. Looks like something wrong with my code. I am looking into it now.
Thanks
Vivek
Quoted 40 lines
RAX: ffff880126dcdd28 RBX: ffff8801251fa158 RCX: 0000000000170001 RDX: ffff880125556700 RSI: ffff8801251fa158 RDI: 6b6b6b6b6b6b6b6b RBP: ffff8801251b1d70 R08: ffff8801255a0448 R09: 000000000000005a R10: ffff8801255a0448 R11: ffffffff818d6210 R12: ffff880126dcdb18 R13: ffff880126dcdb50 R14: 0000000000000286 R15: ffff880125556760 FS: 0000000000000000(0000) GS:ffff88002f200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000000000 CR3: 00000001256a5000 CR4: 00000000000006a0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process async/1 (pid: 729, threadinfo ffff8801251b0000, task ffff880125556770) Stack: ffffffff8119a856 0000000000000002 ffff880126dcdb18 ffff8801251fa158 <0> ffff880125210000 ffff8801251b1d90 ffffffff8119a9e5 ffff8801251f80d0 <0> ffff880126dcdb18 ffff8801251b1db0 ffffffff8119aa62 ffff880126dcdb18 Call Trace: [<ffffffff8119a856>] ? cfq_put_queue+0xfa/0x102 [<ffffffff8119a9e5>] cfq_exit_cfqq+0x99/0x9e [<ffffffff8119aa62>] __cfq_exit_single_io_context+0x78/0x85 [<ffffffff8119aaa9>] cfq_exit_single_io_context+0x3a/0x52 [<ffffffff8119aa6f>] ? cfq_exit_single_io_context+0x0/0x52 [<ffffffff8119b27b>] call_for_each_cic+0x56/0x7c [<ffffffff8119b225>] ? call_for_each_cic+0x0/0x7c [<ffffffff8119b2b1>] cfq_exit_io_context+0x10/0x12 [<ffffffff81192d3b>] exit_io_context+0x93/0xbc [<ffffffff81192d03>] ? exit_io_context+0x5b/0xbc [<ffffffff810474e5>] do_exit+0x71a/0x747 [<ffffffff810628f1>] ? async_thread+0x0/0x1fa [<ffffffff8105cd9e>] kthread_stop+0x0/0xb3 [<ffffffff81033fa6>] ? complete+0x1c/0x4b [<ffffffff8100cafa>] child_rip+0xa/0x20 [<ffffffff8103d667>] ? finish_task_switch+0x0/0xe3 [<ffffffff8100c4bc>] ? restore_args+0x0/0x30 [<ffffffff8105ccf8>] ? kthreadd+0xdf/0x100 [<ffffffff8105cd19>] ? kthread+0x0/0x85 [<ffffffff8100caf0>] ? child_rip+0x0/0x20 Code: 48 c7 43 38 00 00 00 00 48 c7 43 40 00 00 00 00 48 89 3e 48 8b 73 48 e8 fd 9e 00 00 eb 08 48 c7 43 48 00 00 00 00 5b 41 5c c9 c3 <8b> 87 d8 01 00 00 55 48 89 e5 85 c0 7f 04 0f 0b eb fe 48 8d 87 RIP [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP <ffff8801251b1d48> ---[ end trace ac909576caca45e8 ]---
Quoted 67 lines · Jeff Moyer
Quoted 15 lines · Jens Axboe
Quoted 14 lines · Jeff Moyer
Quoted 12 lines · Jens Axboe
Quoted 7 lines · Corrado Zoccolo
Hi Jeff,
I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.I queued this up for post inclusion into 2.6.33, with the
time_after()fixed.Quoted 6 lines
Quoted 4 lines
Quoted 1 line
The patch was word-wrapped, btw.
So in what branch can I find this fix? Once I know that I can queue up some tests.
It's in next-2.6.33
next-2.6.33 won't boot for me:
general protection fault: 0000 [#1] SMPasync/0 used greatest stack depth: 4256 bytes left
last sysfs file:
/sys/class/firmware/timeout
CPU 1Modules linked in: ata_piix pata_acpi libata sd_mod scsi_mod ext3 jbd mbcache uh ci_hcd ohci_hcd ehci_hcd Pid: 729, comm: async/1 Not tainted 2.6.32 #1 ProLiant DL320 G5p RIP: 0010:[<ffffffff81199cee>] [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP: 0018:ffff8801251b1d48 EFLAGS: 00010002 RAX: ffff880126dcdd28 RBX: ffff8801251fa158 RCX: 0000000000170001 RDX: ffff880125556700 RSI: ffff8801251fa158 RDI: 6b6b6b6b6b6b6b6b RBP: ffff8801251b1d70 R08: ffff8801255a0448 R09: 000000000000005a R10: ffff8801255a0448 R11: ffffffff818d6210 R12: ffff880126dcdb18 R13: ffff880126dcdb50 R14: 0000000000000286 R15: ffff880125556760 FS: 0000000000000000(0000) GS:ffff88002f200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000000000 CR3: 00000001256a5000 CR4: 00000000000006a0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process async/1 (pid: 729, threadinfo ffff8801251b0000, task ffff880125556770) Stack: ffffffff8119a856 0000000000000002 ffff880126dcdb18 ffff8801251fa158 <0> ffff880125210000 ffff8801251b1d90 ffffffff8119a9e5 ffff8801251f80d0 <0> ffff880126dcdb18 ffff8801251b1db0 ffffffff8119aa62 ffff880126dcdb18 Call Trace: [<ffffffff8119a856>] ? cfq_put_queue+0xfa/0x102 [<ffffffff8119a9e5>] cfq_exit_cfqq+0x99/0x9e [<ffffffff8119aa62>] __cfq_exit_single_io_context+0x78/0x85 [<ffffffff8119aaa9>] cfq_exit_single_io_context+0x3a/0x52 [<ffffffff8119aa6f>] ? cfq_exit_single_io_context+0x0/0x52 [<ffffffff8119b27b>] call_for_each_cic+0x56/0x7c [<ffffffff8119b225>] ? call_for_each_cic+0x0/0x7c [<ffffffff8119b2b1>] cfq_exit_io_context+0x10/0x12 [<ffffffff81192d3b>] exit_io_context+0x93/0xbc [<ffffffff81192d03>] ? exit_io_context+0x5b/0xbc [<ffffffff810474e5>] do_exit+0x71a/0x747 [<ffffffff810628f1>] ? async_thread+0x0/0x1fa [<ffffffff8105cd9e>] kthread_stop+0x0/0xb3 [<ffffffff81033fa6>] ? complete+0x1c/0x4b [<ffffffff8100cafa>] child_rip+0xa/0x20
Quoted 8 lines
[<ffffffff8103d667>] ? finish_task_switch+0x0/0xe3 [<ffffffff8100c4bc>] ? restore_args+0x0/0x30 [<ffffffff8105ccf8>] ? kthreadd+0xdf/0x100 [<ffffffff8105cd19>] ? kthread+0x0/0x85 [<ffffffff8100caf0>] ? child_rip+0x0/0x20 Code: 48 c7 43 38 00 00 00 00 48 c7 43 40 00 00 00 00 48 89 3e 48 8b 73 48 e8 fd 9e 00 00 eb 08 48 c7 43 48 00 00 00 00 5b 41 5c c9 c3 <8b> 87 d8 01 00 00 55 48 89 e5 85 c0 7f 04 0f 0b eb fe 48 8d 87 RIP [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP <ffff8801251b1d48>
Hm.., I seem to be accessing cfqq->orig_cfqg, after I have freed cfqq. Following patch should fix it. Testing it now.
Thanks
Vivek
block/cfq-iosched.c +4 -3
@@ -2368,7 +2368,7 @@ static int cfq_dispatch_requests(structstatic void cfq_put_queue (struct cfq_queue *cfqq) {struct cfq_data *cfqd = cfqq->cfqd; -struct cfq_group *cfqg; +struct cfq_group *cfqg, *orig_cfqg;BUG_ON (atomic_read (&cfqq->ref) <=0 );
@@ -2379,6 +2379,7 @@ static void cfq_put_queue(struct cfq_queBUG_ON (rb_first (&cfqq->sort_list));BUG_ON (cfqq->allocated[READ ] + cfqq->allocated[WRITE ]); cfqg = cfqq->cfqg; + orig_cfqg = cfqq->orig_cfqg;if (unlikely (cfqd->active_queue == cfqq)) {__cfq_slice_expired (cfqd, cfqq,0 );
@@ -2388,8 +2389,8 @@ static void cfq_put_queue(struct cfq_queBUG_ON (cfq_cfqq_on_rr (cfqq));kmem_cache_free (cfq_pool, cfqq);cfq_put_cfqg (cfqg); -if (cfqq->orig_cfqg) -cfq_put_cfqg (cfqq->orig_cfqg); +if (orig_cfqg) +cfq_put_cfqg (orig_cfqg); }/*
On Mon, Dec 07, 2009 at 12:27:47PM -0500, Vivek Goyal wrote:
[..]
Quoted 52 lines
Quoted 43 lines
next-2.6.33 won't boot for me:
general protection fault: 0000 [#1] SMPasync/0 used greatest stack depth: 4256 bytes left
last sysfs file:
/sys/class/firmware/timeout
CPU 1Modules linked in: ata_piix pata_acpi libata sd_mod scsi_mod ext3 jbd mbcache uh ci_hcd ohci_hcd ehci_hcd Pid: 729, comm: async/1 Not tainted 2.6.32 #1 ProLiant DL320 G5p RIP: 0010:[<ffffffff81199cee>] [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP: 0018:ffff8801251b1d48 EFLAGS: 00010002 RAX: ffff880126dcdd28 RBX: ffff8801251fa158 RCX: 0000000000170001 RDX: ffff880125556700 RSI: ffff8801251fa158 RDI: 6b6b6b6b6b6b6b6b RBP: ffff8801251b1d70 R08: ffff8801255a0448 R09: 000000000000005a R10: ffff8801255a0448 R11: ffffffff818d6210 R12: ffff880126dcdb18 R13: ffff880126dcdb50 R14: 0000000000000286 R15: ffff880125556760 FS: 0000000000000000(0000) GS:ffff88002f200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b CR2: 0000000000000000 CR3: 00000001256a5000 CR4: 00000000000006a0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process async/1 (pid: 729, threadinfo ffff8801251b0000, task ffff880125556770) Stack: ffffffff8119a856 0000000000000002 ffff880126dcdb18 ffff8801251fa158 <0> ffff880125210000 ffff8801251b1d90 ffffffff8119a9e5 ffff8801251f80d0 <0> ffff880126dcdb18 ffff8801251b1db0 ffffffff8119aa62 ffff880126dcdb18 Call Trace: [<ffffffff8119a856>] ? cfq_put_queue+0xfa/0x102 [<ffffffff8119a9e5>] cfq_exit_cfqq+0x99/0x9e [<ffffffff8119aa62>] __cfq_exit_single_io_context+0x78/0x85 [<ffffffff8119aaa9>] cfq_exit_single_io_context+0x3a/0x52 [<ffffffff8119aa6f>] ? cfq_exit_single_io_context+0x0/0x52 [<ffffffff8119b27b>] call_for_each_cic+0x56/0x7c [<ffffffff8119b225>] ? call_for_each_cic+0x0/0x7c [<ffffffff8119b2b1>] cfq_exit_io_context+0x10/0x12 [<ffffffff81192d3b>] exit_io_context+0x93/0xbc [<ffffffff81192d03>] ? exit_io_context+0x5b/0xbc [<ffffffff810474e5>] do_exit+0x71a/0x747 [<ffffffff810628f1>] ? async_thread+0x0/0x1fa [<ffffffff8105cd9e>] kthread_stop+0x0/0xb3 [<ffffffff81033fa6>] ? complete+0x1c/0x4b [<ffffffff8100cafa>] child_rip+0xa/0x20Quoted 8 lines
[<ffffffff8103d667>] ? finish_task_switch+0x0/0xe3 [<ffffffff8100c4bc>] ? restore_args+0x0/0x30 [<ffffffff8105ccf8>] ? kthreadd+0xdf/0x100 [<ffffffff8105cd19>] ? kthread+0x0/0x85 [<ffffffff8100caf0>] ? child_rip+0x0/0x20 Code: 48 c7 43 38 00 00 00 00 48 c7 43 40 00 00 00 00 48 89 3e 48 8b 73 48 e8 fd 9e 00 00 eb 08 48 c7 43 48 00 00 00 00 5b 41 5c c9 c3 <8b> 87 d8 01 00 00 55 48 89 e5 85 c0 7f 04 0f 0b eb fe 48 8d 87 RIP [<ffffffff81199cee>] cfq_put_cfqg+0x0/0x91 RSP <ffff8801251b1d48>
Quoted 3 lines
Hm.., I seem to be accessing
cfqq->orig_cfqg, after I have freed cfqq. Following patch should fix it. Testing it now.
I tested this patch and it is working. Now system boots fine. Thanks for loaning the system to me Jeff.
Vivek
Quoted 35 lines
Thanks
VivekIndex:
linux-2.6-block/block/cfq-iosched.c
===================================================================block/cfq-iosched.c +4
-3@@ -2368,7 +2368,7 @@ static int cfq_dispatch_requests(structstatic void cfq_put_queue (struct cfq_queue *cfqq) {struct cfq_data *cfqd = cfqq->cfqd; -struct cfq_group *cfqg; +struct cfq_group *cfqg, *orig_cfqg;BUG_ON (atomic_read (&cfqq->ref) <=0 );@@ -2379,6 +2379,7 @@ static void cfq_put_queue(struct cfq_queBUG_ON (rb_first (&cfqq->sort_list));BUG_ON (cfqq->allocated[READ ] + cfqq->allocated[WRITE ]); cfqg = cfqq->cfqg; + orig_cfqg = cfqq->orig_cfqg;if (unlikely (cfqd->active_queue == cfqq)) {__cfq_slice_expired (cfqd, cfqq,0 );@@ -2388,8 +2389,8 @@ static void cfq_put_queue(struct cfq_queBUG_ON (cfq_cfqq_on_rr (cfqq));kmem_cache_free (cfq_pool, cfqq);cfq_put_cfqg (cfqg); -if (cfqq->orig_cfqg) -cfq_put_cfqg (cfqq->orig_cfqg); +if (orig_cfqg) +cfq_put_cfqg (orig_cfqg); }/*
Quoted 6 lines · Corrado Zoccolo
Hi Jeff, I remember you saw large performance drop on your SAN for sequential writes with low_latency=1. Can you test if Shaohua's and this patch fix allow to recover some bandwidth? I think that enabling the queue depth ramp up only if a sync request was delayed should disable it for fast hardware like yours, so you should not be seeing the slowdown any more.
Average of 10 runs. Low latency set to 0:
Unit information
================
File size = megabytes
Blk Size = bytes Rate = megabytes per second CPU% = percentage of CPU used during the test Latency = milliseconds Lat% = percent of requests that took longer than X seconds CPU Eff = Rate divided by CPU% - throughput per cpu load
Sequential Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 90.08 94.51% 51.316 10268.25 0.00000 0.00000 95 2.6.32 8192 65536 16 99.36 199.8% 89.248 13883.81 0.00000 0.00000 50
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 81.16 85.90% 45.672 5963.19 0.00000 0.00000 94 2.6.32 8192 65536 16 116.32 230.3% 58.371 6098.36 0.00000 0.00000 51
Sequential Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 112.17 1085.% 42.623 17114.54 0.00152 0.00000 10 2.6.32 8192 65536 16 111.26 2117.% 84.964 26480.60 0.03202 0.00000 5
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 162.48 887.1% 6.106 313.54 0.00000 0.00000 18 2.6.32 8192 65536 16 156.38 1767.% 14.077 1254.62 0.00000 0.00000 9
Average of 10 runs. Low latency set to 1:
Unit information
================
File size = megabytes
Blk Size = bytes Rate = megabytes per second CPU% = percentage of CPU used during the test Latency = milliseconds Lat% = percent of requests that took longer than X seconds CPU Eff = Rate divided by CPU% - throughput per cpu load
Sequential Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 92.23 100.1% 52.119 6920.18 0.00000 0.00000 92 2.6.32 8192 65536 16 97.88 217.0% 99.691 7453.18 0.00000 0.00000 45
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 98.70 107.5% 42.994 3409.08 0.00000 0.00000 92 2.6.32 8192 65536 16 140.41 323.9% 59.616 4525.46 0.00000 0.00000 43
Sequential Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 112.33 1076.% 42.617 17072.28 0.00076 0.00000 10 2.6.32 8192 65536 16 111.84 2097.% 85.156 28221.77 0.02976 0.00000 5
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 159.33 870.5% 6.469 765.50 0.00000 0.00000 18 2.6.32 8192 65536 16 141.60 1632.% 15.364 2337.57 0.00000 0.00000 9
Cheers,
Jeff
On Tue, Dec 8, 2009 at 1:07 AM, Jeff Moyer <[email protected]> wrote:> Corrado Zoccolo <[email protected]> writes:>>> Hi Jeff, I remember you saw large performance drop on your SAN for>> sequential writes with low_latency=1. Can you test if Shaohua's and>> this patch fix allow to recover some bandwidth? I think that enabling>> the queue depth ramp up only if a sync request was delayed should>> disable it for fast hardware like yours, so you should not be seeing>> the slowdown any more.>> Average of 10 runs. Low latency set to 0:>> Unit information> ================> File size = megabytes> Blk Size = bytes> Rate = megabytes per second> CPU% = percentage of CPU used during the test> Latency = milliseconds> Lat% = percent of requests that took longer than X seconds> CPU Eff = Rate divided by CPU% - throughput per cpu load>> Sequential Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 90.08 94.51% 51.316 10268.25 0.00000 0.00000 95> 2.6.32 8192 65536 16 99.36 199.8% 89.248 13883.81 0.00000 0.00000 50>> Random Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 81.16 85.90% 45.672 5963.19 0.00000 0.00000 94> 2.6.32 8192 65536 16 116.32 230.3% 58.371 6098.36 0.00000 0.00000 51>> Sequential Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 112.17 1085.% 42.623 17114.54 0.00152 0.00000 10> 2.6.32 8192 65536 16 111.26 2117.% 84.964 26480.60 0.03202 0.00000 5>> Random Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 162.48 887.1% 6.106 313.54 0.00000 0.00000 18> 2.6.32 8192 65536 16 156.38 1767.% 14.077 1254.62 0.00000 0.00000 9>>> Average of 10 runs. Low latency set to 1:>> Unit information> ================> File size = megabytes> Blk Size = bytes> Rate = megabytes per second> CPU% = percentage of CPU used during the test> Latency = milliseconds> Lat% = percent of requests that took longer than X seconds> CPU Eff = Rate divided by CPU% - throughput per cpu load>> Sequential Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 92.23 100.1% 52.119 6920.18 0.00000 0.00000 92> 2.6.32 8192 65536 16 97.88 217.0% 99.691 7453.18 0.00000 0.00000 45>> Random Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 98.70 107.5% 42.994 3409.08 0.00000 0.00000 92> 2.6.32 8192 65536 16 140.41 323.9% 59.616 4525.46 0.00000 0.00000 43>> Sequential Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 112.33 1076.% 42.617 17072.28 0.00076 0.00000 10> 2.6.32 8192 65536 16 111.84 2097.% 85.156 28221.77 0.02976 0.00000 5>> Random Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 159.33 870.5% 6.469 765.50 0.00000 0.00000 18> 2.6.32 8192 65536 16 141.60 1632.% 15.364 2337.57 0.00000 0.00000 9>>> Cheers,> Jeff> The numbers look good. Now, there is no penalty in having low_latencyset for sequential writes, and just a small penalty for random ones.The fact that random reads are faster with low_latency set is interesting.Is the test is running with your patched tiobench (so that the numberof random operations is comparable with sequential ones)?
Thanks,Corrado
-- __________________________________________________________________________
dott. Corrado Zoccolo mailto:[email protected] - Department of Computer Science - University of Pisa, Italy--------------------------------------------------------------------------The self-confidence of a warrior is not the self-confidence of the averageman. The average man seeks certainty in the eyes of the onlooker and callsthat self-confidence. The warrior seeks impeccability in his own eyes andcalls that humbleness. Tales of Power - C. Castaneda���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
Quoted 5 lines · Corrado Zoccolo
The numbers look good. Now, there is no penalty in having
low_latencyset for sequential writes, and just a small penalty for random ones. The fact that random reads are faster withlow_latencyset is interesting. Is the test is running with your patched tiobench (so that the number of random operations is comparable with sequential ones)?
No, I forgot all about that. The number of random operations defaults to 4000, which is pretty low. I'll re-run the tests with a number comparable to the sequential runs. Sorry about that.
Cheers,
Jeff
Hi Jeff,
Quoted 8 lines · Jeff Moyer
Quoted 5 lines · Corrado Zoccolo
The numbers look good. Now, there is no penalty in having
low_latencyset for sequential writes, and just a small penalty for random ones. The fact that random reads are faster withlow_latencyset is interesting. Is the test is running with your patched tiobench (so that the number of random operations is comparable with sequential ones)?
Quoted 4 lines
No, I forgot all about that. The number of random operations defaults to 4000, which is pretty low. I'll re-run the tests with a number comparable to the sequential runs. Sorry about that.
N.P.
if you have time, can you also re-run the test changing:
iosched/fifo_expire_async to 8 ?
I hope that reducing the expire_async, will make cfq quicker at switching between the different threads, allowing more parallelism for seq writers on your hw.
If this is the case, I think I can try to estimate the fifo_expire_async in the autotuning patch.
Quoted 3 lines
Cheers,
Jeff
Thanks
Corrado
Quoted 10 lines · Corrado Zoccolo
Hi Jeff,
Quoted 8 lines · Jeff Moyer
Quoted 5 lines · Corrado Zoccolo
The numbers look good. Now, there is no penalty in having
low_latencyset for sequential writes, and just a small penalty for random ones. The fact that random reads are faster withlow_latencyset is interesting. Is the test is running with your patched tiobench (so that the number of random operations is comparable with sequential ones)?
Quoted 5 lines
Quoted 4 lines
No, I forgot all about that. The number of random operations defaults to 4000, which is pretty low. I'll re-run the tests with a number comparable to the sequential runs. Sorry about that.
N.P.
low_latency=1
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 19.35 26.10% 74.639 3278.74 0.00000 0.00000 74 2.6.32 8192 65536 16 20.40 53.07% 135.695 3705.55 0.00000 0.00000 38
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 64.64 342.2% 22.708 5960.22 0.00153 0.00000 19 2.6.32 8192 65536 16 61.19 663.7% 47.648 11294.56 0.16098 0.00000 9
low_latency=0
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 19.71 25.32% 70.891 4340.92 0.00000 0.00000 78 2.6.32 8192 65536 16 22.67 58.94% 121.669 6180.49 0.00229 0.00000 38
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 64.69 339.5% 22.651 6770.99 0.00152 0.00000 19 2.6.32 8192 65536 16 61.94 663.0% 46.962 10719.13 0.12741 0.00000 9
Quoted 2 lines
if you have time, can you also re-run the test changing:
iosched/fifo_expire_async to 8 ?
Sure.
Cheers,
Jeff
Quoted 14 lines · Corrado Zoccolo
Hi Jeff,
Quoted 8 lines · Jeff Moyer
Quoted 5 lines · Corrado Zoccolo
The numbers look good. Now, there is no penalty in having
low_latencyset for sequential writes, and just a small penalty for random ones. The fact that random reads are faster withlow_latencyset is interesting. Is the test is running with your patched tiobench (so that the number of random operations is comparable with sequential ones)?Quoted 4 lines
No, I forgot all about that. The number of random operations defaults to 4000, which is pretty low. I'll re-run the tests with a number comparable to the sequential runs. Sorry about that.
Quoted 8 lines
N.P.
if you have time, can you also re-run the test changing:
iosched/fifo_expire_async to 8 ?
I hope that reducing theexpire_async, will make cfq quicker at switching between the different threads, allowing more parallelism for seq writers on your hw.
If this is the case, I think I can try to estimate thefifo_expire_asyncin the autotuning patch.
Sorry this took so long. I've been rather busy of late.
Cheers,
Jeff
low_latency=1, fifo_expire_async=8
Unit information
================
File size = megabytes
Blk Size = bytes Rate = megabytes per second CPU% = percentage of CPU used during the test Latency = milliseconds Lat% = percent of requests that took longer than X seconds CPU Eff = Rate divided by CPU% - throughput per cpu load
Sequential Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 88.39 89.74% 16.388 2032.62 0.00000 0.00000 98 2.6.32 8192 65536 16 90.77 185.3% 32.213 2175.99 0.00000 0.00000 49
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 19.62 25.74% 71.827 3397.26 0.00000 0.00000 76 2.6.32 8192 65536 16 23.82 55.01% 103.361 4075.53 0.00000 0.00000 43
Sequential Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 108.28 1007.% 12.984 5643.55 0.00076 0.00000 11 2.6.32 8192 65536 16 112.40 2014.% 25.430 8592.98 0.00839 0.00000 6
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 63.94 337.7% 22.885 6047.22 0.00076 0.00000 19 2.6.32 8192 65536 16 61.94 662.5% 46.997 12759.69 0.15411 0.00000 9
low_latency=0, fifo_expire_async=8
Unit information
================
File size = megabytes
Blk Size = bytes Rate = megabytes per second CPU% = percentage of CPU used during the test Latency = milliseconds Lat% = percent of requests that took longer than X seconds CPU Eff = Rate divided by CPU% - throughput per cpu load
Sequential Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 89.13 88.30% 15.872 3101.39 0.00000 0.00000 101 2.6.32 8192 65536 16 86.78 161.7% 30.794 4909.02 0.00000 0.00000 54
Random Reads
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 20.21 26.64% 69.863 4285.42 0.00000 0.00000 76 2.6.32 8192 65536 16 20.10 52.75% 139.761 5986.94 0.00076 0.00000 38
Sequential Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 108.74 1020.% 13.070 5331.78 0.00076 0.00000 11 2.6.32 8192 65536 16 112.18 2020.% 25.559 7903.16 0.00992 0.00000 6
Random Writes
File Blk Num Avg Maximum Lat% Lat% CPU Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- ----- 2.6.32 8192 65536 8 64.53 337.8% 22.671 5388.77 0.00000 0.00000 19 2.6.32 8192 65536 16 61.75 668.9% 47.265 13271.37 0.12894 0.00000 9
Thanks Jeff.Your tests show that with the patch, low_latency doesn't penalizewriteback any more on fast hardware, so the goal of the patch isfulfilled. Lowering slice_async doesn't change the picture (I wasexpecting an improvement in seq write bandwidth).I'm still puzzled of why with 2.6.29 your SAN could achieve 300 MB/ssequential writes, and it can't achieve it any more.Can you try lowering slice_idle, trying e.g. 2ms?
ThanksCorrado
On Fri, Dec 18, 2009 at 4:32 PM, Jeff Moyer <[email protected]> wrote:> Corrado Zoccolo <[email protected]> writes:>>> Hi Jeff,>> On Wed, Dec 9, 2009 at 7:09 PM, Jeff Moyer <[email protected]> wrote:>>> Corrado Zoccolo <[email protected]> writes:>>>>>>> The numbers look good. Now, there is no penalty in having low_latency>>>> set for sequential writes, and just a small penalty for random ones.>>>> The fact that random reads are faster with low_latency set is interesting.>>>> Is the test is running with your patched tiobench (so that the number>>>> of random operations is comparable with sequential ones)?>>>>>> No, I forgot all about that. The number of random operations defaults>>> to 4000, which is pretty low. I'll re-run the tests with a number>>> comparable to the sequential runs. Sorry about that.>>>>> N.P.>> if you have time, can you also re-run the test changing:>> iosched/fifo_expire_async to 8 ?>> I hope that reducing the expire_async, will make cfq quicker at switching>> between the different threads, allowing more parallelism for seq>> writers on your hw.>> If this is the case, I think I can try to estimate the>> fifo_expire_async in the autotuning patch.>> Sorry this took so long. I've been rather busy of late.>> Cheers,> Jeff>> low_latency=1, fifo_expire_async=8>> Unit information> ================> File size = megabytes> Blk Size = bytes> Rate = megabytes per second> CPU% = percentage of CPU used during the test> Latency = milliseconds> Lat% = percent of requests that took longer than X seconds> CPU Eff = Rate divided by CPU% - throughput per cpu load>> Sequential Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 88.39 89.74% 16.388 2032.62 0.00000 0.00000 98> 2.6.32 8192 65536 16 90.77 185.3% 32.213 2175.99 0.00000 0.00000 49>> Random Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 19.62 25.74% 71.827 3397.26 0.00000 0.00000 76> 2.6.32 8192 65536 16 23.82 55.01% 103.361 4075.53 0.00000 0.00000 43>> Sequential Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 108.28 1007.% 12.984 5643.55 0.00076 0.00000 11> 2.6.32 8192 65536 16 112.40 2014.% 25.430 8592.98 0.00839 0.00000 6>> Random Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 63.94 337.7% 22.885 6047.22 0.00076 0.00000 19> 2.6.32 8192 65536 16 61.94 662.5% 46.997 12759.69 0.15411 0.00000 9>>> low_latency=0, fifo_expire_async=8>> Unit information> ================> File size = megabytes> Blk Size = bytes> Rate = megabytes per second> CPU% = percentage of CPU used during the test> Latency = milliseconds> Lat% = percent of requests that took longer than X seconds> CPU Eff = Rate divided by CPU% - throughput per cpu load>> Sequential Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 89.13 88.30% 15.872 3101.39 0.00000 0.00000 101> 2.6.32 8192 65536 16 86.78 161.7% 30.794 4909.02 0.00000 0.00000 54>> Random Reads> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 20.21 26.64% 69.863 4285.42 0.00000 0.00000 76> 2.6.32 8192 65536 16 20.10 52.75% 139.761 5986.94 0.00076 0.00000 38>> Sequential Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 108.74 1020.% 13.070 5331.78 0.00076 0.00000 11> 2.6.32 8192 65536 16 112.18 2020.% 25.559 7903.16 0.00992 0.00000 6>> Random Writes> File Blk Num Avg Maximum Lat% Lat% CPU> Identifier Size Size Thr Rate (CPU%) Latency Latency >2s >10s Eff> ---------------------------- ------ ----- --- ------ ------ --------- ----------- -------- -------- -----> 2.6.32 8192 65536 8 64.53 337.8% 22.671 5388.77 0.00000 0.00000 19> 2.6.32 8192 65536 16 61.75 668.9% 47.265 13271.37 0.12894 0.00000 9>
-- __________________________________________________________________________
dott. Corrado Zoccolo mailto:[email protected] - Department of Computer Science - University of Pisa, Italy--------------------------------------------------------------------------The self-confidence of a warrior is not the self-confidence of the averageman. The average man seeks certainty in the eyes of the onlooker and callsthat self-confidence. The warrior seeks impeccability in his own eyes andcalls that humbleness. Tales of Power - C. Castaneda���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
Review static void *cfq_init_queue(struct request_queue *q) · line 3710
Quoted 10 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
(quoted diff) +1
-1@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ;
So, umm, what's that about?
Cheers,
Jeff
Hi Jeff,
Quoted 14 lines · Jeff Moyer
Review static void *cfq_init_queue(struct request_queue *q) · line 3710
Quoted 10 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
(quoted diff) +1
-1@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ;So, umm, what's that about?
Previously, when cfq started, it started in a state where writes were completely throttled. Now, we optimistically prefer to start with a reasonable max depth (10)
Thanks
Corrado
Quoted 3 lines
Cheers,
Jeff
Signature · 10 lines
__________________________________________________________________________ dott. Corrado Zoccolo mailto:[email protected] PhD - Department of Computer Science - University of Pisa, Italy -------------------------------------------------------------------------- The self-confidence of a warrior is not the self-confidence of the average man. The average man seeks certainty in the eyes of the onlooker and calls that self-confidence. The warrior seeks impeccability in his own eyes and calls that humbleness. Tales of Power - C. Castaneda
Quoted 17 lines · Corrado Zoccolo
Hi Jeff,
Quoted 14 lines · Jeff Moyer
Review static void *cfq_init_queue(struct request_queue *q) · line 3710
Quoted 10 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
(quoted diff) +1
-1@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ;So, umm, what's that about?
Quoted 3 lines
Previously, when cfq started, it started in a state where writes were completely throttled. Now, we optimistically prefer to start with a reasonable max depth (10)
OK. Can we put a comment in there and change the initialization to cfq_slice_sync * 10?
Thanks,
Jeff
Quoted 19 lines · Jeff Moyer
Quoted 17 lines · Corrado Zoccolo
Hi Jeff,
Quoted 14 lines · Jeff Moyer
Review static void *cfq_init_queue(struct request_queue *q) · line 3710
Quoted 10 lines · Corrado Zoccolo
The introduction of ramp-up formula for async queue depths has slowed down dirty page reclaim, by reducing async write performance. This patch makes sure the formula kicks in only when sync request was recently delayed.
(quoted diff) +1
-1@@ -3706,7 +3707,7 @@ static void *cfq_init_queue(struct request_queue *q) cfqd->cfq_latency = 1; cfqd->cfq_group_isolation = 0; cfqd->hw_tag = -1; - cfqd->last_end_sync_rq = jiffies; + cfqd->last_delayed_sync = jiffies - HZ;So, umm, what's that about?
Quoted 6 lines
Quoted 3 lines
Previously, when cfq started, it started in a state where writes were completely throttled. Now, we optimistically prefer to start with a reasonable max depth (10)
OK. Can we put a comment in there and change the initialization to
cfq_slice_sync* 10?
Agree, that would be MUCH easier to understand.
Signature · 1 line
Jens Axboe