Skip to contentSkip to conversation

Check if start address is in vma region in NOMMU function get_user_pages().

PATCH New Sonic Zhang 1 participant 1 message Aug 31, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Check if start address is in vma region in NOMMU function get_user_pages().

Hi,

In NOMMU arch, if run "cat /proc/self/mem", data from physical address 0 are read. This behavior is different from MMU arch. In IA32, message "cat: /proc/self/mem: Input/output error" is reported.

This issue is rootcaused by not validate the start address in NOMMU function get_user_pages(). Following patch solves this issue.

Thanks

Sonic Zhang

mm/nommu.c +0 -0
@@ -138,16 +138,20 @@

struct page **pages, struct vm_area_struct **vmas)

{
	int i;

- static struct vm_area_struct dummy_vma;
+ struct vm_area_struct *vma;

	for (i = 0; i < len; i++) {

+ vma = find_vma(mm, start);
+ if(!vma)
+ return i ? : -EFAULT;
+

		if (pages) {
			pages[i] = virt_to_page(start);
			if (pages[i])
				page_cache_get(pages[i]);
		}
		if (vmas)
-			vmas[i] = &dummy_vma;
+			vmas[i] = vma;
		start += PAGE_SIZE;
	}
	return(i);