Drop from 5.15 and older -- clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz
Please drop the following commits from stable 5.10.y and 5.15.y respectively
972acd701b19 ("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz") a8474506c912 ("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")
The commit message states 'Cc: [email protected] # v5.18+' and the commit should only be applied to Linux 5.18.y and newer, on anything older it breaks PLL configuration due to missing prerequisite patches.
Thanks
Greg KH
maintainerQuoted 11 lines · Marek Vasut
Please drop the following commits from stable 5.10.y and 5.15.y respectively
972acd701b19("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")a8474506c912("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")The commit message states 'Cc: [email protected] # v5.18+' and the commit should only be applied to Linux 5.18.y and newer, on anything older it breaks PLL configuration due to missing prerequisite patches.
Ok, I'll go revert them, but the Fixes: tag in this commit is very wrong as that's what we used to determine how far back to take these changes.
thanks,
greg k-h
Hello Greg,
Quoted 8 lines · Greg KH
Quoted 7 lines · Marek Vasut
Please drop the following commits from stable 5.10.y and 5.15.y respectively
972acd701b19("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")a8474506c912("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")
Quoted 7 lines
Quoted 4 lines
The commit message states 'Cc: [email protected] # v5.18+' and the commit should only be applied to Linux 5.18.y and newer, on anything older it breaks PLL configuration due to missing prerequisite patches.
Ok, I'll go revert them, but the Fixes: tag in this commit is very wrong as that's what we used to determine how far back to take these changes.
The Fixes tag is correct. The PLL parameters added in that commit were deemed suboptimal. Kernels >= v5.18 can compute better parameters on the fly, so that's why the patch says
Which is the syntax described in Documentation/admin-guide/reporting-issues.rst. I see now though that Documentation/process/stable-kernel-rules.rst has a slightly different syntax:
Perhaps your maintainer scripts can't handle both cases?
FWIW, I've reached out multiple times about that the patches aren't suitable for backports:
- https://lore.kernel.org/all/[email protected]/
- <[email protected]> (reply to linux-stable-commits)
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
Yet, today I got an email[1] telling me that it's being added to v5.4.258-rc1, although it had been dropped from v5.4.257-rc1 after I objected to it.
So that looks like another potential avenue for improving the maintainer scripts.
[1]: https://lore.kernel.org/all/[email protected]/
Thanks,
Ahmad
Quoted 5 lines
thanks,
greg k-h
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 4 lines · Ahmad Fatoum
On 07.10.23 13:44, Greg KH wrote:
Cc: [email protected] # v5.18+Which is the syntax described in
Documentation/admin-guide/reporting-issues.rst.
This is wrong. The example in that file has "Cc: <[email protected]> # 5.4+" without the v. Still, looking at other commits, the syntax with leading v is common enough that it's worth handling.
Quoted 32 lines
I see now though that
Documentation/process/stable-kernel-rules.rsthas a slightly different syntax:Cc <[email protected]> # 3.3.xPerhaps your maintainer scripts can't handle both cases?
FWIW, I've reached out multiple times about that the patches aren't suitable for backports:
- https://lore.kernel.org/all/[email protected]/
- <[email protected]> (reply to linux-stable-commits)
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/Yet, today I got an email[1] telling me that it's being added to v5.4.258-rc1, although it had been dropped from v5.4.257-rc1 after I objected to it.
So that looks like another potential avenue for improving the maintainer scripts.
[1]: https://lore.kernel.org/all/[email protected]/
Thanks,
AhmadQuoted 5 lines
thanks,
greg k-h
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Greg KH
maintainerQuoted 9 lines · Ahmad Fatoum
Quoted 4 lines · Ahmad Fatoum
On 07.10.23 13:44, Greg KH wrote:
Cc: [email protected] # v5.18+Which is the syntax described in
Documentation/admin-guide/reporting-issues.rst.This is wrong. The example in that file has "Cc: <[email protected]> # 5.4+" without the v. Still, looking at other commits, the syntax with leading v is common enough that it's worth handling.
We can handle it either way, it's me reading it, no script is parsing this :)
thanks,
greg k-h
Greg KH
maintainerQuoted 25 lines · Ahmad Fatoum
Hello Greg,
Quoted 8 lines · Greg KH
Quoted 7 lines · Marek Vasut
Please drop the following commits from stable 5.10.y and 5.15.y respectively
972acd701b19("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")a8474506c912("clk: imx: pll14xx: dynamically configure PLL for 393216000/361267200Hz")Quoted 7 lines
Quoted 4 lines
The commit message states 'Cc: [email protected] # v5.18+' and the commit should only be applied to Linux 5.18.y and newer, on anything older it breaks PLL configuration due to missing prerequisite patches.
Ok, I'll go revert them, but the Fixes: tag in this commit is very wrong as that's what we used to determine how far back to take these changes.
The Fixes tag is correct. The PLL parameters added in that commit were deemed suboptimal. Kernels >= v5.18 can compute better parameters on the fly, so that's why the patch says
Cc [email protected] # v5.18+
Quoted 7 lines
Which is the syntax described in
Documentation/admin-guide/reporting-issues.rst. I see now though thatDocumentation/process/stable-kernel-rules.rsthas a slightly different syntax:Cc <[email protected]> # 3.3.xPerhaps your maintainer scripts can't handle both cases?
That's not what happened here, sorry.
We went off of the Fixes: tag, and ignored the # VERSION marking as sometimes that is wrong (like when we backport changes to older kernels.)
Quoted 8 lines
FWIW, I've reached out multiple times about that the patches aren't suitable for backports:
- https://lore.kernel.org/all/[email protected]/
- <[email protected]> (reply to linux-stable-commits)
- https://lore.kernel.org/all/[email protected]/
- https://lore.kernel.org/all/[email protected]/
Quoted 4 lines
Yet, today I got an email[1] telling me that it's being added to v5.4.258-rc1, although it had been dropped from v5.4.257-rc1 after I objected to it.
So that looks like another potential avenue for improving the maintainer scripts.
I'll go drop it from 5.4 again, Sasha's and my scripts don't always sync up well at times, thanks for pointing this out.
greg k-h