Skip to contentSkip to conversation

x86/IST: Fix comment about stack layout

PATCH In review Andrew Cooper 3 participants 4 messages Apr 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/IST: Fix comment about stack layout

This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>

---
 xen/include/asm-x86/current.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/asm-x86/current.h +1 -1
index 0b47485337..39c2c6cbf8 100644
@@ -18,7 +18,7 @@
  * 6 - Primary stack
  * 5 - Optionally not present (MEMORY_GUARD)
  * 4 - Unused; optionally not present (MEMORY_GUARD)
- * 3 - Unused; optionally not present (MEMORY_GUARD)
+ * 3 -  DB IST stack
  * 2 - MCE IST stack
  * 1 - NMI IST stack
  * 0 - Double Fault IST stack
Signature · 1 line
2.11.0
#1 lore raw
Quoted 18 lines · Andrew Cooper

This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>

---
 xen/include/asm-x86/current.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/asm-x86/current.h +0 -0
index 0b47485337..39c2c6cbf8 100644

xen/include/asm-x86/current.h line 21

Quoted 5 lines
xen/include/asm-x86/current.h +1 -1
@@ -18,7 +18,7 @@
  * 6 - Primary stack
  * 5 - Optionally not present (MEMORY_GUARD)
  * 4 - Unused; optionally not present (MEMORY_GUARD)
- * 3 - Unused; optionally not present (MEMORY_GUARD)
+ * 3 -  DB IST stack

There seems to be an extraneous space before "DB".

Wei.

Quoted 6 lines
xen/include/asm-x86/current.h +0 -0
  * 2 - MCE IST stack
  * 1 - NMI IST stack
  * 0 - Double Fault IST stack
Signature · 1 line
2.11.0
Acked-by
#2 lore raw
Quoted 10 lines · Wei Liu

xen/include/asm-x86/current.h line 21

Quoted 8 lines
xen/include/asm-x86/current.h +1 -1
@@ -18,7 +18,7 @@
  * 6 - Primary stack
  * 5 - Optionally not present (MEMORY_GUARD)
  * 4 - Unused; optionally not present (MEMORY_GUARD)
- * 3 - Unused; optionally not present (MEMORY_GUARD)
+ * 3 -  DB IST stack

There seems to be an extraneous space before "DB".

I guess #DB was meant. With that

Jan

#3 lore raw
In reply to Wei Liu
Quoted 14 lines · Wei Liu
Quoted 13 lines · Andrew Cooper

This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.

---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>

---
 xen/include/asm-x86/current.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

xen/include/asm-x86/current.h line 21

Quoted 10 lines
xen/include/asm-x86/current.h +1 -1
index 0b47485337..39c2c6cbf8 100644
@@ -18,7 +18,7 @@
  * 6 - Primary stack
  * 5 - Optionally not present (MEMORY_GUARD)
  * 4 - Unused; optionally not present (MEMORY_GUARD)
- * 3 - Unused; optionally not present (MEMORY_GUARD)
+ * 3 -  DB IST stack

There seems to be an extraneous space before "DB".

Yes.  The alternative would be for misaligned tabulation with the lower "IST stack".

~Andrew

Quoted 9 lines

Wei.

Quoted 6 lines
xen/include/asm-x86/current.h +0 -0
  * 2 - MCE IST stack
  * 1 - NMI IST stack
  * 0 - Double Fault IST stack
Signature · 1 line
2.11.0