x86/IST: Fix comment about stack layout
PATCH 1/1 x86/IST: Fix comment about stack layout
This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.
---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>
--- xen/include/asm-x86/current.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/asm-x86/current.h +1 -1
@@ -18,7 +18,7 @@* 6 - Primary stack * 5 - Optionally not present (MEMORY_GUARD) * 4 - Unused; optionally not present (MEMORY_GUARD) -* 3 - Unused; optionally not present (MEMORY_GUARD) +* 3 - DB IST stack * 2 - MCE IST stack * 1 - NMI IST stack * 0 - Double Fault IST stack
Signature · 1 line
2.11.0
Quoted 18 lines · Andrew Cooper
This was an oversight in c/s
5d37af364dc"x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.Reported-by Jan Beulich <[email protected]>Signed-off-by Andrew Cooper <[email protected]>---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>--- xen/include/asm-x86/current.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)xen/include/asm-x86/current.h +0
-0
xen/include/asm-x86/current.h line 21
Quoted 5 lines
xen/include/asm-x86/current.h +1
-1@@ -18,7 +18,7 @@* 6 - Primary stack * 5 - Optionally not present (MEMORY_GUARD) * 4 - Unused; optionally not present (MEMORY_GUARD) -* 3 - Unused; optionally not present (MEMORY_GUARD) +* 3 - DB IST stack
There seems to be an extraneous space before "DB".
Wei.
Quoted 6 lines
xen/include/asm-x86/current.h +0
-0* 2 - MCE IST stack * 1 - NMI IST stack * 0 - Double Fault IST stack Signature · 1 line
2.11.0
Jan Beulich
Acked-byQuoted 10 lines · Wei Liu
xen/include/asm-x86/current.h line 21
Quoted 8 lines
xen/include/asm-x86/current.h +1
-1@@ -18,7 +18,7 @@* 6 - Primary stack * 5 - Optionally not present (MEMORY_GUARD) * 4 - Unused; optionally not present (MEMORY_GUARD) -* 3 - Unused; optionally not present (MEMORY_GUARD) +* 3 - DB IST stack There seems to be an extraneous space before "DB".
I guess #DB was meant. With that
Jan
Quoted 14 lines · Wei Liu
Quoted 13 lines · Andrew Cooper
This was an oversight in c/s
5d37af364dc"x86/traps: Use an Interrupt Stack Table for #DB" which introduced the #DB IST to begin with.Reported-by Jan Beulich <[email protected]>Signed-off-by Andrew Cooper <[email protected]>---
CC: Jan Beulich <[email protected]>
CC: Wei Liu <[email protected]>
CC: Roger Pau Monné <[email protected]>--- xen/include/asm-x86/current.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
xen/include/asm-x86/current.h line 21
Quoted 10 lines
xen/include/asm-x86/current.h +1
-1@@ -18,7 +18,7 @@* 6 - Primary stack * 5 - Optionally not present (MEMORY_GUARD) * 4 - Unused; optionally not present (MEMORY_GUARD) -* 3 - Unused; optionally not present (MEMORY_GUARD) +* 3 - DB IST stack There seems to be an extraneous space before "DB".
Yes. The alternative would be for misaligned tabulation with the lower "IST stack".
~Andrew
Quoted 9 lines
Wei.
Quoted 6 lines
xen/include/asm-x86/current.h +0
-0* 2 - MCE IST stack * 1 - NMI IST stack * 0 - Double Fault IST stack Signature · 1 line
2.11.0