bpf: remove trailing semicolon in macro definition
Subsystems (5)
PATCH 1/1 bpf: remove trailing semicolon in macro definition
From: Tom Rix <[email protected]>
The macro use will already have a semicolon.
Signed-off-by Tom Rix <[email protected]>
--- include/trace/events/xdp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/trace/events/xdp.h +2 -2
@@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err, );#define _trace_xdp_redirect (dev, xdp, to) \ - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to); + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)#define _trace_xdp_redirect_err (dev, xdp, to, err) \ trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);#define _trace_xdp_redirect_map (dev, xdp, to, map, index) \ - trace_xdp_redirect(dev, xdp, to, 0, map, index); + trace_xdp_redirect(dev, xdp, to, 0, map, index)#define _trace_xdp_redirect_map_err (dev, xdp, to, map, index, err) \ trace_xdp_redirect_err(dev, xdp, to, err, map, index);
Signature · 1 line
2.18.4
Daniel Borkmann
maintainerQuoted 20 lines · On 11/27/20 8:27 PM, [email protected] wrote:
From: Tom Rix <[email protected]>
The macro use will already have a semicolon.
Signed-off-by Tom Rix <[email protected]>--- include/trace/events/xdp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)include/trace/events/xdp.h +1
-1@@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err, );#define _trace_xdp_redirect (dev, xdp, to) \ - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to); + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to)
include/trace/events/xdp.h DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err, · line 158
Quoted 10 lines
include/trace/events/xdp.h +1
-1#define _trace_xdp_redirect_err (dev, xdp, to, err) \ trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);#define _trace_xdp_redirect_map (dev, xdp, to, map, index) \ - trace_xdp_redirect(dev, xdp, to, 0, map, index); + trace_xdp_redirect(dev, xdp, to, 0, map, index)#define _trace_xdp_redirect_map_err (dev, xdp, to, map, index, err) \ trace_xdp_redirect_err(dev, xdp, to, err, map, index);
This looks random, why those but not other locations ?
Thanks,
Daniel
Quoted 21 lines · Daniel Borkmann
Quoted 20 lines · On 11/27/20 8:27 PM, [email protected] wrote:
From: Tom Rix <[email protected]>
The macro use will already have a semicolon.
Signed-off-by Tom Rix <[email protected]>---
include/trace/events/xdp.h| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)include/trace/events/xdp.h +1
-1@@ -146,13 +146,13 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err, ); #define _trace_xdp_redirect(dev, xdp, to) \ - trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to); + trace_xdp_redirect(dev, xdp, NULL, 0, NULL, to) #define _trace_xdp_redirect_err(dev, xdp, to, err) \ trace_xdp_redirect_err(dev, xdp, NULL, err, NULL, to);
Quoted 8 lines
include/trace/events/xdp.h DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,
Quoted 6 lines
include/trace/events/xdp.h +1
-1#define _trace_xdp_redirect_map(dev, xdp, to, map, index) \ - trace_xdp_redirect(dev, xdp, to, 0, map, index); + trace_xdp_redirect(dev, xdp, to, 0, map, index) #define _trace_xdp_redirect_map_err(dev, xdp, to, map, index, err) \ trace_xdp_redirect_err(dev, xdp, to, err, map, index);This looks random, why those but not other locations ?
Those other macros were never used.
Tom
Quoted 4 lines
Thanks,
Daniel