net/mlx5: remove unreachable return
Subsystems (4)
PATCH 1/1 net/mlx5: remove unreachable return
The last return statement is unreachable code. I'm not sure if it will provoke any warnings, but it looks ugly.
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +0 -2
@@ -431,8 +431,6 @@ static int mlx5_ptp_verify(struct ptp_clock_info *ptp, unsigned int pin,default :return -EOPNOTSUPP ; } - -return -EOPNOTSUPP ; }static const struct ptp_clock_info mlx5_ptp_clock_info = {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Saeed Mahameed
AppliedQuoted 7 lines · Pavel Machek
The last return statement is unreachable code. I'm not sure if it will
provoke any warnings, but it looks ugly.Signed-off-by Pavel Machek (CIP) <[email protected]>
Applied to net-next-mlx5.
Thanks,
Saeed.
Quoted 5 lines · Saeed Mahameed
Quoted 4 lines · Pavel Machek
The last return statement is unreachable code. I'm not sure if it will
provoke any warnings, but it looks ugly.
Quoted 9 lines
Quoted 3 lines
Signed-off-by Pavel Machek (CIP) <[email protected]>Applied to net-next-mlx5.
Thanks,
Saeed.
Actually checkpatch reports this issue:
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Pavel Machek <[email protected]>'
Do you want me to override the Signed-off-by tag with the above email ?
Thanks,
Saeed.
Quoted 16 lines · Saeed Mahameed
Quoted 5 lines · Saeed Mahameed
Quoted 4 lines · Pavel Machek
The last return statement is unreachable code. I'm not sure if it will
provoke any warnings, but it looks ugly.Quoted 9 lines
Quoted 3 lines
Signed-off-by Pavel Machek (CIP) <[email protected]>Applied to net-next-mlx5.
Thanks,
Saeed.
Quoted 5 lines
Actually checkpatch reports this issue:
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Pavel Machek <[email protected]>'Do you want me to override the Signed-off-by tag with the above email ?
Sorry about that.
Actually, overriding patch author to match signoff would be better (I should have sent it from: denx), but either way is okay with me.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html