Skip to contentSkip to conversation

board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

PATCH New Soeren Moch 3 participants 5 messages Sep 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

Quoted 6 lines · sbabic at denx.de
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Applied to u-boot-imx, master, thanks !

Thanks, Stefano.

What happened to the first patch of this series?? Patchwork status is "Changes Requested", but his patch only received 2 reviewed-by, no other requests.

Thanks,
Soeren

#1 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

Quoted 5 lines · Soeren Moch
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Quoted 8 lines
Quoted 2 lines

Applied to u-boot-imx, master, thanks !

Thanks, Stefano.

What happened to the first patch of this series?? Patchwork status is "Changes Requested", but his patch only received 2 reviewed-by, no other requests.

Mmmhhh...when patch is in "Changes requested", it disappears from Patchwork's TODO list and I do not see it anymore. Thanks for reporting this, I search for it and I'll pick it up.

Stefano

Quoted 4 lines

Thanks,
Soeren

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

Quoted 8 lines · Stefano Babic
Quoted 7 lines · Soeren Moch
Quoted 6 lines · sbabic at denx.de
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Applied to u-boot-imx, master, thanks !

Quoted 9 lines
Quoted 5 lines

Thanks, Stefano.

What happened to the first patch of this series?? Patchwork status is "Changes Requested", but his patch only received 2 reviewed-by, no other requests.

Mmmhhh...when patch is in "Changes requested", it disappears from Patchwork's TODO list and I do not see it anymore. Thanks for reporting this, I search for it and I'll pick it up.

OK, thanks. No problem to apply patch 1/2 after 2/2.

Thanks again,
Soeren

#3 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

Quoted 13 lines · Soeren Moch
Quoted 10 lines · Stefano Babic
Quoted 9 lines · Soeren Moch
Quoted 6 lines · sbabic at denx.de
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Applied to u-boot-imx, master, thanks !

Thanks, Stefano.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

What happened to the first patch of this series?? Patchwork status is "Changes Requested", but his patch only received 2 reviewed-by, no other requests.

Mmmhhh...when patch is in "Changes requested", it disappears from Patchwork's TODO list and I do not see it anymore. Thanks for reporting this, I search for it and I'll pick it up.

OK, thanks. No problem to apply patch 1/2 after 2/2.

Sorry, I think I see what happened. I had intended to, I suspect, mark
https://patchwork.ozlabs.org/project/uboot/patch/20191010230048.10935-1-smoch at web.de/ as "Changes Requested" (in part because it was suggested to also change the level of the message, and in part because I think it's been
superseded by a change to do the same thing basically by now) and my
mouse slipped.

I'll re-confirm that the MAC warning thing has been taken care of today, as well. Again, sorry about that!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200918/a17da9bd/attachment.sig>
#4 lore raw

PATCH 2/2 board: tbs2910: Disable CONFIG_ENV_VARS_UBOOT_CONFIG in defconfig

Quoted 28 lines · Tom Rini
Quoted 12 lines · Soeren Moch
Quoted 10 lines · Stefano Babic
Quoted 9 lines · Soeren Moch
Quoted 6 lines · sbabic at denx.de
Quoted 4 lines

This is not required for sysboot (we defined fdtfile), let's save a few bytes in the binary image without these variables.

Applied to u-boot-imx, master, thanks !

Thanks, Stefano.

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

What happened to the first patch of this series?? Patchwork status is "Changes Requested", but his patch only received 2 reviewed-by, no other requests.

Mmmhhh...when patch is in "Changes requested", it disappears from Patchwork's TODO list and I do not see it anymore. Thanks for reporting this, I search for it and I'll pick it up.

OK, thanks. No problem to apply patch 1/2 after 2/2.

Sorry, I think I see what happened. I had intended to, I suspect, mark
https://patchwork.ozlabs.org/project/uboot/patch/20191010230048.10935-1-smoch at web.de/ as "Changes Requested" (in part because it was suggested to also change the level of the message, and in part because I think it's been
superseded by a change to do the same thing basically by now) and my
mouse slipped.

Quoted 3 lines

I'll re-confirm that the MAC warning thing has been taken care of today, as well. Again, sorry about that!

The MAC warning on tbs2910 was gone some time ago. So the linked patch must indeed be superseded by something that is already applied.

Soeren