Skip to contentSkip to conversation

vf610twr: Fix typo in DRAM init

PATCH In review Anthony Felice 7 participants 12 messages Oct 9, 2015 – Oct 17, 2015

lore
Share & tools
lore

Anthony Felice

author
#0 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index a78e9e6..fa0075c 100644
@@ -108,7 +108,7 @@ int dram_init(void)
 		.trcd_int          = 6,
 		.tras_lockout      = 0,
 		.tdal              = 12,
-		.bstlen            = 0,
+		.bstlen            = 3,
 		.tdll              = 512,
 		.trp_ab            = 6,
 		.tref              = 3120,
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Quoted 5 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>

Seems fine for me. Stefano?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Quoted 8 lines · Fabio Estevam
Quoted 5 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Also, adding the author of 3f353cecc ("vf610: refactor DDRMC code") and the i.MX/Vybrid maintainer.

Thanks

#4 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Bonjour Fabio,

Le Tue, 13 Oct 2015 12:30:47 -0300, Fabio Estevam <[email protected]> a ?crit :

Quoted 6 lines · Fabio Estevam
Quoted 5 lines · Anthony Felice
Quoted 4 lines

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Anthony Felice <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Also, adding the author of 3f353cecc ("vf610: refactor DDRMC code") and the i.MX/Vybrid maintainer.

Thanks

Thanks to Anthony for spotting and fixing this!

Cordialement,
Albert ARIBAUD
3ADEV

#5 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Hi Stefano,

Quoted 1 line · Albert ARIBAUD

Thanks to Anthony for spotting and fixing this!

This one fixes a regression. Please consider applying it to 2015.10.

Thanks

#6 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

In reply to Anthony Felice

Hi Anthony,

Tested on a Tower, works for me.

Can you also fix the Colibri VF board? It seems to suffer the same issue, introduced by the same commit...

--
Stefan

Quoted 23 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index a78e9e6..fa0075c 100644
@@ -108,7 +108,7 @@ int dram_init(void)
 		.trcd_int          = 6,
 		.tras_lockout      = 0,
 		.tdal              = 12,
-		.bstlen            = 0,
+		.bstlen            = 3,
 		.tdll              = 512,
 		.trp_ab            = 6,
 		.tref              = 3120,
author
#7 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Hi Stefan,

Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week.

Thanks,

Tony

Quoted 36 lines · Stefan Agner

Hi Anthony,

Tested on a Tower, works for me.

Can you also fix the Colibri VF board? It seems to suffer the same issue, introduced by the same commit...

--
Stefan

Quoted 23 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>
---
 board/freescale/vf610twr/vf610twr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index a78e9e6..fa0075c 100644
@@ -108,7 +108,7 @@ int dram_init(void)
              .trcd_int          = 6,
              .tras_lockout      = 0,
              .tdal              = 12,
-             .bstlen            = 0,
+             .bstlen            = 3,
              .tdll              = 512,
              .trp_ab            = 6,
              .tref              = 3120,
Signature · 3 lines
Tony Felice
Vybrid Technical Lead
Timesys Corporation
#8 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Hi Tony,

I then realized that we are close to the release and submitted an individual patch right away. So you don't need to create a patch. Thanks for uncovering the bug and the offer.

Patch, see:
https://patchwork.ozlabs.org/patch/529985/

--
Stefan

Quoted 49 lines · Tony Felice

Hi Stefan,

Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week.

Thanks,

Tony

Quoted 34 lines · Stefan Agner

Hi Anthony,

Tested on a Tower, works for me.

Can you also fix the Colibri VF board? It seems to suffer the same issue, introduced by the same commit...

--
Stefan

Quoted 23 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>

---
board/freescale/vf610twr/vf610twr.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/vf610twr/vf610twr.c +1 -1
index a78e9e6..fa0075c 100644
@@ -108,7 +108,7 @@ int dram_init(void)
 .trcd_int = 6,
 .tras_lockout = 0,
 .tdal = 12,
- .bstlen = 0,
+ .bstlen = 3,
 .tdll = 512,
 .trp_ab = 6,
 .tref = 3120,
Signature · 2 lines
Tony Felice
Vybrid Technical Lead Timesys Corporation
#9 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Hi Stefano,

This patch did not make it into the git tree, however my patch which followed that one (and which fixed the same issue on colibri_vf only), did make it...

Sorry, my comment below was somewhat confusing. I descided afterwards to just send a seperate one for colibri_vf.

Could you also merge this one into 2015.10?

--
Stefan

Quoted 67 lines · Stefan Agner

Hi Tony,

I then realized that we are close to the release and submitted an individual patch right away. So you don't need to create a patch. Thanks for uncovering the bug and the offer.

Patch, see:
https://patchwork.ozlabs.org/patch/529985/

--
Stefan

Quoted 47 lines · Tony Felice

Hi Stefan,

Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week.

Thanks,

Tony

Quoted 20 lines · Stefan Agner

Hi Anthony,

Tested on a Tower, works for me.

Can you also fix the Colibri VF board? It seems to suffer the same issue, introduced by the same commit...

--
Stefan

Quoted 9 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>

---
board/freescale/vf610twr/vf610twr.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
board/freescale/vf610twr/vf610twr.c +0 -0
index a78e9e6..fa0075c 100644

board/freescale/vf610twr/vf610twr.c int dram_init(void) · line 114

Quoted 8 lines
board/freescale/vf610twr/vf610twr.c +1 -1
@@ -108,7 +108,7 @@ int dram_init(void)
 .trcd_int = 6,
 .tras_lockout = 0,
 .tdal = 12,
- .bstlen = 0,
+ .bstlen = 3,
 .tdll = 512,
 .trp_ab = 6,
 .tref = 3120,

--

Quoted 2 lines

Tony Felice
Vybrid Technical Lead Timesys Corporation

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#10 lore raw

PATCH 1/1 vf610twr: Fix typo in DRAM init

Hi Stefan,

Quoted 10 lines · Stefan Agner

Hi Stefano,

This patch did not make it into the git tree, however my patch which followed that one (and which fixed the same issue on colibri_vf only), did make it...

Sorry, my comment below was somewhat confusing. I descided afterwards to just send a seperate one for colibri_vf.

Could you also merge this one into 2015.10?

Yes, I was quite confused. I have seen more patches (from you, Anthony and Fabio) fixing the same issue, and I missed that only two of them overlap. Fabio's patch (already merged) fixes the same issue on colibri_vf, vf610twr is still broken.

I merge it and I ask Tom how to proceed. Maybe he prefer to pick it up himself.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#11 lore raw
In reply to Anthony Felice
Quoted 6 lines · Anthony Felice

This commit fixes a typo in vf610twr DRAM init that was causing a hang in U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc (vf610: refactor DDRMC code).

Signed-off-by Anthony Felice <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151016/ba726f54/attachment.sig>