Skip to contentSkip to conversation

infra: /usr support: STAGING_DIR can be outside BASE_DIR

PATCH New Thomas De Schampheleire 2 participants 3 messages Jun 30, 2014 – Jul 3, 2014

lore
Share & tools
lore

Thomas De Schampheleire

author
#0 lore raw

PATCH 1/1 infra: /usr support: STAGING_DIR can be outside BASE_DIR

If the user sets a custom BR2_HOST_DIR, then STAGING_DIR is not under BASE_DIR. The .pc/.la file fixup commands incorrectly made this assumption and thus should be corrected.

Additionally, this patch rewords the comment in pkg-autotools that explains the replacements.

Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/pkg-autotools.mk |  23 ++++++++++++-----------
 package/pkg-generic.mk   |   5 +++--
 2 files changed, 15 insertions(+), 13 deletions(-)
package/pkg-autotools.mk +12 -11
diff -r 5471dd6af081 -r 4f110d39879d package/pkg-autotools.mk
@@ -267,25 +267,26 @@
 # Most autotools packages install libtool .la files alongside any
 # installed libraries. These .la files sometimes refer to paths
 # relative to the sysroot, which libtool will interpret as absolute
-# paths to host libraries instead of the target libraries. Since we
-# configure with --prefix=/usr, such absolute paths start with
-# /usr. So we add $(STAGING_DIR) in front of any path that starts with
-# /usr.
+# paths to host libraries instead of the target libraries. Since this
+# is not what we want, these paths are fixed by prefixing them with
+# $(STAGING_DIR).  As we configure with --prefix=/usr, this fix
+# needs to be applied to any path that starts with /usr.
 #
-# To protect against the case that the output directory itself is
-# under /usr, we first substitute away any occurences of the output
-# directory to @BASE_DIR at .
+# To protect against the case that the output or staging directories
+# themselves are under /usr, we first substitute away any occurrences
+# of these directories as @BASE_DIR@ and @STAGING_DIR at . Note that
+# STAGING_DIR can be outside BASE_DIR when the user sets BR2_HOST_DIR
+# to a custom value.
 #
 ifndef $(2)_INSTALL_STAGING_CMDS
 define $(2)_INSTALL_STAGING_CMDS
 	$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_INSTALL_STAGING_OPT) -C $$($$(PKG)_SRCDIR)
-	for i in $$$$(find $$(STAGING_DIR)/usr/lib* -name "*.la"); do \
+	find $$(STAGING_DIR)/usr/lib* -name "*.la" | xargs \
 		$$(SED) "s:$$(BASE_DIR):@BASE_DIR@:g" \
+			-e "s:$$(STAGING_DIR):@STAGING_DIR@:g" \
 			-e "s:\(['= ]\)/usr:\\1 at STAGING_DIR@/usr:g" \
 			-e "s:@STAGING_DIR@:$$(STAGING_DIR):g" \
-			-e "s:@BASE_DIR@:$$(BASE_DIR):g" \
-			$$$$i; \
-	done
+			-e "s:@BASE_DIR@:$$(BASE_DIR):g"
 endef
 endif
package/pkg-generic.mk +3 -2
diff -r 5471dd6af081 -r 4f110d39879d package/pkg-generic.mk
@@ -202,9 +202,10 @@
 	$(Q)if test -n "$($(PKG)_CONFIG_SCRIPTS)" ; then \
 		$(call MESSAGE,"Fixing package configuration files") ;\
 			$(SED)  "s,$(BASE_DIR), at BASE_DIR@,g" \
+				-e "s,$(STAGING_DIR), at STAGING_DIR@,g" \
 				-e "s,^\(exec_\)\?prefix=.*,\1prefix=@STAGING_DIR@/usr,g" \
-				-e "s,-I/usr/,-I at STAGING_DIR@/usr/,g" \
-				-e "s,-L/usr/,-L at STAGING_DIR@/usr/,g" \
+				-e "s,-I/usr/,-I at STAGING_DIR/usr/,g" \
+				-e "s,-L/usr/,-L at STAGING_DIR/usr/,g" \
 				-e "s, at STAGING_DIR@,$(STAGING_DIR),g" \
 				-e "s, at BASE_DIR@,$(BASE_DIR),g" \
 				$(addprefix $(STAGING_DIR)/usr/bin/,$($(PKG)_CONFIG_SCRIPTS)) ;\
#1 lore raw

PATCH 1/1 infra: /usr support: STAGING_DIR can be outside BASE_DIR

Quoted 4 lines · Thomas De Schampheleire

If the user sets a custom BR2_HOST_DIR, then STAGING_DIR is not under BASE_DIR. The .pc/.la file fixup commands incorrectly made this assumption and thus should be corrected.

Quoted 8 lines

Additionally, this patch rewords the comment in pkg-autotools that explains the replacements.

Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/pkg-autotools.mk |  23 ++++++++++++-----------
 package/pkg-generic.mk   |   5 +++--

Doesn't QT5_LA_PRL_FILES_FIXUP need this as well?

Also, perhaps you should mention in the commit message the for -> xargs change.

Regards,
Arnout

Quoted 61 lines
 2 files changed, 15 insertions(+), 13 deletions(-)

diff -r 5471dd6af081 -r 4f110d39879d package/pkg-autotools.mk

package/pkg-autotools.mk +12 -11
@@ -267,25 +267,26 @@
 # Most autotools packages install libtool .la files alongside any
 # installed libraries. These .la files sometimes refer to paths
 # relative to the sysroot, which libtool will interpret as absolute
-# paths to host libraries instead of the target libraries. Since we
-# configure with --prefix=/usr, such absolute paths start with
-# /usr. So we add $(STAGING_DIR) in front of any path that starts with
-# /usr.
+# paths to host libraries instead of the target libraries. Since this
+# is not what we want, these paths are fixed by prefixing them with
+# $(STAGING_DIR).  As we configure with --prefix=/usr, this fix
+# needs to be applied to any path that starts with /usr.
 #
-# To protect against the case that the output directory itself is
-# under /usr, we first substitute away any occurences of the output
-# directory to @BASE_DIR at .
+# To protect against the case that the output or staging directories
+# themselves are under /usr, we first substitute away any occurrences
+# of these directories as @BASE_DIR@ and @STAGING_DIR at . Note that
+# STAGING_DIR can be outside BASE_DIR when the user sets BR2_HOST_DIR
+# to a custom value.
 #
 ifndef $(2)_INSTALL_STAGING_CMDS
 define $(2)_INSTALL_STAGING_CMDS
 	$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_INSTALL_STAGING_OPT) -C $$($$(PKG)_SRCDIR)
-	for i in $$$$(find $$(STAGING_DIR)/usr/lib* -name "*.la"); do \
+	find $$(STAGING_DIR)/usr/lib* -name "*.la" | xargs \
 		$$(SED) "s:$$(BASE_DIR):@BASE_DIR@:g" \
+			-e "s:$$(STAGING_DIR):@STAGING_DIR@:g" \
 			-e "s:\(['= ]\)/usr:\\1 at STAGING_DIR@/usr:g" \
 			-e "s:@STAGING_DIR@:$$(STAGING_DIR):g" \
-			-e "s:@BASE_DIR@:$$(BASE_DIR):g" \
-			$$$$i; \
-	done
+			-e "s:@BASE_DIR@:$$(BASE_DIR):g"
 endef
 endif

diff -r 5471dd6af081 -r 4f110d39879d package/pkg-generic.mk

package/pkg-generic.mk +3 -2
@@ -202,9 +202,10 @@
 	$(Q)if test -n "$($(PKG)_CONFIG_SCRIPTS)" ; then \
 		$(call MESSAGE,"Fixing package configuration files") ;\
 			$(SED)  "s,$(BASE_DIR), at BASE_DIR@,g" \
+				-e "s,$(STAGING_DIR), at STAGING_DIR@,g" \
 				-e "s,^\(exec_\)\?prefix=.*,\1prefix=@STAGING_DIR@/usr,g" \
-				-e "s,-I/usr/,-I at STAGING_DIR@/usr/,g" \
-				-e "s,-L/usr/,-L at STAGING_DIR@/usr/,g" \
+				-e "s,-I/usr/,-I at STAGING_DIR/usr/,g" \
+				-e "s,-L/usr/,-L at STAGING_DIR/usr/,g" \
 				-e "s, at STAGING_DIR@,$(STAGING_DIR),g" \
 				-e "s, at BASE_DIR@,$(BASE_DIR),g" \
 				$(addprefix $(STAGING_DIR)/usr/bin/,$($(PKG)_CONFIG_SCRIPTS)) ;\
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#2 lore raw

PATCH 1/1 infra: /usr support: STAGING_DIR can be outside BASE_DIR

Quoted 8 lines · Arnout Vandecappelle
Quoted 7 lines · Thomas De Schampheleire

If the user sets a custom BR2_HOST_DIR, then STAGING_DIR is not under BASE_DIR. The .pc/.la file fixup commands incorrectly made this assumption and thus should be corrected.

Additionally, this patch rewords the comment in pkg-autotools that explains the replacements.

Quoted 7 lines
Quoted 5 lines
Signed-off-by Thomas De Schampheleire <[email protected]>
---
 package/pkg-autotools.mk |  23 ++++++++++++-----------
 package/pkg-generic.mk   |   5 +++--

Doesn't QT5_LA_PRL_FILES_FIXUP need this as well?

Yes indeed, and the above patch is broken for pkg-generic too. I'll fix and resubmit...

Quoted 2 lines

Also, perhaps you should mention in the commit message the for -> xargs change.

Will do.

Thanks!
Thomas