Skip to contentSkip to conversation

asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

PATCH RESEND Superseded Oleksandr Natalenko 3 participants 4 messages Feb 17, 2016 – Feb 18, 2016

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 asus-nb-wmi: add wapf=4 quirk for ASUS X75VD

Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module is loaded with wapf=4 option. Add quirk for this.

---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +9 -0
index 131fee2..091ca7a 100644
@@ -272,6 +272,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X75VD",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X75VD"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. 1015E",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
Signature · 1 line
2.7.1
#1 lore raw
Quoted 3 lines · Oleksandr Natalenko

Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module is loaded with wapf=4 option. Add quirk for this.
---

You forgot Signed-off-by here. Always run your patch through scripts/checkpatch.pl. Also, I think the format is usually [PATCH RESEND vX AA/BB] and not [PATCH][RESEND].

#2 lore raw
Quoted 8 lines · Giedrius Statkevičius
Quoted 3 lines · Oleksandr Natalenko

Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module is loaded with wapf=4 option. Add quirk for this.
---

You forgot Signed-off-by here. Always run your patch through scripts/checkpatch.pl. Also, I think the format is usually [PATCH RESEND vX AA/BB] and not [PATCH][RESEND].

RESEND means it's identical. v2 means there was a change. The change should be noted below the --- line. See Documentation/SubmittingPatches Section 14.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center
#3 lore raw
In reply to Oleksandr Natalenko
Quoted 2 lines · Oleksandr Natalenko

Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module is loaded with wapf=4 option. Add quirk for this.

Point of terminology. It is not a RESEND if you made changes, even whitespace, it's v2, v3, etc. RESEND means it's identical to the previous one, but it's been a long time (2 weeks) and nobody responded with a review.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center