Skip to contentSkip to conversation

dmaengine: tegra210-adma: use platform to ioremap

PATCH Applied Rosen Penev 4 participants 9 messages Jun 9 – Jul 2

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dmaengine: tegra210-adma: use platform to ioremap

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

 drivers/dma/tegra210-adma.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +3 -9
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
 		}
 	} else {
 		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return dev_err_probe(&pdev->dev, -ENODEV,
-					     "failed to get memory resource\n");
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);
 
 		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
 	}

--
2.54.0

Reviewed-by on v4 1/1
#1 lore raw

On Tue, Jun 09, 2026 at 02:25:31PM -0700, Rosen Penev wrote:

Nit: subject
dmaengine: tegra210-adma: use devm_platform_ioremap_resource()

Quoted 5 lines

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---

Quoted 32 lines

v4: rebase and reword commit message
v3: change subject
v2: reword commit message

 drivers/dma/tegra210-adma.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +3 -10
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
 		}
 	} else {
 		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return dev_err_probe(&pdev->dev, -ENODEV,
-					     "failed to get memory resource\n");
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);
 
 		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
 	}
--

2.54.0

maintainer
#2 lore raw
In reply to Rosen Penev
Quoted 21 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

  drivers/dma/tegra210-adma.c | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +0 -2
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
  		}
  	} else {
  		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1092

Quoted 10 lines
drivers/dma/tegra210-adma.c +3 -7
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);
-		} else {
-			return dev_err_probe(&pdev->dev, -ENODEV,
-					     "failed to get memory resource\n");
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't drop this.

Jon

Signature · 1 line
nvpublic
#3 lore raw
Quoted 29 lines · Jon Hunter
Quoted 26 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

  drivers/dma/tegra210-adma.c | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +0 -7
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
              }
      } else {
              /* If no 'page' property found, then reg DT binding would be legacy */
-             res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-             if (res_base) {
-                     tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-                     if (IS_ERR(tdma->base_addr))
-                             return PTR_ERR(tdma->base_addr);
-             } else {
-                     return dev_err_probe(&pdev->dev, -ENODEV,
Quoted 8 lines

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1092

Quoted 5 lines
drivers/dma/tegra210-adma.c +3 -2
-                                          "failed to get memory resource\n");
-             }
+             tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+             if (IS_ERR(tdma->base_addr))
+                     return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't drop this.

If you're talking about the memory resource error, devm_platform_ioremap_resource() prints

ret = dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res);

That's more descriptive, no?

Quoted 6 lines

Jon

--
nvpublic

maintainer
#4 lore raw
Quoted 38 lines · Rosen Penev
Quoted 29 lines · Jon Hunter
Quoted 26 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

   drivers/dma/tegra210-adma.c | 12 +++---------
   1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +0 -7
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
               }
       } else {
               /* If no 'page' property found, then reg DT binding would be legacy */
-             res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-             if (res_base) {
-                     tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-                     if (IS_ERR(tdma->base_addr))
-                             return PTR_ERR(tdma->base_addr);
-             } else {
-                     return dev_err_probe(&pdev->dev, -ENODEV,
Quoted 8 lines

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1092

Quoted 5 lines
drivers/dma/tegra210-adma.c +3 -2
-                                          "failed to get memory resource\n");
-             }
+             tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+             if (IS_ERR(tdma->base_addr))
+                     return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't drop this.

Quoted 4 lines

If you're talking about the memory resource error, devm_platform_ioremap_resource() prints

ret = dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res);

Well technically it is devm_ioremap_resource() that prints the above which was not obvious. So clarifying that in the commit message would be good.

Jon

Signature · 1 line
nvpublic
#5 lore raw
Quoted 41 lines · Jon Hunter
Quoted 38 lines · Rosen Penev
Quoted 37 lines · Jon Hunter
Quoted 21 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

   drivers/dma/tegra210-adma.c | 12 +++---------
   1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +0 -2
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
               }
       } else {
               /* If no 'page' property found, then reg DT binding would be legacy */
-             res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-             if (res_base) {

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1092

Quoted 10 lines
drivers/dma/tegra210-adma.c +3 -7
-                     tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-                     if (IS_ERR(tdma->base_addr))
-                             return PTR_ERR(tdma->base_addr);
-             } else {
-                     return dev_err_probe(&pdev->dev, -ENODEV,
-                                          "failed to get memory resource\n");
-             }
+             tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+             if (IS_ERR(tdma->base_addr))
+                     return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't drop this.

Quoted 8 lines
Quoted 4 lines

If you're talking about the memory resource error, devm_platform_ioremap_resource() prints

ret = dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res);

Well technically it is devm_ioremap_resource() that prints the above which was not obvious. So clarifying that in the commit message would be good.

I mentioned it returns multiple error messages.

Quoted 6 lines

Jon

--
nvpublic

maintainer
#6 lore raw
Quoted 45 lines · Rosen Penev
Quoted 44 lines · Jon Hunter
Quoted 41 lines · Rosen Penev
Quoted 29 lines · Jon Hunter
Quoted 26 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message drivers/dma/tegra210-adma.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)

drivers/dma/tegra210-adma.c +0 -7
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
                }
        } else {
                /* If no 'page' property found, then reg DT binding would be legacy */
-             res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-             if (res_base) {
-                     tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-                     if (IS_ERR(tdma->base_addr))
-                             return PTR_ERR(tdma->base_addr);
-             } else {
-                     return dev_err_probe(&pdev->dev, -ENODEV,
Quoted 8 lines

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1092

Quoted 5 lines
drivers/dma/tegra210-adma.c +3 -2
-                                          "failed to get memory resource\n");
-             }
+             tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+             if (IS_ERR(tdma->base_addr))
+                     return PTR_ERR(tdma->base_addr);

The dev_err_probe() was purposely added to assist debug. Please don't drop this.

If you're talking about the memory resource error, devm_platform_ioremap_resource() prints

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

ret = dev_err_probe(dev, -EINVAL, "invalid resource %pR\n", res);

Well technically it is devm_ioremap_resource() that prints the above which was not obvious. So clarifying that in the commit message would be good.

I mentioned it returns multiple error messages.

Yes you did. OK, then this is fine with me.

Thanks
Jon

Signature · 1 line
nvpublic
maintainer Reviewed-by on v4 1/1
#7 lore raw
In reply to Rosen Penev
Quoted 24 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

---
v4: rebase and reword commit message
v3: change subject
v2: reword commit message

  drivers/dma/tegra210-adma.c | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)
drivers/dma/tegra210-adma.c +0 -5
index ceaee1e33e68..21a381d022cf 100644
@@ -1087,15 +1087,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
  		}
  	} else {
  		/* If no 'page' property found, then reg DT binding would be legacy */
-		res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (res_base) {
-			tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
-			if (IS_ERR(tdma->base_addr))
-				return PTR_ERR(tdma->base_addr);

drivers/dma/tegra210-adma.c static int tegra_adma_probe(struct platform_device *pdev) · line 1095

Quoted 10 lines
drivers/dma/tegra210-adma.c +3 -4
-		} else {
-			return dev_err_probe(&pdev->dev, -ENODEV,
-					     "failed to get memory resource\n");
-		}
+		tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+		if (IS_ERR(tdma->base_addr))
+			return PTR_ERR(tdma->base_addr);
 
  		tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
  	}

Thanks
Jon

Signature · 1 line
nvpublic
maintainer Applied
#8 lore raw
In reply to Rosen Penev
Quoted 4 lines · Rosen Penev

Simpler to call devm_platform_ioremap_resource() as it returns multiple error messages for whichever part fails.

Applied, thanks!

[1/1] dmaengine: tegra210-adma: use platform to ioremap

      commit: 95cf38ae309f21b651fb7b8afe267eb3c84017a3

Best regards,

Signature · 1 line
~Vinod