Skip to contentSkip to conversation

net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

PATCH Superseded Kangjie Lu 3 participants 3 messages Mar 9, 2019 – Mar 22, 2019

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

If ixgbevf_write_msg_read_ack fails, return its error code upstream

---
 drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/vf.c +2 -3
index cd3b81300cc7..d5ce49636548 100644
@@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
 		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
 	}
 
-	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
-
-	return 0;
+	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
+			IXGBE_VFMAILBOX_SIZE);
 }
 
 /**
Signature · 1 line
2.17.1
Tested-by on v1 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Kangjie Lu
Sent: Friday, March 8, 2019 7:31 PM
To: kjlu at umn.edu
Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org; intel-wired- lan at lists.osuosl.org; pakki001 at umn.edu; David S. Miller <[email protected]>
Subject: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

Quoted 6 lines

If ixgbevf_write_msg_read_ack fails, return its error code upstream

---
 drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
#2 lore raw

PATCH 1/1 net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

In reply to Kangjie Lu
Quoted 12 lines · Kangjie Lu

If ixgbevf_write_msg_read_ack fails, return its error code upstream

---
  drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/ixgbevf/vf.c +0 -0
index cd3b81300cc7..d5ce49636548 100644

drivers/net/ethernet/intel/ixgbevf/vf.c static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw, · line 512

Quoted 8 lines
drivers/net/ethernet/intel/ixgbevf/vf.c +2 -3
@@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
  		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
  	}
 
-	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
-
-	return 0;
+	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
+			IXGBE_VFMAILBOX_SIZE);

Reviewed-by: Mukesh Ojha <mojha at codeaurora.org
<mailto:[email protected]>>

Thanks,
Mukesh

drivers/net/ethernet/intel/ixgbevf/vf.c static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw, · line 515

Quoted 3 lines
drivers/net/ethernet/intel/ixgbevf/vf.c +0 -0
  }
 
  /**

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190322/eecc7cca/attachment.html>