Skip to contentSkip to conversation

gcc-cross-canadian: Enable wildcard expansion support

PATCH In review Mark Hatle 5 participants 9 messages Mar 2, 2020

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

PATCH 1/1 gcc-cross-canadian: Enable wildcard expansion support

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

---
 recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
index 9c0d828..e0463c6 100644
@@ -1,5 +1,5 @@
 INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
 LDFLAGS_append_sdkmingw32 = " -Wl,-static"
 EXEEXT_sdkmingw32 = ".exe"
 ELFUTILS_sdkmingw32 = ""
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

with backports to zeus & warrior?

-armin

Quoted 19 lines
---
 recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
index 9c0d828..e0463c6 100644
@@ -1,5 +1,5 @@
 INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
 LDFLAGS_append_sdkmingw32 = " -Wl,-static"
 EXEEXT_sdkmingw32 = ".exe"
 ELFUTILS_sdkmingw32 = ""
author
#2 lore raw

Ya, it backports to Zeus fine. That is as far back as I've looked.

--Mark

Quoted 33 lines · On 3/2/20 12:15 PM, akuster808 wrote:
Quoted 7 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

with backports to zeus & warrior?

-armin

Quoted 18 lines
---
 recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
index 9c0d828..e0463c6 100644
@@ -1,5 +1,5 @@
 INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
 LDFLAGS_append_sdkmingw32 = " -Wl,-static"
 EXEEXT_sdkmingw32 = ".exe"
 ELFUTILS_sdkmingw32 = ""
#3 lore raw
In reply to Mark Hatle
Quoted 18 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

---
  recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
index 9c0d828..e0463c6 100644

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend line 2

Quoted 3 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
@@ -1,5 +1,5 @@
  INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"

this change is fine. is this the only place we need it ?

Quoted 7 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
  LDFLAGS_append_sdkmingw32 = " -Wl,-static"
  EXEEXT_sdkmingw32 = ".exe"
  ELFUTILS_sdkmingw32 = ""
author
#4 lore raw
Quoted 16 lines · Khem Raj
Quoted 13 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

---
  recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend line 2

Quoted 8 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
index 9c0d828..e0463c6 100644
@@ -1,5 +1,5 @@
  INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"

this change is fine. is this the only place we need it ?

Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK, we're only build cross-canadian there.

(binutils and others don't appear to have this option, unless I just missed it.)

--Mark

Quoted 9 lines
Quoted 9 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
  LDFLAGS_append_sdkmingw32 = " -Wl,-static"
  EXEEXT_sdkmingw32 = ".exe"
  ELFUTILS_sdkmingw32 = ""
#5 lore raw
Quoted 30 lines · Mark Hatle
Quoted 16 lines · Khem Raj
Quoted 13 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

---
  recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend line 2

Quoted 8 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
index 9c0d828..e0463c6 100644
@@ -1,5 +1,5 @@
  INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"

this change is fine. is this the only place we need it ?

Quoted 1 line

Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,

Where does this bbappend go? Should this patch be designated to mingw layer?

Quoted 17 lines

we're only build cross-canadian there.

(binutils and others don't appear to have this option, unless I just missed it.)

--Mark

Quoted 9 lines
Quoted 9 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
  LDFLAGS_append_sdkmingw32 = " -Wl,-static"
  EXEEXT_sdkmingw32 = ".exe"
  ELFUTILS_sdkmingw32 = ""
#6 lore raw
Quoted 31 lines · Denys Dmytriyenko
Quoted 30 lines · Mark Hatle
Quoted 26 lines · Khem Raj
Quoted 18 lines · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls of gcc were disabled by default. This behavior may be required by some (poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

---
   recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
index 9c0d828..e0463c6 100644

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend line 2

Quoted 3 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
@@ -1,5 +1,5 @@
   INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"

this change is fine. is this the only place we need it ?

Quoted 4 lines
Quoted 1 line

Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,

Where does this bbappend go? Should this patch be designated to mingw layer?

its using an override, so it wont be effective elsewhere, perhaps oe-core is better place for it.

Quoted 19 lines
Quoted 18 lines

we're only build cross-canadian there.

(binutils and others don't appear to have this option, unless I just missed it.)

--Mark

Quoted 9 lines
Quoted 9 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
   LDFLAGS_append_sdkmingw32 = " -Wl,-static"
   EXEEXT_sdkmingw32 = ".exe"
   ELFUTILS_sdkmingw32 = ""
#7 lore raw
Quoted 39 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko
Quoted 7 lines · Mark Hatle
Quoted 4 lines · Khem Raj
Quoted 1 line · Mark Hatle

In gcc 8, the behavior of GCC changed and expansion of wild cards to

calls

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

of gcc were disabled by default. This behavior may be required by

some

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

(poorly written) makefiles.

This will allow someone to do:

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Review

Quoted 8 lines

gcc *.c -o myoutput

---
   recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend line 2

Quoted 7 lines

index 9c0d828..e0463c6 100644

recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +1 -1
@@ -1,5 +1,5 @@
   INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls

--enable-mingw-wildcard"

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

this change is fine. is this the only place we need it ?

Yes, it doesn't do anything if the generated toolchain isn't mingw..

Quoted 9 lines

and AFAIK,

Quoted 2 lines

Where does this bbappend go? Should this patch be designated to mingw

layer?

Quoted 1 line

its using an override, so it wont be effective elsewhere, perhaps oe-core is better place for it.

Heh, I already applied it to master-next in meta-mingw :)

Quoted 22 lines
Quoted 4 lines
Quoted 4 lines

we're only build cross-canadian there.

(binutils and others don't appear to have this option, unless I just

missed it.)

Quoted 15 lines
Quoted 14 lines

--Mark

Quoted 9 lines
Quoted 9 lines
recipes-devtools/gcc/gcc-cross-canadian_%.bbappend +0 -0
   LDFLAGS_append_sdkmingw32 = " -Wl,-static"
   EXEEXT_sdkmingw32 = ".exe"
   ELFUTILS_sdkmingw32 = ""
#8 lore raw
Quoted 55 lines · Joshua Watt

On Mon, Mar 2, 2020, 5:03 PM Khem Raj <[email protected] <mailto:[email protected]>> wrote:

    On 3/2/20 2:30 PM, Denys Dmytriyenko wrote:
     > On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
     >>
     >>
     >> On 3/2/20 12:42 PM, Khem Raj wrote:
     >>>
     >>>
     >>> On 3/2/20 9:39 AM, Mark Hatle wrote:
     >>>> In gcc 8, the behavior of GCC changed and expansion of wild
    cards to calls
     >>>> of gcc were disabled by default.  This behavior may be
    required by some
     >>>> (poorly written) makefiles.
     >>>>
     >>>> This will allow someone to do:
     >>>>
     >>>> gcc *.c -o myoutput
     >>>>
     >>>> Signed-off-by: Mark Hatle <[email protected]
    <mailto:[email protected]>>
     >>>> ---
     >>>>    recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
     >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
     >>>>
     >>>> diff --git
    a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
    b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
     >>>> index 9c0d828..e0463c6 100644
     >>>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
     >>>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
     >>>> @@ -1,5 +1,5 @@
     >>>>    INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
     >>>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
     >>>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls
    --enable-mingw-wildcard"
     >>>
     >>> this change is fine. is this the only place we need it ?
     >>
     >> Yes, it doesn't do anything if the generated toolchain isn't
    mingw.. and AFAIK,
     >
     > Where does this bbappend go? Should this patch be designated to
    mingw layer?
     >

    its using an override, so it wont be effective elsewhere, perhaps
    oe-core is better place for it.
Quoted 1 line

Heh, I already applied it to master-next in meta-mingw :)

thats fine.

Quoted 24 lines

     >
     >> we're only build cross-canadian there.
     >>
     >> (binutils and others don't appear to have this option, unless I
    just missed it.)
     >>
     >> --Mark
     >>
     >>>>    LDFLAGS_append_sdkmingw32 = " -Wl,-static"
     >>>>    EXEEXT_sdkmingw32 = ".exe"
     >>>>    ELFUTILS_sdkmingw32 = ""
     >>>>
     >>>>
     >>>>
     >>>>
     >>>>
     >>>>
     >
     >>
     >