Skip to contentSkip to conversation

unmapped quotes

PATCH In review [email protected] 6 participants 6 messages May 12, 2012 – May 13, 2012

Subsystems (2)
Memory management Page cache
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 unmapped quotes

From: Wanpeng Li <[email protected]>

Signed-off-by Wanpeng Li <[email protected]>
---
 mm/page-writeback.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page-writeback.c +1 -1
index 26adea8..2b317a3 100644
@@ -1155,7 +1155,7 @@ static long bdi_min_pause(struct backing_dev_info *bdi,
  * balance_dirty_pages() must be called by processes which are generating dirty
  * data.  It looks at the number of dirty pages in the machine and will force
  * the caller to wait once crossing the (background_thresh + dirty_thresh) / 2.
- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to
  * perform some writeout.
  */
 static void balance_dirty_pages(struct address_space *mapping,
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 2 lines · On 12.05.2012 12:47, [email protected] wrote:

- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to

I can't say the original is wrong. Since these quotes don't have "open" and "close" versions like {} or () pairs does, people often use ` as opening and ' as closing - while staying within ascii. Alternatives are things like « » or other things, but these aren't ascii anymore. So I'd say keep it alone... ;)

/mjt

#2 lore raw
Quoted 9 lines · Michael Tokarev
Quoted 2 lines · On 12.05.2012 12:47, [email protected] wrote:

- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to

I can't say the original is wrong. Since these quotes don't have "open" and "close" versions like {} or () pairs does, people often use ` as opening and ' as closing - while staying within ascii. Alternatives are things like « » or other things, but these aren't ascii anymore. So I'd say keep it alone... ;)

Agreed. For example, latex uses ` and ' as opening and closing pairs. That does look a bit weird for C and shell users ;)

Thanks,
Fengguang

#3 lore raw
Quoted 5 lines · Fengguang Wu
Quoted 4 lines · Michael Tokarev
Quoted 2 lines · On 12.05.2012 12:47, [email protected] wrote:

- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to

Quoted 8 lines
Quoted 5 lines

I can't say the original is wrong. Since these quotes don't have "open" and "close" versions like {} or () pairs does, people often use ` as opening and ' as closing - while staying within ascii. Alternatives are things like « » or other things, but these aren't ascii anymore. So I'd say keep it alone... ;)

Agreed. For example, latex uses ` and ' as opening and closing pairs. That does look a bit weird for C and shell users ;)

In some fonts, ` is actually symmetrical to '.

If you change it to 'background_thresh', it will look like crap in my Sütterlin emacs.

#4 lore raw
Quoted 12 lines · Johannes Weiner
Quoted 11 lines · Fengguang Wu
Quoted 9 lines · Michael Tokarev
Quoted 2 lines · On 12.05.2012 12:47, [email protected] wrote:

- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to

I can't say the original is wrong.  Since these quotes don't have "open" and "close" versions like {} or () pairs does, people often use ` as opening and ' as closing - while staying within ascii. Alternatives are things like « » or other things, but these aren't ascii anymore.  So I'd say keep it alone... ;)

Quoted 7 lines
Quoted 2 lines

Agreed. For example, latex uses ` and ' as opening and closing pairs. That does look a bit weird for C and shell users ;)

In some fonts, ` is actually symmetrical to '.

If you change it to 'background_thresh', it will look like crap in my Sütterlin emacs.

Yup, see also,

http://english.stackexchange.com/questions/17695/any-reference-on-the-usage-of-a-backtick-and-single-quotation-mark-like-this/18669#18669

#5 lore raw
In reply to Fengguang Wu
Quoted 5 lines · Fengguang Wu
Quoted 4 lines · Michael Tokarev
Quoted 2 lines · On 12.05.2012 12:47, [email protected] wrote:

- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to

Quoted 7 lines
Quoted 5 lines

I can't say the original is wrong. Since these quotes don't have "open" and "close" versions like {} or () pairs does, people often use ` as opening and ' as closing - while staying within ascii. Alternatives are things like « » or other things, but these aren't ascii anymore. So I'd say keep it alone... ;)

Agreed. For example, latex uses ` and ' as opening and closing pairs.

m4 too.

Quoted 1 line

That does look a bit weird for C and shell users ;)

Just because they aren't used to it;-)
And shell scripting would be easier if shells had different opening and closing quote characters.

Bernd

Signature · 2 lines
Bernd Petrovitsch                  Email : [email protected]
                     LUGA : http://www.luga.at