Skip to contentSkip to conversation

staging: rtl8192u: ieee80211: Fix space required after }.

PATCH Superseded Valerio Genovese 2 participants 3 messages Apr 5, 2017 – Apr 6, 2017 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192u: ieee80211: Fix space required after }.

This was reported by checkpatch.pl:
ERROR: space required after that close brace '}'

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +1 -1
index 2c398ca..5218f27 100644
@@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
 	struct {
 		u16	FragNum:4;
 		u16	SeqNum:12;
-	}field;
+	} field;
 }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
 
 typedef union _BA_PARAM_SET {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Valerio Genovese

This was reported by checkpatch.pl:
ERROR: space required after that close brace '}'

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +0 -0
index 2c398ca..5218f27 100644

drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h typedef union _SEQUENCE_CONTROL{ · line 35

Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +1 -1
@@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
 	struct {
 		u16	FragNum:4;
 		u16	SeqNum:12;
-	}field;
+	} field;
 }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;

What about the one on the next line?

$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
author
#2 lore raw

Hi,

Thanks for the feedback. I re-submitted the patch as v2.

best
Valerio

Il 06/04/2017 01:57, Joe Perches ha scritto:

Quoted 28 lines · Valerio Genovese
Quoted 13 lines

This was reported by checkpatch.pl:
ERROR: space required after that close brace '}'

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +0 -0
index 2c398ca..5218f27 100644

drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h typedef union _SEQUENCE_CONTROL{ · line 35

Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h +1 -1
@@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
 	struct {
 		u16	FragNum:4;
 		u16	SeqNum:12;
-	}field;
+	} field;
 }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;

What about the one on the next line?

$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'