Skip to contentSkip to conversation

.gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

PATCH In review Thomas Huth 3 participants 7 messages Jan 5, 2023 – Jan 6, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

The qtests are not stable in the msys2-32bit job yet - especially the test-hmp and the qom-test are failing randomly. Until this is fixed, let's better disable the qtests here again to avoid failing CI tests.

---
 .gitlab-ci.d/windows.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
.gitlab-ci.d/windows.yml +2 -1
index 22f794e537..a1d5790580 100644
@@ -116,4 +116,5 @@ msys2-32bit:
   - ..\msys64\usr\bin\bash -lc '../configure --target-list=ppc64-softmmu
         --disable-opengl'
   - ..\msys64\usr\bin\bash -lc 'make'
-  - ..\msys64\usr\bin\bash -lc 'make check || { cat meson-logs/testlog.txt; exit 1; } ;'
+  - ..\msys64\usr\bin\bash -lc 'make check MTESTARGS=\"--no-suite qtest\" ||
+                                { cat meson-logs/testlog.txt; exit 1; }'
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Thomas Huth

The qtests are not stable in the msys2-32bit job yet - especially the test-hmp and the qom-test are failing randomly. Until this is fixed,

Who is gonna look after this?

I'm not against this patch, but I'm afraid this config starts to bitrot more. That said, maybe it is time to deprecate the 32-bit hosts?

Quoted 19 lines

let's better disable the qtests here again to avoid failing CI tests.

---
  .gitlab-ci.d/windows.yml | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
.gitlab-ci.d/windows.yml +2 -1
index 22f794e537..a1d5790580 100644
@@ -116,4 +116,5 @@ msys2-32bit:
    - ..\msys64\usr\bin\bash -lc '../configure --target-list=ppc64-softmmu
          --disable-opengl'
    - ..\msys64\usr\bin\bash -lc 'make'
-  - ..\msys64\usr\bin\bash -lc 'make check || { cat meson-logs/testlog.txt; exit 1; } ;'
+  - ..\msys64\usr\bin\bash -lc 'make check MTESTARGS=\"--no-suite qtest\" ||
+                                { cat meson-logs/testlog.txt; exit 1; }'
#2 lore raw
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Thomas Huth

The qtests are not stable in the msys2-32bit job yet - especially the test-hmp and the qom-test are failing randomly. Until this is fixed,

Who is gonna look after this?

It certainly has to be someone who's got a proper Windows installation. I've now tried to debug the failures for two days via the gitlab-CI jobs, and that just does not work. The turnaround times are way to long, and I really cannot waste all my limited CI minutes for such problems.

Quoted 2 lines

I'm not against this patch, but I'm afraid this config starts to bitrot more.

It's not really a big step backward - the qtests have just been enabled there 3 weeks ago (see commit a35e2ee929741fd), so this is just restoring the state from the time before the qtests have been enabled for Windows.

Quoted 2 lines

That said, maybe it is time to deprecate the 32-bit hosts?

Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?

Thomas

#3 lore raw

Am 06.01.23 um 08:49 schrieb Thomas Huth:

Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 3 lines

That said, maybe it is time to deprecate the 32-bit hosts?

Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?

 Thomas

Download numbers from yesterday for my latest Windows installers:

qemu-w32-setup-20221230.exe - 243

qemu-w64-setup-20221230.exe - 6540

On Wednesday the ratio was 288 : 3516.

As expected the 64-bit variant is used much more often, but it looks like there is still a certain desire for the 32-bit variant.

Stefan

#4 lore raw
Quoted 14 lines · Stefan Weil

Am 06.01.23 um 08:49 schrieb Thomas Huth:

Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 3 lines

That said, maybe it is time to deprecate the 32-bit hosts?

Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?

 Thomas

Download numbers from yesterday for my latest Windows installers:

Quoted 7 lines

qemu-w32-setup-20221230.exe - 243

qemu-w64-setup-20221230.exe - 6540

On Wednesday the ratio was 288 : 3516.

As expected the 64-bit variant is used much more often, but it looks like there is still a certain desire for the 32-bit variant.

OK, thanks. Could you maybe also check the browser types in the logs? ... I'm wondering whether a big part of those w32 downloads were just automatic web crawlers?

Thomas

#5 lore raw
Quoted 17 lines · Thomas Huth
Quoted 16 lines · Stefan Weil

Am 06.01.23 um 08:49 schrieb Thomas Huth:

Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 3 lines

That said, maybe it is time to deprecate the 32-bit hosts?

Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?

 Thomas

Download numbers from yesterday for my latest Windows installers:

qemu-w32-setup-20221230.exe - 243

Quoted 7 lines
Quoted 5 lines

qemu-w64-setup-20221230.exe - 6540

On Wednesday the ratio was 288 : 3516.

As expected the 64-bit variant is used much more often, but it looks like there is still a certain desire for the 32-bit variant.

OK, thanks. Could you maybe also check the browser types in the logs? ... I'm wondering whether a big part of those w32 downloads were just automatic web crawlers?

Or people downloading both variants "just in case" but only install the 64-bit one ;)

#6 lore raw
In reply to Thomas Huth

Am 06.01.23 um 09:19 schrieb Thomas Huth:

Quoted 8 lines · Stefan Weil
Quoted 7 lines

Download numbers from yesterday for my latest Windows installers:

qemu-w32-setup-20221230.exe - 243

qemu-w64-setup-20221230.exe - 6540

Quoted 7 lines
Quoted 3 lines

On Wednesday the ratio was 288 : 3516.

As expected the 64-bit variant is used much more often, but it looks like there is still a certain desire for the 32-bit variant.

OK, thanks. Could you maybe also check the browser types in the logs? ... I'm wondering whether a big part of those w32 downloads were just automatic web crawlers?

 Thomas

I now checked all downloads of the latests installers since 2022-12-30.

qemu-w32-setup-20221230.exe – 509 different IP addresses qemu-w64-setup-20221230.exe - 5471 different IP addresses

339 unique IP addresses are common for 32- and 64-bit, either crawlers or people who simply got both variants. So there remain 170 IP addresses which only downloaded the 32-bit variant in the last week.

I see 437 different strings for the browser type, but surprisingly none of them looks like a crawler.

Stefan