Skip to contentSkip to conversation

package/perl-crypt-openssl-guess: new package

PATCH New Bernd Kuhls 2 participants 8 messages Aug 21, 2018 – Sep 13, 2018 1 message not in the archive

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v2 1/3 package/perl-crypt-openssl-guess: new package

Needed for upcoming version bumps of perl-crypt-openssl-random and perl-crypt-openssl-rsa, only host-package is needed.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: switched to host package (Thomas)

 DEVELOPERS                                          |  1 +
 .../perl-crypt-openssl-guess.hash                   |  6 ++++++
 .../perl-crypt-openssl-guess.mk                     | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/perl-crypt-openssl-guess/perl-crypt-openssl-guess.hash
 create mode 100644 package/perl-crypt-openssl-guess/perl-crypt-openssl-guess.mk
DEVELOPERS +1 -0
index ccbc0a3b7a..154315fcfb 100644
@@ -330,6 +330,7 @@ F:	package/libyuv/
 F:	package/mesa3d/
 F:	package/minidlna/
 F:	package/mjpg-streamer/
+F:	package/perl-crypt-openssl-guess/
 F:	package/perl-crypt-openssl-random/
 F:	package/perl-crypt-openssl-rsa/
 F:	package/perl-digest-sha1/
package/perl-crypt-openssl-guess/perl-crypt-openssl-guess.hash new file +6 -0
new file mode 100644
index 0000000000..327b06900a
@@ -0,0 +1,6 @@
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    e768fe2c07826b0ac9ea604c79f93032 Crypt-OpenSSL-Guess-0.11.tar.gz
+sha256 aa6b18e38cb852cbad80a58cd90c395b40819d4d01e0ab37e7703149094d7167 Crypt-OpenSSL-Guess-0.11.tar.gz
+
+# computed by scancpan
+sha256 5c739f181ce7aa31d739277996ff230067dad39332e5597c0dffd36e5d784072 LICENSE
package/perl-crypt-openssl-guess/perl-crypt-openssl-guess.mk new file +13 -0
new file mode 100644
index 0000000000..69d7a0ef8f
@@ -0,0 +1,13 @@
+################################################################################
+#
+# perl-crypt-openssl-guess
+#
+################################################################################
+
+PERL_CRYPT_OPENSSL_GUESS_VERSION = 0.11
+PERL_CRYPT_OPENSSL_GUESS_SOURCE = Crypt-OpenSSL-Guess-$(PERL_CRYPT_OPENSSL_GUESS_VERSION).tar.gz
+PERL_CRYPT_OPENSSL_GUESS_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AK/AKIYM
+PERL_CRYPT_OPENSSL_GUESS_LICENSE = Artistic or GPL-1.0+
+PERL_CRYPT_OPENSSL_GUESS_LICENSE_FILES = LICENSE
+
+$(eval $(host-perl-package))
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v2 2/3 package/perl-crypt-openssl-random: bump version to 0.15

Changelog:
https://metacpan.org/changes/distribution/Crypt-OpenSSL-Random

Added new build dependency to host-perl-crypt-openssl-guess and force it to search for openssl in STAGING_DIR. Added license hash.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: switched to host version of perl-crypt-openssl-guess (Thomas)

 .../perl-crypt-openssl-random.hash                     |  7 +++++--
 .../perl-crypt-openssl-random.mk                       | 10 ++++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)
package/perl-crypt-openssl-random/perl-crypt-openssl-random.hash +5 -2
index caacdc9015..57677e3445 100644
@@ -1,3 +1,6 @@
 # retrieved by scancpan from http://cpan.metacpan.org/
-md5    5d71337503e0356ce1ce1481504e5885 Crypt-OpenSSL-Random-0.11.tar.gz
-sha256 bb8c81c6a39b9b13a22d818ee9a746242f136f0fadceb6b9776ae615e7524c7a Crypt-OpenSSL-Random-0.11.tar.gz
+md5    bcde8d5a822c91376deda3c4f0c75fbe Crypt-OpenSSL-Random-0.15.tar.gz
+sha256 f0876faa1ba3111e39b86aa730c603211eff2905e460c72a57b61e8cf475cef4 Crypt-OpenSSL-Random-0.15.tar.gz
+
+# computed by scancpan
+sha256 fdaba2134145d3e252c5930180b2bcb13b5367ad5a8713d6868f014cd25c496f LICENSE
package/perl-crypt-openssl-random/perl-crypt-openssl-random.mk +8 -2
index de029e9af0..1e1d7c1112 100644
@@ -4,11 +4,17 @@
 #
 ################################################################################
 
-PERL_CRYPT_OPENSSL_RANDOM_VERSION = 0.11
+PERL_CRYPT_OPENSSL_RANDOM_VERSION = 0.15
 PERL_CRYPT_OPENSSL_RANDOM_SOURCE = Crypt-OpenSSL-Random-$(PERL_CRYPT_OPENSSL_RANDOM_VERSION).tar.gz
 PERL_CRYPT_OPENSSL_RANDOM_SITE = $(BR2_CPAN_MIRROR)/authors/id/R/RU/RURBAN
-PERL_CRYPT_OPENSSL_RANDOM_DEPENDENCIES = openssl
+PERL_CRYPT_OPENSSL_RANDOM_DEPENDENCIES = \
+	host-perl-crypt-openssl-guess \
+	openssl
 PERL_CRYPT_OPENSSL_RANDOM_LICENSE = Artistic or GPL-1.0+
 PERL_CRYPT_OPENSSL_RANDOM_LICENSE_FILES = LICENSE
 
+# Try as hard as possible to remedy to the brain-damage their build-system
+# suffers from: don't search for openssl, they pick the host-system one.
+PERL_CRYPT_OPENSSL_RANDOM_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
+
 $(eval $(perl-package))
Signature · 1 line
2.18.0
#2 lore raw

PATCH v2 2/3 package/perl-crypt-openssl-random: bump version to 0.15

Hello,

Quoted 9 lines · Bernd Kuhls

Changelog:
https://metacpan.org/changes/distribution/Crypt-OpenSSL-Random

Added new build dependency to host-perl-crypt-openssl-guess and force it to search for openssl in STAGING_DIR. Added license hash.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: switched to host version of perl-crypt-openssl-guess (Thomas)

It would be nice if you could *reply* to the review e-mails that are being sent to you. Indeed, I'd like to have more explanation about this.

How is it possible that your previous iteration, which was adding perl-crypt-openssl-guess as a *target* package could be working ?

Thmas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 2/3 package/perl-crypt-openssl-random: bump version to 0.15

In reply to Bernd Kuhls

Hello,

Quoted 7 lines · Bernd Kuhls

Changelog:
https://metacpan.org/changes/distribution/Crypt-OpenSSL-Random

Added new build dependency to host-perl-crypt-openssl-guess and force it to search for openssl in STAGING_DIR. Added license hash.

Signed-off-by Bernd Kuhls <[email protected]>

This update is causing issues in the autobuilders:
http://autobuild.buildroot.net/?reason=perl-crypt-openssl-random-0.15.
Since it's only happening since September 9, even though the commit was made on August 22, maybe the root issue is due to another update/change, but it breaks this package.

Could you have a look ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

PATCH v2 2/3 package/perl-crypt-openssl-random: bump version to 0.15

Am Wed, 12 Sep 2018 16:39:06 +0200 schrieb Thomas Petazzoni:

Quoted 9 lines

Hello,

Quoted 6 lines · Bernd Kuhls

Changelog:
https://metacpan.org/changes/distribution/Crypt-OpenSSL-Random

Added new build dependency to host-perl-crypt-openssl-guess and force it to search for openssl in STAGING_DIR. Added license hash.

Quoted 8 lines
Quoted 2 lines

Signed-off-by: Bernd Kuhls
<[email protected]>

This update is causing issues in the autobuilders:
http://autobuild.buildroot.net/?reason=perl-crypt-openssl-random-0.15.
Since it's only happening since September 9, even though the commit was made on August 22, maybe the root issue is due to another update/change, but it breaks this package.

Hi Thomas,

I can not reproduce the problem with this defconfig
http://autobuild.buildroot.net/results/54f/
54f274f33e5221d6979c6c0ad9b5633a1869b204/

xlocale.h is present:

$ find output/staging/usr/include/ | grep xlocale
output/staging/usr/include/xlocale.h

But it is weird that the autobuilder build uses perl.h from output/host

/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/host/lib/ perl5/5.26.2/x86_64-linux/CORE/perl.h:738:13: fatal error: xlocale.h: No such file or directory
# include <xlocale.h>

instead of staging... But again, the build works on my machine.

Regards, Bernd

author
#5 lore raw

PATCH v2 3/3 package/perl-crypt-openssl-rsa: bump version to 0.30

In reply to Bernd Kuhls

Changelog:
https://metacpan.org/changes/distribution/Crypt-OpenSSL-RSA

Added new build dependency to host-perl-crypt-openssl-guess and force it to search for openssl in STAGING_DIR. Added license hash. Updated _SITE according to scancpan.

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: switched to host version of perl-crypt-openssl-guess (Thomas)

 .../perl-crypt-openssl-rsa.hash                      |  7 +++++--
 .../perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk | 12 +++++++++---
 2 files changed, 14 insertions(+), 5 deletions(-)
package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.hash +5 -2
index 6e060ce672..0d101d7bb8 100644
@@ -1,3 +1,6 @@
 # retrieved by scancpan from http://cpan.metacpan.org/
-md5    86217a5036fc63779c30420b5fd84129 Crypt-OpenSSL-RSA-0.28.tar.gz
-sha256 5357f977464bb3a8184cf2d3341851a10d5515b4b2b0dfb88bf78995c0ded7be Crypt-OpenSSL-RSA-0.28.tar.gz
+md5    10bca2fc6d0ba1aa329f227424ae87d5 Crypt-OpenSSL-RSA-0.30.tar.gz
+sha256 23e13531397af102db4fd24bcf70137add7c85c23cca697c43aa71c2959a29ac Crypt-OpenSSL-RSA-0.30.tar.gz
+
+# computed by scancpan
+sha256 8a693ad3f52daeeb5ac5deceb1e1109c9c87095ed5ba6506d6d5c106e4066f5a LICENSE
package/perl-crypt-openssl-rsa/perl-crypt-openssl-rsa.mk +9 -3
index b853d9953e..790af760c7 100644
@@ -4,11 +4,17 @@
 #
 ################################################################################
 
-PERL_CRYPT_OPENSSL_RSA_VERSION = 0.28
+PERL_CRYPT_OPENSSL_RSA_VERSION = 0.30
 PERL_CRYPT_OPENSSL_RSA_SOURCE = Crypt-OpenSSL-RSA-$(PERL_CRYPT_OPENSSL_RSA_VERSION).tar.gz
-PERL_CRYPT_OPENSSL_RSA_SITE = $(BR2_CPAN_MIRROR)/authors/id/P/PE/PERLER
-PERL_CRYPT_OPENSSL_RSA_DEPENDENCIES = perl-crypt-openssl-random
+PERL_CRYPT_OPENSSL_RSA_SITE = $(BR2_CPAN_MIRROR)/authors/id/T/TO/TODDR
+PERL_CRYPT_OPENSSL_RSA_DEPENDENCIES = \
+	host-perl-crypt-openssl-guess \
+	perl-crypt-openssl-random
 PERL_CRYPT_OPENSSL_RSA_LICENSE = Artistic or GPL-1.0+
 PERL_CRYPT_OPENSSL_RSA_LICENSE_FILES = LICENSE
 
+# Try as hard as possible to remedy to the brain-damage their build-system
+# suffers from: don't search for openssl, they pick the host-system one.
+PERL_CRYPT_OPENSSL_RSA_CONF_ENV = OPENSSL_PREFIX=$(STAGING_DIR)/usr
+
 $(eval $(perl-package))
Signature · 1 line
2.18.0
#6 lore raw

PATCH v2 1/3 package/perl-crypt-openssl-guess: new package

In reply to Bernd Kuhls

Hello,

Quoted 4 lines · Bernd Kuhls

Needed for upcoming version bumps of perl-crypt-openssl-random and perl-crypt-openssl-rsa, only host-package is needed.

Signed-off-by Bernd Kuhls <[email protected]>

Series applied to next. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

PATCH v2 2/3 package/perl-crypt-openssl-random: bump

Hello Bernd,

Quoted 8 lines · Bernd Kuhls

I can not reproduce the problem with this defconfig
http://autobuild.buildroot.net/results/54f/
54f274f33e5221d6979c6c0ad9b5633a1869b204/

xlocale.h is present:

$ find output/staging/usr/include/ | grep xlocale
output/staging/usr/include/xlocale.h

The same problem happens with perl-crypt-blowfish, and I was able to reproduce it. If you build just this package (i.e simple configuration), then it works fine because it uses the Perl headers from STAGING_DIR:

/home/test/buildroot/output/host/bin/powerpc-linux-gcc -c   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os      -DVERSION=\"2.14\" -DXS_VERSION=\"2.14\" -fPIC "-I/home/test/buildroot/output/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/perl5/5.26.2/powerpc-linux/CORE"   Blowfish.c
/home/test/buildroot/output/host/bin/powerpc-linux-gcc -c   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os      -DVERSION=\"2.14\" -DXS_VERSION=\"2.14\" -fPIC "-I/home/test/buildroot/output/host/powerpc-buildroot-linux-uclibc/sysroot/usr/lib/perl5/5.26.2/powerpc-linux/CORE"   _blowfish.c

However, if you do the full build of
http://autobuild.buildroot.net/results/aa764fd8e851225664af94e3bcb68657126d85e0/
using br-reproduce-build, you can reproduce the issue. And in this case, it's the host Perl headers that are included:

/home/test/aa764fd8e851225664af94e3bcb68657126d85e0/output/host/bin/powerpc-linux-gcc -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -DVERSION=\"2.14\" -DXS_VERSION=\"2.14\" -fPIC "-I/home/test/aa764fd8e851225664af94e3bcb68657126d85e0/output/host/lib/perl5/5.26.2/x86_64-linux/CORE" Blowfish.c
In file included from Blowfish.xs:9:0:
/home/test/aa764fd8e851225664af94e3bcb68657126d85e0/output/host/lib/perl5/5.26.2/x86_64-linux/CORE/perl.h:738:24: fatal error: xlocale.h: No such file or directory
# include <xlocale.h>

Not only this is incorrect, but it also fails badly because there is no xlocale.h in the toolchain sysroot:

output$ find . -name 'xlocale.h'
output$

Could you try:

wget http://git.buildroot.net/buildroot-test/plain/utils/br-reproduce-build
chmod +x br-reproduce-build
./br-reproduce-build aa764fd8e851225664af94e3bcb68657126d85e0

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com