Skip to contentSkip to conversation

libplayer: fix handling of cflags in configure

PATCH Superseded Arnout Vandecappelle (Essensium/Mind) 3 participants 4 messages Jul 14, 2012 – Oct 22, 2012

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libplayer: fix handling of cflags in configure

Problem was found when compiling libplayer with GStreamer support on x86_64 with a Sourcery toolchain.

---
v2: document error situation in commit log

 .../libplayer/libplayer-fix-configure-cflags.patch |   41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)
package/libplayer/libplayer-fix-configure-cflags.patch new file +41 -0
new file mode 100644
index 0000000..186afd5
@@ -0,0 +1,41 @@
+From: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
+Subject: [PATCH] libplayer: Fix handling of cflags in configure.
+
+The cflags returned by pkg-config or another config script may consist
+of several arguments for the compiler.  These should not be quoted together
+into a single argument.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
+---
+Sent upstream to devel at geexbox.org on July 11, 2012.
+---
+diff -rup libplayer-2.0.1.orig/configure libplayer-2.0.1/configure
+--- libplayer-2.0.1.orig/configure	2010-10-03 19:26:11.000000000 +0200
++++ libplayer-2.0.1/configure	2012-07-10 23:33:02.783701852 +0200
+@@ -342,7 +342,7 @@ check_libconfig(){
+   err=1
+   if `which "$config" 1>/dev/null 2>&1`; then
+     cflags=`$config $ccflags`
+-    [ -n "$cflags" ] && check_cflags "$cflags"
++    [ -n "$cflags" ] && check_cflags $cflags
+     libs=`$config $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"
+@@ -364,7 +364,7 @@ check_libconfig_exists(){
+   err=1
+   if `which "$config" 1>/dev/null 2>&1`; then
+     cflags=`$config $ccflags`
+-    [ -n "$cflags" ] && temp_cflags "$cflags"
++    [ -n "$cflags" ] && temp_cflags $cflags
+     libs=`$config $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"
+@@ -386,7 +386,7 @@ check_pkgconfig(){
+   err=1
+   if `which pkg-config 1>/dev/null 2>&1`; then
+     cflags=`pkg-config $pkg $ccflags`
+-    [ -n "$cflags" ] && check_cflags "$cflags"
++    [ -n "$cflags" ] && check_cflags $cflags
+     libs=`pkg-config $pkg $clibs`
+     if [ -n "$libs" ]; then
+       temp_extralibs "$libs"
Signature · 1 line
tg: (b8b57bb..) t/libplayer-cflags (depends on: master)
#1 lore raw

PATCH v2 1/1 libplayer: fix handling of cflags in configure

Le Sat, 14 Jul 2012 23:34:36 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> a ?crit :

Quoted 2 lines

Problem was found when compiling libplayer with GStreamer support on x86_64 with a Sourcery toolchain.

I've tried to build libplayer with gstreamer support for x86_64 with a Sourcery toolchain, and I didn't had an issue. Since your problem was quoting related, I thought that it could be caused by the ccache support, but it isn't.

Can you post the .config that triggers the problem, or provide more details on the problem? It's not that I don't believe that there is a problem, but without producing it, I feel a bit out of infos to review the patch.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 libplayer: fix handling of cflags in configure

Quoted 11 lines · Thomas Petazzoni

Le Sat, 14 Jul 2012 23:34:36 +0200,
"Arnout Vandecappelle (Essensium/Mind)"<[email protected]> a ?crit :

Quoted 2 lines

Problem was found when compiling libplayer with GStreamer support on x86_64 with a Sourcery toolchain.

I've tried to build libplayer with gstreamer support for x86_64 with a Sourcery toolchain, and I didn't had an issue. Since your problem was quoting related, I thought that it could be caused by the ccache support, but it isn't.

Quoted 4 lines

Can you post the .config that triggers the problem, or provide more details on the problem? It's not that I don't believe that there is a problem, but without producing it, I feel a bit out of infos to review the patch.

The config is an allpackageyesconfig from which I removed a few packages
that don't work on x86_64 or that can't be downloaded anymore. I've attached the defconfig. You'd best interrupt the build after the cross-compiler is extracted and then run 'make libplayer' explicitly, or you'll have to wait for hours for the build to finish...

Regards,
Arnout

Signature · 10 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: defconfig
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120717/e7bb9b87/attachment-0001.ksh>
#3 lore raw

PATCH v2 1/1 libplayer: fix handling of cflags in configure

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 11 lines · Thomas Petazzoni
Quoted 11 lines

Le Sat, 14 Jul 2012 23:34:36 +0200,
"Arnout Vandecappelle (Essensium/Mind)"<[email protected]> a ?crit :

Quoted 2 lines

Problem was found when compiling libplayer with GStreamer support on x86_64 with a Sourcery toolchain.

I've tried to build libplayer with gstreamer support for x86_64 with a Sourcery toolchain, and I didn't had an issue. Since your problem was quoting related, I thought that it could be caused by the ccache support, but it isn't.

Quoted 4 lines
Quoted 4 lines

Can you post the .config that triggers the problem, or provide more details on the problem? It's not that I don't believe that there is a problem, but without producing it, I feel a bit out of infos to review the patch.

Arnout> The config is an allpackageyesconfig from which I removed a Arnout> few packages that don't work on x86_64 or that can't be Arnout> downloaded anymore. I've attached the defconfig. You'd best Arnout> interrupt the build after the cross-compiler is extracted and Arnout> then run 'make libplayer' explicitly, or you'll have to wait Arnout> for hours for the build to finish...

Committed, thanks. The issue also triggered on the autobuilder yesterday:

http://autobuild.buildroot.net/results/2a22f33410197f5cf546bf1974c2e168d1b1a070/build-end.log

Signature · 1 line
Bye, Peter Korsgaard