Skip to contentSkip to conversation

Add missing modules aliases to get sound working on omap devices

PATCH In review Guillaume Gardet 2 participants 5 messages Jul 12, 2012 – Jul 26, 2012

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Guillaume Gardet

author
#0 lore raw

PATCH v2 1/1 Add missing modules aliases to get sound working on omap devices

This patch add missing modules aliases to get sound working on omap devices.

Tested on Beagleboard xM rev. B.

This patch is against 3.5-rc6 vanilla.

Signed-off-by Guillaume GARDET <[email protected]>
Signed-off-by Mans Rullgard <[email protected]>
Quoted 1 line

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001

From: Guillaume GARDET <[email protected]>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices

---
 sound/soc/omap/omap-mcbsp.c |    1 +
 sound/soc/omap/omap-pcm.c   |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/omap/omap-mcbsp.c +1 -0
index 1046083..acdd3ef 100644
@@ -820,3 +820,4 @@ module_platform_driver(asoc_mcbsp_driver);
 MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_DESCRIPTION("OMAP I2S SoC Interface");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-mcbsp");
sound/soc/omap/omap-pcm.c +1 -0
index 5a649da..f0feb06 100644
@@ -441,3 +441,4 @@ module_platform_driver(omap_pcm_driver);
 MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_DESCRIPTION("OMAP PCM DMA module");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-pcm-audio");
Signature · 1 line
1.7.7
#1 lore raw
Quoted 6 lines · Guillaume Gardet

This patch add missing modules aliases to get sound working on omap devices.

Tested on Beagleboard xM rev. B.

This patch is against 3.5-rc6 vanilla.

Quoted 8 lines
Signed-off-by Guillaume GARDET <[email protected]>
Signed-off-by Mans Rullgard <[email protected]>

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <[email protected]>
Date: Tue, 10 Jul 2012 13:47:16 +0200

Please resend in the format from SubmittingPatches rather than as an attachment.

author
#2 lore raw

Hi,

Quoted 11 lines · Mark Brown
Quoted 10 lines · Guillaume Gardet

This patch add missing modules aliases to get sound working on omap devices.

Tested on Beagleboard xM rev. B.

This patch is against 3.5-rc6 vanilla.

Signed-off-by Guillaume GARDET <[email protected]>
Signed-off-by Mans Rullgard <[email protected]>
Quoted 5 lines
Quoted 3 lines

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <[email protected]>
Date: Tue, 10 Jul 2012 13:47:16 +0200

Please resend in the format from SubmittingPatches rather than as an attachment.

Ok. Please find the patch below.

This patch add missing modules aliases to get sound working on omap devices.

Tested on Beagleboard xM rev. B.

This patch is against 3.5-rc6 vanilla.

Signed-off-by Guillaume GARDET <[email protected]>
Signed-off-by Mans Rullgard <[email protected]>

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <[email protected]>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices

---
 sound/soc/omap/omap-mcbsp.c |    1 +
 sound/soc/omap/omap-pcm.c   |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/omap/omap-mcbsp.c +1 -0
index 1046083..acdd3ef 100644
@@ -820,3 +820,4 @@ module_platform_driver(asoc_mcbsp_driver);
 MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_DESCRIPTION("OMAP I2S SoC Interface");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-mcbsp");
sound/soc/omap/omap-pcm.c +1 -0
index 5a649da..f0feb06 100644
@@ -441,3 +441,4 @@ module_platform_driver(omap_pcm_driver);
 MODULE_AUTHOR("Jarkko Nikula <[email protected]>");
 MODULE_DESCRIPTION("OMAP PCM DMA module");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-pcm-audio");
Signature · 7 lines
1.7.7


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 6 lines · Guillaume Gardet
Quoted 2 lines

Please resend in the format from SubmittingPatches rather than as an attachment.

Ok. Please find the patch below.

This patch add missing modules aliases to get sound working on omap devices.

I'm not sure you've looked at all of SubmittingPatches...

#4 lore raw
In reply to Guillaume Gardet
Quoted 1 line · Guillaume Gardet

This patch add missing modules aliases to get sound working on omap devices.

So, after a bunch of hand editing I applied this. As I *repeatedly* requested you should send patches in the format covered in SubmittingPatches, the main reason it took me so long to get round to applying this is that I had to strip things like this:

Quoted 4 lines

From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <[email protected]>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices

out of the commit message, plus the fact that since you hadn't used an appropriate subject line for the subsystem your patch didn't turn up when I searched my mail for patches to be handled.