hob2: add elf to image types

PATCH In review Kang Kai 2 participants 6 messages Jul 17, 2012 – Jul 19, 2012

lore

Share & tools

lore

Kang Kai

author

2012-07-17 07:10 UTC #0 lore raw

cover hob2: add elf to image types

Fixes Yocto #2709

The following changes since commit eb0cb7e8234f5d2e5623406e9660be91cf52f65e:

perf: add perl, python to DEPENDS (2012-07-12 12:52:09 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib kangkai/distro
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro

Kang Kai (1):
hob2: add elf to hcc supported image types

 bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Signature · 1 line

1.7.5.4

Kang Kai

author

2012-07-17 07:10 UTC #1 lore raw

PATCH 1/1 hob2: add elf to hcc supported image types

[Yocto #2709]

OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed.
Add elf to hcc supoorted image types to fix this issue.

Signed-off-by Kang Kai <[email protected]>

---
 bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

bitbake/lib/bb/ui/crumbs/hobwidget.py +1 -0

index dba278c..d10c56b 100644
@@ -89,6 +89,7 @@ class hcc:
         "cpio.xz"       : ["cpio.xz"],
         "vmdk"          : ["vmdk"],
         "cpio.lzma"     : ["cpio.lzma"],
+        "elf"           : ["elf"],
     }
 
 class HobViewTable (gtk.VBox):

Signature · 1 line

1.7.5.4

Richard Purdie

2012-07-17 10:04 UTC #2 lore raw

Re: [PATCH 1/1] hob2: add elf to hcc supported image types

Quoted 16 lines · Kang Kai

[Yocto #2709]
OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed.
Add elf to hcc supoorted image types to fix this issue.
Signed-off-by Kang Kai <[email protected]>
---
 bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
bitbake/lib/bb/ui/crumbs/hobwidget.py +0 -0
index dba278c..d10c56b 100644

bitbake/lib/bb/ui/crumbs/hobwidget.py class hcc: · line 95

Quoted 7 lines

bitbake/lib/bb/ui/crumbs/hobwidget.py +1 -0

@@ -89,6 +89,7 @@ class hcc:
         "cpio.xz"       : ["cpio.xz"],
         "vmdk"          : ["vmdk"],
         "cpio.lzma"     : ["cpio.lzma"],
+        "elf"           : ["elf"],
     }
 
 class HobViewTable (gtk.VBox):

Why do we have a hardcoded list here and why do new image types cause builds to fail?

We need to rewrite this code so this does not happen and the user at least gets a sensible error message. Hardcoded lists are bad...

I've merged the patch but I'd like to see a bug opened about this.

Cheers,

Richard

Kang Kai

author

2012-07-18 03:25 UTC #3 lore raw

Re: [PATCH 1/1] hob2: add elf to hcc supported image types

Quoted 23 lines · Richard Purdie

Quoted 22 lines · Kang Kai
[Yocto #2709]
OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed.
Add elf to hcc supoorted image types to fix this issue.
Signed-off-by Kang Kai<[email protected]>
---
  bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
bitbake/lib/bb/ui/crumbs/hobwidget.py +1 -0
index dba278c..d10c56b 100644
@@ -89,6 +89,7 @@ class hcc:
          "cpio.xz"       : ["cpio.xz"],
          "vmdk"          : ["vmdk"],
          "cpio.lzma"     : ["cpio.lzma"],
+        "elf"           : ["elf"],
      }
 

Quoted 1 line

bitbake/lib/bb/ui/crumbs/hobwidget.py class hcc: · line 95
Quoted 1 line
bitbake/lib/bb/ui/crumbs/hobwidget.py +0 -0
  class HobViewTable (gtk.VBox):

Hi Richard,

Thanks.

Quoted 2 lines

Why do we have a hardcoded list here and why do new image types cause builds to fail?

After build the image, Hob trys to get list of created images. It needs a map from image type to real image file's extend name, such as "live" --> "hddimg" and "iso". then search the image output dir to get the list.

Quoted 3 lines

We need to rewrite this code so this does not happen and the user at least gets a sensible error message. Hardcoded lists are bad...

For the current, only image type 'live' need this map. So I can remove the list and check the image type is whether 'live' or not. But for the future, if a new image type added and need this kind of map, new check for the single type is needed. I think for this scenario the list is better.

Regards,
Kai

Quoted 8 lines

I've merged the patch but I'd like to see a bug opened about this.
Cheers,
Richard

Richard Purdie

2012-07-18 13:26 UTC #4 lore raw

Re: [PATCH 1/1] hob2: add elf to hcc supported image types

Quoted 37 lines · Kang Kai

Quoted 23 lines · Richard Purdie
Quoted 22 lines · Kang Kai
[Yocto #2709]
OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed.
Add elf to hcc supoorted image types to fix this issue.
Signed-off-by Kang Kai<[email protected]>
---
  bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
bitbake/lib/bb/ui/crumbs/hobwidget.py +1 -0
index dba278c..d10c56b 100644
@@ -89,6 +89,7 @@ class hcc:
          "cpio.xz"       : ["cpio.xz"],
          "vmdk"          : ["vmdk"],
          "cpio.lzma"     : ["cpio.lzma"],
+        "elf"           : ["elf"],
      }
 
Quoted 1 line
bitbake/lib/bb/ui/crumbs/hobwidget.py class hcc: · line 95
Quoted 1 line
bitbake/lib/bb/ui/crumbs/hobwidget.py +0 -0
  class HobViewTable (gtk.VBox):
Hi Richard,
Thanks.
Quoted 2 lines
Why do we have a hardcoded list here and why do new image types cause builds to fail?
After build the image, Hob trys to get list of created images. It needs a map from image type to real image file's extend name, such as "live" --> "hddimg" and "iso".
then search the image output dir to get the list.
Quoted 1 line

Quoted 8 lines

Quoted 2 lines
We need to rewrite this code so this does not happen and the user at least gets a sensible error message. Hardcoded lists are bad...
For the current, only image type 'live' need this map. So I can remove the list and check the image type is whether 'live' or not. But for the future, if a new image type added and need this kind of map, new check for the single type is needed. I think for this scenario the list is better.

Well, I *hate* the concept that if you add a new image type, the UI has to be changed.

Ideally, we need to add something to the metadata that explains this mapping to the UI. I want to see the hardcoded list removed from the UI, one way or another.

Cheers,

Richard

Kang Kai

author

2012-07-19 03:27 UTC #5 lore raw

Re: [PATCH 1/1] hob2: add elf to hcc supported image types

Quoted 36 lines · Richard Purdie

Quoted 35 lines · Kang Kai
Quoted 23 lines · Richard Purdie
Quoted 22 lines · Kang Kai
[Yocto #2709]
OE Core Commit c9b01af84b64edba056f959c349895e0698324e6 add elf image type. This will cause hob build image failed.
Add elf to hcc supoorted image types to fix this issue.
Signed-off-by Kang Kai<[email protected]>
---
   bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
bitbake/lib/bb/ui/crumbs/hobwidget.py +1 -0
index dba278c..d10c56b 100644
@@ -89,6 +89,7 @@ class hcc:
           "cpio.xz"       : ["cpio.xz"],
           "vmdk"          : ["vmdk"],
           "cpio.lzma"     : ["cpio.lzma"],
+        "elf"           : ["elf"],
       }
 
Quoted 1 line
bitbake/lib/bb/ui/crumbs/hobwidget.py class hcc: · line 95
Quoted 1 line
bitbake/lib/bb/ui/crumbs/hobwidget.py +0 -0
   class HobViewTable (gtk.VBox):
Hi Richard,
Thanks.
Quoted 2 lines
Why do we have a hardcoded list here and why do new image types cause builds to fail?
After build the image, Hob trys to get list of created images. It needs a map from image type to real image file's extend name, such as "live" --> "hddimg" and "iso".
then search the image output dir to get the list.

Quoted 7 lines

Quoted 7 lines
Quoted 2 lines
We need to rewrite this code so this does not happen and the user at least gets a sensible error message. Hardcoded lists are bad...
For the current, only image type 'live' need this map. So I can remove the list and check the image type is whether 'live' or not. But for the future, if a new image type added and need this kind of map, new check for the single type is needed. I think for this scenario the list is better.

Hi Richard,

Quoted 6 lines

Well, I *hate* the concept that if you add a new image type, the UI has to be changed.
Ideally, we need to add something to the metadata that explains this mapping to the UI. I want to see the hardcoded list removed from the UI, one way or another.

I create *Bug 2795* <https://bugzilla.yoctoproject.org/show_bug.cgi?id=2795> to follow this issue, and 2709 is closed suggested by Jessica.

Regards,
Kai
<mailto:[email protected]>

Quoted 6 lines

Cheers,
Richard