meta: update crownbay.scc for newer emgd driver

PATCH In review [email protected] 3 participants 10 messages Jul 18, 2012 – Jul 20, 2012

lore

Share & tools

lore

[email protected]

author

2012-07-18 05:58 UTC #0 lore raw

cover meta: update crownbay.scc for newer emgd driver

From: Nitin A Kamble <[email protected]>

This commit changes emgd kernel driver for crownbay bsp to the emgd-1.14.

Thanks,
Nitin

The following changes since commit c2b5ee363bf2612932301488f3ac0644ff70fc7c:

meta: disable CONFIG_MTD_NAND_VERIFY_WRITE (2012-07-14 00:21:49 -0400)

are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/meta
http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=nitin/meta

Nitin A Kamble (1):
meta: crownbay.scc change emgd branch name

 .../bsp/crownbay/crownbay-standard.scc             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Signature · 1 line

1.7.3.4

[email protected]

author

2012-07-18 05:58 UTC #1 lore raw

PATCH 1/1 meta: crownbay.scc change emgd branch name

From: Nitin A Kamble <[email protected]>

Signed-off-by Nitin A Kamble <[email protected]>

---
 .../bsp/crownbay/crownbay-standard.scc             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

meta/cfg/kernel-cache/bsp/crownbay/crownbay-standard.scc +1 -1

index 4990371..cbda721 100644
@@ -6,7 +6,7 @@ include ktypes/standard
 branch crownbay
 
 include features/emgd/emgd-1.10.scc
-git merge emgd-1.10
+git merge emgd-1.14
 
 include crownbay.scc

Signature · 1 line

1.7.3.4

Tom Zanussi

2012-07-18 14:13 UTC #2 lore raw

In reply to [email protected]

Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:

From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-1.14.

Nitin,

Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?

Tom

Quoted 17 lines

Thanks,
Nitin
The following changes since commit c2b5ee363bf2612932301488f3ac0644ff70fc7c:
meta: disable CONFIG_MTD_NAND_VERIFY_WRITE (2012-07-14 00:21:49 -0400)
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/meta
http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=nitin/meta
Nitin A Kamble (1):
meta: crownbay.scc change emgd branch name
 .../bsp/crownbay/crownbay-standard.scc             |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Bruce Ashfield

2012-07-18 16:47 UTC #3 lore raw

Quoted 10 lines · Tom Zanussi

Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble<[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-1.14.
Nitin,
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?

Good question. I'm holding on merging and pushing this until we are sure that the whole stack will work ..

Cheers,

Bruce

Quoted 22 lines

Tom
Quoted 17 lines
Thanks,
Nitin
The following changes since commit c2b5ee363bf2612932301488f3ac0644ff70fc7c:
   meta: disable CONFIG_MTD_NAND_VERIFY_WRITE (2012-07-14 00:21:49 -0400)
are available in the git repository at:
   git://git.yoctoproject.org/linux-yocto-2.6.37-contrib nitin/meta
   http://git.yoctoproject.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=nitin/meta
Nitin A Kamble (1):
meta: crownbay.scc change emgd branch name
  .../bsp/crownbay/crownbay-standard.scc             |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Kamble, Nitin A

author

2012-07-19 02:58 UTC #4 lore raw

In reply to Tom Zanussi

Quoted 16 lines

-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 3 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line

Quoted 7 lines

Nitin,
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom

Tom,
I am holding the emgd 1.14 userspace commits until the kernel repository change goes upstream. The kernel recipe will need new SRCREV (with emgd 1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.

Nitin

Tom Zanussi

2012-07-19 03:26 UTC #5 lore raw

Quoted 17 lines · Nitin A

Quoted 17 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 3 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line
Nitin,

Quoted 8 lines

Quoted 5 lines
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom
Tom,
I am holding the emgd 1.14 userspace commits until the kernel repository change goes upstream. The kernel recipe will need new SRCREV (with emgd 1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.

Yeah, I understand, the crownbay is typically the most complicated update for all of those reasons - simultaneous new kernel version/recipe, new emgd branch, and new emgd userspace recipe all at the same time.

In the past I've submitted them all at the same time for simultaneous review and some coordination with Bruce - once the kernel parts are in, the kernel recipe and the userspace parts can then be pulled in along with a simple follow-on patch to update the SRCREVs Bruce give us.

The thing is that if Bruce pulls in the patch to switch to emgd-1.14 and only at that point do you post the userspace recipe, and it ends up needing some rework, in the meantime the graphics remain non-functional (I know, they already are, thanks to the package re-ordering patches breaking the current recipe, but hopefully the 1.14 changes will be in and we don't have to worry about it any more.).

Does that make sense, and can you just post the userspace and kernel recipe parts before we give Bruce the go-ahead in making the kernel changes? (I'd also like to try it out myself as well...).

Thanks,

Tom

Quoted 2 lines

Nitin

Kamble, Nitin A

author

2012-07-19 14:39 UTC #6 lore raw

Quoted 57 lines

-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:57 AM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 19 lines · Nitin A
Quoted 19 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line
Nitin,
Quoted 7 lines
Quoted 5 lines
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom
Tom,
I am holding the emgd 1.14 userspace commits until the kernel repository
change goes upstream. The kernel recipe will need new SRCREV (with emgd 1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.
Quoted 1 line
Yeah, I understand, the crownbay is typically the most complicated update for all of those reasons - simultaneous new kernel version/recipe, new emgd branch, and new emgd userspace recipe all at the same time.
In the past I've submitted them all at the same time for simultaneous review and some coordination with Bruce - once the kernel parts are in, the kernel recipe and the userspace parts can then be pulled in along with a simple follow-on patch to update the SRCREVs Bruce give us.
The thing is that if Bruce pulls in the patch to switch to emgd-1.14 and only at that point do you post the userspace recipe, and it ends up needing some rework, in the meantime the graphics remain non-functional (I know, they already are, thanks to the package re-ordering patches breaking the current recipe, but hopefully the 1.14 changes will be in and we don't have to worry about it any more.).

Quoted 4 lines

Does that make sense, and can you just post the userspace and kernel recipe parts before we give Bruce the go-ahead in making the kernel changes? (I'd also like to try it out myself as well...).

Tom,
Until the crownbay bsp's Linux-yocto kernel recipe's meta SRCREV is updated, these kernel repo changes have no effect in the build process. Right ? So as I see, this commit does not make anything worst (or better).
I am sending the userland recipe commits anyway; So that you can also test it out.

Thanks,
Nitin

Tom Zanussi

2012-07-19 14:57 UTC #7 lore raw

Quoted 56 lines · Nitin A

Quoted 56 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:57 AM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 19 lines · Nitin A
Quoted 19 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line
Nitin,
Quoted 7 lines
Quoted 5 lines
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom
Tom,
I am holding the emgd 1.14 userspace commits until the kernel repository
change goes upstream. The kernel recipe will need new SRCREV (with emgd 1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.
Quoted 1 line
Yeah, I understand, the crownbay is typically the most complicated update for all of those reasons - simultaneous new kernel version/recipe, new emgd branch, and new emgd userspace recipe all at the same time.
In the past I've submitted them all at the same time for simultaneous review and some coordination with Bruce - once the kernel parts are in, the kernel recipe and the userspace parts can then be pulled in along with a simple follow-on patch to update the SRCREVs Bruce give us.
The thing is that if Bruce pulls in the patch to switch to emgd-1.14 and only at that point do you post the userspace recipe, and it ends up needing some rework, in the meantime the graphics remain non-functional (I know, they already are, thanks to the package re-ordering patches breaking the current recipe, but hopefully the 1.14 changes will be in and we don't have to worry about it any more.).

Quoted 8 lines

Quoted 4 lines
Does that make sense, and can you just post the userspace and kernel recipe parts before we give Bruce the go-ahead in making the kernel changes? (I'd also like to try it out myself as well...).
Tom,
Until the crownbay bsp's Linux-yocto kernel recipe's meta SRCREV is updated, these kernel repo changes have no effect in the build process. Right ? So as I see, this commit does not make anything worst (or better).
I am sending the userland recipe commits anyway; So that you can also test it out.

Right, but what if we have to update the meta SRCREV for a different reason in the meantime (like we did last week for instance). We're then forced to take the emgd commit as well.

In any case, it's your BSP so it's up to you how you want to manage it, I'm just trying to save you and the users some headaches. It always made sense to me to do it all at the same time, all else being equal...

Tom

Quoted 6 lines

Thanks,
Nitin

Kamble, Nitin A

author

2012-07-19 15:25 UTC #8 lore raw

Quoted 79 lines

-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:27 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 43 lines · Nitin A
Quoted 43 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:57 AM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 19 lines · Nitin A
Quoted 19 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble <[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line
Nitin,
Quoted 8 lines
Quoted 5 lines
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom
Tom,
I am holding the emgd 1.14 userspace commits until the kernel
repository
change goes upstream. The kernel recipe will need new SRCREV (with emgd
1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.
Quoted 1 line
Quoted 3 lines
Quoted 3 lines
Yeah, I understand, the crownbay is typically the most complicated update for all of those reasons - simultaneous new kernel version/recipe, new emgd branch, and new emgd userspace recipe all at
the same time.
Quoted 5 lines
Quoted 5 lines
In the past I've submitted them all at the same time for simultaneous review and some coordination with Bruce - once the kernel parts are in, the kernel recipe and the userspace parts can then be pulled in along with a simple follow-on patch to update the
SRCREVs Bruce give us.
Quoted 8 lines
Quoted 8 lines
The thing is that if Bruce pulls in the patch to switch to emgd-1.14 and only at that point do you post the userspace recipe, and it ends up needing some rework, in the meantime the graphics remain non-functional (I know, they already are, thanks to the package re-ordering patches breaking the current recipe, but hopefully the 1.14 changes will be in and we don't have to worry about it any more.).
Quoted 6 lines
Quoted 4 lines
Does that make sense, and can you just post the userspace and kernel recipe parts before we give Bruce the go-ahead in making the kernel changes? (I'd also like to try it out myself as well...).
Tom,
Until the crownbay bsp's Linux-yocto kernel recipe's meta SRCREV is
updated, these kernel repo changes have no effect in the build process. Right ? So as I see, this commit does not make anything worst (or better).

Quoted 7 lines

Quoted 1 line
I am sending the userland recipe commits anyway; So that you can also test
it out.
Quoted 1 line
Right, but what if we have to update the meta SRCREV for a different reason in the meantime (like we did last week for instance). We're then forced to take the emgd commit as well.

I see the issue now. And I don't see a perfect solution to the issue. Because of commits in two different repos there always going to be this kind of a sync issue. The best is pull the commits in both repositories at the same time.

Thanks,
Nitin

Quoted 14 lines

In any case, it's your BSP so it's up to you how you want to manage it, I'm just trying to save you and the users some headaches. It always made sense to me to do it all at the same time, all else being equal...
Tom
Quoted 6 lines
Thanks,
Nitin

Bruce Ashfield

2012-07-20 04:53 UTC #9 lore raw

Quoted 80 lines · Nitin A

Quoted 80 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:27 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 43 lines · Nitin A
Quoted 43 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Thursday, July 19, 2012 8:57 AM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: RE: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 19 lines · Nitin A
Quoted 19 lines
-----Original Message-----
From: Zanussi, Tom
Sent: Wednesday, July 18, 2012 7:43 PM
To: Kamble, Nitin A
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/1] meta: update crownbay.scc for newer emgd driver
Quoted 4 lines · On Mon, 2012-07-16 at 22:57 -0700, [email protected] wrote:
From: Nitin A Kamble<[email protected]>
This commit changes emgd kernel driver for crownbay bsp to the emgd-
1.14.
Quoted 1 line
Nitin,
Quoted 8 lines
Quoted 5 lines
Doesn't switching this over in the kenrnel require emgd-1.14 userspace recipe updates to work? Did I miss those?
Tom
Tom,
I am holding the emgd 1.14 userspace commits until the kernel
repository
change goes upstream. The kernel recipe will need new SRCREV (with emgd
1.14 kernel parts) for the user level emgd 1.14 parts to work. And that dependency will get satisfied once this commit is in.
Quoted 1 line
Quoted 3 lines
Quoted 3 lines
Yeah, I understand, the crownbay is typically the most complicated update for all of those reasons - simultaneous new kernel version/recipe, new emgd branch, and new emgd userspace recipe all at
the same time.
Quoted 5 lines
Quoted 5 lines
In the past I've submitted them all at the same time for simultaneous review and some coordination with Bruce - once the kernel parts are in, the kernel recipe and the userspace parts can then be pulled in along with a simple follow-on patch to update the
SRCREVs Bruce give us.
Quoted 8 lines
Quoted 8 lines
The thing is that if Bruce pulls in the patch to switch to emgd-1.14 and only at that point do you post the userspace recipe, and it ends up needing some rework, in the meantime the graphics remain non-functional (I know, they already are, thanks to the package re-ordering patches breaking the current recipe, but hopefully the 1.14 changes will be in and we don't have to worry about it any more.).
Quoted 6 lines
Quoted 4 lines
Does that make sense, and can you just post the userspace and kernel recipe parts before we give Bruce the go-ahead in making the kernel changes? (I'd also like to try it out myself as well...).
Tom,
Until the crownbay bsp's Linux-yocto kernel recipe's meta SRCREV is
updated, these kernel repo changes have no effect in the build process. Right ? So as I see, this commit does not make anything worst (or better).
Quoted 1 line
I am sending the userland recipe commits anyway; So that you can also test

Quoted 8 lines

Quoted 6 lines
it out.
Quoted 1 line
Right, but what if we have to update the meta SRCREV for a different reason in the meantime (like we did last week for instance). We're then forced to take the emgd commit as well.
I see the issue now. And I don't see a perfect solution to the issue. Because of commits in two different repos there always going to be this kind of a sync issue. The best is pull the commits in both repositories at the same time.

FYI: everything is staged and I have a SRCREV commit prepared for this.

When I hear a clear "yes" on the userspace changes, I can send the pull request immediately.

Cheers,

Bruce

Quoted 19 lines

Thanks,
Nitin
Quoted 14 lines
In any case, it's your BSP so it's up to you how you want to manage it, I'm just trying to save you and the users some headaches. It always made sense to me to do it all at the same time, all else being equal...
Tom
Quoted 6 lines
Thanks,
Nitin