tools, config.mk: add binutils-version

Disable sibling call optimization based on binutils version. This is to work around a bug in the assember in binutils versions < 2.22. Branches to weak symbols can be incorrectly optimized in thumb mode to a short branch (b.n instruction) that won't reach when the symbol gets preempted.

http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Signed-off-by Allen Martin <[email protected]>

---
changes for v4:
-removed warning print
changes for v3:
-split shell line to improve readability
changes for v2:
-changed GAS_BUG_12532 from yes/no to y/n to be consistent -added additional warning about code size increase

---
 arch/arm/config.mk |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

arch/arm/config.mk +8 -0

index 3f4453a..24b9d7c 100644
@@ -87,3 +87,21 @@ endif
 ifndef CONFIG_NAND_SPL
 LDFLAGS_u-boot += -pie
 endif
+
+#
+# FIXME: binutils versions < 2.22 have a bug in the assembler where
+# branches to weak symbols can be incorrectly optimized in thumb mode
+# to a short branch (b.n instruction) that won't reach when the symbol
+# gets preempted
+#
+# http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Hi Allen,

Quoted 42 lines · Allen Martin

Disable sibling call optimization based on binutils version. This is to work around a bug in the assember in binutils versions < 2.22. Branches to weak symbols can be incorrectly optimized in thumb mode to a short branch (b.n instruction) that won't reach when the symbol gets preempted.

http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Signed-off-by Allen Martin <[email protected]>

---
changes for v4:
-removed warning print
changes for v3:
-split shell line to improve readability
changes for v2:
-changed GAS_BUG_12532 from yes/no to y/n to be consistent -added additional warning about code size increase

---
 arch/arm/config.mk |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

arch/arm/config.mk +13 -0

index 3f4453a..24b9d7c 100644
@@ -87,3 +87,21 @@ endif
 ifndef CONFIG_NAND_SPL
 LDFLAGS_u-boot += -pie
 endif
+
+#
+# FIXME: binutils versions < 2.22 have a bug in the assembler where
+# branches to weak symbols can be incorrectly optimized in thumb mode
+# to a short branch (b.n instruction) that won't reach when the symbol
+# gets preempted
+#
+# http://sourceware.org/bugzilla/show_bug.cgi?id=12532
+#
+ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
+ifeq ($(GAS_BUG_12532),)
+export GAS_BUG_12532:=$(shell if [ $(call binutils-version) -lt 0222 ] ; \
+	then echo y; else echo n; fi)

arch/arm/config.mk endif · line 107

Quoted 5 lines

arch/arm/config.mk +5 -0

+endif
+ifeq ($(GAS_BUG_12532),y)
+PLATFORM_RELFLAGS += -fno-optimize-sibling-calls
+endif
+endif

Can previous reviewers ack or test this? I would like to have it in the ARM master branch in time for 12.07.

Quoted 11 lines · Albert ARIBAUD

Hi Allen,

Quoted 8 lines · Allen Martin

Disable sibling call optimization based on binutils version. This is to work around a bug in the assember in binutils versions < 2.22. Branches to weak symbols can be incorrectly optimized in thumb mode to a short branch (b.n instruction) that won't reach when the symbol gets preempted.

http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Quoted 5 lines

Quoted 1 line

Signed-off-by Allen Martin <[email protected]>

Can previous reviewers ack or test this? I would like to have it in the ARM master branch in time for 12.07.

Acked-by Tom Rini <[email protected]>

Disable sibling call optimization based on binutils version. This is to work around a bug in the assember in binutils versions < 2.22. Branches to weak symbols can be incorrectly optimized in thumb mode to a short branch (b.n instruction) that won't reach when the symbol gets preempted.

http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Signed-off-by Allen Martin <[email protected]>

---
changes for v4:
-removed warning print
changes for v3:
-split shell line to improve readability
changes for v2:
-changed GAS_BUG_12532 from yes/no to y/n to be consistent -added additional warning about code size increase

---
 arch/arm/config.mk |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

arch/arm/config.mk +8 -0

index 3f4453a..24b9d7c 100644
@@ -87,3 +87,21 @@ endif
 ifndef CONFIG_NAND_SPL
 LDFLAGS_u-boot += -pie
 endif
+
+#
+# FIXME: binutils versions < 2.22 have a bug in the assembler where
+# branches to weak symbols can be incorrectly optimized in thumb mode
+# to a short branch (b.n instruction) that won't reach when the symbol
+# gets preempted
+#
+# http://sourceware.org/bugzilla/show_bug.cgi?id=12532

Quoted 3 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

(quoted diff) +1 -1

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . 
-f 1) +MINOR=$($gas --version | head -1 | awk '{print $NF}' |

cut -d . -f 2) + +printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

Quoted 8 lines · Mike Frysinger

tools/binutils-version.sh line 20

Quoted 4 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

tools/binutils-version.sh new file +4 -0

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1)
+MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2)
+
+printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

Quoted 2 lines

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

That looks much longer and we call this once so a few execs is noise.

Quoted 8 lines · On Thursday 19 July 2012 11:08:10 Tom Rini wrote:

Quoted 7 lines · Mike Frysinger

Quoted 3 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

(quoted diff) +1 -1

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut
-d . -f 1) +MINOR=$($gas --version | head -1 | awk '{print

$NF}' | cut -d . -f 2) + +printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

Quoted 5 lines

Quoted 2 lines

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

That looks much longer and we call this once so a few execs is noise.

here's a shorter version: $gas --version | awk '{ gsub(/[.]/, " ", $NF); $0 = $NF; printf "%02d%02d\n", $1, $2; exit }'

Quoted 13 lines · Mike Frysinger

Quoted 12 lines · On Thursday 19 July 2012 11:08:10 Tom Rini wrote:

Quoted 10 lines · Mike Frysinger

tools/binutils-version.sh line 20

Quoted 4 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

tools/binutils-version.sh new file +4 -0

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1)
+MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2)
+
+printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

Quoted 5 lines

Quoted 2 lines

That looks much longer and we call this once so a few execs is noise.

here's a shorter version: $gas --version | awk '{ gsub(/[.]/, " ", $NF); $0 = $NF; printf "%02d%02d\n", $1, $2; exit }'

And still over 80 chars before we assign it to a variable. I could get it to 77 chars with all whitespace removed.

Quoted 20 lines · On Thursday 19 July 2012 11:38:39 Tom Rini wrote:

Quoted 18 lines · Mike Frysinger

Quoted 7 lines · On Thursday 19 July 2012 11:08:10 Tom Rini wrote:

Quoted 6 lines · Mike Frysinger

Quoted 4 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1) +MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2) + +printf "%02d%02d\\n" $MAJOR $MINOR

Quoted 7 lines

Quoted 4 lines

can be replaced with a single awk script:

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

That looks much longer and we call this once so a few execs is noise.

here's a shorter version: $gas --version | awk '{ gsub(/[.]/, " ", $NF); $0 = $NF; printf "%02d%02d\n", $1, $2; exit }'

Quoted 2 lines

And still over 80 chars before we assign it to a variable. I could get it to 77 chars with all whitespace removed.

which is why i unrolled it to make it readable. i don't know what metrics you're using here, but i don't think the awk version is "longer" by really any of them.

Quoted 24 lines · Mike Frysinger

Quoted 22 lines · On Thursday 19 July 2012 11:38:39 Tom Rini wrote:

Quoted 10 lines · Mike Frysinger

Quoted 9 lines · On Thursday 19 July 2012 11:08:10 Tom Rini wrote:

Quoted 8 lines · Mike Frysinger

Quoted 4 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1) +MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2) + +printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

Quoted 8 lines

Quoted 5 lines

Quoted 2 lines

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

That looks much longer and we call this once so a few execs is noise.

here's a shorter version: $gas --version | awk '{ gsub(/[.]/, " ", $NF); $0 = $NF; printf "%02d%02d\n", $1, $2; exit }'

And still over 80 chars before we assign it to a variable. I could get it to 77 chars with all whitespace removed.

Quoted 3 lines

which is why i unrolled it to make it readable. i don't know what metrics you're using here, but i don't think the awk version is "longer" by really any of them.

The metric of 'wc -c' and "what fits in a single line, unwrapped on an 80x24 terminal." awk is great and awesome, don't get me wrong, but it's not doing the job as compactly as the original.

Quoted 29 lines · On Thursday 19 July 2012 12:54:37 Tom Rini wrote:

Quoted 27 lines · Mike Frysinger

Quoted 14 lines · On Thursday 19 July 2012 11:38:39 Tom Rini wrote:

Quoted 13 lines · Mike Frysinger

Quoted 12 lines · On Thursday 19 July 2012 11:08:10 Tom Rini wrote:

Quoted 10 lines · Mike Frysinger

Quoted 4 lines · On Wednesday 18 July 2012 19:45:52 Allen Martin wrote:

+MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1) +MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2) + +printf "%02d%02d\\n" $MAJOR $MINOR

can be replaced with a single awk script:

$gas --version | awk '{ gsub(/[.]/, " ", $NF) $0 = $NF printf "%02d%02d\n", $1, $2 exit }'

Quoted 8 lines

Quoted 5 lines

Quoted 2 lines

That looks much longer and we call this once so a few execs is noise.

here's a shorter version: $gas --version | awk '{ gsub(/[.]/, " ", $NF); $0 = $NF; printf "%02d%02d\n", $1, $2; exit }'

And still over 80 chars before we assign it to a variable. I could get it to 77 chars with all whitespace removed.

which is why i unrolled it to make it readable. i don't know what metrics you're using here, but i don't think the awk version is "longer" by really any of them.

Quoted 3 lines

The metric of 'wc -c' and "what fits in a single line, unwrapped on an 80x24 terminal." awk is great and awesome, don't get me wrong, but it's not doing the job as compactly as the original.

obviously i disagree. i find the awk version "better" in just about every way. maybe someone else will jump in with their favorite bike.

As the original author I don't really care either way, I only care about working around the assembler bug so I can turn on thumb for tegra. But maybe I'll rewrite it in prolog just to mess with you guys :^)

But maybe I'll rewrite it in prolog just to mess with you guys

Quoted 1 line · On Wednesday 01 August 2012 18:46:18 Allen Martin wrote:

But maybe I'll rewrite it in prolog just to mess with you guys

i'd ack it if it were written in bf
-mike

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

]<<<<<<[<<<<<<]>>>>>[>>>>>>]><<<<<<<<<<<<[-]<[-]++++++[>++++++++<-]>.>>\

.>>>>>>>>>>>>.>>>>>>.' > $tmp

Challenge accepted

tmp=$(mktemp)
echo '>>++++[<++++++++>-]>>+++++[>+++++++++<-]>+>,[>>++++[<++++++++>-]>>+++++[>\
+++++++++<-]>+>,]<<<<<<[<<<<<<]>>>>>>[<[<+>-]>[<<-<+>>>-]<<<[>>>+<<<-]>[>+<[-]]\

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 2 lines

Quoted 1 line

Quoted 1 line

Quoted 1 line

Quoted 1 line

]<<<<<<[<<<<<<]>>>>>[>>>>>>]><<<<<<<<<<<<[-]<[-]++++++[>++++++++<-]>.>>\

.>>>>>>>>>>>>.>>>>>>.' > $tmp