mmc: dw-mmc: fixed secstion mismatch in reference

PATCH Superseded Jaehoon Chung 2 participants 4 messages Jul 19, 2012 – Jul 23, 2012

Subsystems (2)

MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver

lore

Share & tools

lore

Jaehoon Chung

author maintainer

2012-07-19 15:19 UTC #0 lore raw

PATCH 1/1 mmc: dw-mmc: fixed secstion mismatch in reference

Fixed the below message.

WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function dw_mci_probe() to the function .init.text:dw_mci_init_slot() The function dw_mci_probe() references
the function __init dw_mci_init_slot().
This is often because dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong

Signed-off-by Jaehoon Chung <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/mmc/host/dw_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/mmc/host/dw_mmc.c +1 -1

index 72dc3cd..7955eba 100644
@@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
 	}
 }
 
-static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
+static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
 {
 	struct mmc_host *mmc;
 	struct dw_mci_slot *slot;

Signature · 1 line

1.7.4.1

Seungwon Jeon

2012-07-20 11:36 UTC #1 lore raw

Hi Jaehoon,

July 20, 2012, Jaehoon Chung <[email protected]>

Quoted 20 lines

Fixed the below message.
WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function dw_mci_probe() to the function .init.text:dw_mci_init_slot()
The function dw_mci_probe() references
the function __init dw_mci_init_slot().
This is often because dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +0 -0
index 72dc3cd..7955eba 100644

drivers/mmc/host/dw_mmc.c static void dw_mci_work_routine_card(struct work_struct *work) · line 1766

Quoted 8 lines

drivers/mmc/host/dw_mmc.c +1 -1

@@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
 	}
 }
 
-static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
+static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
 {
 	struct mmc_host *mmc;
 	struct dw_mci_slot *slot;

__init macro isn't required?
If so, how about adding __init macros to dw_mci_probe and dw_mci_pltfm_probe?

Best regards,
Seungwon Jeon

Quoted 6 lines

--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Jaehoon Chung

author maintainer

2012-07-23 01:52 UTC #2 lore raw

Hi Seungwon,

Quoted 26 lines · Seungwon Jeon

Hi Jaehoon,
July 20, 2012, Jaehoon Chung <[email protected]>
Quoted 23 lines
Fixed the below message.
WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function dw_mci_probe() to the function .init.text:dw_mci_init_slot()
The function dw_mci_probe() references
the function __init dw_mci_init_slot().
This is often because dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +0 -0
index 72dc3cd..7955eba 100644
@@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
 	}
 }
 

Quoted 9 lines

drivers/mmc/host/dw_mmc.c static void dw_mci_work_routine_card(struct work_struct *work) · line 1766
Quoted 5 lines
drivers/mmc/host/dw_mmc.c +1 -1
-static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
+static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
 {
 	struct mmc_host *mmc;
 	struct dw_mci_slot *slot;
__init macro isn't required?
If so, how about adding __init macros to dw_mci_probe and dw_mci_pltfm_probe?

As you're mentioned, I think right that add __init macro to dw_mci_pltfm_probe. but dw_mci_probe? i didn't think so...

Best Regards,
Jaehoon Chung

Quoted 11 lines

Best regards,
Seungwon Jeon
Quoted 6 lines
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Seungwon Jeon

2012-07-23 03:02 UTC #3 lore raw

Quoted 38 lines · Jaehoon Chung

Hi Seungwon,
Quoted 26 lines · Seungwon Jeon
Hi Jaehoon,
July 20, 2012, Jaehoon Chung <[email protected]>
Quoted 23 lines
Fixed the below message.
WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function dw_mci_probe() to the function .init.text:dw_mci_init_slot()
The function dw_mci_probe() references
the function __init dw_mci_init_slot().
This is often because dw_mci_probe lacks a __init
annotation or the annotation of dw_mci_init_slot is wrong
Signed-off-by Jaehoon Chung <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/mmc/host/dw_mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mmc/host/dw_mmc.c +0 -0
index 72dc3cd..7955eba 100644
@@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
 	}
 }
 
Quoted 9 lines
drivers/mmc/host/dw_mmc.c static void dw_mci_work_routine_card(struct work_struct *work) · line 1766
Quoted 5 lines
drivers/mmc/host/dw_mmc.c +1 -1
-static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
+static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
 {
 	struct mmc_host *mmc;
 	struct dw_mci_slot *slot;
__init macro isn't required?
If so, how about adding __init macros to dw_mci_probe and dw_mci_pltfm_probe?

Quoted 2 lines

As you're mentioned, I think right that add __init macro to dw_mci_pltfm_probe. but dw_mci_probe? i didn't think so...

Yes, dw_mci_pltfm_probe is only proper.

Thanks,
Seungwon Jeon

Quoted 20 lines

Best Regards,
Jaehoon Chung
Quoted 11 lines
Best regards,
Seungwon Jeon
Quoted 6 lines
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html