Skip to contentSkip to conversation

V2 add downloadfilename param to wget fetcher

PATCH Applied [email protected] 3 participants 4 messages Jul 19, 2012 – Jul 24, 2012

lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover V2 add downloadfilename param to wget fetcher

From: Nitin A Kamble <[email protected]>

In this V2 commit, not required changes from __init__.py are removed. Thanks,
Nitin

The following changes since commit 5b014eae151a1584df4e3d3b96d18f9df3e55665:

fix my typos in patch headers (2012-07-16 21:45:01 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib nitin/misc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Nitin A Kamble (1):
bitbake wget fetcher: add parameter: downloadfilename

 bitbake/lib/bb/fetch2/wget.py |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH 1/1 bitbake wget fetcher: add parameter: downloadfilename

From: Nitin A Kamble <[email protected]>

this allows wget fetcher to store the downloaded file in a specified custom filename in ${DL_DIR}

Exmaple:
SRC_URI = "https://edc.intel.com/Download.aspx?id=6190;downloadfilename=LIN_IEMGD_1_14_GOLD_2443.tgz"

This fixes bug:
[YOCTO #2570]

Signed-off-by Nitin A Kamble <[email protected]>
---
 bitbake/lib/bb/fetch2/wget.py |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
bitbake/lib/bb/fetch2/wget.py +8 -1
index b784afb..9affa0d 100644
@@ -50,7 +50,11 @@ class Wget(FetchMethod):
 
     def urldata_init(self, ud, d):
 
-        ud.basename = os.path.basename(ud.path)
+        if 'downloadfilename' in ud.parm:
+            ud.basename = ud.parm['downloadfilename']
+        else:
+            ud.basename = os.path.basename(ud.path)
+
         ud.localfile = data.expand(urllib.unquote(ud.basename), d)
 
     def download(self, uri, ud, d, checkonly = False):

@@ -58,6 +62,9 @@ class Wget(FetchMethod):
 
         basecmd = d.getVar("FETCHCMD_wget", True) or "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --no-check-certificate"
 
+        if 'downloadfilename' in ud.parm:
+            basecmd += " -O ${DL_DIR}/" + ud.localfile
+
         if checkonly:
             fetchcmd = d.getVar("CHECKCOMMAND_wget", True) or d.expand(basecmd + " -c -P ${DL_DIR} '${URI}'")
         elif os.path.exists(ud.localpath):
Signature · 1 line
1.7.3.4
Applied
#2 lore raw

Re: [PATCH 1/1] bitbake wget fetcher: add parameter: downloadfilename

Quoted 7 lines · On Wed, 2012-07-18 at 17:39 -0700, [email protected] wrote:

From: Nitin A Kamble <[email protected]>

this allows wget fetcher to store the downloaded file in a specified custom filename in ${DL_DIR}

Exmaple:
SRC_URI = "https://edc.intel.com/Download.aspx?id=6190;downloadfilename=LIN_IEMGD_1_14_GOLD_2443.tgz"

Quoted 7 lines

This fixes bug:
[YOCTO #2570]

Signed-off-by Nitin A Kamble <[email protected]>
---
 bitbake/lib/bb/fetch2/wget.py |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

Merged to master, thanks.

Richard

#3 lore raw

Re: [PATCH 0/1] V2 add downloadfilename to wget fetcher

In reply to [email protected]

This should go to the [email protected]

Sau!

Quoted 20 lines · On 07/18/2012 11:21 AM, [email protected] wrote:

From: Nitin A Kamble <[email protected]>

In this V2 commit, not required changes from __init__.py are removed. Thanks,
Nitin

The following changes since commit 5b014eae151a1584df4e3d3b96d18f9df3e55665:

fix my typos in patch headers (2012-07-16 21:45:01 -0700)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib nitin/misc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/misc

Nitin A Kamble (1):
bitbake wget fetcher: add parameter: downloadfilename

  bitbake/lib/bb/fetch2/wget.py |    9 ++++++++-
  1 files changed, 8 insertions(+), 1 deletions(-)