wimax: fix printk format warnings
Subsystems (2)
PATCH 1/1 wimax: fix printk format warnings
From: Randy Dunlap <[email protected]>
Fix printk format warnings in drivers/net/wimax/i2400m:
drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat] drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'ssize_t' [-Wformat] drivers/net/wimax/i2400m/usb-fw.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat]
I don't see these warnings on x86. The warnings that are quoted above are from Geert's kernel build reports.
--- drivers/net/wimax/i2400m/control.c | 4 ++-- drivers/net/wimax/i2400m/usb-fw.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/wimax/i2400m/control.c +2 -2
@@ -130,7 +130,7 @@ ssize_t i2400m_tlv_match(const struct i2 && le16_to_cpu(tlv->length) + sizeof(*tlv) != tlv_size) {size_t size =le16_to_cpu (tlv->length) +sizeof (*tlv);printk (KERN_WARNING "W: tlv type 0x%x mismatched because of " -"size (got %zu vs %zu expected)\n" , +"size (got %zu vs %zd expected)\n" , tlv_type, size, tlv_size);return size; }
@@ -235,7 +235,7 @@ const struct i2400m_tlv_hdr *i2400m_tlv_break ;if (match >0 )dev_warn (dev,"TLV type 0x%04x found with size " -"mismatch (%zu vs %zu needed)\n" , +"mismatch (%zu vs %zd needed)\n" , tlv_type, match, tlv_size); }return tlv;
drivers/net/wimax/i2400m/usb-fw.c +1 -1
@@ -212,7 +212,7 @@ ssize_t i2400mu_bus_bm_cmd_send(struct i }if (result != cmd_size) {/* all was transferred? */ dev_err (dev,"boot-mode cmd %d: incomplete transfer " -"(%zu vs %zu submitted)\n" , opcode, result, cmd_size); +"(%zd vs %zu submitted)\n" , opcode, result, cmd_size); result = -EIO ; goto error_cmd_size; }
Quoted 8 lines · Randy Dunlap
Fix printk format warnings in
drivers/net/wimax/i2400m:
drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat]drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'ssize_t' [-Wformat]drivers/net/wimax/i2400m/usb-fw.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat]I don't see these warnings on x86. The warnings that are quoted above are from Geert's kernel build reports.
Yeah, while technically they are correct (size_t and ssize_t differ in signedness),
they only happen for cris, which has different base types for (s)size_t (size_t = unsigned int, ssize_t = long), which is actually incorrect. Still on my list of things to fix...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Randy Dunlap <[email protected]>
Date: Sat, 21 Jul 2012 13:54:35 -0700
Quoted 8 lines
From: Randy Dunlap <[email protected]>
Fix printk format warnings in
drivers/net/wimax/i2400m:
drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat]drivers/net/wimax/i2400m/control.c: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'ssize_t' [-Wformat]drivers/net/wimax/i2400m/usb-fw.c: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'ssize_t' [-Wformat]
Quoted 5 lines
I don't see these warnings on x86. The warnings that are quoted above are from Geert's kernel build reports.
Signed-off-by Randy Dunlap <[email protected]>Reported-by Geert Uytterhoeven <[email protected]>
Applied, thanks Randy.