Skip to contentSkip to conversation

staging/iio: use module_platform_driver macro

PATCH Applied Devendra Naga 2 participants 2 messages Jul 21, 2012 – Jul 22, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging/iio: use module_platform_driver macro

the code which under _init and _exit does only the platform_driver_register and platform_driver_unregister, and nothing else,
so its better to use the module_platform_driver macro rather duplicating its implementation

---

 drivers/staging/iio/iio_hwmon.c |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/staging/iio/iio_hwmon.c +1 -11
index 27d27ec..4bb017a 100644
@@ -215,17 +215,7 @@ static struct platform_driver __refdata iio_hwmon_driver = {
 	.remove = __devexit_p(iio_hwmon_remove),
 };
 
-static int iio_inkern_init(void)
-{
-	return platform_driver_register(&iio_hwmon_driver);
-}
-module_init(iio_inkern_init);
-
-static void iio_inkern_exit(void)
-{
-	platform_driver_unregister(&iio_hwmon_driver);
-}
-module_exit(iio_inkern_exit);
+module_platform_driver(iio_hwmon_driver);
 
 MODULE_AUTHOR("Jonathan Cameron <[email protected]>");
 MODULE_DESCRIPTION("IIO to hwmon driver");
Signature · 1 line
1.7.9.5
maintainer Applied
#1 lore raw
Quoted 6 lines · Devendra Naga

the code which under _init and _exit does only the platform_driver_register and platform_driver_unregister, and nothing else,
so its better to use the module_platform_driver macro rather duplicating its implementation

Thanks.

Queued this up for when I resume sending pull requests to Greg post merge window.

Quoted 29 lines

---

 drivers/staging/iio/iio_hwmon.c |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/staging/iio/iio_hwmon.c +1 -11
index 27d27ec..4bb017a 100644
@@ -215,17 +215,7 @@ static struct platform_driver __refdata iio_hwmon_driver = {
 	.remove = __devexit_p(iio_hwmon_remove),
 };
 
-static int iio_inkern_init(void)
-{
-	return platform_driver_register(&iio_hwmon_driver);
-}
-module_init(iio_inkern_init);
-
-static void iio_inkern_exit(void)
-{
-	platform_driver_unregister(&iio_hwmon_driver);
-}
-module_exit(iio_inkern_exit);
+module_platform_driver(iio_hwmon_driver);
 
 MODULE_AUTHOR("Jonathan Cameron <[email protected]>");
 MODULE_DESCRIPTION("IIO to hwmon driver");