quota 4.00: add DEPENDS gettext-native
cover quota 4.00: add DEPENDS gettext-native
From: Jackie Huang <[email protected]>
do_install needs command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.
[YOCTO #2811]
---
The following changes since commit da1de01aa74da0f38f07af523a9861824f7b0c95:
Pyphon-native: Fix typo (2012-07-22 14:20:26 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/defect2811_quota_msgfmt
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/defect2811_quota_msgfmt
Jackie Huang (1):
quota 4.00: add DEPENDS gettext-native
meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4
PATCH 1/1 quota 4.00: add DEPENDS gettext-native
From: Jackie Huang <[email protected]>
do_install needs command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.
[YOCTO #2811]
--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
meta/recipes-extended/quota/quota_4.00.bb +2 -0
@@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f S = "${WORKDIR}/quota-tools" +DEPENDS = "gettext-native" + inherit autotools EXTRA_OEMAKE += 'STRIP=""'
Signature · 1 line
1.7.4
Quoted 17 lines · On Mon, 2012-07-23 at 16:38 +0800, [email protected] wrote:
From: Jackie Huang <[email protected]>
do_installneeds command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.[YOCTO #2811]
Signed-off-by Jackie Huang <[email protected]>--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)meta/recipes-extended/quota/quota_4.00.bb +0
-0
meta/recipes-extended/quota/quota_4.00.bb SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f · line 22
Quoted 8 lines
meta/recipes-extended/quota/quota_4.00.bb +2
-0@@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f S = "${WORKDIR}/quota-tools" +DEPENDS = "gettext-native" + inherit autotools EXTRA_OEMAKE += 'STRIP=""'
Shouldn't this be "inherit gettext" ?
Cheers,
Richard
Quoted 21 lines · Richard Purdie
Quoted 20 lines · On Mon, 2012-07-23 at 16:38 +0800, [email protected] wrote:
From: Jackie Huang<[email protected]>
do_installneeds command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.[YOCTO #2811]
Signed-off-by Jackie Huang<[email protected]>--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)meta/recipes-extended/quota/quota_4.00.bb +0
-0@@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f S = "${WORKDIR}/quota-tools"
Quoted 7 lines
meta/recipes-extended/quota/quota_4.00.bb SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f · line 22
Quoted 5 lines
meta/recipes-extended/quota/quota_4.00.bb +2
-0+DEPENDS = "gettext-native" + inherit autotools EXTRA_OEMAKE += 'STRIP=""'Shouldn't this be "inherit gettext" ?
No, quota doesn't depend on gettext at runtime, so I don't think we need 'inherit gettext'.
Thanks,
Jackie
Quoted 12 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745
Quoted 30 lines · On 7/24/2012 1:17 PM, jhuang0 wrote:
Quoted 27 lines · Richard Purdie
Quoted 26 lines · On Mon, 2012-07-23 at 16:38 +0800, [email protected] wrote:
From: Jackie Huang<[email protected]>
do_installneeds command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.[YOCTO #2811]
Signed-off-by Jackie Huang<[email protected]>--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)meta/recipes-extended/quota/quota_4.00.bb +0
-0@@ -15,6 +15,8 @@ SRC_URI[sha256sum] ="
eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51fS = "${WORKDIR}/quota-tools"meta/recipes-extended/quota/quota_4.00.bb +2
-0+DEPENDS = "gettext-native" + inherit autotools
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
EXTRA_OEMAKE+= 'STRIP=""'Shouldn't this be "inherit gettext" ?
No, quota doesn't depend on gettext at runtime, so I don't think we need 'inherit gettext'.
quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native?
Thanks,
Jackie
Quoted 17 lines
Thanks,
JackieQuoted 12 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745
Hello,
Kindly someone merge this patch. We are hitting this issue.
Regards,
Noor
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of jhuang0
Sent: Friday, August 24, 2012 8:18 AM
To: Patches and discussions about the oe-core layer
Cc: Zhao, Zhenfeng; Yang, Liezhi
Subject: Re: [OE-core] [PATCH 1/1] quota 4.00: add DEPENDS gettext-native
Quoted 30 lines · On 7/24/2012 1:17 PM, jhuang0 wrote:
Quoted 27 lines · Richard Purdie
Quoted 26 lines · On Mon, 2012-07-23 at 16:38 +0800, [email protected] wrote:
From: Jackie Huang<[email protected]>
do_installneeds command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.[YOCTO #2811]
Signed-off-by Jackie Huang<[email protected]>--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)meta/recipes-extended/quota/quota_4.00.bb +0
-0@@ -15,6 +15,8 @@ SRC_URI[sha256sum] ="
eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51fS = "${WORKDIR}/quota-tools"meta/recipes-extended/quota/quota_4.00.bb +2
-0+DEPENDS = "gettext-native" + inherit autotools
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
EXTRA_OEMAKE+= 'STRIP=""'Shouldn't this be "inherit gettext" ?
No, quota doesn't depend on gettext at runtime, so I don't think we need 'inherit gettext'.
quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native?
Thanks,
Jackie
Quoted 17 lines
Thanks,
JackieQuoted 12 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Jackie Huang
WIND RIVER | China Development Center
MSN:[email protected]
Tel: +86 8477 8594
Mobile: +86 138 1027 4745
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie
AppliedQuoted 11 lines · On Mon, 2012-07-23 at 16:38 +0800, [email protected] wrote:
From: Jackie Huang <[email protected]>
do_installneeds command 'msgfmt', it would fail if the command doesn't exist on the host, add DEPENDS gettext-native to fix this.[YOCTO #2811]
Signed-off-by Jackie Huang <[email protected]>--- meta/recipes-extended/quota/quota_4.00.bb | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Merged to master, thanks. Sorry for the delay on this on, the patch is the correct fix in this case (just a little unusual).
Cheers,
Richard