Check dmi version when get system uuid
PATCH 1/2 Check dmi version when get system uuid
As of version 2.6 of the SMBIOS specification, the first 3 fields of the UUID are supposed to be encoded on little-endian.
Also a minor fix to match variable meaning and mute checkpatch.pl
--- drivers/firmware/dmi_scan.c | 19 ++++++++++++++++--- 1 files changed, 16 insertions(+), 3 deletions(-)
drivers/firmware/dmi_scan.c +16 -3
@@ -15,6 +15,7 @@*/ static char dmi_empty_string[] =" " ; +static u16 __initdata dmi_ver;/* * Catch too early calls to dmi_check_system(): */
@@ -158,8 +159,10 @@ static void __init dmi_save_uuid(const struct dmi_header *dm, int slot, int indereturn ;for (i =0 ; i <16 && (is_ff || is_00); i++) { -if (d[i] !=0x00 ) is_ff =0 ; -if (d[i] !=0xFF ) is_00 =0 ; +if (d[i] !=0x00 ) + is_00 =0 ; +if (d[i] !=0xFF ) + is_ff =0 ; }if (is_ff || is_00)
@@ -169,7 +172,16 @@ static void __init dmi_save_uuid(const struct dmi_header *dm, int slot, int indeif (!s)return ; -sprintf (s,"%pUB" , d); +/* +* As of version 2.6 of the SMBIOS specification, the first 3 +* fields of the UUID are supposed to be encoded on little-endian. +* The specification says that this is the defacto standard, +* update kernel code to match dmidecode data. +*/ +if (dmi_ver >=0x0206 ) +sprintf (s,"%pUL" , d); +else +sprintf (s,"%pUB" , d); dmi_ident[slot] = s; }
@@ -411,6 +423,7 @@ static int __init dmi_present(const char __iomem *p)* DMI version 0.0 means that the real version is taken from * the SMBIOS version, which we don't know at this point. */ + dmi_ver = (buf[14 ] &0xf0 ) <<4 | (buf[14 ] &0x0f );if (buf[14 ] !=0 )printk (KERN_INFO "DMI %d.%d present.\n" , buf[14 ] >>4 , buf[14 ] &0xF );
Signature · 1 line
1.7.3
Quoted 5 lines · zhenzhong.duan
As of version 2.6 of the SMBIOS specification, the first 3 fields of the UUID are supposed to be encoded on little-endian.
Also a minor fix to match variable meaning and mute checkpatch.pl
I'm late to the party, as this patch went into 3.8, mimicking a patch sent in 2011:
https://lkml.org/lkml/2011/1/19/260
Only problem: it breaks the ABI. By changing the value of the DMI UUID previously sent by the kernel, any application relying on this UUID is likely to break with 3.8.
I don't know if I should be happy I finally can drop this patch from my tree, or sad that a different process let it through.
Regards,
Anisse