Skip to contentSkip to conversation

ASoC: ab8500: Remove pointless cast

PATCH In review Mark Brown 2 participants 2 messages Jul 26, 2012

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: ab8500: Remove pointless cast

There's never any need to cast away from void.

---
 sound/soc/codecs/ab8500-codec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ab8500-codec.c +1 -1
index 3c79592..05d70934 100644
@@ -2405,7 +2405,7 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
 	dev_dbg(dev, "%s: Enter.\n", __func__);
 
 	/* Setup AB8500 according to board-settings */
-	pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent);
+	pdata = dev_get_platdata(dev->parent);
 	status = ab8500_audio_setup_mics(codec, &pdata->codec->amics);
 	if (status < 0) {
 		pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Mark Brown

There's never any need to cast away from void.

---
  sound/soc/codecs/ab8500-codec.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ab8500-codec.c +0 -0
index 3c79592..05d70934 100644

sound/soc/codecs/ab8500-codec.c static int ab8500_codec_probe(struct snd_soc_codec *codec) · line 2411

Quoted 8 lines
sound/soc/codecs/ab8500-codec.c +1 -1
@@ -2405,7 +2405,7 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
  	dev_dbg(dev, "%s: Enter.\n", __func__);
 
  	/* Setup AB8500 according to board-settings */
-	pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent);
+	pdata = dev_get_platdata(dev->parent);
  	status = ab8500_audio_setup_mics(codec, &pdata->codec->amics);
  	if (status < 0) {
  		pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);

I think Ola needs to ACK this, but fwiw:

Signature · 8 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel