Skip to contentSkip to conversation

lib/oe/lsb: Add basic LSB functions

PATCH In review Richard Purdie 4 participants 7 messages Jul 26, 2012 – Jul 31, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/oe/lsb: Add basic LSB functions

This code was written by Christopher Larson <[email protected]> and allows generation of the LSB release data based upon the lsb_release command. It also includes a helper function to generate a string representing a given distribution.

---

meta/lib/oe/lsb.py renamed from dev/null +28 -0
new file mode 100644
index 0000000..a774169
@@ -0,0 +1,28 @@
+def release_dict():
+    """Return the output of lsb_release -a as a dictionary"""
+    from subprocess import PIPE
+
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
+
+    data = {}
+    for line in output.splitlines():
+        try:
+            key, value = line.split(":\t", 1)
+        except ValueError:
+            continue
+        else:
+            data[key] = value
+    return data
+
+def distro_identifier(adjust_hook=None):
+    """Return a distro identifier string based upon lsb_release -ri,
+       with optional adjustment via a hook"""
+
+    lsb_data = release_dict()
+    distro_id, release = lsb_data['Distributor ID'], lsb_data['Release']
+    if adjust_hook:
+        distro_id, release = adjust_hook(distro_id, release)
+    return '{0}-{1}'.format(distro_id, release)
#1 lore raw
Quoted 44 lines · Richard Purdie

This code was written by Christopher Larson <[email protected]> and allows generation of the LSB release data based upon the lsb_release command. It also includes a helper function to generate a string representing a given distribution.

---

meta/lib/oe/lsb.py renamed from dev/null +28 -0
new file mode 100644
index 0000000..a774169
@@ -0,0 +1,28 @@
+def release_dict():
+    """Return the output of lsb_release -a as a dictionary"""
+    from subprocess import PIPE
+
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
+
+    data = {}
+    for line in output.splitlines():
+        try:
+            key, value = line.split(":\t", 1)
+        except ValueError:
+            continue
+        else:
+            data[key] = value
+    return data
+
+def distro_identifier(adjust_hook=None):
+    """Return a distro identifier string based upon lsb_release -ri,
+       with optional adjustment via a hook"""
+
+    lsb_data = release_dict()
+    distro_id, release = lsb_data['Distributor ID'], lsb_data['Release']
+    if adjust_hook:
+        distro_id, release = adjust_hook(distro_id, release)
+    return '{0}-{1}'.format(distro_id, release)
Quoted 4 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

There is an unchecked error case here. I just had to fix this issue:

ERROR: Execution of event handler 'oe_import_eh' failed Traceback (most recent call last):
File "oe_import_eh(e)", line 4, in
oe_import_eh(e=<bb.event.ConfigParsed object at 0x3834f90>)
File "/mnt/yocto/poky.git/meta/lib/oe/lsb.py", line 25, in
distro_identifier(adjust_hook=None):
lsb_data = release_dict()
> distro_id, release = lsb_data['Distributor ID'],
lsb_data['Release']
if adjust_hook:
TypeError: 'NoneType' object has no attribute '__getitem__'

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

+ try:
+ output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+ except bb.process.CmdError as exc:
+ return

but it must be missing something.

Regards,
Jack

#2 lore raw
Quoted 76 lines · Jack Mitchell
Quoted 44 lines · Richard Purdie

This code was written by Christopher Larson <[email protected]> and allows generation of the LSB release data based upon the lsb_release command. It also includes a helper function to generate a string representing a given distribution.

---

meta/lib/oe/lsb.py renamed from dev/null +28 -0
new file mode 100644
index 0000000..a774169
@@ -0,0 +1,28 @@
+def release_dict():
+    """Return the output of lsb_release -a as a dictionary"""
+    from subprocess import PIPE
+
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
+
+    data = {}
+    for line in output.splitlines():
+        try:
+            key, value = line.split(":\t", 1)
+        except ValueError:
+            continue
+        else:
+            data[key] = value
+    return data
+
+def distro_identifier(adjust_hook=None):
+    """Return a distro identifier string based upon lsb_release -ri,
+       with optional adjustment via a hook"""
+
+    lsb_data = release_dict()
+    distro_id, release = lsb_data['Distributor ID'], lsb_data['Release']
+    if adjust_hook:
+        distro_id, release = adjust_hook(distro_id, release)
+    return '{0}-{1}'.format(distro_id, release)
Quoted 4 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

There is an unchecked error case here. I just had to fix this issue:

ERROR: Execution of event handler 'oe_import_eh' failed Traceback (most recent call last):

   File "oe_import_eh(e)", line 4, in 

oe_import_eh(e=<bb.event.ConfigParsed object at 0x3834f90>)
File "/mnt/yocto/poky.git/meta/lib/oe/lsb.py", line 25, in
distro_identifier(adjust_hook=None):
lsb_data = release_dict()
> distro_id, release = lsb_data['Distributor ID'],
lsb_data['Release']
if adjust_hook:
TypeError: 'NoneType' object has no attribute '__getitem__'

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

meta/lib/oe/lsb.py renamed from dev/null +4 -0
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
Quoted 1 line

but it must be missing something.

Same here, interesting is that it failed only during 2nd build, 1st with this commit applied finished fine.

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 11 lines · Martin Jansa
Quoted 11 lines

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

meta/lib/oe/lsb.py renamed from dev/null +4 -0
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
Quoted 4 lines
Quoted 1 line

but it must be missing something.

Same here, interesting is that it failed only during 2nd build, 1st with this commit applied finished fine.

Ah no, it was there also first time I've overlooked it as it's not fatal.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 12 lines · Martin Jansa
Quoted 11 lines · Martin Jansa
Quoted 11 lines

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

meta/lib/oe/lsb.py renamed from dev/null +4 -0
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

but it must be missing something.

Same here, interesting is that it failed only during 2nd build, 1st with this commit applied finished fine.

Ah no, it was there also first time I've overlooked it as it's not fatal.

It was fatal for me as it trashed my sstate folder naming and then refused to build some packages. The directory in my sstate was created as:

${NATIVELSBSTRING}

Then when Bitbake tried to use shared state it expanded NATIVELSBSTRING to nothing and failed.

#5 lore raw
Quoted 22 lines · Jack Mitchell
Quoted 12 lines · Martin Jansa
Quoted 11 lines · Martin Jansa
Quoted 11 lines

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

meta/lib/oe/lsb.py renamed from dev/null +4 -0
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

but it must be missing something.

Same here, interesting is that it failed only during 2nd build, 1st with this commit applied finished fine.

Ah no, it was there also first time I've overlooked it as it's not fatal.

Quoted 8 lines

It was fatal for me as it trashed my sstate folder naming and then refused to build some packages. The directory in my sstate was created as:

${NATIVELSBSTRING}

Then when Bitbake tried to use shared state it expanded NATIVELSBSTRING to nothing and failed.

I have the same issue here - Gentoo/64. Can we get it fixed in the master, please? Thanks.

Signature · 1 line
Denys
#6 lore raw
Quoted 27 lines · Denys Dmytriyenko
Quoted 26 lines · Jack Mitchell
Quoted 12 lines · Martin Jansa
Quoted 11 lines · Martin Jansa
Quoted 11 lines

by installing lsb_release. Archlinux 64.

Should it check to see if it installed first and error otherwise? It looks like it tries to do it here:

meta/lib/oe/lsb.py renamed from dev/null +4 -0
+    try:
+        output, err = bb.process.run(['lsb_release', '-a'], stderr=PIPE)
+    except bb.process.CmdError as exc:
+        return
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

but it must be missing something.

Same here, interesting is that it failed only during 2nd build, 1st with this commit applied finished fine.

Ah no, it was there also first time I've overlooked it as it's not fatal.

It was fatal for me as it trashed my sstate folder naming and then refused to build some packages. The directory in my sstate was created as:

Quoted 7 lines
Quoted 4 lines

${NATIVELSBSTRING}

Then when Bitbake tried to use shared state it expanded NATIVELSBSTRING to nothing and failed.

I have the same issue here - Gentoo/64. Can we get it fixed in the master, please? Thanks.

I've pushed something which should resolve the problem and at least set this to a known string ('Unknown').

Cheers,

Richard