x86,fs/resctrl telemetry monitoring
Subsystems (3)
Tony Luck
maintainerv13 cover x86,fs/resctrl telemetry monitoring
Patches based on v6.18-rc3
Series available here:git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git rdt-aet-v13
Changes since v12 was posted here:
My usual convention, patches from v11 named "XX/28", patches in this series when they have a different number as "00YY".
--- v12 00/31 x86,fs/resctrl telemetry monitoring --- No changes to "Background" section of cover letter.
--- v12 01/31 x86,fs/resctrl: Improve domain type checking --- Added Reinette RB tag
--- v12 02/31 x86/resctrl: Move L3 initialization into new helper --- No change
--- v12 03/31 x86/resctrl: Refactor domain_remove_cpu_mon() ready --- Added Reinette RB tag
--- v12 04/31 x86/resctrl: Clean up domain_remove_cpu_ctrl() --- No change
--- v12 05/31 x86,fs/resctrl: Refactor domain create/remove using --- Move (keep) lockdep_assert_cpus_held() at start of mon_event_read() Defer SNC change (summing cache-sharing domains) in rdtgroup_mondata_show() to later patch.
--- v12 06/31 x86,fs/resctrl: Use struct rdt_domain_hdr when --- New 0006 (pulled in __mon_event_count() refactor from old 18/31) Set rr->err when returning an error from __mon_event_count() for bad r->rid.
0007 (was 06/31)
Rewrite commit message including "telemetry events" -> "monitoring events" Drop change to resctrl_arch_cntr_read()
Set rr->err when returning an error from __mon_event_count() for invalid domain header.
--- v12 07/31 x86,fs/resctrl: Rename struct rdt_mon_domain and ---
0008 Drop RB tag because of fir order issues introduced in v11
Fix fir order issues.
--- v12 08/31 x86,fs/resctrl: Rename some L3 specific functions ---
0009 Update kerneldoc "Return" fixes to match existing style.
Use imperative in commit message note about kerneldoc changes.
--- v12 09/31 fs/resctrl: Make event details accessible to ---
0010 No change
--- v12 10/31 x86,fs/resctrl: Handle events that can be read from ---
0011 Dropped cpu_on_correct_domain(). The refactor of __mon_event_count()
in patch 0006 means it is no longer needed. The cpu checks in __l3_mon_event_count() continue to work without change.
--- v12 11/31 x86,fs/resctrl: Support binary fixed point event ---
0012 No change
--- v12 12/31 x86,fs/resctrl: Add an architectural hook called ---
0013 No change
--- v12 13/31 x86,fs/resctrl: Add and initialize rdt_resource for --- Split
0014 Parts of 13/31 related to new resource. Dropped Reinette RB tag.
0015 SNC L3 checks and kerneldoc changes.
--- v12 14/31 x86/resctrl: Discover hardware telemetry events ---
0016 Major rewrite on the commit messge.
Simplified the code to keep just one array of known event groups. Don't "return false" for failed intel_pmt_get_regions_by_feature() just continue to check other event_groups.
--- v12 15/31 x86,fs/resctrl: Fill in details of events for guid ---
0017 Clarify pmt_feature_group and event_group in commit message.
--- v12 16/31 x86,fs/resctrl: Add architectural event pointer --- 0018 Rebased and added Reinette RB tag.
--- v12 17/31 x86/resctrl: Find and enable usable telemetry ---
0019 Re-write commit to match current design.
Move open coded check for usable regions to group_has_usable_regions() helper.
--- v12 18/31 fs/resctrl: Split L3 dependent parts out of --- Pulled forward in series. Is now patch 0006.
--- v12 19/31 x86/resctrl: Read telemetry events ---
0020 Declare "tval" inside "case RDT_RESOURCE_PERF_PKG".
Make intel_aet_read_event() sum to a local variable and assign to *val on success.
Delete irrelevant paragraphs from commit comment. Update to say that when none of the aggregators have valid data the use will see "Unavailable".
--- v12 20/31 fs/resctrl: Refactor mkdir_mondata_subdir() ---
0021 Drop do_sum argument from mon_add_all_files(). Can infer from
whether hdr argument is NULL.
Rename mon_add_all_files() to _mkdir_mondata_subdir() and have it make the directory and fix user/group id to avoid code duplication at each call site.
Pass explicit NULL for hdr argument to _mkdir_mondata_subdir() when creating files in top-level mon_L3_XX directory. Add check for r->rid == RDT_RESOURCE_L3 to mkdir_mondata_subdir() Fix commit comment to avoid code reference and just describe the problem.
--- v12 21/31 fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp() ---
0022: Move and reword comment about SNC sum directories to the new
refactored function. Add check for r->rid == RDT_RESOURCE_L3 to rmdir_mondata_subdir_allrdtgrp() Fix commit comment as suggested.
--- v12 22/31 x86,fs/resctrl: Handle domain creation/deletion for ---
0023: Added Reinette RB tag
--- v12 23/31 x86/resctrl: Add energy/perf choices to rdt boot ---
0024: Added Reinette RB tag
--- v12 24/31 x86/resctrl: Handle number of RMIDs supported by ---
0025: Replace "Limit an event group's number ..." paragraph in commit
message with suggested alternative.
Drop description of code ("Print r->num_rmid ...") New all_regions_have_sufficient_rmid() that builds on assumption that groups with no regions were weeded out in changes to patch 17/31 (now 0019).
--- v12 25/31 fs/resctrl: Move allocation/free of ---
0026: Drop rdtgroup_mutex before error return in closid_num_dirty_rmid_alloc()
--- v12 26/31 x86,fs/resctrl: Compute number of RMIDs as minimum ---
0027: No change
--- v12 27/31 fs/resctrl: Move RMID initialization to first mount ---
0028: "may likely need" -> "needs"
Added Reinette RB tag.
--- v12 28/31 x86/resctrl: Enable RDT_RESOURCE_PERF_PKG ---
0029: Add to commit message that a console log is added.
--- v12 29/31 fs/resctrl: Provide interface to create ---
0030: Added Reinette RB tag.
--- v12 30/31 x86/resctrl: Add debugfs files to show telemetry ---
0031: Dropped spurious blank line from intel_aet_add_debugfs()
Update to use new for_each_event_group() macro. Added Reinette RB tag.
--- v12 31/31 x86,fs/resctrl: Update documentation for telemetry ---
0032: "if the number of RMIDs supported is lower than the number of RMIDs
supported by the system" -> "if the number of RMIDs supported for that type is lower than the number of RMIDs supported by hardware for L3 monitoring events" "this will reduce" -> "this may reduce" "the current RMID" -> "for the current monitoring group"
Background
----------
On Intel systems that support per-RMID telemetry monitoring each logical processor keeps a local count for various events. When the MSR_IA32_PQR_ASSOC.RMID value for the logical processor changes (or when a two millisecond counter expires) these event counts are transmitted to an event aggregator on the same package as the processor together with the current RMID value. The event counters are reset to zero to begin counting again.
Each aggregator takes the incoming event counts and adds them to cumulative counts for each event for each RMID. Note that there can be multiple aggregators on each package with no architectural association between logical processors and an aggregator.
All of these aggregated counters can be read by an operating system from the MMIO space of the Out Of Band Management Service Module (OOBMSM) device(s) on a system. Any counter can be read from any logical processor.
Intel publishes details for each processor generation showing which events are counted by each logical processor and the offsets for each accumulated counter value within the MMIO space in XML files here:
https://github.com/intel/Intel-PMT.
For example there are two energy related telemetry events for the Clearwater Forest family of processors and the MMIO space looks like this:
Offset RMID Event ------ ---- ----- 0x0000 0 core_energy 0x0008 0 activity 0x0010 1 core_energy 0x0018 1 activity ... 0x23F0 575 core_energy 0x23F8 575 activity
In addition the XML file provides the units (Joules for core_energy, Farads for activity) and the type of data (fixed-point binary with bit 63 used to indicate the data is valid, and the low 18 bits as a binary fraction).
Finally, each XML file provides a 32-bit unique id (or guid) that is used as an index to find the correct XML description file for each telemetry implementation.
The INTEL_PMT_TELEMETRY driver provides intel_pmt_get_regions_by_feature() to enumerate the aggregator instances (also referred to as "telemetry regions" in this series) on a platform. It provides:
1) guid - so resctrl can determine which events are supported
2) MMIO base address of counters
3) package id
Resctrl accumulates counts from all aggregators on a package in order to provide a consistent user interface across processor generations.
Directory structure for the telemetry events looks like this:
$ tree /sys/fs/resctrl/mon_data/
/sys/fs/resctrl/mon_data/
mon_data
├── mon_PERF_PKG_00
│ ├── activity
│ └── core_energy
└── mon_PERF_PKG_01
├── activity
└── core_energyReading the "core_energy" file from some resctrl mon_data directory shows the cumulative energy (in Joules) used by all tasks that ran with the RMID associated with that directory on a given package. Note that "core_energy" reports only energy consumed by CPU cores (data processing units, L1/L2 caches, etc.). It does not include energy used in the "uncore" (L3 cache, on package devices, etc.), or used by memory or I/O devices.
Tony Luck (32):
x86,fs/resctrl: Improve domain type checking x86/resctrl: Move L3 initialization into new helper function x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain
types
x86/resctrl: Clean up domain_remove_cpu_ctrl() x86,fs/resctrl: Refactor domain create/remove using struct
rdt_domain_hdr
fs/resctrl: Split L3 dependent parts out of __mon_event_count() x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain x86,fs/resctrl: Rename some L3 specific functions fs/resctrl: Make event details accessible to functions when reading
events
x86,fs/resctrl: Handle events that can be read from any CPU x86,fs/resctrl: Support binary fixed point event counters x86,fs/resctrl: Add an architectural hook called for each mount x86,fs/resctrl: Add and initialize rdt_resource for package scope
monitor
fs/resctrl: Cleanup as L3 is no longer the only monitor resource x86/resctrl: Discover hardware telemetry events x86,fs/resctrl: Fill in details of events for guid 0x26696143 and
0x26557651
x86,fs/resctrl: Add architectural event pointer x86/resctrl: Find and enable usable telemetry events x86/resctrl: Read telemetry events
fs/resctrl: Refactor mkdir_mondata_subdir()
fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp() x86,fs/resctrl: Handle domain creation/deletion for
RDT_RESOURCE_PERF_PKG
x86/resctrl: Add energy/perf choices to rdt boot option x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG fs/resctrl: Move allocation/free of closid_num_dirty_rmid[] x86,fs/resctrl: Compute number of RMIDs as minimum across resources fs/resctrl: Move RMID initialization to first mount x86/resctrl: Enable RDT_RESOURCE_PERF_PKG
fs/resctrl: Provide interface to create architecture specific debugfs
area
x86/resctrl: Add debugfs files to show telemetry aggregator status x86,fs/resctrl: Update documentation for telemetry events
.../admin-guide/kernel-parameters.txt | 2 +- Documentation/filesystems/resctrl.rst | 102 ++++- include/linux/resctrl.h | 67 ++- include/linux/resctrl_types.h | 11 + arch/x86/kernel/cpu/resctrl/internal.h | 52 ++- fs/resctrl/internal.h | 68 ++- arch/x86/kernel/cpu/resctrl/core.c | 275 ++++++++---- arch/x86/kernel/cpu/resctrl/intel_aet.c | 417 ++++++++++++++++++ arch/x86/kernel/cpu/resctrl/monitor.c | 50 ++- fs/resctrl/ctrlmondata.c | 123 +++++- fs/resctrl/monitor.c | 321 +++++++++----- fs/resctrl/rdtgroup.c | 293 ++++++++---- arch/x86/Kconfig | 13 + arch/x86/kernel/cpu/resctrl/Makefile | 1 + 14 files changed, 1409 insertions(+), 386 deletions(-) create mode 100644 arch/x86/kernel/cpu/resctrl/intel_aet.c
base-commit: dcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 1/32 x86,fs/resctrl: Improve domain type checking
Every resctrl resource has a list of domain structures. struct rdt_ctrl_domain and struct rdt_mon_domain both begin with struct rdt_domain_hdr with rdt_domain_hdr::type used in validity checks before accessing the domain of a particular type.
Add the resource id to struct rdt_domain_hdr in preparation for a new monitoring domain structure that will be associated with a new monitoring resource. Improve existing domain validity checks with a new helper domain_header_is_valid() that checks both domain type and resource id. domain_header_is_valid() should be used before every call to container_of() that accesses a domain structure.
--- include/linux/resctrl.h | 9 +++++++++ arch/x86/kernel/cpu/resctrl/core.c | 10 ++++++---- fs/resctrl/ctrlmondata.c | 2 +- 3 files changed, 16 insertions(+), 5 deletions(-)
include/linux/resctrl.h +9 -0
@@ -131,15 +131,24 @@ enum resctrl_domain_type {* @list: all instances of this resource * @id: unique id for this instance * @type: type of this instance +* @rid: resource id for this instance * @cpu_mask: which CPUs share this resource */ struct rdt_domain_hdr {struct list_head list;int id;enum resctrl_domain_type type; +enum resctrl_res_level rid;struct cpumask cpu_mask; }; +static inline bool domain_header_is_valid (struct rdt_domain_hdr *hdr, +enum resctrl_domain_type type, +enum resctrl_res_level rid) +{ +return !WARN_ON_ONCE (hdr->type != type || hdr->rid != rid); +} +/** * struct rdt_ctrl_domain - group of CPUs sharing a resctrl control resource * @hdr: common header for different domain types
arch/x86/kernel/cpu/resctrl/core.c +6 -4
@@ -459,7 +459,7 @@ static void domain_add_cpu_ctrl(int cpu, struct rdt_resource *r) hdr =resctrl_find_domain (&r->ctrl_domains, id, &add_pos);if (hdr) { -if (WARN_ON_ONCE (hdr->type !=RESCTRL_CTRL_DOMAIN )) +if (!domain_header_is_valid (hdr,RESCTRL_CTRL_DOMAIN , r->rid))return ; d = container_of(hdr, struct rdt_ctrl_domain, hdr);
@@ -476,6 +476,7 @@ static void domain_add_cpu_ctrl(int cpu, struct rdt_resource *r) d = &hw_dom->d_resctrl; d->hdr.id = id; d->hdr.type =RESCTRL_CTRL_DOMAIN ; + d->hdr.rid = r->rid;cpumask_set_cpu (cpu, &d->hdr.cpu_mask);rdt_domain_reconfigure_cdp (r);
@@ -515,7 +516,7 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) hdr =resctrl_find_domain (&r->mon_domains, id, &add_pos);if (hdr) { -if (WARN_ON_ONCE (hdr->type !=RESCTRL_MON_DOMAIN )) +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , r->rid))return ; d = container_of(hdr, struct rdt_mon_domain, hdr);
@@ -533,6 +534,7 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) d = &hw_dom->d_resctrl; d->hdr.id = id; d->hdr.type =RESCTRL_MON_DOMAIN ; + d->hdr.rid = r->rid; ci =get_cpu_cacheinfo_level (cpu,RESCTRL_L3_CACHE );if (!ci) {pr_warn_once ("Can't find L3 cache for CPU:%d resource %s\n" , cpu, r->name);
@@ -593,7 +595,7 @@ static void domain_remove_cpu_ctrl(int cpu, struct rdt_resource *r)return ; } -if (WARN_ON_ONCE (hdr->type !=RESCTRL_CTRL_DOMAIN )) +if (!domain_header_is_valid (hdr,RESCTRL_CTRL_DOMAIN , r->rid))return ; d = container_of(hdr, struct rdt_ctrl_domain, hdr);
@@ -639,7 +641,7 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)return ; } -if (WARN_ON_ONCE (hdr->type !=RESCTRL_MON_DOMAIN )) +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , r->rid))return ; d = container_of(hdr, struct rdt_mon_domain, hdr);
fs/resctrl/ctrlmondata.c +1 -1
@@ -649,7 +649,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)* the resource to find the domain with "domid". */ hdr =resctrl_find_domain (&r->mon_domains, domid,NULL ); -if (!hdr ||WARN_ON_ONCE (hdr->type !=RESCTRL_MON_DOMAIN )) { +if (!hdr || !domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , resid)) { ret = -ENOENT ; goto out; }
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 2/32 x86/resctrl: Move L3 initialization into new helper function
In reply to Tony LuckCarve out the resource monitoring domain init code into a separate helper in order to be able to initialize new types of monitoring domains besides the usual L3 ones.
--- arch/x86/kernel/cpu/resctrl/core.c | 64 ++++++++++++++++-------------- 1 file changed, 34 insertions(+), 30 deletions(-)
arch/x86/kernel/cpu/resctrl/core.c +34 -30
@@ -496,37 +496,13 @@ static void domain_add_cpu_ctrl(int cpu, struct rdt_resource *r) } } -static void domain_add_cpu_mon (int cpu,struct rdt_resource *r) +static void l3_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { -int id =get_domain_id_from_scope (cpu, r->mon_scope); -struct list_head *add_pos =NULL ;struct rdt_hw_mon_domain *hw_dom; -struct rdt_domain_hdr *hdr;struct rdt_mon_domain *d;struct cacheinfo *ci;int err; -lockdep_assert_held (&domain_list_lock); - -if (id <0 ) { -pr_warn_once ("Can't find monitor domain id for CPU:%d scope:%d for resource %s\n" , - cpu, r->mon_scope, r->name); -return ; - } - - hdr =resctrl_find_domain (&r->mon_domains, id, &add_pos); -if (hdr) { -if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , r->rid)) -return ; - d = container_of(hdr, struct rdt_mon_domain, hdr); - -cpumask_set_cpu (cpu, &d->hdr.cpu_mask); -/* Update the mbm_assign_mode state for the CPU if supported */ -if (r->mon.mbm_cntr_assignable) -resctrl_arch_mbm_cntr_assign_set_one (r); -return ; - } - hw_dom =kzalloc_node (sizeof (*hw_dom),GFP_KERNEL ,cpu_to_node (cpu));if (!hw_dom)return ;
@@ -534,7 +510,7 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) d = &hw_dom->d_resctrl; d->hdr.id = id; d->hdr.type =RESCTRL_MON_DOMAIN ; - d->hdr.rid = r->rid; + d->hdr.rid =RDT_RESOURCE_L3 ; ci =get_cpu_cacheinfo_level (cpu,RESCTRL_L3_CACHE );if (!ci) {pr_warn_once ("Can't find L3 cache for CPU:%d resource %s\n" , cpu, r->name);
@@ -544,10 +520,6 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) d->ci_id = ci->id;cpumask_set_cpu (cpu, &d->hdr.cpu_mask); -/* Update the mbm_assign_mode state for the CPU if supported */ -if (r->mon.mbm_cntr_assignable) -resctrl_arch_mbm_cntr_assign_set_one (r); -arch_mon_domain_online (r, d);if (arch_domain_mbm_alloc (r->mon.num_rmid, hw_dom)) {
@@ -565,6 +537,38 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r) } } +static void domain_add_cpu_mon (int cpu,struct rdt_resource *r) +{ +int id =get_domain_id_from_scope (cpu, r->mon_scope); +struct list_head *add_pos =NULL ; +struct rdt_domain_hdr *hdr; + +lockdep_assert_held (&domain_list_lock); + +if (id <0 ) { +pr_warn_once ("Can't find monitor domain id for CPU:%d scope:%d for resource %s\n" , + cpu, r->mon_scope, r->name); +return ; + } + + hdr =resctrl_find_domain (&r->mon_domains, id, &add_pos); +if (hdr) +cpumask_set_cpu (cpu, &hdr->cpu_mask); + +switch (r->rid) { +case RDT_RESOURCE_L3 : +/* Update the mbm_assign_mode state for the CPU if supported */ +if (r->mon.mbm_cntr_assignable) +resctrl_arch_mbm_cntr_assign_set_one (r); +if (!hdr) +l3_mon_domain_setup (cpu, id, r, add_pos); +break ; +default : +pr_warn_once ("Unknown resource rid=%d\n" , r->rid); +break ; + } +} +static void domain_add_cpu (int cpu,struct rdt_resource *r) {if (r->alloc_capable)
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 3/32 x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain types
In reply to Tony LuckNew telemetry events will be associated with a new package scoped resource with new domain structures.
Refactor domain_remove_cpu_mon() so all the L3 domain processing is separate from general domain actions of clearing the CPU bit in the mask.
--- arch/x86/kernel/cpu/resctrl/core.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-)
arch/x86/kernel/cpu/resctrl/core.c +17 -10
@@ -626,9 +626,7 @@ static void domain_remove_cpu_ctrl(int cpu, struct rdt_resource *r)static void domain_remove_cpu_mon (int cpu,struct rdt_resource *r) {int id =get_domain_id_from_scope (cpu, r->mon_scope); -struct rdt_hw_mon_domain *hw_dom;struct rdt_domain_hdr *hdr; -struct rdt_mon_domain *d;lockdep_assert_held (&domain_list_lock);
@@ -645,20 +643,29 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)return ; } -if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , r->rid)) +cpumask_clear_cpu (cpu, &hdr->cpu_mask); +if (!cpumask_empty (&hdr->cpu_mask))return ; - d = container_of(hdr, struct rdt_mon_domain, hdr); - hw_dom =resctrl_to_arch_mon_dom (d); +switch (r->rid) { +case RDT_RESOURCE_L3 : { +struct rdt_hw_mon_domain *hw_dom; +struct rdt_mon_domain *d; -cpumask_clear_cpu (cpu, &d->hdr.cpu_mask); -if (cpumask_empty (&d->hdr.cpu_mask)) { +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) +return ; + + d = container_of(hdr, struct rdt_mon_domain, hdr); + hw_dom =resctrl_to_arch_mon_dom (d);resctrl_offline_mon_domain (r, d); -list_del_rcu (&d->hdr.list); +list_del_rcu (&hdr->list);synchronize_rcu ();mon_domain_free (hw_dom); - -return ; +break ; + } +default : +pr_warn_once ("Unknown resource rid=%d\n" , r->rid); +break ; } }
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 4/32 x86/resctrl: Clean up domain_remove_cpu_ctrl()
In reply to Tony LuckFor symmetry with domain_remove_cpu_mon() refactor domain_remove_cpu_ctrl() to take an early return when removing a CPU does not empty the domain.
--- arch/x86/kernel/cpu/resctrl/core.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-)
arch/x86/kernel/cpu/resctrl/core.c +14 -15
@@ -599,28 +599,27 @@ static void domain_remove_cpu_ctrl(int cpu, struct rdt_resource *r)return ; } +cpumask_clear_cpu (cpu, &hdr->cpu_mask); +if (!cpumask_empty (&hdr->cpu_mask)) +return ; +if (!domain_header_is_valid (hdr,RESCTRL_CTRL_DOMAIN , r->rid))return ; d = container_of(hdr, struct rdt_ctrl_domain, hdr); hw_dom =resctrl_to_arch_ctrl_dom (d); -cpumask_clear_cpu (cpu, &d->hdr.cpu_mask); -if (cpumask_empty (&d->hdr.cpu_mask)) { -resctrl_offline_ctrl_domain (r, d); -list_del_rcu (&d->hdr.list); -synchronize_rcu (); - -/* -* rdt_ctrl_domain "d" is going to be freed below, so clear -* its pointer from pseudo_lock_region struct. -*/ -if (d->plr) - d->plr->d =NULL ; -ctrl_domain_free (hw_dom); +resctrl_offline_ctrl_domain (r, d); +list_del_rcu (&hdr->list); +synchronize_rcu (); -return ; - } +/* +* rdt_ctrl_domain "d" is going to be freed below, so clear +* its pointer from pseudo_lock_region struct. +*/ +if (d->plr) + d->plr->d =NULL ; +ctrl_domain_free (hw_dom); }static void domain_remove_cpu_mon (int cpu,struct rdt_resource *r)
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 5/32 x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain_hdr
In reply to Tony LuckUp until now, all monitoring events were associated with the L3 resource and it made sense to use the L3 specific "struct rdt_mon_domain *" argument to functions operating on domains.
Telemetry events will be tied to a new resource with its instances represented by a new domain structure that, just like struct rdt_mon_domain, starts with the generic struct rdt_domain_hdr.
Prepare to support domains belonging to different resources by changing the calling convention of functions operating on domains. Pass the generic header and use that to find the domain specific structure where needed.
--- include/linux/resctrl.h | 4 +- fs/resctrl/internal.h | 2 +- arch/x86/kernel/cpu/resctrl/core.c | 4 +- fs/resctrl/ctrlmondata.c | 14 +++++-- fs/resctrl/rdtgroup.c | 65 +++++++++++++++++++++--------- 5 files changed, 61 insertions(+), 28 deletions(-)
include/linux/resctrl.h +2 -2
@@ -504,9 +504,9 @@ int resctrl_arch_update_one(struct rdt_resource *r, struct rdt_ctrl_domain *d,u32 resctrl_arch_get_config (struct rdt_resource *r,struct rdt_ctrl_domain *d,u32 closid,enum resctrl_conf_type type);int resctrl_online_ctrl_domain (struct rdt_resource *r,struct rdt_ctrl_domain *d); -int resctrl_online_mon_domain (struct rdt_resource *r,struct rdt_mon_domain *d); +int resctrl_online_mon_domain (struct rdt_resource *r,struct rdt_domain_hdr *hdr);void resctrl_offline_ctrl_domain (struct rdt_resource *r,struct rdt_ctrl_domain *d); -void resctrl_offline_mon_domain (struct rdt_resource *r,struct rdt_mon_domain *d); +void resctrl_offline_mon_domain (struct rdt_resource *r,struct rdt_domain_hdr *hdr);void resctrl_online_cpu (unsigned int cpu);void resctrl_offline_cpu (unsigned int cpu);
fs/resctrl/internal.h +1 -1
@@ -362,7 +362,7 @@ void mon_event_count(void *info);int rdtgroup_mondata_show (struct seq_file *m,void *arg);void mon_event_read (struct rmid_read *rr,struct rdt_resource *r, -struct rdt_mon_domain *d,struct rdtgroup *rdtgrp, +struct rdt_domain_hdr *hdr,struct rdtgroup *rdtgrp,cpumask_t *cpumask,int evtid,int first);int resctrl_mon_resource_init (void );
arch/x86/kernel/cpu/resctrl/core.c +2 -2
@@ -529,7 +529,7 @@ static void l3_mon_domain_setup(int cpu, int id, struct rdt_resource *r, structlist_add_tail_rcu (&d->hdr.list, add_pos); - err =resctrl_online_mon_domain (r, d); + err =resctrl_online_mon_domain (r, &d->hdr);if (err) {list_del_rcu (&d->hdr.list);synchronize_rcu ();
@@ -656,7 +656,7 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r) d = container_of(hdr, struct rdt_mon_domain, hdr); hw_dom =resctrl_to_arch_mon_dom (d); -resctrl_offline_mon_domain (r, d); +resctrl_offline_mon_domain (r, hdr);list_del_rcu (&hdr->list);synchronize_rcu ();mon_domain_free (hw_dom);
fs/resctrl/ctrlmondata.c +10 -4
@@ -547,14 +547,21 @@ struct rdt_domain_hdr *resctrl_find_domain(struct list_head *h, int id, }void mon_event_read (struct rmid_read *rr,struct rdt_resource *r, -struct rdt_mon_domain *d,struct rdtgroup *rdtgrp, +struct rdt_domain_hdr *hdr,struct rdtgroup *rdtgrp,cpumask_t *cpumask,int evtid,int first) { +struct rdt_mon_domain *d =NULL ;int cpu;/* When picking a CPU from cpu_mask, ensure it can't race with cpuhp */ lockdep_assert_cpus_held (); +if (hdr) { +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) +return ; + d = container_of(hdr, struct rdt_mon_domain, hdr); + } +/* * Setup the parameters to pass to mon_event_count() to read the data. */
@@ -649,12 +656,11 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)* the resource to find the domain with "domid". */ hdr =resctrl_find_domain (&r->mon_domains, domid,NULL ); -if (!hdr || !domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN , resid)) { +if (!hdr) { ret = -ENOENT ; goto out; } - d = container_of(hdr, struct rdt_mon_domain, hdr); -mon_event_read (&rr, r, d, rdtgrp, &d->hdr.cpu_mask, evtid, false); +mon_event_read (&rr, r, hdr, rdtgrp, &hdr->cpu_mask, evtid, false); } checkresult:
fs/resctrl/rdtgroup.c +46 -19
192 lines not on this page · raw message
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 05/32] x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain_hdr
Hi Tony,
Quoted 13 lines · Tony Luck
fs/resctrl/rdtgroup.c +2
-1@@ -3164,13 +3164,18 @@ static void mon_rmdir_one_subdir(struct kernfs_node *pkn, char *name, char *subn* when last domain being summed is removed. */ static void rmdir_mondata_subdir_allrdtgrp (struct rdt_resource *r, -struct rdt_mon_domain *d) +struct rdt_domain_hdr *hdr) {struct rdtgroup *prgrp, *crgrp; +struct rdt_mon_domain *d;
fs/resctrl/rdtgroup.c static void mon_rmdir_one_subdir(struct kernfs_node *pkn, char *name, char *subn · line 3180
Quoted 10 lines
fs/resctrl/rdtgroup.c +4
-0char subname[32 ];bool snc_mode;char name[32 ]; +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) +return ; + + d = container_of(hdr, struct rdt_mon_domain, hdr); snc_mode = r->mon_scope ==RESCTRL_L3_NODE ;sprintf (name,"mon_%s_%02d" , r->name, snc_mode ? d->ci_id : d->hdr.id);
Please note that this patch is inconsistent in how the functions are modified to access members of struct rdt_domain_hdr now that it is provided as a parameter. For example, the above d->hdr.id is unchanged while a similar line in mkdir_mondata_subdir() changes the d->hdr.id to hdr->id.
This becomes irrelevant when considering the refactoring that comes later in the series but a reviewer cannot be expected to know that at this point.
Reinette
Tony Luck
maintainerPATCH v13 6/32 fs/resctrl: Split L3 dependent parts out of __mon_event_count()
In reply to Tony LuckCarve out the L3 resource specific event reading code into a separate helper to support reading event data from a new monitoring resource.
--- fs/resctrl/monitor.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
fs/resctrl/monitor.c +13 -1
@@ -413,7 +413,7 @@ static void mbm_cntr_free(struct rdt_mon_domain *d, int cntr_id)memset (&d->cntr_cfg[cntr_id],0 ,sizeof (*d->cntr_cfg)); } -static int __mon_event_count (struct rdtgroup *rdtgrp,struct rmid_read *rr) +static int __l3_mon_event_count (struct rdtgroup *rdtgrp,struct rmid_read *rr) {int cpu =smp_processor_id ();u32 closid = rdtgrp->closid;
@@ -494,6 +494,18 @@ static int __mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)return ret; } +static int __mon_event_count (struct rdtgroup *rdtgrp,struct rmid_read *rr) +{ +switch (rr->r->rid) { +case RDT_RESOURCE_L3 : +return __l3_mon_event_count (rdtgrp, rr); + +default : + rr->err = -EINVAL ; +return -EINVAL ; + } +} +/* * mbm_bw_count() - Update bw count from values previously read by * __mon_event_count().
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 7/32 x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters
In reply to Tony LuckConvert the whole call sequence from mon_event_read() to resctrl_arch_rmid_read() to pass resource independent struct rdt_domain_hdr instead of an L3 specific domain structure to prepare for monitoring events in other resources.
--- include/linux/resctrl.h | 4 +-- fs/resctrl/internal.h | 18 ++++++----- arch/x86/kernel/cpu/resctrl/monitor.c | 12 +++++-- fs/resctrl/ctrlmondata.c | 9 +----- fs/resctrl/monitor.c | 46 +++++++++++++++++---------- 5 files changed, 52 insertions(+), 37 deletions(-)
include/linux/resctrl.h +2 -2
@@ -514,7 +514,7 @@ void resctrl_offline_cpu(unsigned int cpu);* resctrl_arch_rmid_read() - Read the eventid counter corresponding to rmid * for this resource and domain. * @r: resource that the counter should be read from. -* @d: domain that the counter should be read from. +* @hdr: Header of domain that the counter should be read from. * @closid: closid that matches the rmid. Depending on the architecture, the * counter may match traffic of both @closid and @rmid, or @rmid * only.
@@ -535,7 +535,7 @@ void resctrl_offline_cpu(unsigned int cpu);* Return: * 0 on success, or -EIO, -EINVAL etc on error. */ -int resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_mon_domain *d, +int resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_domain_hdr *hdr,u32 closid,u32 rmid,enum resctrl_event_id eventid,u64 *val,void *arch_mon_ctx);
fs/resctrl/internal.h +10 -8
@@ -106,24 +106,26 @@ struct mon_data {* resource group then its event count is summed with the count from all * its child resource groups. * @r: Resource describing the properties of the event being read. -* @d: Domain that the counter should be read from. If NULL then sum all -* domains in @r sharing L3 @ci.id +* @hdr: Header of domain that the counter should be read from. If NULL then +* sum all domains in @r sharing L3 @ci.id * @evtid: Which monitor event to read. * @first: Initialize MBM counter when true. -* @ci: Cacheinfo for L3. Only set when @d is NULL. Used when summing domains. +* @ci: Cacheinfo for L3. Only set when @hdr is NULL. Used when summing +* domains. * @is_mbm_cntr: true if "mbm_event" counter assignment mode is enabled and it * is an MBM event. * @err: Error encountered when reading counter. -* @val: Returned value of event counter. If @rgrp is a parent resource group, -* @val includes the sum of event counts from its child resource groups. -* If @d is NULL, @val includes the sum of all domains in @r sharing @ci.id, -* (summed across child resource groups if @rgrp is a parent resource group). +* @val: Returned value of event counter. If @rgrp is a parent resource +* group, @val includes the sum of event counts from its child +* resource groups. If @hdr is NULL, @val includes the sum of all +* domains in @r sharing @ci.id, (summed across child resource groups +* if @rgrp is a parent resource group). * @arch_mon_ctx: Hardware monitor allocated for this read request (MPAM only). */ struct rmid_read {struct rdtgroup *rgrp;struct rdt_resource *r; -struct rdt_mon_domain *d; +struct rdt_domain_hdr *hdr;enum resctrl_event_id evtid;bool first;struct cacheinfo *ci;
arch/x86/kernel/cpu/resctrl/monitor.c +9 -3
@@ -238,19 +238,25 @@ static u64 get_corrected_val(struct rdt_resource *r, struct rdt_mon_domain *d,return chunks * hw_res->mon_scale; } -int resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_mon_domain *d, +int resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_domain_hdr *hdr,u32 unused,u32 rmid,enum resctrl_event_id eventid,u64 *val,void *ignored) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); -int cpu =cpumask_any (&d->hdr.cpu_mask); +struct rdt_hw_mon_domain *hw_dom;struct arch_mbm_state *am; +struct rdt_mon_domain *d;u64 msr_val;u32 prmid; +int cpu;int ret;resctrl_arch_rmid_read_context_check (); +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) +return -EINVAL ; + d = container_of(hdr, struct rdt_mon_domain, hdr); + hw_dom =resctrl_to_arch_mon_dom (d); + cpu =cpumask_any (&hdr->cpu_mask); prmid =logical_rmid_to_physical_rmid (cpu, rmid); ret =__rmid_read_phys (prmid, eventid, &msr_val);
fs/resctrl/ctrlmondata.c +1 -8
@@ -550,25 +550,18 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, struct rdt_domain_hdr *hdr, struct rdtgroup *rdtgrp, cpumask_t *cpumask, int evtid, int first) { - struct rdt_mon_domain *d = NULL; int cpu;/* When picking a CPU from cpu_mask, ensure it can't race with cpuhp */ lockdep_assert_cpus_held (); -if (hdr) { -if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) -return ; - d = container_of(hdr, struct rdt_mon_domain, hdr); - } -/* * Setup the parameters to pass to mon_event_count() to read the data. */ rr->rgrp = rdtgrp; rr->evtid = evtid; rr->r = r; - rr->d = d; + rr->hdr = hdr; rr->first = first;if (resctrl_arch_mbm_cntr_assign_enabled (r) &&resctrl_is_mbm_event (evtid)) {
fs/resctrl/monitor.c +30 -16
111 lines not on this page · raw message
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters
Hi Tony,
Quoted 8 lines · Tony Luck
fs/resctrl/monitor.c +2
-2@@ -497,8 +497,18 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)static int __mon_event_count (struct rdtgroup *rdtgrp,struct rmid_read *rr) {switch (rr->r->rid) { -case RDT_RESOURCE_L3 : -return __l3_mon_event_count (rdtgrp, rr); +case RDT_RESOURCE_L3 : { +struct rdt_mon_domain *d =NULL ;
fs/resctrl/monitor.c static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr) · line 511
Quoted 10 lines
fs/resctrl/monitor.c +10
-0+ +if (rr->hdr) { +if (!domain_header_is_valid (rr->hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) { + rr->err = -EIO ; +return -EINVAL ; + } + d = container_of(rr->hdr, struct rdt_mon_domain, hdr); + } +return __l3_mon_event_count (rdtgrp, rr, d); + }
I tried running this series through a static checker and it flagged a few issues related to this flow. The issues appear to be false positives but it demonstrates that this code is becoming very hard to understand. Consider, for example, how __l3_mon_event_count() is structured while thinking about d==NULL:
__l3_mon_event_count()
{
...
if (rr->is_mbm_cntr) {
/* dereferences d */
}
if (rr->first) {
/* dereferences d */
return 0;
}
if (d) {
/* dereferences d */
return 0;
}
/* sum code */
}I believe it will be difficult for somebody to trace that rr->is_mbm_cntr and rr->first cannot be true of d==NULL (the static checker issues supports this). The "if (d)" test that follows these checks just adds to difficulty by implying that d could indeed be NULL before then.
I see two options to address this. I tried both and the static checker was ok with either. I find the second option easier to understand than the first, but I share both for context:
option 1:
To make it obvious when the domain can be NULL:
__l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)
{
...
if (rr->hdr) {
if (!domain_header_is_valid(rr->hdr, RESCTRL_MON_DOMAIN, RDT_RESOURCE_L3)) {
rr->err = -EIO;
return -EINVAL;
}
d = container_of(rr->hdr, struct rdt_mon_domain, hdr);
if (rr->is_mbm_cntr) {
/* dereferences d */
}
if (rr->first) {
/* dereferences d */
return 0;
}
/* dereferences d */
return 0;
}
/* sum code */
}While easier to understand the above does not make the code easier to read. The function is already quite long and this adds an additional indentation level. This does not seem necessary since the rr->hdr!=NULL scenario really just looks like a "function within a function" since it does a "return".
This brings to:
option 2:
Split __l3_mon_event_count() into, for example, __l3_mon_event_count() that handles the rr->hdr!=NULL flow and __l3_mon_event_count_sum() that handles the rr->hdr==NULL flow.
This can be called from __mon_event_count():
if (rr->hdr) return __l3_mon_event_count(rdtgrp, rr); else return __l3_mon_event_count_sum(rdtgrp, rr);
Option 2 looks like the better option to me. What do you think?
Reinette
Tony Luck
maintainerPATCH v13 8/32 x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain
In reply to Tony LuckThe upcoming telemetry event monitoring are not tied to the L3 resource and will have a new domain structures.
Rename the L3 resource specific domain data structures to include "l3_" in their names to avoid confusion between the different resource specific domain structures:rdt_mon_domain -> rdt_l3_mon_domainrdt_hw_mon_domain -> rdt_hw_l3_mon_domain
No functional change.
--- include/linux/resctrl.h | 22 ++++---- arch/x86/kernel/cpu/resctrl/internal.h | 16 +++--- fs/resctrl/internal.h | 8 +-- arch/x86/kernel/cpu/resctrl/core.c | 14 +++--- arch/x86/kernel/cpu/resctrl/monitor.c | 36 ++++++------- fs/resctrl/ctrlmondata.c | 2 +- fs/resctrl/monitor.c | 70 +++++++++++++------------- fs/resctrl/rdtgroup.c | 40 +++++++-------- 8 files changed, 104 insertions(+), 104 deletions(-)
include/linux/resctrl.h +11 -11
@@ -178,7 +178,7 @@ struct mbm_cntr_cfg { };/** -* struct rdt_mon_domain - group of CPUs sharing a resctrl monitor resource +* struct rdt_l3_mon_domain - group of CPUs sharing a resctrl monitor resource * @hdr: common header for different domain types * @ci_id: cache info id for this domain * @rmid_busy_llc: bitmap of which limbo RMIDs are above threshold
@@ -192,7 +192,7 @@ struct mbm_cntr_cfg {* @cntr_cfg: array of assignable counters' configuration (indexed * by counter ID) */ -struct rdt_mon_domain { +struct rdt_l3_mon_domain {struct rdt_domain_hdr hdr;unsigned int ci_id;unsigned long *rmid_busy_llc;
@@ -364,10 +364,10 @@ struct resctrl_cpu_defaults { };struct resctrl_mon_config_info { -struct rdt_resource *r; -struct rdt_mon_domain *d; -u32 evtid; -u32 mon_config; +struct rdt_resource *r; +struct rdt_l3_mon_domain *d; +u32 evtid; +u32 mon_config; };/**
@@ -582,7 +582,7 @@ struct rdt_domain_hdr *resctrl_find_domain(struct list_head *h, int id,* * This can be called from any CPU. */ -void resctrl_arch_reset_rmid (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_reset_rmid (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 closid,u32 rmid,enum resctrl_event_id eventid);
@@ -595,7 +595,7 @@ void resctrl_arch_reset_rmid(struct rdt_resource *r, struct rdt_mon_domain *d,* * This can be called from any CPU. */ -void resctrl_arch_reset_rmid_all (struct rdt_resource *r,struct rdt_mon_domain *d); +void resctrl_arch_reset_rmid_all (struct rdt_resource *r,struct rdt_l3_mon_domain *d);/** * resctrl_arch_reset_all_ctrls() - Reset the control for each CLOSID to its
@@ -621,7 +621,7 @@ void resctrl_arch_reset_all_ctrls(struct rdt_resource *r);* * This can be called from any CPU. */ -void resctrl_arch_config_cntr (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_config_cntr (struct rdt_resource *r,struct rdt_l3_mon_domain *d,enum resctrl_event_id evtid,u32 rmid,u32 closid,u32 cntr_id,bool assign);
@@ -644,7 +644,7 @@ void resctrl_arch_config_cntr(struct rdt_resource *r, struct rdt_mon_domain *d,* Return: * 0 on success, or -EIO, -EINVAL etc on error. */ -int resctrl_arch_cntr_read (struct rdt_resource *r,struct rdt_mon_domain *d, +int resctrl_arch_cntr_read (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 closid,u32 rmid,int cntr_id,enum resctrl_event_id eventid,u64 *val);
@@ -659,7 +659,7 @@ int resctrl_arch_cntr_read(struct rdt_resource *r, struct rdt_mon_domain *d,* * This can be called from any CPU. */ -void resctrl_arch_reset_cntr (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_reset_cntr (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 closid,u32 rmid,int cntr_id,enum resctrl_event_id eventid);
arch/x86/kernel/cpu/resctrl/internal.h +8 -8
@@ -60,17 +60,17 @@ struct rdt_hw_ctrl_domain { };/** -* struct rdt_hw_mon_domain - Arch private attributes of a set of CPUs that share -* a resource for a monitor function -* @d_resctrl: Properties exposed to the resctrl file system +* struct rdt_hw_l3_mon_domain - Arch private attributes of a set of CPUs that share +* a resource for a monitor function +* @d_resctrl: Properties exposed to the resctrl file system * @arch_mbm_states: Per-event pointer to the MBM event's saved state. * An MBM event's state is an array of struct arch_mbm_state * indexed by RMID on x86. * * Members of this structure are accessed via helpers that provide abstraction. */ -struct rdt_hw_mon_domain { -struct rdt_mon_domain d_resctrl; +struct rdt_hw_l3_mon_domain { +struct rdt_l3_mon_domain d_resctrl;struct arch_mbm_state *arch_mbm_states[QOS_NUM_L3_MBM_EVENTS ]; };
@@ -79,9 +79,9 @@ static inline struct rdt_hw_ctrl_domain *resctrl_to_arch_ctrl_dom(struct rdt_ctr return container_of(r, struct rdt_hw_ctrl_domain, d_resctrl); } -static inline struct rdt_hw_mon_domain *resctrl_to_arch_mon_dom (struct rdt_mon_domain *r) +static inline struct rdt_hw_l3_mon_domain *resctrl_to_arch_mon_dom (struct rdt_l3_mon_domain *r) { - return container_of(r, struct rdt_hw_mon_domain, d_resctrl); + return container_of(r, struct rdt_hw_l3_mon_domain, d_resctrl); }/**
@@ -135,7 +135,7 @@ static inline struct rdt_hw_resource *resctrl_to_arch_res(struct rdt_resource *rextern struct rdt_hw_resource rdt_resources_all[]; -void arch_mon_domain_online (struct rdt_resource *r,struct rdt_mon_domain *d); +void arch_mon_domain_online (struct rdt_resource *r,struct rdt_l3_mon_domain *d);/* CPUID.(EAX=10H, ECX=ResID=1).EAX */ union cpuid_0x10_1_eax {
fs/resctrl/internal.h +4 -4
@@ -369,7 +369,7 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,int resctrl_mon_resource_init (void ); -void mbm_setup_overflow_handler (struct rdt_mon_domain *dom, +void mbm_setup_overflow_handler (struct rdt_l3_mon_domain *dom,unsigned long delay_ms,int exclude_cpu);
@@ -377,14 +377,14 @@ void mbm_handle_overflow(struct work_struct *work);bool is_mba_sc (struct rdt_resource *r); -void cqm_setup_limbo_handler (struct rdt_mon_domain *dom,unsigned long delay_ms, +void cqm_setup_limbo_handler (struct rdt_l3_mon_domain *dom,unsigned long delay_ms,int exclude_cpu);void cqm_handle_limbo (struct work_struct *work); -bool has_busy_rmid (struct rdt_mon_domain *d); +bool has_busy_rmid (struct rdt_l3_mon_domain *d); -void __check_limbo (struct rdt_mon_domain *d,bool force_free); +void __check_limbo (struct rdt_l3_mon_domain *d,bool force_free);void resctrl_file_fflags_init (const char *config,unsigned long fflags);
arch/x86/kernel/cpu/resctrl/core.c +7 -7
@@ -363,7 +363,7 @@ static void ctrl_domain_free(struct rdt_hw_ctrl_domain *hw_dom)kfree (hw_dom); } -static void mon_domain_free (struct rdt_hw_mon_domain *hw_dom) +static void mon_domain_free (struct rdt_hw_l3_mon_domain *hw_dom) {int idx;
@@ -400,7 +400,7 @@ static int domain_setup_ctrlval(struct rdt_resource *r, struct rdt_ctrl_domain ** @num_rmid: The size of the MBM counter array * @hw_dom: The domain that owns the allocated arrays */ -static int arch_domain_mbm_alloc (u32 num_rmid,struct rdt_hw_mon_domain *hw_dom) +static int arch_domain_mbm_alloc (u32 num_rmid,struct rdt_hw_l3_mon_domain *hw_dom) {size_t tsize =sizeof (*hw_dom->arch_mbm_states[0 ]);enum resctrl_event_id eventid;
@@ -498,8 +498,8 @@ static void domain_add_cpu_ctrl(int cpu, struct rdt_resource *r)static void l3_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { -struct rdt_hw_mon_domain *hw_dom; -struct rdt_mon_domain *d; +struct rdt_hw_l3_mon_domain *hw_dom; +struct rdt_l3_mon_domain *d;struct cacheinfo *ci;int err;
@@ -648,13 +648,13 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)switch (r->rid) {case RDT_RESOURCE_L3 : { -struct rdt_hw_mon_domain *hw_dom; -struct rdt_mon_domain *d; +struct rdt_hw_l3_mon_domain *hw_dom; +struct rdt_l3_mon_domain *d;if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return ; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr); hw_dom =resctrl_to_arch_mon_dom (d);resctrl_offline_mon_domain (r, hdr);list_del_rcu (&hdr->list);
arch/x86/kernel/cpu/resctrl/monitor.c +18 -18
@@ -109,7 +109,7 @@ static inline u64 get_corrected_mbm_count(u32 rmid, unsigned long val)* * In RMID sharing mode there are fewer "logical RMID" values available * to accumulate data ("physical RMIDs" are divided evenly between SNC -* nodes that share an L3 cache). Linux creates an rdt_mon_domain for +* nodes that share an L3 cache). Linux creates an rdt_l3_mon_domain for * each SNC node. * * The value loaded into IA32_PQR_ASSOC is the "logical RMID".
@@ -157,7 +157,7 @@ static int __rmid_read_phys(u32 prmid, enum resctrl_event_id eventid, u64 *val)return 0 ; } -static struct arch_mbm_state *get_arch_mbm_state (struct rdt_hw_mon_domain *hw_dom, +static struct arch_mbm_state *get_arch_mbm_state (struct rdt_hw_l3_mon_domain *hw_dom,u32 rmid,enum resctrl_event_id eventid) {
@@ -171,11 +171,11 @@ static struct arch_mbm_state *get_arch_mbm_state(struct rdt_hw_mon_domain *hw_doreturn state ? &state[rmid] :NULL ; } -void resctrl_arch_reset_rmid (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_reset_rmid (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 unused,u32 rmid,enum resctrl_event_id eventid) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); +struct rdt_hw_l3_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d);int cpu =cpumask_any (&d->hdr.cpu_mask);struct arch_mbm_state *am;u32 prmid;
@@ -194,9 +194,9 @@ void resctrl_arch_reset_rmid(struct rdt_resource *r, struct rdt_mon_domain *d,* Assumes that hardware counters are also reset and thus that there is * no need to record initial non-zero counts. */ -void resctrl_arch_reset_rmid_all (struct rdt_resource *r,struct rdt_mon_domain *d) +void resctrl_arch_reset_rmid_all (struct rdt_resource *r,struct rdt_l3_mon_domain *d) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); +struct rdt_hw_l3_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d);enum resctrl_event_id eventid;int idx;
@@ -217,10 +217,10 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)return chunks >> shift; } -static u64 get_corrected_val (struct rdt_resource *r,struct rdt_mon_domain *d, +static u64 get_corrected_val (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 rmid,enum resctrl_event_id eventid,u64 msr_val) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); +struct rdt_hw_l3_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d);struct rdt_hw_resource *hw_res =resctrl_to_arch_res (r);struct arch_mbm_state *am;u64 chunks;
@@ -242,9 +242,9 @@ int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain_hdr *hdr, u32 unused, u32 rmid, enum resctrl_event_id eventid, u64 *val, void *ignored) { - struct rdt_hw_mon_domain *hw_dom; + struct rdt_hw_l3_mon_domain *hw_dom; +struct rdt_l3_mon_domain *d;struct arch_mbm_state *am; -struct rdt_mon_domain *d;u64 msr_val;u32 prmid;int cpu;
@@ -254,7 +254,7 @@ int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain_hdr *hdr,if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return -EINVAL ; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr); hw_dom =resctrl_to_arch_mon_dom (d); cpu =cpumask_any (&hdr->cpu_mask); prmid =logical_rmid_to_physical_rmid (cpu, rmid);
@@ -308,11 +308,11 @@ static int __cntr_id_read(u32 cntr_id, u64 *val)return 0 ; } -void resctrl_arch_reset_cntr (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_reset_cntr (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 unused,u32 rmid,int cntr_id,enum resctrl_event_id eventid) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); +struct rdt_hw_l3_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d);struct arch_mbm_state *am; am =get_arch_mbm_state (hw_dom, rmid, eventid);
@@ -324,7 +324,7 @@ void resctrl_arch_reset_cntr(struct rdt_resource *r, struct rdt_mon_domain *d, } } -int resctrl_arch_cntr_read (struct rdt_resource *r,struct rdt_mon_domain *d, +int resctrl_arch_cntr_read (struct rdt_resource *r,struct rdt_l3_mon_domain *d,u32 unused,u32 rmid,int cntr_id,enum resctrl_event_id eventid,u64 *val) {
@@ -354,7 +354,7 @@ int resctrl_arch_cntr_read(struct rdt_resource *r, struct rdt_mon_domain *d,* must adjust RMID counter numbers based on SNC node. See * logical_rmid_to_physical_rmid() for code that does this. */ -void arch_mon_domain_online (struct rdt_resource *r,struct rdt_mon_domain *d) +void arch_mon_domain_online (struct rdt_resource *r,struct rdt_l3_mon_domain *d) {if (snc_nodes_per_l3_cache >1 )msr_clear_bit (MSR_RMID_SNC_CONFIG ,0 );
@@ -515,7 +515,7 @@ static void resctrl_abmc_set_one_amd(void *arg)*/ static void _resctrl_abmc_enable (struct rdt_resource *r,bool enable) { -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;lockdep_assert_cpus_held ();
@@ -554,11 +554,11 @@ static void resctrl_abmc_config_one_amd(void *info)/* * Send an IPI to the domain to assign the counter to RMID, event pair. */ -void resctrl_arch_config_cntr (struct rdt_resource *r,struct rdt_mon_domain *d, +void resctrl_arch_config_cntr (struct rdt_resource *r,struct rdt_l3_mon_domain *d,enum resctrl_event_id evtid,u32 rmid,u32 closid,u32 cntr_id,bool assign) { -struct rdt_hw_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d); +struct rdt_hw_l3_mon_domain *hw_dom =resctrl_to_arch_mon_dom (d);union l3_qos_abmc_cfg abmc_cfg = {0 };struct arch_mbm_state *am;
fs/resctrl/ctrlmondata.c +1 -1
@@ -596,9 +596,9 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)struct kernfs_open_file *of = m->private;enum resctrl_res_level resid;enum resctrl_event_id evtid; +struct rdt_l3_mon_domain *d;struct rdt_domain_hdr *hdr;struct rmid_read rr = {0 }; -struct rdt_mon_domain *d;struct rdtgroup *rdtgrp;int domid, cpu, ret =0 ;struct rdt_resource *r;
fs/resctrl/monitor.c +35 -35
275 lines not on this page · raw message
fs/resctrl/rdtgroup.c +20 -20
@@ -1618,7 +1618,7 @@ static void mondata_config_read(struct resctrl_mon_config_info *mon_info)static int mbm_config_show (struct seq_file *s,struct rdt_resource *r,u32 evtid) {struct resctrl_mon_config_info mon_info; -struct rdt_mon_domain *dom; +struct rdt_l3_mon_domain *dom;bool sep = false;cpus_read_lock ();
@@ -1666,7 +1666,7 @@ static int mbm_local_bytes_config_show(struct kernfs_open_file *of, }static void mbm_config_write_domain (struct rdt_resource *r, -struct rdt_mon_domain *d,u32 evtid,u32 val) +struct rdt_l3_mon_domain *d,u32 evtid,u32 val) {struct resctrl_mon_config_info mon_info = {0 };
@@ -1707,8 +1707,8 @@ static void mbm_config_write_domain(struct rdt_resource *r,static int mon_config_write (struct rdt_resource *r,char *tok,u32 evtid) {char *dom_str =NULL , *id_str; +struct rdt_l3_mon_domain *d;unsigned long dom_id, val; -struct rdt_mon_domain *d;/* Walking r->domains, ensure it can't race with cpuhp */ lockdep_assert_cpus_held ();
@@ -2716,7 +2716,7 @@ static int rdt_get_tree(struct fs_context *fc) {struct rdt_fs_context *ctx =rdt_fc2context (fc);unsigned long flags =RFTYPE_CTRL_BASE ; -struct rdt_mon_domain *dom; +struct rdt_l3_mon_domain *dom;struct rdt_resource *r;int ret;
@@ -3167,7 +3167,7 @@ static void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, struct rdt_domain_hdr *hdr) {struct rdtgroup *prgrp, *crgrp; -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;char subname[32 ];bool snc_mode;char name[32 ];
@@ -3175,7 +3175,7 @@ static void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r,if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return ; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr); snc_mode = r->mon_scope ==RESCTRL_L3_NODE ;sprintf (name,"mon_%s_%02d" , r->name, snc_mode ? d->ci_id : d->hdr.id);if (snc_mode)
@@ -3193,8 +3193,8 @@ static int mon_add_all_files(struct kernfs_node *kn, struct rdt_domain_hdr *hdr, struct rdt_resource *r, struct rdtgroup *prgrp, bool do_sum) { + struct rdt_l3_mon_domain *d;struct rmid_read rr = {0 }; -struct rdt_mon_domain *d;struct mon_data *priv;struct mon_evt *mevt;int ret, domid;
@@ -3202,7 +3202,7 @@ static int mon_add_all_files(struct kernfs_node *kn, struct rdt_domain_hdr *hdr,if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return -EINVAL ; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr);for_each_mon_event (mevt) {if (mevt->rid != r->rid || !mevt->enabled)continue ;
@@ -3227,7 +3227,7 @@ static int mkdir_mondata_subdir(struct kernfs_node *parent_kn, struct rdt_resource *r, struct rdtgroup *prgrp) { struct kernfs_node *kn, *ckn; -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;char name[32 ];bool snc_mode;int ret =0 ;
@@ -3237,7 +3237,7 @@ static int mkdir_mondata_subdir(struct kernfs_node *parent_kn,if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return -EINVAL ; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr); snc_mode = r->mon_scope ==RESCTRL_L3_NODE ;sprintf (name,"mon_%s_%02d" , r->name, snc_mode ? d->ci_id : d->hdr.id); kn =kernfs_find_and_get (parent_kn, name);
@@ -4180,7 +4180,7 @@ static void rdtgroup_setup_default(void)mutex_unlock (&rdtgroup_mutex); } -static void domain_destroy_mon_state (struct rdt_mon_domain *d) +static void domain_destroy_mon_state (struct rdt_l3_mon_domain *d) {int idx;
@@ -4204,14 +4204,14 @@ void resctrl_offline_ctrl_domain(struct rdt_resource *r, struct rdt_ctrl_domainvoid resctrl_offline_mon_domain (struct rdt_resource *r,struct rdt_domain_hdr *hdr) { -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;mutex_lock (&rdtgroup_mutex);if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) goto out_unlock; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr);/* * If resctrl is mounted, remove all the
@@ -4253,7 +4253,7 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *h* * Returns 0 for success, or -ENOMEM. */ -static int domain_setup_mon_state (struct rdt_resource *r,struct rdt_mon_domain *d) +static int domain_setup_mon_state (struct rdt_resource *r,struct rdt_l3_mon_domain *d) {u32 idx_limit =resctrl_arch_system_num_rmid_idx ();size_t tsize =sizeof (*d->mbm_states[0 ]);
@@ -4311,7 +4311,7 @@ int resctrl_online_ctrl_domain(struct rdt_resource *r, struct rdt_ctrl_domain *dint resctrl_online_mon_domain (struct rdt_resource *r,struct rdt_domain_hdr *hdr) { -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;int err = -EINVAL ;mutex_lock (&rdtgroup_mutex);
@@ -4319,7 +4319,7 @@ int resctrl_online_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hdrif (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) goto out_unlock; - d = container_of(hdr, struct rdt_mon_domain, hdr); + d = container_of(hdr, struct rdt_l3_mon_domain, hdr); err =domain_setup_mon_state (r, d);if (err) goto out_unlock;
@@ -4366,10 +4366,10 @@ static void clear_childcpus(struct rdtgroup *r, unsigned int cpu) } } -static struct rdt_mon_domain *get_mon_domain_from_cpu (int cpu, -struct rdt_resource *r) +static struct rdt_l3_mon_domain *get_mon_domain_from_cpu (int cpu, +struct rdt_resource *r) { -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;lockdep_assert_cpus_held ();
@@ -4385,7 +4385,7 @@ static struct rdt_mon_domain *get_mon_domain_from_cpu(int cpu,void resctrl_offline_cpu (unsigned int cpu) {struct rdt_resource *l3 =resctrl_arch_get_resource (RDT_RESOURCE_L3 ); -struct rdt_mon_domain *d; +struct rdt_l3_mon_domain *d;struct rdtgroup *rdtgrp;mutex_lock (&rdtgroup_mutex);
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 08/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain
Hi Tony,
Quoted 1 line · Tony Luck
The upcoming telemetry event monitoring are not tied to the L3
"are not tied" -> "is not tied"?
Quoted 1 line
resource and will have a new domain structures.
"a new domain structures" -> "new domain structures"?
Could you please review all changelogs, even those that already have RB tag, to make full use of line length? This is required by tip and having patches formatted correctly will reduce fixups needed later.
(This repeats
https://lore.kernel.org/lkml/[email protected]/)
Quoted 11 lines
Rename the L3 resource specific domain data structures to include "
l3_" in their names to avoid confusion between the different resource specific domain structures:rdt_mon_domain->rdt_l3_mon_domainrdt_hw_mon_domain->rdt_hw_l3_mon_domainNo functional change.
Signed-off-by Tony Luck <[email protected]>---
...
include/linux/resctrl.h struct mbm_cntr_cfg { · line 181
Quoted 10 lines
include/linux/resctrl.h +1
-1@@ -178,7 +178,7 @@ struct mbm_cntr_cfg { };/** -* struct rdt_mon_domain - group of CPUs sharing a resctrl monitor resource +* struct rdt_l3_mon_domain - group of CPUs sharing a resctrl monitor resource
nit: The "a resctrl monitor" in the description can now be updated to reflect that it is now L3 resource specific. For example, "group of CPUs sharing RDT_RESOURCE_L3 monitoring"
Quoted 12 lines
include/linux/resctrl.h +1
-1* @hdr: common header for different domain types * @ci_id: cache info id for this domain * @rmid_busy_llc: bitmap of which limbo RMIDs are above threshold @@ -192,7 +192,7 @@ struct mbm_cntr_cfg {* @cntr_cfg: array of assignable counters' configuration (indexed * by counter ID) */ -struct rdt_mon_domain { +struct rdt_l3_mon_domain {struct rdt_domain_hdr hdr;unsigned int ci_id;unsigned long *rmid_busy_llc;
...
arch/x86/kernel/cpu/resctrl/internal.h struct rdt_hw_ctrl_domain { · line 64
Quoted 13 lines
arch/x86/kernel/cpu/resctrl/internal.h +2
-3@@ -60,17 +60,17 @@ struct rdt_hw_ctrl_domain { };/** -* struct rdt_hw_mon_domain - Arch private attributes of a set of CPUs that share -* a resource for a monitor function -* @d_resctrl: Properties exposed to the resctrl file system +* struct rdt_hw_l3_mon_domain - Arch private attributes of a set of CPUs that share +* a resource for a monitor function
Similar here. This is no longer just "a resource" but can only be an L3 resource.
Reinette
Tony Luck
maintainerPATCH v13 9/32 x86,fs/resctrl: Rename some L3 specific functions
In reply to Tony LuckWith the arrival of monitor events tied to new domains associated with a different resource it would be clearer if the L3 resource specific functions are more accurately named.
Rename three groups of functions:
Functions that allocate/free architecture per-RMID MBM state information:arch_domain_mbm_alloc() -> l3_mon_domain_mbm_alloc()mon_domain_free() -> l3_mon_domain_free()
Functions that allocate/free filesystem per-RMID MBM state information:domain_setup_mon_state() -> domain_setup_l3_mon_state()domain_destroy_mon_state() -> domain_destroy_l3_mon_state()
Initialization/exit:rdt_get_mon_l3_config() -> rdt_get_l3_mon_config()resctrl_mon_resource_init() -> resctrl_l3_mon_resource_init()resctrl_mon_resource_exit() -> resctrl_l3_mon_resource_exit()
Ensure kernel-doc descriptions of these functions' return values are present and correctly formatted.
--- arch/x86/kernel/cpu/resctrl/internal.h | 2 +- fs/resctrl/internal.h | 6 +++--- arch/x86/kernel/cpu/resctrl/core.c | 20 +++++++++++--------- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- fs/resctrl/monitor.c | 8 ++++---- fs/resctrl/rdtgroup.c | 24 ++++++++++++------------ 6 files changed, 32 insertions(+), 30 deletions(-)
arch/x86/kernel/cpu/resctrl/internal.h +1 -1
@@ -208,7 +208,7 @@ union l3_qos_abmc_cfg {void rdt_ctrl_update (void *arg); -int rdt_get_mon_l3_config (struct rdt_resource *r); +int rdt_get_l3_mon_config (struct rdt_resource *r);bool rdt_cpu_has (int flag);
fs/resctrl/internal.h +3 -3
@@ -357,7 +357,9 @@ int alloc_rmid(u32 closid);void free_rmid (u32 closid,u32 rmid); -void resctrl_mon_resource_exit (void ); +int resctrl_l3_mon_resource_init (void ); + +void resctrl_l3_mon_resource_exit (void );void mon_event_count (void *info);
@@ -367,8 +369,6 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, struct rdt_domain_hdr *hdr, struct rdtgroup *rdtgrp, cpumask_t *cpumask, int evtid, int first); -int resctrl_mon_resource_init (void ); -void mbm_setup_overflow_handler (struct rdt_l3_mon_domain *dom,unsigned long delay_ms,int exclude_cpu);
arch/x86/kernel/cpu/resctrl/core.c +11 -9
@@ -363,7 +363,7 @@ static void ctrl_domain_free(struct rdt_hw_ctrl_domain *hw_dom)kfree (hw_dom); } -static void mon_domain_free (struct rdt_hw_l3_mon_domain *hw_dom) +static void l3_mon_domain_free (struct rdt_hw_l3_mon_domain *hw_dom) {int idx;
@@ -396,11 +396,13 @@ static int domain_setup_ctrlval(struct rdt_resource *r, struct rdt_ctrl_domain * }/** -* arch_domain_mbm_alloc() - Allocate arch private storage for the MBM counters +* l3_mon_domain_mbm_alloc() - Allocate arch private storage for the MBM counters * @num_rmid: The size of the MBM counter array * @hw_dom: The domain that owns the allocated arrays +* +* Return: 0 for success, or -ENOMEM. */ -static int arch_domain_mbm_alloc (u32 num_rmid,struct rdt_hw_l3_mon_domain *hw_dom) +static int l3_mon_domain_mbm_alloc (u32 num_rmid,struct rdt_hw_l3_mon_domain *hw_dom) {size_t tsize =sizeof (*hw_dom->arch_mbm_states[0 ]);enum resctrl_event_id eventid;
@@ -514,7 +516,7 @@ static void l3_mon_domain_setup(int cpu, int id, struct rdt_resource *r, struct ci =get_cpu_cacheinfo_level (cpu,RESCTRL_L3_CACHE );if (!ci) {pr_warn_once ("Can't find L3 cache for CPU:%d resource %s\n" , cpu, r->name); -mon_domain_free (hw_dom); +l3_mon_domain_free (hw_dom);return ; } d->ci_id = ci->id;
@@ -522,8 +524,8 @@ static void l3_mon_domain_setup(int cpu, int id, struct rdt_resource *r, structarch_mon_domain_online (r, d); -if (arch_domain_mbm_alloc (r->mon.num_rmid, hw_dom)) { -mon_domain_free (hw_dom); +if (l3_mon_domain_mbm_alloc (r->mon.num_rmid, hw_dom)) { +l3_mon_domain_free (hw_dom);return ; }
@@ -533,7 +535,7 @@ static void l3_mon_domain_setup(int cpu, int id, struct rdt_resource *r, structif (err) {list_del_rcu (&d->hdr.list);synchronize_rcu (); -mon_domain_free (hw_dom); +l3_mon_domain_free (hw_dom); } }
@@ -659,7 +661,7 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)resctrl_offline_mon_domain (r, hdr);list_del_rcu (&hdr->list);synchronize_rcu (); -mon_domain_free (hw_dom); +l3_mon_domain_free (hw_dom);break ; }default :
@@ -908,7 +910,7 @@ static __init bool get_rdt_mon_resources(void)if (!ret)return false; -return !rdt_get_mon_l3_config (r); +return !rdt_get_l3_mon_config (r); }static __init void __check_quirks_intel (void )
arch/x86/kernel/cpu/resctrl/monitor.c +1 -1
@@ -423,7 +423,7 @@ static __init int snc_get_config(void)return ret; } -int __init rdt_get_mon_l3_config (struct rdt_resource *r) +int __init rdt_get_l3_mon_config (struct rdt_resource *r) {unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;struct rdt_hw_resource *hw_res =resctrl_to_arch_res (r);
fs/resctrl/monitor.c +4 -4
@@ -1768,7 +1768,7 @@ ssize_t mbm_L3_assignments_write(struct kernfs_open_file *of, char *buf, }/** -* resctrl_mon_resource_init() - Initialise global monitoring structures. +* resctrl_l3_mon_resource_init() - Initialise global monitoring structures. * * Allocate and initialise global monitor resources that do not belong to a * specific domain. i.e. the rmid_ptrs[] used for the limbo and free lists.
@@ -1777,9 +1777,9 @@ ssize_t mbm_L3_assignments_write(struct kernfs_open_file *of, char *buf,* Resctrl's cpuhp callbacks may be called before this point to bring a domain * online. * -* Returns 0 for success, or -ENOMEM. +* Return: 0 for success, or -ENOMEM. */ -int resctrl_mon_resource_init (void ) +int resctrl_l3_mon_resource_init (void ) {struct rdt_resource *r =resctrl_arch_get_resource (RDT_RESOURCE_L3 );int ret;
@@ -1829,7 +1829,7 @@ int resctrl_mon_resource_init(void)return 0 ; } -void resctrl_mon_resource_exit (void ) +void resctrl_l3_mon_resource_exit (void ) {struct rdt_resource *r =resctrl_arch_get_resource (RDT_RESOURCE_L3 );
fs/resctrl/rdtgroup.c +12 -12
@@ -4180,7 +4180,7 @@ static void rdtgroup_setup_default(void)mutex_unlock (&rdtgroup_mutex); } -static void domain_destroy_mon_state (struct rdt_l3_mon_domain *d) +static void domain_destroy_l3_mon_state (struct rdt_l3_mon_domain *d) {int idx;
@@ -4235,13 +4235,13 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hcancel_delayed_work (&d->cqm_limbo); } -domain_destroy_mon_state (d); +domain_destroy_l3_mon_state (d); out_unlock:mutex_unlock (&rdtgroup_mutex); }/** -* domain_setup_mon_state() - Initialise domain monitoring structures. +* domain_setup_l3_mon_state() - Initialise domain monitoring structures. * @r: The resource for the newly online domain. * @d: The newly online domain. *
@@ -4249,11 +4249,11 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *h* Called when the first CPU of a domain comes online, regardless of whether * the filesystem is mounted. * During boot this may be called before global allocations have been made by -* resctrl_mon_resource_init(). +* resctrl_l3_mon_resource_init(). * -* Returns 0 for success, or -ENOMEM. +* Return: 0 for success, or -ENOMEM. */ -static int domain_setup_mon_state (struct rdt_resource *r,struct rdt_l3_mon_domain *d) +static int domain_setup_l3_mon_state (struct rdt_resource *r,struct rdt_l3_mon_domain *d) {u32 idx_limit =resctrl_arch_system_num_rmid_idx ();size_t tsize =sizeof (*d->mbm_states[0 ]);
@@ -4320,7 +4320,7 @@ int resctrl_online_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hdr goto out_unlock; d = container_of(hdr, struct rdt_l3_mon_domain, hdr); - err =domain_setup_mon_state (r, d); + err =domain_setup_l3_mon_state (r, d);if (err) goto out_unlock;
@@ -4435,13 +4435,13 @@ int resctrl_init(void)thread_throttle_mode_init (); - ret =resctrl_mon_resource_init (); + ret =resctrl_l3_mon_resource_init ();if (ret)return ret; ret =sysfs_create_mount_point (fs_kobj,"resctrl" );if (ret) { -resctrl_mon_resource_exit (); +resctrl_l3_mon_resource_exit ();return ret; }
@@ -4476,7 +4476,7 @@ int resctrl_init(void) cleanup_mountpoint:sysfs_remove_mount_point (fs_kobj,"resctrl" ); -resctrl_mon_resource_exit (); +resctrl_l3_mon_resource_exit ();return ret; }
@@ -4512,7 +4512,7 @@ static bool resctrl_online_domains_exist(void)* When called by the architecture code, all CPUs and resctrl domains must be * offline. This ensures the limbo and overflow handlers are not scheduled to * run, meaning the data structures they access can be freed by -* resctrl_mon_resource_exit(). +* resctrl_l3_mon_resource_exit(). * * After resctrl_exit() returns, the architecture code should return an * error from all resctrl_arch_ functions that can do this.
@@ -4539,5 +4539,5 @@ void resctrl_exit(void)* it can be used to umount resctrl. */ -resctrl_mon_resource_exit (); +resctrl_l3_mon_resource_exit (); }
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 09/32] x86,fs/resctrl: Rename some L3 specific functions
Hi Tony,
Quoted 19 lines · Tony Luck
With the arrival of monitor events tied to new domains associated with a different resource it would be clearer if the L3 resource specific functions are more accurately named.
Rename three groups of functions:
Functions that allocate/free architecture per-RMID MBM state information:
arch_domain_mbm_alloc()->l3_mon_domain_mbm_alloc()mon_domain_free()->l3_mon_domain_free()Functions that allocate/free filesystem per-RMID MBM state information:
domain_setup_mon_state()->domain_setup_l3_mon_state()domain_destroy_mon_state()->domain_destroy_l3_mon_state()Initialization/exit:
rdt_get_mon_l3_config()->rdt_get_l3_mon_config()resctrl_mon_resource_init()->resctrl_l3_mon_resource_init()resctrl_mon_resource_exit()->resctrl_l3_mon_resource_exit()
Quoted 5 lines
Ensure kernel-doc descriptions of these functions' return values are present and correctly formatted.
Signed-off-by Tony Luck <[email protected]>---
With changelog line lengths fixed:
| Reviewed-by: Reinette Chatre <[email protected]>
Reinette
Tony Luck
maintainerPATCH v13 10/32 fs/resctrl: Make event details accessible to functions when reading events
In reply to Tony LuckReading monitoring event data from MMIO requires more context than the event id to be able to read the correct memory location. struct mon_evt is the appropriate place for this event specific context.
Prepare for addition of extra fields to struct mon_evt by changing the calling conventions to pass a pointer to the mon_evt structure instead of just the event id.
--- fs/resctrl/internal.h | 10 +++++----- fs/resctrl/ctrlmondata.c | 18 +++++++++--------- fs/resctrl/monitor.c | 24 ++++++++++++------------ fs/resctrl/rdtgroup.c | 6 +++--- 4 files changed, 29 insertions(+), 29 deletions(-)
fs/resctrl/internal.h +5 -5
@@ -81,7 +81,7 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];* struct mon_data - Monitoring details for each event file. * @list: Member of the global @mon_data_kn_priv_list list. * @rid: Resource id associated with the event file. -* @evtid: Event id associated with the event file. +* @evt: Event structure associated with the event file. * @sum: Set when event must be summed across multiple * domains. * @domid: When @sum is zero this is the domain to which
@@ -95,7 +95,7 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];struct mon_data {struct list_head list;enum resctrl_res_level rid; -enum resctrl_event_id evtid; +struct mon_evt *evt;int domid;bool sum; };
@@ -108,7 +108,7 @@ struct mon_data {* @r: Resource describing the properties of the event being read. * @hdr: Header of domain that the counter should be read from. If NULL then * sum all domains in @r sharing L3 @ci.id -* @evtid: Which monitor event to read. +* @evt: Which monitor event to read. * @first: Initialize MBM counter when true. * @ci: Cacheinfo for L3. Only set when @hdr is NULL. Used when summing * domains.
@@ -126,7 +126,7 @@ struct rmid_read {struct rdtgroup *rgrp;struct rdt_resource *r;struct rdt_domain_hdr *hdr; -enum resctrl_event_id evtid; +struct mon_evt *evt;bool first;struct cacheinfo *ci;bool is_mbm_cntr;
@@ -367,7 +367,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg);void mon_event_read (struct rmid_read *rr,struct rdt_resource *r,struct rdt_domain_hdr *hdr,struct rdtgroup *rdtgrp, -cpumask_t *cpumask,int evtid,int first); +cpumask_t *cpumask,struct mon_evt *evt,int first); void mbm_setup_overflow_handler(struct rdt_l3_mon_domain *dom, unsigned long delay_ms,
fs/resctrl/ctrlmondata.c +9 -9
@@ -548,7 +548,7 @@ struct rdt_domain_hdr *resctrl_find_domain(struct list_head *h, int id,void mon_event_read (struct rmid_read *rr,struct rdt_resource *r,struct rdt_domain_hdr *hdr,struct rdtgroup *rdtgrp, -cpumask_t *cpumask,int evtid,int first) +cpumask_t *cpumask,struct mon_evt *evt,int first) {int cpu;
@@ -559,15 +559,15 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,* Setup the parameters to pass to mon_event_count() to read the data. */ rr->rgrp = rdtgrp; - rr->evtid = evtid; + rr->evt = evt; rr->r = r; rr->hdr = hdr; rr->first = first;if (resctrl_arch_mbm_cntr_assign_enabled (r) && -resctrl_is_mbm_event (evtid)) { +resctrl_is_mbm_event (evt->evtid)) { rr->is_mbm_cntr = true; }else { - rr->arch_mon_ctx =resctrl_arch_mon_ctx_alloc (r, evtid); + rr->arch_mon_ctx =resctrl_arch_mon_ctx_alloc (r, evt->evtid);if (IS_ERR (rr->arch_mon_ctx)) { rr->err = -EINVAL ;return ;
@@ -588,14 +588,13 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,smp_call_on_cpu (cpu, smp_mon_event_count, rr, false);if (rr->arch_mon_ctx) -resctrl_arch_mon_ctx_free (r, evtid, rr->arch_mon_ctx); +resctrl_arch_mon_ctx_free (r, evt->evtid, rr->arch_mon_ctx); }int rdtgroup_mondata_show (struct seq_file *m,void *arg) {struct kernfs_open_file *of = m->private;enum resctrl_res_level resid; -enum resctrl_event_id evtid;struct rdt_l3_mon_domain *d;struct rdt_domain_hdr *hdr;struct rmid_read rr = {0 };
@@ -603,6 +602,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)int domid, cpu, ret =0 ;struct rdt_resource *r;struct cacheinfo *ci; +struct mon_evt *evt;struct mon_data *md; rdtgrp =rdtgroup_kn_lock_live (of->kn);
@@ -619,7 +619,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg) resid = md->rid; domid = md->domid; - evtid = md->evtid; + evt = md->evt; r =resctrl_arch_get_resource (resid);if (md->sum) {
@@ -637,7 +637,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)continue ; rr.ci = ci;mon_event_read (&rr, r,NULL , rdtgrp, - &ci->shared_cpu_map, evtid, false); + &ci->shared_cpu_map, evt, false); goto checkresult; } }
@@ -653,7 +653,7 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg) ret = -ENOENT ; goto out; } -mon_event_read (&rr, r, hdr, rdtgrp, &hdr->cpu_mask, evtid, false); +mon_event_read (&rr, r, hdr, rdtgrp, &hdr->cpu_mask, evt, false); } checkresult:
fs/resctrl/monitor.c +12 -12
@@ -425,7 +425,7 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr,u64 tval =0 ;if (rr->is_mbm_cntr) { - cntr_id =mbm_cntr_get (rr->r, d, rdtgrp, rr->evtid); + cntr_id =mbm_cntr_get (rr->r, d, rdtgrp, rr->evt->evtid);if (cntr_id <0 ) { rr->err = -ENOENT ;return -EINVAL ;
@@ -434,10 +434,10 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr,if (rr->first) {if (rr->is_mbm_cntr) -resctrl_arch_reset_cntr (rr->r, d, closid, rmid, cntr_id, rr->evtid); +resctrl_arch_reset_cntr (rr->r, d, closid, rmid, cntr_id, rr->evt->evtid);else -resctrl_arch_reset_rmid (rr->r, d, closid, rmid, rr->evtid); - m =get_mbm_state (d, closid, rmid, rr->evtid); +resctrl_arch_reset_rmid (rr->r, d, closid, rmid, rr->evt->evtid); + m =get_mbm_state (d, closid, rmid, rr->evt->evtid);if (m)memset (m,0 ,sizeof (struct mbm_state ));return 0 ;
@@ -449,10 +449,10 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr,return -EINVAL ;if (rr->is_mbm_cntr) rr->err =resctrl_arch_cntr_read (rr->r, d, closid, rmid, cntr_id, - rr->evtid, &tval); + rr->evt->evtid, &tval);else rr->err =resctrl_arch_rmid_read (rr->r, rr->hdr, closid, rmid, - rr->evtid, &tval, rr->arch_mon_ctx); + rr->evt->evtid, &tval, rr->arch_mon_ctx);if (rr->err)return rr->err;
@@ -478,10 +478,10 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr,continue ;if (rr->is_mbm_cntr) err =resctrl_arch_cntr_read (rr->r, d, closid, rmid, cntr_id, - rr->evtid, &tval); + rr->evt->evtid, &tval);else err =resctrl_arch_rmid_read (rr->r, &d->hdr, closid, rmid, - rr->evtid, &tval, rr->arch_mon_ctx); + rr->evt->evtid, &tval, rr->arch_mon_ctx);if (!err) { rr->val += tval; ret =0 ;
@@ -539,7 +539,7 @@ static void mbm_bw_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)if (!domain_header_is_valid (rr->hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return ; d = container_of(rr->hdr, struct rdt_l3_mon_domain, hdr); - m =get_mbm_state (d, closid, rmid, rr->evtid); + m =get_mbm_state (d, closid, rmid, rr->evt->evtid);if (WARN_ON_ONCE (!m))return ;
@@ -713,11 +713,11 @@ static void mbm_update_one_event(struct rdt_resource *r, struct rdt_l3_mon_domai rr.r = r; rr.hdr = &d->hdr; - rr.evtid = evtid; + rr.evt = &mon_event_all[evtid];if (resctrl_arch_mbm_cntr_assign_enabled (r)) { rr.is_mbm_cntr = true; }else { - rr.arch_mon_ctx =resctrl_arch_mon_ctx_alloc (rr.r, rr.evtid); + rr.arch_mon_ctx =resctrl_arch_mon_ctx_alloc (rr.r, evtid);if (IS_ERR (rr.arch_mon_ctx)) {pr_warn_ratelimited ("Failed to allocate monitor context: %ld" ,PTR_ERR (rr.arch_mon_ctx));
@@ -735,7 +735,7 @@ static void mbm_update_one_event(struct rdt_resource *r, struct rdt_l3_mon_domaimbm_bw_count (rdtgrp, &rr);if (rr.arch_mon_ctx) -resctrl_arch_mon_ctx_free (rr.r, rr.evtid, rr.arch_mon_ctx); +resctrl_arch_mon_ctx_free (rr.r, evtid, rr.arch_mon_ctx); } static void mbm_update(struct rdt_resource *r, struct rdt_l3_mon_domain *d,
fs/resctrl/rdtgroup.c +3 -3
@@ -3038,7 +3038,7 @@ static struct mon_data *mon_get_kn_priv(enum resctrl_res_level rid, int domid,list_for_each_entry (priv, &mon_data_kn_priv_list, list) {if (priv->rid == rid && priv->domid == domid && - priv->sum == do_sum && priv->evtid == mevt->evtid) + priv->sum == do_sum && priv->evt == mevt)return priv; }
@@ -3049,7 +3049,7 @@ static struct mon_data *mon_get_kn_priv(enum resctrl_res_level rid, int domid, priv->rid = rid; priv->domid = domid; priv->sum = do_sum; - priv->evtid = mevt->evtid; + priv->evt = mevt;list_add_tail (&priv->list, &mon_data_kn_priv_list);return priv;
@@ -3216,7 +3216,7 @@ static int mon_add_all_files(struct kernfs_node *kn, struct rdt_domain_hdr *hdr,return ret;if (!do_sum &&resctrl_is_mbm_event (mevt->evtid)) -mon_event_read (&rr, r, hdr, prgrp, &hdr->cpu_mask, mevt->evtid, true); +mon_event_read (&rr, r, hdr, prgrp, &hdr->cpu_mask, mevt, true); }return 0 ;
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 11/32 x86,fs/resctrl: Handle events that can be read from any CPU
In reply to Tony Luckresctrl assumes that monitor events can only be read from a CPU in the cpumask_t set of each domain. This is true for x86 events accessed with an MSR interface, but may not be true for other access methods such as MMIO.
Introduce and use flag mon_evt::any_cpu, settable by architecture, that indicates there are no restrictions on which CPU can read that event.
--- include/linux/resctrl.h | 2 +- fs/resctrl/internal.h | 2 ++ arch/x86/kernel/cpu/resctrl/core.c | 6 +++--- fs/resctrl/ctrlmondata.c | 6 ++++++ fs/resctrl/monitor.c | 3 ++- 5 files changed, 14 insertions(+), 5 deletions(-)
include/linux/resctrl.h +1 -1
@@ -409,7 +409,7 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r);u32 resctrl_arch_system_num_rmid_idx (void );int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid); -void resctrl_enable_mon_event (enum resctrl_event_id eventid); +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);
fs/resctrl/internal.h +2 -0
@@ -61,6 +61,7 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* READS_TO_REMOTE_MEM) being tracked by @evtid. * Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable +* @any_cpu: true if the event can be read from any CPU * @enabled: true if the event is enabled */ struct mon_evt {
@@ -69,6 +70,7 @@ struct mon_evt {char *name;u32 evt_cfg;bool configurable; +bool any_cpu;bool enabled; };
arch/x86/kernel/cpu/resctrl/core.c +3 -3
@@ -893,15 +893,15 @@ static __init bool get_rdt_mon_resources(void)bool ret = false;if (rdt_cpu_has (X86_FEATURE_CQM_OCCUP_LLC )) { -resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID ); +resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_TOTAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID ); +resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_LOCAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID ); +resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false); ret = true; }if (rdt_cpu_has (X86_FEATURE_ABMC ))
fs/resctrl/ctrlmondata.c +6 -0
@@ -574,6 +574,11 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, } } +if (evt->any_cpu) { +mon_event_count (rr); + goto out_ctx_free; + } + cpu =cpumask_any_housekeeping (cpumask,RESCTRL_PICK_ANY_CPU );/*
@@ -587,6 +592,7 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,else smp_call_on_cpu (cpu, smp_mon_event_count, rr, false); +out_ctx_free:if (rr->arch_mon_ctx)resctrl_arch_mon_ctx_free (r, evt->evtid, rr->arch_mon_ctx); }
fs/resctrl/monitor.c +2 -1
@@ -975,7 +975,7 @@ struct mon_evt mon_event_all[QOS_NUM_EVENTS] = { }, }; -void resctrl_enable_mon_event (enum resctrl_event_id eventid) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu) {if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS ))return ;
@@ -984,6 +984,7 @@ void resctrl_enable_mon_event(enum resctrl_event_id eventid)return ; } + mon_event_all[eventid].any_cpu = any_cpu; mon_event_all[eventid].enabled = true; }
Signature · 1 line
2.51.0
Re: [PATCH v13 11/32] x86,fs/resctrl: Handle events that can be read from any CPU
Hi Tony,
Quoted 9 lines · Tony Luck
resctrl assumes that monitor events can only be read from a CPU in the
cpumask_tset of each domain. This is true for x86 events accessed with an MSR interface, but may not be true for other access methods such as MMIO.Introduce and use flag
mon_evt::any_cpu, settable by architecture, that indicates there are no restrictions on which CPU can read that event.Signed-off-by Tony Luck <[email protected]>
[snip]
fs/resctrl/monitor.c void resctrl_enable_mon_event(enum resctrl_event_id eventid) · line 990
Quoted 13 lines
fs/resctrl/monitor.c +2
-1-void resctrl_enable_mon_event (enum resctrl_event_id eventid) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu) {if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS ))return ;@@ -984,6 +984,7 @@ void resctrl_enable_mon_event(enum resctrl_event_id eventid)return ; } + mon_event_all[eventid].any_cpu = any_cpu; mon_event_all[eventid].enabled = true; }
It seems that cpu_on_correct_domain() was dropped, due to the refactor of __mon_event_count() in patch 0006 means it is no longer needed. But we still invoke smp_processor_id() in preemptible context in __l3_mon_event_count() before further checkings, which would cause a warning.
[ 4266.361951] BUG: using smp_processor_id() in preemptible [00000000] code: grep/1603 [ 4266.363231] caller is __l3_mon_event_count+0x30/0x2a0 [ 4266.364250] Call Trace: [ 4266.364262] <TASK> [ 4266.364273] dump_stack_lvl+0x53/0x70 [ 4266.364289] check_preemption_disabled+0xca/0xe0 [ 4266.364303] __l3_mon_event_count+0x30/0x2a0 [ 4266.364320] mon_event_count+0x22/0x90 [ 4266.364334] rdtgroup_mondata_show+0x108/0x390 [ 4266.364353] seq_read_iter+0x10d/0x450 [ 4266.364368] vfs_read+0x215/0x330 [ 4266.364386] ksys_read+0x6b/0xe0 [ 4266.364401] do_syscall_64+0x57/0xd70
thanks,
Chenyu
Luck, Tony
maintainerRe: [PATCH v13 11/32] x86,fs/resctrl: Handle events that can be read from any CPU
Quoted 32 lines · Yu C
Hi Tony,
Quoted 9 lines · Tony Luck
resctrl assumes that monitor events can only be read from a CPU in the
cpumask_tset of each domain. This is true for x86 events accessed with an MSR interface, but may not be true for other access methods such as MMIO.Introduce and use flag
mon_evt::any_cpu, settable by architecture, that indicates there are no restrictions on which CPU can read that event.Signed-off-by Tony Luck <[email protected]>[snip]
fs/resctrl/monitor.c void resctrl_enable_mon_event(enum resctrl_event_id eventid) · line 988
Quoted 11 lines
fs/resctrl/monitor.c +2
-1-void resctrl_enable_mon_event (enum resctrl_event_id eventid) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu) {if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS ))return ;@@ -984,6 +984,7 @@ void resctrl_enable_mon_event(enum resctrl_event_id eventid)return ; } + mon_event_all[eventid].any_cpu = any_cpu; mon_event_all[eventid].enabled = true; }It seems that
cpu_on_correct_domain()was dropped, due to the refactor of__mon_event_count()in patch 0006 means it is no longer needed. But we still invokesmp_processor_id()in preemptible context in__l3_mon_event_count()before further checkings, which would cause a warning.
Quoted 14 lines
[ 4266.361951] BUG: using smp_processor_id() in preemptible [00000000] code: grep/1603 [ 4266.363231] caller is __l3_mon_event_count+0x30/0x2a0 [ 4266.364250] Call Trace: [ 4266.364262] <TASK> [ 4266.364273] dump_stack_lvl+0x53/0x70 [ 4266.364289] check_preemption_disabled+0xca/0xe0 [ 4266.364303] __l3_mon_event_count+0x30/0x2a0 [ 4266.364320] mon_event_count+0x22/0x90 [ 4266.364334] rdtgroup_mondata_show+0x108/0x390 [ 4266.364353] seq_read_iter+0x10d/0x450 [ 4266.364368] vfs_read+0x215/0x330 [ 4266.364386] ksys_read+0x6b/0xe0 [ 4266.364401] do_syscall_64+0x57/0xd70
I didn't notice this in my testing. Is this in your region aware tree? If you are still using RDT_RESOURCE_L3 then I can see how you got this call trace.
Maybe you need to dig cpu_on_correct_domain() back up and apply it to __l3_mon_event_count()?
-Tony
Re: [PATCH v13 11/32] x86,fs/resctrl: Handle events that can be read from any CPU
Quoted 48 lines · Tony
Quoted 32 lines · Yu C
Hi Tony,
Quoted 9 lines · Tony Luck
resctrl assumes that monitor events can only be read from a CPU in the
cpumask_tset of each domain. This is true for x86 events accessed with an MSR interface, but may not be true for other access methods such as MMIO.Introduce and use flag
mon_evt::any_cpu, settable by architecture, that indicates there are no restrictions on which CPU can read that event.Signed-off-by Tony Luck <[email protected]>[snip]
fs/resctrl/monitor.c void resctrl_enable_mon_event(enum resctrl_event_id eventid) · line 988
Quoted 11 lines
fs/resctrl/monitor.c +2
-1-void resctrl_enable_mon_event (enum resctrl_event_id eventid) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu) {if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS ))return ;@@ -984,6 +984,7 @@ void resctrl_enable_mon_event(enum resctrl_event_id eventid)return ; } + mon_event_all[eventid].any_cpu = any_cpu; mon_event_all[eventid].enabled = true; }It seems that
cpu_on_correct_domain()was dropped, due to the refactor of__mon_event_count()in patch 0006 means it is no longer needed. But we still invokesmp_processor_id()in preemptible context in__l3_mon_event_count()before further checkings, which would cause a warning.Quoted 14 lines
[ 4266.361951] BUG: using smp_processor_id() in preemptible [00000000] code: grep/1603 [ 4266.363231] caller is __l3_mon_event_count+0x30/0x2a0 [ 4266.364250] Call Trace: [ 4266.364262] <TASK> [ 4266.364273] dump_stack_lvl+0x53/0x70 [ 4266.364289] check_preemption_disabled+0xca/0xe0 [ 4266.364303] __l3_mon_event_count+0x30/0x2a0 [ 4266.364320] mon_event_count+0x22/0x90 [ 4266.364334] rdtgroup_mondata_show+0x108/0x390 [ 4266.364353] seq_read_iter+0x10d/0x450 [ 4266.364368] vfs_read+0x215/0x330 [ 4266.364386] ksys_read+0x6b/0xe0 [ 4266.364401] do_syscall_64+0x57/0xd70
Quoted 4 lines
I didn't notice this in my testing. Is this in your region aware tree? If you are still using
RDT_RESOURCE_L3then I can see how you got this call trace.
Yes, it was tested on the region aware tree.
Quoted 3 lines
Maybe you need to dig
cpu_on_correct_domain()back up and apply it to__l3_mon_event_count()?
Got it, will do.
Thanks,
Chenyu
Reinette Chatre
maintainerRe: [PATCH v13 11/32] x86,fs/resctrl: Handle events that can be read from any CPU
In reply to Tony LuckHi Tony,
Quoted 10 lines · Tony Luck
resctrl assumes that monitor events can only be read from a CPU in the
cpumask_tset of each domain. This is true for x86 events accessed with an MSR interface, but may not be true for other access methods such as MMIO.Introduce and use flag
mon_evt::any_cpu, settable by architecture, that indicates there are no restrictions on which CPU can read that event.Signed-off-by Tony Luck <[email protected]>---
This implies a generic change while __l3_mon_event_count() cannot support it. While I understand why cpu_on_correct_domain() was removed, the existing checking requires DEBUG_PREEMPT to be set so I think it would be helpful if there is something like a WARN_ON_ONCE(rr->evt->any_cpu) before calling __l3_mon_event_count() to help catch issues.
Reinette
Tony Luck
maintainerPATCH v13 12/32 x86,fs/resctrl: Support binary fixed point event counters
In reply to Tony Luckresctrl assumes that all monitor events can be displayed as unsigned decimal integers.
Hardware architecture counters may provide some telemetry events with greater precision where the event is not a simple count, but is a measurement of some sort (e.g. Joules for energy consumed).
Add a new argument to resctrl_enable_mon_event() for architecture code to inform the file system that the value for a counter is a fixed-point value with a specific number of binary places.
Only allow architecture to use floating point format on events that the file system has marked with mon_evt::is_floating_point.
Display fixed point values with values rounded to an appropriate number of decimal places for the precision of the number of binary places provided. Add one extra decimal place for every three additional binary places, except for low precision binary values where exact representation is possible:
1 binary place is 0.0 or 0.5 => 1 decimal place
2 binary places is 0.0, 0.25, 0.5, 0.75 => 2 decimal places
3 binary places is 0.0, 0.125, etc. => 3 decimal places
--- include/linux/resctrl.h | 3 +- fs/resctrl/internal.h | 8 +++ arch/x86/kernel/cpu/resctrl/core.c | 6 +-- fs/resctrl/ctrlmondata.c | 84 ++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 10 +++- 5 files changed, 105 insertions(+), 6 deletions(-)
include/linux/resctrl.h +2 -1
@@ -409,7 +409,8 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r);u32 resctrl_arch_system_num_rmid_idx (void );int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid); -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu); +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, +unsigned int binary_bits);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);
fs/resctrl/internal.h +8 -0
@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format +* @binary_bits: number of fixed-point binary bits from architecture, +* only valid if @is_floating_point is true * @enabled: true if the event is enabled */ struct mon_evt {
@@ -71,6 +74,8 @@ struct mon_evt {u32 evt_cfg;bool configurable;bool any_cpu; +bool is_floating_point; +unsigned int binary_bits;bool enabled; };
@@ -79,6 +84,9 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];#define for_each_mon_event (mevt) for (mevt = &mon_event_all[QOS_FIRST_EVENT]; \ mevt < &mon_event_all[QOS_NUM_EVENTS]; mevt++) +/* Limit for mon_evt::binary_bits */ +#define MAX_BINARY_BITS 27 +/** * struct mon_data - Monitoring details for each event file. * @list: Member of the global @mon_data_kn_priv_list list.
arch/x86/kernel/cpu/resctrl/core.c +3 -3
@@ -893,15 +893,15 @@ static __init bool get_rdt_mon_resources(void)bool ret = false;if (rdt_cpu_has (X86_FEATURE_CQM_OCCUP_LLC )) { -resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_TOTAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_LOCAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_ABMC ))
fs/resctrl/ctrlmondata.c +84 -0
102 lines not on this page · raw message
fs/resctrl/monitor.c +8 -2
@@ -975,16 +975,22 @@ struct mon_evt mon_event_all[QOS_NUM_EVENTS] = { }, }; -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu,unsigned int binary_bits) { -if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS )) +if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS || + binary_bits >MAX_BINARY_BITS ))return ;if (mon_event_all[eventid].enabled) {pr_warn ("Duplicate enable for event %d\n" , eventid);return ; } +if (binary_bits && !mon_event_all[eventid].is_floating_point) { +pr_warn ("Event %d may not be floating point\n" , eventid); +return ; + } mon_event_all[eventid].any_cpu = any_cpu; + mon_event_all[eventid].binary_bits = binary_bits; mon_event_all[eventid].enabled = true; }
Signature · 1 line
2.51.0
Dave Martin
reviewerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Tony,
A few drive-by nits from me -- apologies, I hadn't looked at this in a while.
Quoted 13 lines · Tony Luck
resctrl assumes that all monitor events can be displayed as unsigned decimal integers.
Hardware architecture counters may provide some telemetry events with greater precision where the event is not a simple count, but is a measurement of some sort (e.g. Joules for energy consumed).
Add a new argument to
resctrl_enable_mon_event()for architecture code to inform the file system that the value for a counter is a fixed-point value with a specific number of binary places.
Only allow architecture to use floating point format on events that the file system has marked withmon_evt::is_floating_point.
Quoted 3 lines
Display fixed point values with values rounded to an appropriate number of decimal places for the precision of the number of binary places provided. Add one extra decimal place for every three additional binary
(Is this just informal wording? If not, it's wrong...)
Quoted 6 lines
places, except for low precision binary values where exact representation is possible:
1 binary place is 0.0 or 0.5 => 1 decimal place
2 binary places is 0.0, 0.25, 0.5, 0.75 => 2 decimal places
3 binary places is 0.0, 0.125, etc. => 3 decimal places
What's the rationale for this special treatment? I don't see any previous discussion (apologies if I missed it).
Quoted 30 lines
Signed-off-by Tony Luck <[email protected]>Reviewed-by Reinette Chatre <[email protected]>--- include/linux/resctrl.h | 3 +- fs/resctrl/internal.h | 8 +++ arch/x86/kernel/cpu/resctrl/core.c | 6 +-- fs/resctrl/ctrlmondata.c | 84 ++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 10 +++- 5 files changed, 105 insertions(+), 6 deletions(-)include/linux/resctrl.h +2
-1@@ -409,7 +409,8 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r);u32 resctrl_arch_system_num_rmid_idx (void );int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid); -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu); +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, +unsigned int binary_bits);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);fs/resctrl/internal.h +0
-0
fs/resctrl/internal.h static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc) · line 65
Quoted 4 lines
fs/resctrl/internal.h +1
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format
Nit: Maybe rebrand this as is_fixed_point, or is_fractional, or similar?
The print syntax is just a decimal fraction, and the hardware representation is fixed-point. Nothing floats.
Quoted 15 lines
fs/resctrl/internal.h +4
-0+* @binary_bits: number of fixed-point binary bits from architecture, +* only valid if @is_floating_point is true * @enabled: true if the event is enabled */ struct mon_evt {@@ -71,6 +74,8 @@ struct mon_evt {u32 evt_cfg;bool configurable;bool any_cpu; +bool is_floating_point; +unsigned int binary_bits;bool enabled; };
fs/resctrl/internal.h extern struct mon_evt mon_event_all[QOS_NUM_EVENTS]; · line 89
Quoted 6 lines
fs/resctrl/internal.h +3
-0@@ -79,6 +84,9 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];#define for_each_mon_event (mevt) for (mevt = &mon_event_all[QOS_FIRST_EVENT]; \ mevt < &mon_event_all[QOS_NUM_EVENTS]; mevt++) +/* Limit for mon_evt::binary_bits */ +#define MAX_BINARY_BITS 27 +
Could this be up to 30?
(The formatting code relies on the the product of the maximum fraction value with 10^decplaces[] not exceeding a u64, so I think 30 bits fits? But this only has to be as large as the largest value required by some supported piece of hardware... I didn't go check on that.)
Quoted 39 lines
fs/resctrl/internal.h +0
-0/** * struct mon_data - Monitoring details for each event file. * @list: Member of the global @mon_data_kn_priv_list list. arch/x86/kernel/cpu/resctrl/core.c +3
-3@@ -893,15 +893,15 @@ static __init bool get_rdt_mon_resources(void)bool ret = false;if (rdt_cpu_has (X86_FEATURE_CQM_OCCUP_LLC )) { -resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_TOTAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_LOCAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_ABMC ))fs/resctrl/ctrlmondata.c +1
-0@@ -17,6 +17,7 @@#include <linux/cpu.h> #include <linux/kernfs.h> +#include <linux/math.h> #include <linux/seq_file.h> #include <linux/slab.h> #include <linux/tick.h>
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 605
Quoted 8 lines
fs/resctrl/ctrlmondata.c +5
-0@@ -597,6 +598,87 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,resctrl_arch_mon_ctx_free (r, evt->evtid, rr->arch_mon_ctx); } +/* +* Decimal place precision to use for each number of fixed-point +* binary bits. +*/ +static unsigned int decplaces[MAX_BINARY_BITS +1 ] = {
^ const
Also, maybe explicitly initialise
[0] = 1,
here? (See print_event_value().)
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 615
Quoted 10 lines
fs/resctrl/ctrlmondata.c +10
-0+ [1] = 1, + [2] = 2, + [3] = 3, + [4] = 3, + [5] = 3, + [6] = 3, + [7] = 3, + [8] = 3, + [9] = 3, + [10] = 4,
Why these specific values?
ceil(binary_bits * log10(2)) makes sense if we want to expose all available hardware precision with as few digits as possible.
floor(binary_bits * log10(2)) makes sense if we want expose as many digits as possible without advertising spurious precision.
Disregarding the special-casing for binary_bits <= 3, still neither option quite seems to match this list.
Rounding up means that the hardware value can be reconstructed, but only if userspace knows the value of binary_bits. Should that be exposed?
Quoted 7 lines
fs/resctrl/ctrlmondata.c +7
-0+ [11] = 4, + [12] = 4, + [13] = 5, + [14] = 5, + [15] = 5, + [16] = 6, + [17] = 6,
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 632
Quoted 10 lines
fs/resctrl/ctrlmondata.c +10
-0+ [18] = 6, + [19] = 7, + [20] = 7, + [21] = 7, + [22] = 8, + [23] = 8, + [24] = 8, + [25] = 9, + [26] = 9, + [27 ] =9
Documenting the rule for generating these may be a good idea unless we are sure that no more entries will never be added.
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 638
Quoted 6 lines
fs/resctrl/ctrlmondata.c +6
-0+}; + +static void print_event_value (struct seq_file *m,unsigned int binary_bits,u64 val) +{ +unsigned long long frac; +char buf[10 ];
In place of the magic number 10, how about
decplaces[MAX_BINARY_BITS] + 1 ?
(I think the compiler should accept that as an initialiser if the array is const.)
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }
Can an initialiser for decplaces[0] reduce the special-casing for binary_bits == 0?
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 646
Quoted 3 lines
fs/resctrl/ctrlmondata.c +3
-0+ +/* Mask off the integer part of the fixed-point value. */ + frac = val &GENMASK_ULL (binary_bits,0 );
Should this be GENMASK_ULL(binary_bits - 1, 0)?
Should we be telling userspace the binary_bits value? It is not (exactly) deducible from the number of decimal places printed.
It depends on the use cases and what the code is trying to achieve, but this does not seem to be described in detail, unless I've missed it somewhere.
Quoted 17 lines
fs/resctrl/ctrlmondata.c +17
-0+ +/* +* Multiply by 10^{desired decimal places}. The integer part of +* the fixed point value is now almost what is needed. +*/ + frac *=int_pow (10ull , decplaces[binary_bits]); + +/* +* Round to nearest by adding a value that would be a "1" in the +* binary_bits + 1 place. Integer part of fixed point value is +* now the needed value. +*/ + frac +=1ull << (binary_bits -1 ); + +/* +* Extract the integer part of the value. This is the decimal +* representation of the original fixed-point fractional value.
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 673
Quoted 10 lines
fs/resctrl/ctrlmondata.c +10
-0+*/ + frac >>= binary_bits; + +/* +* "frac" is now in the range [0 .. 10^decplaces). I.e. string +* representation will fit into chosen number of decimal places. +*/ +snprintf (buf,sizeof (buf),"%0*llu" , decplaces[binary_bits], frac); + +/* Trim trailing zeroes */
Why?
Would it be better to present the values with consistent precision?
There's no reason why a telemetry counter should settle for any length of time at a tidy value, so the precision represented by the trailing zeros is always significant.
The hardware precision doesn't go up and down depending on the precise value of the counter...
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 681
Quoted 8 lines
fs/resctrl/ctrlmondata.c +8
-0+for (int i = decplaces[binary_bits] -1 ; i >0 ; i--) { +if (buf[i] !='0' ) +break ; + buf[i] ='\0' ; + } +seq_printf (m,"%llu.%s\n" , val >> binary_bits, buf); +} +
[...]
Cheers
---Dave
Luck, Tony
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Dave,
Thanks for taking time to review. You did unearth one big bug and I'm super-grateful for that.
Quoted 19 lines · Dave Martin
Hi Tony,
A few drive-by nits from me -- apologies, I hadn't looked at this in a while.
Quoted 13 lines · Tony Luck
resctrl assumes that all monitor events can be displayed as unsigned decimal integers.
Hardware architecture counters may provide some telemetry events with greater precision where the event is not a simple count, but is a measurement of some sort (e.g. Joules for energy consumed).
Add a new argument to
resctrl_enable_mon_event()for architecture code to inform the file system that the value for a counter is a fixed-point value with a specific number of binary places.
Only allow architecture to use floating point format on events that the file system has marked withmon_evt::is_floating_point.
Quoted 5 lines
Quoted 3 lines
Display fixed point values with values rounded to an appropriate number of decimal places for the precision of the number of binary places provided. Add one extra decimal place for every three additional binary
(Is this just informal wording? If not, it's wrong...)
Informal. It isn't far off from the table. Once out of the small numbers the number of decimal places does increment after each group of three.
Quoted 10 lines
Quoted 7 lines
places, except for low precision binary values where exact representation is possible:
1 binary place is 0.0 or 0.5 => 1 decimal place
2 binary places is 0.0, 0.25, 0.5, 0.75 => 2 decimal places
3 binary places is 0.0, 0.125, etc. => 3 decimal placesWhat's the rationale for this special treatment? I don't see any previous discussion (apologies if I missed it).
The strict log10(2) calculations below throw away some precision from these cases. I thought that was bad.
Quoted 37 lines
Quoted 30 lines
Signed-off-by Tony Luck <[email protected]>Reviewed-by Reinette Chatre <[email protected]>--- include/linux/resctrl.h | 3 +- fs/resctrl/internal.h | 8 +++ arch/x86/kernel/cpu/resctrl/core.c | 6 +-- fs/resctrl/ctrlmondata.c | 84 ++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 10 +++- 5 files changed, 105 insertions(+), 6 deletions(-)include/linux/resctrl.h +2
-1@@ -409,7 +409,8 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r);u32 resctrl_arch_system_num_rmid_idx (void );int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid); -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu); +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, +unsigned int binary_bits);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);fs/resctrl/internal.h +0
-0fs/resctrl/internal.h static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc) · line 65
Quoted 4 lines
fs/resctrl/internal.h +1
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format Nit: Maybe rebrand this as
is_fixed_point, oris_fractional, or similar?
Quoted 2 lines
The print syntax is just a decimal fraction, and the hardware representation is fixed-point. Nothing floats.
You are right. I can change from is_floating_point to is_fixed_point.
Quoted 18 lines
Quoted 18 lines
fs/resctrl/internal.h +4
-0+* @binary_bits: number of fixed-point binary bits from architecture, +* only valid if @is_floating_point is true * @enabled: true if the event is enabled */ struct mon_evt {@@ -71,6 +74,8 @@ struct mon_evt {u32 evt_cfg;bool configurable;bool any_cpu; +bool is_floating_point; +unsigned int binary_bits;bool enabled; };@@ -79,6 +84,9 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];#define for_each_mon_event (mevt) for (mevt = &mon_event_all[QOS_FIRST_EVENT]; \ mevt < &mon_event_all[QOS_NUM_EVENTS]; mevt++)
Quoted 5 lines
fs/resctrl/internal.h extern struct mon_evt mon_event_all[QOS_NUM_EVENTS]; · line 89
Quoted 3 lines
fs/resctrl/internal.h +3
-0+/* Limit for mon_evt::binary_bits */ +#define MAX_BINARY_BITS 27 +Could this be up to 30?
Yes.
Quoted 4 lines
(The formatting code relies on the the product of the maximum fraction value with 10^decplaces[] not exceeding a u64, so I think 30 bits fits? But this only has to be as large as the largest value required by some supported piece of hardware... I didn't go check on that.)
I only have one data point. The Intel telemetry events are using 18 binary places.
Quoted 42 lines
Quoted 42 lines
fs/resctrl/internal.h +0
-0/** * struct mon_data - Monitoring details for each event file. * @list: Member of the global @mon_data_kn_priv_list list. arch/x86/kernel/cpu/resctrl/core.c +3
-3@@ -893,15 +893,15 @@ static __init bool get_rdt_mon_resources(void)bool ret = false;if (rdt_cpu_has (X86_FEATURE_CQM_OCCUP_LLC )) { -resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_TOTAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_LOCAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false); +resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false,0 ); ret = true; }if (rdt_cpu_has (X86_FEATURE_ABMC ))fs/resctrl/ctrlmondata.c +1
-0@@ -17,6 +17,7 @@#include <linux/cpu.h> #include <linux/kernfs.h> +#include <linux/math.h> #include <linux/seq_file.h> #include <linux/slab.h> #include <linux/tick.h> @@ -597,6 +598,87 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,resctrl_arch_mon_ctx_free (r, evt->evtid, rr->arch_mon_ctx); }
Quoted 7 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 605
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+/* +* Decimal place precision to use for each number of fixed-point +* binary bits. +*/ +static unsigned int decplaces[MAX_BINARY_BITS +1 ] = {^ const
OK
Quoted 4 lines
Also, maybe explicitly initialise
[0] = 1,
OK (though this might only occur if there is an event that resctrl says must be fixed point, with a h/w implementation that provides a simple integer).
Quoted 14 lines
here? (See
print_event_value().)fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 615
Quoted 10 lines
fs/resctrl/ctrlmondata.c +10
-0+ [1] = 1, + [2] = 2, + [3] = 3, + [4] = 3, + [5] = 3, + [6] = 3, + [7] = 3, + [8] = 3, + [9] = 3, + [10] = 4,Why these specific values?
For 1, 2, 3 binary bits you get an exact decimal representation with 1, 2, 3 decimal places. I kept the "3" going from 4 to 9 bits because it should output at least as many places as 3 bits.
After that I started stepping every 3 extra bits.
Quoted 8 lines
ceil(binary_bits * log10(2))makes sense if we want to expose all available hardware precision with as few digits as possible.
floor(binary_bits * log10(2))makes sense if we want expose as many digits as possible without advertising spurious precision.Disregarding the special-casing for
binary_bits<= 3, still neither option quite seems to match this list.
Side-by-side comparion:
#include <stdio.h>
#include <math.h>
static unsigned int tony[] = {
[0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 3, [5] = 3,
[6] = 3, [7] = 3, [8] = 3, [9] = 3, [10] = 4, [11] = 4,
[12] = 4, [13] = 5, [14] = 5, [15] = 5, [16] = 6, [17] = 6,
[18] = 6, [19] = 7, [20] = 7, [21] = 7, [22] = 8, [23] = 8,
[24] = 8, [25] = 9, [26] = 9, [27] = 9
};int main(void)
{
int binary_bits;
double log10_2 = log10(2.0);
printf("bits:\tceil\tfloor\ttony\n");
for (binary_bits = 0; binary_bits < 28; binary_bits++)
printf("%d:\t%d\t%d\t%d\n",
binary_bits,
(int)ceil(binary_bits * log10_2),
(int)floor(binary_bits * log10_2),
tony[binary_bits]);
return 0;
}bits: ceil floor tony
0: 0 0 0
1: 1 0 1
2: 1 0 2
3: 1 0 3
4: 2 1 3
5: 2 1 3
6: 2 1 3
7: 3 2 3
8: 3 2 3
9: 3 2 3
10: 4 3 4
11: 4 3 4
12: 4 3 4
13: 4 3 5
14: 5 4 5
15: 5 4 5
16: 5 4 6
17: 6 5 6
18: 6 5 6
19: 6 5 7
20: 7 6 7
21: 7 6 7
22: 7 6 8
23: 7 6 8
24: 8 7 8
25: 8 7 9
26: 8 7 9
27: 9 8 9
I'm not a fan of the "floor" option. Looks like it loses precision. Terrible for 1-3 binary bits. Also not what I'd like for the bits==18 case that I currently care about.
"ceil" is good for bits > 6. Almost matches my numbers (except I jump to one more decimal place one binary bit earlier).
What do you think of me swapping out the values from 7 upwards for the ceil values and documenting that 0..6 are hand-picked, but 7 and up are ceil(binary_bits * log10_2)?
Quoted 4 lines
Rounding up means that the hardware value can be reconstructed, but only if userspace knows the value of
binary_bits. Should that be exposed?
I'm not sure I see when users would need to reconstruct the h/w value. General use case for these resctrl events is: read1, sleepN, read2 & compute rate = (read2 - read1) / N
In the case of the Intel telemetry events there is some jitter around the timing of the reads (since events may only be updated every 2ms). So the error bars get big if "N" is small. Which all leads me to believe that a "good enough" approach to representing the event values will be close enough for all use cases.
Quoted 13 lines
Quoted 13 lines
fs/resctrl/ctrlmondata.c +12
-0+ [11] = 4, + [12] = 4, + [13] = 5, + [14] = 5, + [15] = 5, + [16] = 6, + [17] = 6, + [18] = 6, + [19] = 7, + [20] = 7, + [21] = 7, + [22] = 8,
Quoted 8 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 632
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ [23] = 8, + [24] = 8, + [25] = 9, + [26] = 9, + [27 ] =9 Documenting the rule for generating these may be a good idea unless we are sure that no more entries will never be added.
Above proposal - use the ceil function for bits >= 7.
Quoted 10 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 638
Quoted 6 lines
fs/resctrl/ctrlmondata.c +6
-0+}; + +static void print_event_value (struct seq_file *m,unsigned int binary_bits,u64 val) +{ +unsigned long long frac; +char buf[10 ];In place of the magic number 10, how about
decplaces[MAX_BINARY_BITS] + 1 ?
Quoted 2 lines
(I think the compiler should accept that as an initialiser if the array is const.)
If the compiler doesn't barf, then OK.
Quoted 8 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }Can an initialiser for decplaces[0] reduce the special-casing for
binary_bits== 0?
I'll check and see.
Quoted 5 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 646
Quoted 3 lines
fs/resctrl/ctrlmondata.c +3
-0+ +/* Mask off the integer part of the fixed-point value. */ + frac = val &GENMASK_ULL (binary_bits,0 );Should this be
GENMASK_ULL(binary_bits - 1, 0)?
Oops. I think you are right.
Quoted 2 lines
Should we be telling userspace the
binary_bitsvalue? It is not (exactly) deducible from the number of decimal places printed.
I could add another info file for fixed_point events to display this. But I'm not convinced that it would result in users doing anything different.
Assume you just did the "read1, sleepN, read2" and got values of 235.617542 and 338.964815, tell me how things would be different if an info file said that binary_bits was 17 vs. 19?
Quoted 25 lines
It depends on the use cases and what the code is trying to achieve, but this does not seem to be described in detail, unless I've missed it somewhere.
Quoted 21 lines
fs/resctrl/ctrlmondata.c +21
-0+ +/* +* Multiply by 10^{desired decimal places}. The integer part of +* the fixed point value is now almost what is needed. +*/ + frac *=int_pow (10ull , decplaces[binary_bits]); + +/* +* Round to nearest by adding a value that would be a "1" in the +* binary_bits + 1 place. Integer part of fixed point value is +* now the needed value. +*/ + frac +=1ull << (binary_bits -1 ); + +/* +* Extract the integer part of the value. This is the decimal +* representation of the original fixed-point fractional value. +*/ + frac >>= binary_bits; + +/*
Quoted 8 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 673
Quoted 6 lines
fs/resctrl/ctrlmondata.c +6
-0+* "frac" is now in the range [0 .. 10^decplaces). I.e. string +* representation will fit into chosen number of decimal places. +*/ +snprintf (buf,sizeof (buf),"%0*llu" , decplaces[binary_bits], frac); + +/* Trim trailing zeroes */ Why?
It felt good. I'm not wedded to this. Maybe saving a few cycles of kernel CPU time by dropping this would be good.
Quoted 1 line
Would it be better to present the values with consistent precision?
Humans might notice the difference. Apps reading the file aren't going to care.
Quoted 3 lines
There's no reason why a telemetry counter should settle for any length of time at a tidy value, so the precision represented by the trailing zeros is always significant.
But x1 = atof("1.5") and x2 = atof("1.500000") ... can the subsequent use of x1 tell that there was less precision that x2?
Quoted 15 lines
The hardware precision doesn't go up and down depending on the precise value of the counter...
Quoted 8 lines
fs/resctrl/ctrlmondata.c +8
-0+for (int i = decplaces[binary_bits] -1 ; i >0 ; i--) { +if (buf[i] !='0' ) +break ; + buf[i] ='\0' ; + } +seq_printf (m,"%llu.%s\n" , val >> binary_bits, buf); +} +[...]
Quoted 2 lines
Cheers
---Dave
-Tony
Reinette Chatre
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Dave and Tony,
Quoted 2 lines · Tony
Quoted 1 line · Dave Martin
On Wed, Oct 29, 2025 at 09:20:55AM -0700, Tony Luck wrote:
...
Quoted 12 lines
Quoted 12 lines
fs/resctrl/internal.h static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc) · line 65
Quoted 9 lines
fs/resctrl/internal.h +1
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format Nit: Maybe rebrand this as
is_fixed_point, oris_fractional, or similar?
Quoted 5 lines
Quoted 2 lines
The print syntax is just a decimal fraction, and the hardware representation is fixed-point. Nothing floats.
You are right. I can change from
is_floating_pointtois_fixed_point.
This is a fs property though, not hardware, and highlights that the value is displayed in floating point format which is the closest resctrl has to establish a "contract" with user space on what format user space can expect when reading the data as backed with a matching update to resctrl.rst for the events that have this hardcoded by the fs. Whether an architecture uses fixed point format or some other mechanism to determine the value eventually exposed to user space is unique to the architecture.
Reinette
Dave Martin
reviewerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi,
Quoted 26 lines · Reinette Chatre
Hi Dave and Tony,
Quoted 2 lines · Tony
Quoted 1 line · Dave Martin
On Wed, Oct 29, 2025 at 09:20:55AM -0700, Tony Luck wrote:
...
Quoted 12 lines
Quoted 12 lines
fs/resctrl/internal.h static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc) · line 65
Quoted 9 lines
fs/resctrl/internal.h +1
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format Nit: Maybe rebrand this as
is_fixed_point, oris_fractional, or similar?Quoted 5 lines
Quoted 2 lines
The print syntax is just a decimal fraction, and the hardware representation is fixed-point. Nothing floats.
You are right. I can change from
is_floating_pointtois_fixed_point.
Quoted 6 lines
This is a fs property though, not hardware, and highlights that the value is displayed in floating point format which is the closest resctrl has to establish a "contract" with user space on what format user space can expect when reading the data as backed with a matching update to
resctrl.rstfor the events that have this hardcoded by the fs. Whether an architecture uses fixed point format or some other mechanism to determine the value eventually exposed to user space is unique to the architecture.
Sure, getting the docmuentation right is the most important thing, while the internal name for this property is not ABI.
(I don't strongly object to "is_floating_point", even if we expose this in the filesystem, so long as we document carefully what it means.)
Cheers
---Dave
Reinette Chatre
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Dave,
Quoted 36 lines · Dave Martin
Hi,
Quoted 26 lines · Reinette Chatre
Hi Dave and Tony,
Quoted 2 lines · Tony
Quoted 1 line · Dave Martin
On Wed, Oct 29, 2025 at 09:20:55AM -0700, Tony Luck wrote:
...
Quoted 12 lines
Quoted 12 lines
fs/resctrl/internal.h static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc) · line 65
Quoted 9 lines
fs/resctrl/internal.h +1
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format Nit: Maybe rebrand this as
is_fixed_point, oris_fractional, or similar?Quoted 5 lines
Quoted 2 lines
The print syntax is just a decimal fraction, and the hardware representation is fixed-point. Nothing floats.
You are right. I can change from
is_floating_pointtois_fixed_point.Quoted 6 lines
This is a fs property though, not hardware, and highlights that the value is displayed in floating point format which is the closest resctrl has to establish a "contract" with user space on what format user space can expect when reading the data as backed with a matching update to
resctrl.rstfor the events that have this hardcoded by the fs. Whether an architecture uses fixed point format or some other mechanism to determine the value eventually exposed to user space is unique to the architecture.
Quoted 5 lines
Sure, getting the docmuentation right is the most important thing, while the internal name for this property is not ABI.
(I don't strongly object to "
is_floating_point", even if we expose this in the filesystem, so long as we document carefully what it means.)
Highlighting the member name and description in fs/resctrl/internal.h:
@is_floating_point: event values are displayed in floating point format
I consider it important that the description highlights that the event will be displayed to user space as floating point. struct mon_evt that contains this member is internal to resctrl fs and there is no helper available to arch with which @is_floating_point can be changed since this is a contract with user space. I find that having the member name match that description and contract easier to read.
The documentation (resctrl.rst) is updated in patch #32 with below to make this clear:
"core energy" reports a floating point number for the energy (in Joules) ...
...
"activity" also reports a floating point value (in Farads).
I agree that internal names are not ABI and this is evident with the only internal connection to a value displayed as floating point being an internal fixed point fraction number. This can change any time. We have to draw the line somewhere to make it clear how resctrl interacts with user space and I find the event's display property to be appropriate for this.
Reinette
Luck, Tony
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
In reply to Luck, TonyQuoted 5 lines · Tony
Quoted 5 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }
I can't completely escape a test for !binary_bits. Most of the flow works ok (doing nothing, working towards frac == 0 when it comes time for the snprintf()).
But the round-up code:
frac += 1ull << (binary_bits - 1);
goes badly wrong if binary_bits == 0.
I could write it like this:
static void print_event_value(struct seq_file *m, unsigned int binary_bits, u64 val)
{
char buf[decplaces[MAX_BINARY_BITS] + 1];
unsigned long long frac = 0;
if (binary_bits) {
/* Mask off the integer part of the fixed-point value. */
frac = val & GENMASK_ULL(binary_bits - 1, 0);
/*
* Multiply by 10^{desired decimal places}. The integer part of
* the fixed point value is now almost what is needed.
*/
frac *= int_pow(10ull, decplaces[binary_bits]);
/*
* Round to nearest by adding a value that would be a "1" in the
* binary_bits + 1 place. Integer part of fixed point value is
* now the needed value.
*/
frac += 1ull << (binary_bits - 1);
/*
* Extract the integer part of the value. This is the decimal
* representation of the original fixed-point fractional value.
*/
frac >>= binary_bits;
}
/*
* "frac" is now in the range [0 .. 10^decplaces). I.e. string
* representation will fit into chosen number of decimal places.
*/
snprintf(buf, sizeof(buf), "%0*llu", decplaces[binary_bits], frac);
seq_printf(m, "%llu.%s\n", val >> binary_bits, buf);
}-Tony
Dave Martin
reviewerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi,
Quoted 21 lines · Tony
Quoted 5 lines · Tony
Quoted 5 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }I can't completely escape a test for !binary_bits. Most of the flow works ok (doing nothing, working towards frac == 0 when it comes time for the
snprintf()).But the round-up code:
frac += 1ull << (binary_bits - 1);goes badly wrong if
binary_bits== 0.I could write it like this:
static void
print_event_value(struct seq_file *m, unsigned int binary_bits, u64 val)
Quoted 13 lines
{
char buf[decplaces[MAX_BINARY_BITS] + 1];
unsigned long long frac = 0;
if (binary_bits) {
/* Mask off the integer part of the fixed-point value. */
frac = val & GENMASK_ULL(binary_bits - 1, 0);
/*
* Multiply by 10^{desired decimal places}. The integer part of
* the fixed point value is now almost what is needed.
*/
frac *= int_pow(10ull, decplaces[binary_bits]);I guess there was already a discussion on whether it is worth precomputing this multiplier.
int_pow() is not free, but if implemented in the standard way, it should be pretty fast on 64-bit arches (which is all we care about).
(I've not checked.)
Quoted 4 lines
/* * Round to nearest by adding a value that would be a "1" in the * binary_bits + 1 place. Integer part of fixed point value is * now the needed value.
Quoted 8 lines
*/ frac += 1ull << (binary_bits - 1); /* * Extract the integer part of the value. This is the decimal * representation of the original fixed-point fractional value. */ frac >>= binary_bits;
Looks reasonable. It's your call whether this is simpler, I guess.
Quoted 9 lines
} /* * "frac" is now in the range [0 .. 10^decplaces). I.e. string * representation will fit into chosen number of decimal places. */ snprintf(buf, sizeof(buf), "%0*llu", decplaces[binary_bits], frac); seq_printf(m, "%llu.%s\n", val >> binary_bits, buf);
Can we get rid of buf, actually?
I don't see why we can't just do
seq_printf(m, "%llu.%0*llu", val >> binary_bits, decplaces[binary_bits], frac);
...?
This avoids having to care about the size of buf.
seq_file's crystal ball knows how to make its buffer large enough.
Cheers
---Dave
Luck, Tony
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Dave,
Quoted 38 lines · Dave Martin
Hi,
Quoted 21 lines · Tony
Quoted 5 lines · Tony
Quoted 5 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }I can't completely escape a test for !binary_bits. Most of the flow works ok (doing nothing, working towards frac == 0 when it comes time for the
snprintf()).But the round-up code:
frac += 1ull << (binary_bits - 1);goes badly wrong if
binary_bits== 0.I could write it like this:
static void
print_event_value(struct seq_file *m, unsigned int binary_bits, u64 val)Quoted 13 lines
{ char buf[decplaces[MAX_BINARY_BITS] + 1]; unsigned long long frac = 0; if (binary_bits) { /* Mask off the integer part of the fixed-point value. */ frac = val & GENMASK_ULL(binary_bits - 1, 0); /* * Multiply by 10^{desired decimal places}. The integer part of * the fixed point value is now almost what is needed. */ frac *= int_pow(10ull, decplaces[binary_bits]);
Quoted 5 lines
I guess there was already a discussion on whether it is worth precomputing this multiplier.
int_pow()is not free, but if implemented in the standard way, it should be pretty fast on 64-bit arches (which is all we care about).
Earlier versions of the patch had the precomputed value. Reinette pointed me to int_pow(). It is in lib/math/int_pow.c and does seem to be pretty efficient.
Quoted 26 lines
(I've not checked.)
Quoted 4 lines
/* * Round to nearest by adding a value that would be a "1" in the * binary_bits + 1 place. Integer part of fixed point value is * now the needed value.Quoted 8 lines
*/ frac += 1ull << (binary_bits - 1); /* * Extract the integer part of the value. This is the decimal * representation of the original fixed-point fractional value. */ frac >>= binary_bits;Looks reasonable. It's your call whether this is simpler, I guess.
Quoted 8 lines
} /* * "frac" is now in the range [0 .. 10^decplaces). I.e. string * representation will fit into chosen number of decimal places. */ snprintf(buf, sizeof(buf), "%0*llu", decplaces[binary_bits], frac);
Quoted 8 lines
Quoted 1 line
seq_printf(m, "%llu.%s\n", val >> binary_bits, buf);Can we get rid of buf, actually?
I don't see why we can't just do
seq_printf(m, "%llu.%0*llu", val >> binary_bits, decplaces[binary_bits], frac);
The buf[] was only there for trimming the trailing zeroes. Now that is gone the result can be sent directly to seq_printf() as you suggest.
Quoted 9 lines
...?
This avoids having to care about the size of buf.
seq_file's crystal ball knows how to make its buffer large enough.
Cheers
---Dave
-Tony
Dave Martin
reviewerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
In reply to Luck, TonyHi Tony,
Quoted 42 lines · Tony
Hi Dave,
Thanks for taking time to review. You did unearth one big bug and I'm super-grateful for that.
Quoted 19 lines · Dave Martin
Hi Tony,
A few drive-by nits from me -- apologies, I hadn't looked at this in a while.
Quoted 13 lines · Tony Luck
resctrl assumes that all monitor events can be displayed as unsigned decimal integers.
Hardware architecture counters may provide some telemetry events with greater precision where the event is not a simple count, but is a measurement of some sort (e.g. Joules for energy consumed).
Add a new argument to
resctrl_enable_mon_event()for architecture code to inform the file system that the value for a counter is a fixed-point value with a specific number of binary places.
Only allow architecture to use floating point format on events that the file system has marked withmon_evt::is_floating_point.Quoted 5 lines
Quoted 3 lines
Display fixed point values with values rounded to an appropriate number of decimal places for the precision of the number of binary places provided. Add one extra decimal place for every three additional binary
(Is this just informal wording? If not, it's wrong...)
Informal. It isn't far off from the table. Once out of the small numbers the number of decimal places does increment after each group of three.
Quoted 8 lines
Quoted 7 lines
places, except for low precision binary values where exact representation is possible:
1 binary place is 0.0 or 0.5 => 1 decimal place
2 binary places is 0.0, 0.25, 0.5, 0.75 => 2 decimal places
3 binary places is 0.0, 0.125, etc. => 3 decimal places
Quoted 5 lines
Quoted 2 lines
What's the rationale for this special treatment? I don't see any previous discussion (apologies if I missed it).
The strict log10(2) calculations below throw away some precision from these cases. I thought that was bad.
It depends what is meant by "precision".
We can't magic up accuracy that isn't present in the counters, just by including extra digits when formatting.
So long as we format values in such a way that every counter value is formatted in a unique way, we are as precise as it is possible to be.
If I didn't confuse myself, ceil(binary_bits * log10(2)) is the smallest number of fractional decimal digits that provide this guarantee.
(This may seem pedantic -- partly, I was wondering what was so special about implementations with fewer than 3 binary places that they needed special treatment -- I think that still hasn't been answered?)
[...]
Quoted 8 lines
Quoted 5 lines
fs/resctrl/internal.h extern struct mon_evt mon_event_all[QOS_NUM_EVENTS]; · line 89
Quoted 3 lines
fs/resctrl/internal.h +3
-0+/* Limit for mon_evt::binary_bits */ +#define MAX_BINARY_BITS 27 +Could this be up to 30?
Yes.
Quoted 7 lines
Quoted 4 lines
(The formatting code relies on the the product of the maximum fraction value with 10^decplaces[] not exceeding a u64, so I think 30 bits fits? But this only has to be as large as the largest value required by some supported piece of hardware... I didn't go check on that.)
I only have one data point. The Intel telemetry events are using 18 binary places.
Ah, right.
[...]
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
fs/resctrl/ctrlmondata.c +0
-0
[...]
Quoted 112 lines
Quoted 11 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 605
Quoted 9 lines
fs/resctrl/ctrlmondata.c +5
-0@@ -597,6 +598,87 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r,resctrl_arch_mon_ctx_free (r, evt->evtid, rr->arch_mon_ctx); } +/* +* Decimal place precision to use for each number of fixed-point +* binary bits. +*/ +static unsigned int decplaces[MAX_BINARY_BITS +1 ] = {^ const
OK
Quoted 4 lines
Also, maybe explicitly initialise
[0] = 1,OK (though this might only occur if there is an event that resctrl says must be fixed point, with a h/w implementation that provides a simple integer).
Quoted 14 lines
here? (See
print_event_value().)fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 615
Quoted 10 lines
fs/resctrl/ctrlmondata.c +10
-0+ [1] = 1, + [2] = 2, + [3] = 3, + [4] = 3, + [5] = 3, + [6] = 3, + [7] = 3, + [8] = 3, + [9] = 3, + [10] = 4,Why these specific values?
For 1, 2, 3 binary bits you get an exact decimal representation with 1, 2, 3 decimal places. I kept the "3" going from 4 to 9 bits because it should output at least as many places as 3 bits.
After that I started stepping every 3 extra bits.
Quoted 8 lines
ceil(binary_bits * log10(2))makes sense if we want to expose all available hardware precision with as few digits as possible.
floor(binary_bits * log10(2))makes sense if we want expose as many digits as possible without advertising spurious precision.Disregarding the special-casing for
binary_bits<= 3, still neither option quite seems to match this list.Side-by-side comparion:
#include <
stdio.h>
#include <math.h>static unsigned int tony[] = { [0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 3, [5] = 3, [6] = 3, [7] = 3, [8] = 3, [9] = 3, [10] = 4, [11] = 4, [12] = 4, [13] = 5, [14] = 5, [15] = 5, [16] = 6, [17] = 6, [18] = 6, [19] = 7, [20] = 7, [21] = 7, [22] = 8, [23] = 8, [24] = 8, [25] = 9, [26] = 9, [27] = 9 };int main(void)
{ int binary_bits; double log10_2 = log10(2.0); printf("bits:\tceil\tfloor\ttony\n"); for (binary_bits = 0; binary_bits < 28; binary_bits++) printf("%d:\t%d\t%d\t%d\n", binary_bits, (int)ceil(binary_bits * log10_2), (int)floor(binary_bits * log10_2), tony[binary_bits]); return 0; }bits: ceil floor tony
0: 0 0 0
1: 1 0 1
2: 1 0 2
3: 1 0 3
4: 2 1 3
5: 2 1 3
6: 2 1 3
7: 3 2 3
8: 3 2 3
9: 3 2 3
10: 4 3 4
11: 4 3 4
12: 4 3 4
13: 4 3 5
14: 5 4 5
15: 5 4 5
16: 5 4 6
17: 6 5 6
18: 6 5 6
19: 6 5 7
20: 7 6 7
21: 7 6 7
22: 7 6 8
23: 7 6 8
24: 8 7 8
25: 8 7 9
26: 8 7 9
27: 9 8 9
Quoted 1 line
I'm not a fan of the "floor" option. Looks like it loses precision. Terrible for
Loses precision, but does not advertise bogus precision precision beyond the precision in the original value. (This is why it is not standard to print doubles with more then 15 significant digits, even though 17 significant digits are needed for bit-exact reproduction.)
I don't know whether this matters relative to the use cases, but it would be nice to have some rationale.
Quoted 9 lines
1-3 binary bits. Also not what I'd like for the bits==18 case that I currently care about.
"ceil" is good for bits > 6. Almost matches my numbers (except I jump to one more decimal place one binary bit earlier).
What do you think of me swapping out the values from 7 upwards for the ceil values and documenting that 0..6 are hand-picked, but 7 and up are
ceil(binary_bits * log10_2)?
If there is sound rationale for hand-picking some values then yes.
I haven't yet been convinced that there is ;)
(The 7 times table could doubtless be made to look nicer by hand- picking some entries. But it wouldn't be the 7 times table any more.)
Quoted 7 lines
Quoted 3 lines
Rounding up means that the hardware value can be reconstructed, but only if userspace knows the value of
binary_bits. Should that be exposed?I'm not sure I see when users would need to reconstruct the h/w value. General use case for these resctrl events is: read1, sleepN, read2 & compute rate = (read2 - read1) / N
If userspace can reconstruct the original values, it can do this calculation more accurately.
Since the values yielded by read1 and read2 might not differ by very much, the relative error introduced by formatting the values in decimal _might_ be significant.
(If we include enough decimal digits that there is no error, userspace will see unexpectedly coarse granularity in the delta read2 - read1. And this is only practical when the number of fractional bits is small.)
Again, I don't know whether this matters for use cases, but minimising the number of magic numbers and arbitrary tradeoffs feels like it would hide fewer potential surprises...
Quoted 5 lines
In the case of the Intel telemetry events there is some jitter around the timing of the reads (since events may only be updated every 2ms). So the error bars get big if "N" is small. Which all leads me to believe that a "good enough" approach to representing the event values will be close enough for all use cases.
Probably (and in any case, userspace is likely to be a giant hack rather than rigorous statistical analysis).
Still, telling the userspace the actual precision the hardware supports feels easy to do.
(It could be added later on as an extension, though.)
Quoted 60 lines
Quoted 12 lines
Quoted 12 lines
fs/resctrl/ctrlmondata.c +12
-0+ [11] = 4, + [12] = 4, + [13] = 5, + [14] = 5, + [15] = 5, + [16] = 6, + [17] = 6, + [18] = 6, + [19] = 7, + [20] = 7, + [21] = 7, + [22] = 8,Quoted 8 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 632
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ [23] = 8, + [24] = 8, + [25] = 9, + [26] = 9, + [27 ] =9 Documenting the rule for generating these may be a good idea unless we are sure that no more entries will never be added.
Above proposal - use the ceil function for bits >= 7.
Quoted 10 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 638
Quoted 6 lines
fs/resctrl/ctrlmondata.c +6
-0+}; + +static void print_event_value (struct seq_file *m,unsigned int binary_bits,u64 val) +{ +unsigned long long frac; +char buf[10 ];In place of the magic number 10, how about
decplaces[MAX_BINARY_BITS] + 1 ?Quoted 2 lines
(I think the compiler should accept that as an initialiser if the array is const.)
If the compiler doesn't barf, then OK.
Quoted 8 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 643
Quoted 5 lines
fs/resctrl/ctrlmondata.c +5
-0+ +if (!binary_bits) { +seq_printf (m,"%llu.0\n" , val); +return ; + }Can an initialiser for decplaces[0] reduce the special-casing for
binary_bits== 0?I'll check and see.
Quoted 5 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 646
Quoted 3 lines
fs/resctrl/ctrlmondata.c +3
-0+ +/* Mask off the integer part of the fixed-point value. */ + frac = val &GENMASK_ULL (binary_bits,0 );Should this be
GENMASK_ULL(binary_bits - 1, 0)?Oops. I think you are right.
Quoted 2 lines
Should we be telling userspace the
binary_bitsvalue? It is not (exactly) deducible from the number of decimal places printed.
Quoted 7 lines
I could add another info file for
fixed_pointevents to display this. But I'm not convinced that it would result in users doing anything different.Assume you just did the "read1, sleepN, read2" and got values of 235.617542 and 338.964815, tell me how things would be different if an info file said that
binary_bitswas 17 vs. 19?
It changes the error bars, no?
For 17 bits, ± .00000381 (approx.)
For 19 bits, ± .000000953 (approx.)
(i.e., ± 0.5 times the least-significant bit).
Whether it is important / useful to know this is usecase dependent, though.
[...]
Quoted 11 lines
Quoted 3 lines
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 673
Quoted 1 line
fs/resctrl/ctrlmondata.c +1
-0+/* Trim trailing zeroes */ Why?
It felt good. I'm not wedded to this. Maybe saving a few cycles of kernel CPU time by dropping this would be good.
Quoted 1 line
Would it be better to present the values with consistent precision?
Humans might notice the difference. Apps reading the file aren't going to care.
I noticed ;) In that, there is explicit code here that seems to have no function other than to make the output worse (i.e., more unpredictable and with no obvious gain in usefulness).
If the number of digits is the only clue to the size of the error bars in the readings, userspace code might well care about this.
Quoted 7 lines
Quoted 4 lines
There's no reason why a telemetry counter should settle for any length of time at a tidy value, so the precision represented by the trailing zeros is always significant.
But x1 =
atof("1.5")and x2 =atof("1.500000")... can the subsequent use of x1 tell that there was less precision that x2?
Exactly. If knowledge of the error bars is needed, just knowing the nearest real number to the measured value is insufficient.
But the number of digits is all we seem to be giving userspace to go on here -- and we're not presenting that in a predictable way, either (?)
Cheers
---Dave
Luck, Tony
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
On Tue, Nov 11, 2025 at 05:16:22PM +0000, Dave Martin wrote:
... snip
Quoted 16 lines
Quoted 1 line
I'm not a fan of the "floor" option. Looks like it loses precision. Terrible for
Loses precision, but does not advertise bogus precision precision beyond the precision in the original value. (This is why it is not standard to print doubles with more then 15 significant digits, even though 17 significant digits are needed for bit-exact reproduction.)
I don't know whether this matters relative to the use cases, but it would be nice to have some rationale.
Quoted 6 lines
1-3 binary bits. Also not what I'd like for the bits==18 case that I currently care about.
"ceil" is good for bits > 6. Almost matches my numbers (except I jump to one more decimal place one binary bit earlier).
Quoted 7 lines
Quoted 3 lines
What do you think of me swapping out the values from 7 upwards for the ceil values and documenting that 0..6 are hand-picked, but 7 and up are
ceil(binary_bits * log10_2)?If there is sound rationale for hand-picking some values then yes.
I haven't yet been convinced that there is ;)
I don't have a rationale and I've been doing the thing I tell others not to do "getting attached to code that I wrote". I will switch the whole table to the ceil(binary_bits * log10_2) values.
One exception for binary_bits == 0. Back in the v6 version of these patches I printed as a plain integer. Reinette commented[1]:
At this time I understand that it will be clear for which events user space expects floating point numbers. If the architecture in turn does not support any "binary bits" then I think resctrl should still print a floating point number ("x.0") to match user space expectation.
-Tony
Luck, Tony
maintainerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
In reply to Dave MartinQuoted 10 lines · Dave Martin
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 638
Quoted 4 lines
fs/resctrl/ctrlmondata.c +4
-0+static void print_event_value (struct seq_file *m,unsigned int binary_bits,u64 val) +{ +unsigned long long frac; +char buf[10 ];In place of the magic number 10, how about
decplaces[MAX_BINARY_BITS] + 1 ?(I think the compiler should accept that as an initialiser if the array is const.)
The compiler (gcc 15.2.1) accepts without any warnings. But generates different code.
sparse complains:fs/resctrl/ctrlmondata.c:640:45: warning: Variable length array is used.
I may change the hard coded constant to 21 (guaranteed to be big enough for a "long long" plus terminating NUL byte.)
-Tony
Dave Martin
reviewerRe: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
Hi Tony,
Quoted 9 lines · Tony
Quoted 8 lines · Dave Martin
fs/resctrl/ctrlmondata.c void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, · line 638
Quoted 4 lines
fs/resctrl/ctrlmondata.c +4
-0+static void print_event_value (struct seq_file *m,unsigned int binary_bits,u64 val) +{ +unsigned long long frac; +char buf[10 ];In place of the magic number 10, how about
decplaces[MAX_BINARY_BITS] + 1 ?
Quoted 8 lines
Quoted 2 lines
(I think the compiler should accept that as an initialiser if the array is const.)
The compiler (gcc 15.2.1) accepts without any warnings. But generates different code.
sparse complains:
fs/resctrl/ctrlmondata.c:640:45: warning: Variable length array is used.
Hmmm. Shame.
(Of course, this is only a warning. sparse may not know how to determine that the resulting buffer is limited to a sane size, but looking at the code makes it pretty obvious. Perhaps best avoided, though.)
Quoted 2 lines
I may change the hard coded constant to 21 (guaranteed to be big enough for a "long long" plus terminating NUL byte.)
I guess. We may be able to sidestep this, though (see my other reply about getting rid of buf[] altogether.)
Cheers
---Dave
Re: [PATCH v13 12/32] x86,fs/resctrl: Support binary fixed point event counters
In reply to Tony LuckQuoted 62 lines · On Wed, 29 Oct 2025 09:20:55 -0700 Tony Luck <[email protected]> wrote:
resctrl assumes that all monitor events can be displayed as unsigned decimal integers.
Hardware architecture counters may provide some telemetry events with greater precision where the event is not a simple count, but is a measurement of some sort (e.g. Joules for energy consumed).
Add a new argument to
resctrl_enable_mon_event()for architecture code to inform the file system that the value for a counter is a fixed-point value with a specific number of binary places.
Only allow architecture to use floating point format on events that the file system has marked withmon_evt::is_floating_point.Display fixed point values with values rounded to an appropriate number of decimal places for the precision of the number of binary places provided. Add one extra decimal place for every three additional binary places, except for low precision binary values where exact representation is possible:
1 binary place is 0.0 or 0.5 => 1 decimal place
2 binary places is 0.0, 0.25, 0.5, 0.75 => 2 decimal places
3 binary places is 0.0, 0.125, etc. => 3 decimal placesSigned-off-by Tony Luck <[email protected]>Reviewed-by Reinette Chatre <[email protected]>--- include/linux/resctrl.h | 3 +- fs/resctrl/internal.h | 8 +++ arch/x86/kernel/cpu/resctrl/core.c | 6 +-- fs/resctrl/ctrlmondata.c | 84 ++++++++++++++++++++++++++++++ fs/resctrl/monitor.c | 10 +++- 5 files changed, 105 insertions(+), 6 deletions(-)include/linux/resctrl.h +2
-1@@ -409,7 +409,8 @@ u32 resctrl_arch_get_num_closid(struct rdt_resource *r);u32 resctrl_arch_system_num_rmid_idx (void );int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid); -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu); +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, +unsigned int binary_bits);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);fs/resctrl/internal.h +3
-0@@ -62,6 +62,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* Only valid if @evtid is an MBM event. * @configurable: true if the event is configurable * @any_cpu: true if the event can be read from any CPU +* @is_floating_point: event values are displayed in floating point format +* @binary_bits: number of fixed-point binary bits from architecture, +* only valid if @is_floating_point is true * @enabled: true if the event is enabled */ struct mon_evt {
fs/resctrl/internal.h struct mon_evt { · line 80
Quoted 7 lines
fs/resctrl/internal.h +2
-0@@ -71,6 +74,8 @@ struct mon_evt {u32 evt_cfg;bool configurable;bool any_cpu; +bool is_floating_point; +unsigned int binary_bits;bool enabled; };
Nit: You've added 4 bytes of padding.
David
Tony Luck
maintainerPATCH v13 13/32 x86,fs/resctrl: Add an architectural hook called for each mount
In reply to Tony LuckEnumeration of Intel telemetry events is an asynchronous process involving several mutually dependent drivers added as auxiliary devices during the device_initcall() phase of Linux boot. The process finishes after the probe functions of these drivers completes. But this happens after resctrl_arch_late_init() is executed.
Tracing the enumeration process shows that it does complete a full seven seconds before the earliest possible mount of the resctrl file system (when included in /etc/fstab for automatic mount by systemd).
Add a hook at the beginning of the mount code that will be used to check for telemetry events and initialize if any are found.
Call the hook on every attempted mount. Expectations are that most actions (like enumeration) will only need to be performed on the first call.
resctrl filesystem calls the hook with no locks held. Architecture code is responsible for any required locking.
--- include/linux/resctrl.h | 6 ++++++ arch/x86/kernel/cpu/resctrl/core.c | 9 +++++++++ fs/resctrl/rdtgroup.c | 2 ++ 3 files changed, 17 insertions(+)
include/linux/resctrl.h +6 -0
@@ -511,6 +511,12 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hvoid resctrl_online_cpu (unsigned int cpu);void resctrl_offline_cpu (unsigned int cpu); +/* +* Architecture hook called at beginning of each file system mount attempt. +* No locks are held. +*/ +void resctrl_arch_pre_mount (void ); +/** * resctrl_arch_rmid_read() - Read the eventid counter corresponding to rmid * for this resource and domain.
arch/x86/kernel/cpu/resctrl/core.c +9 -0
@@ -721,6 +721,15 @@ static int resctrl_arch_offline_cpu(unsigned int cpu)return 0 ; } +void resctrl_arch_pre_mount (void ) +{ +static atomic_t only_once =ATOMIC_INIT (0 ); +int old =0 ; + +if (!atomic_try_cmpxchg (&only_once, &old,1 )) +return ; +} +enum {RDT_FLAG_CMT ,RDT_FLAG_MBM_TOTAL ,
fs/resctrl/rdtgroup.c +2 -0
@@ -2720,6 +2720,8 @@ static int rdt_get_tree(struct fs_context *fc)struct rdt_resource *r;int ret; +resctrl_arch_pre_mount (); +cpus_read_lock ();mutex_lock (&rdtgroup_mutex);/*
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 14/32 x86,fs/resctrl: Add and initialize rdt_resource for package scope monitor
In reply to Tony LuckAdd a new PERF_PKG resource and introduce package level scope for monitoring telemetry events so that CPU hot plug notifiers can build domains at the package granularity.
Use the physical package ID available via topology_physical_package_id() to identify the monitoring domains with package level scope. This enables user space to use:
/sys/devices/system/cpu/cpuX/topology/physical_package_id
to identify the monitoring domain a CPU is associated with.
--- include/linux/resctrl.h | 2 ++ fs/resctrl/internal.h | 2 ++ arch/x86/kernel/cpu/resctrl/core.c | 10 ++++++++++ fs/resctrl/rdtgroup.c | 2 ++ 4 files changed, 16 insertions(+)
include/linux/resctrl.h +2 -0
@@ -53,6 +53,7 @@ enum resctrl_res_level {RDT_RESOURCE_L2 ,RDT_RESOURCE_MBA ,RDT_RESOURCE_SMBA , +RDT_RESOURCE_PERF_PKG ,/* Must be the last */ RDT_NUM_RESOURCES,
@@ -267,6 +268,7 @@ enum resctrl_scope {RESCTRL_L2_CACHE =2 ,RESCTRL_L3_CACHE =3 ,RESCTRL_L3_NODE , + RESCTRL_PACKAGE, };/**
fs/resctrl/internal.h +2 -0
@@ -255,6 +255,8 @@ struct rdtgroup {#define RFTYPE_ASSIGN_CONFIG BIT(11) +#define RFTYPE_RES_PERF_PKG BIT(11) +#define RFTYPE_CTRL_INFO (RFTYPE_INFO | RFTYPE_CTRL)#define RFTYPE_MON_INFO (RFTYPE_INFO | RFTYPE_MON)
arch/x86/kernel/cpu/resctrl/core.c +10 -0
@@ -100,6 +100,14 @@ struct rdt_hw_resource rdt_resources_all[RDT_NUM_RESOURCES] = { .schema_fmt = RESCTRL_SCHEMA_RANGE, }, }, + [RDT_RESOURCE_PERF_PKG ] = + { + .r_resctrl = { + .name ="PERF_PKG" , + .mon_scope =RESCTRL_PACKAGE , + .mon_domains =mon_domain_init (RDT_RESOURCE_PERF_PKG ), + }, + }, };u32 resctrl_arch_system_num_rmid_idx (void )
@@ -435,6 +443,8 @@ static int get_domain_id_from_scope(int cpu, enum resctrl_scope scope)return get_cpu_cacheinfo_id (cpu, scope);case RESCTRL_L3_NODE :return cpu_to_node (cpu); +case RESCTRL_PACKAGE : +return topology_physical_package_id (cpu);default :break ; }
fs/resctrl/rdtgroup.c +2 -0
@@ -2330,6 +2330,8 @@ static unsigned long fflags_from_resource(struct rdt_resource *r)case RDT_RESOURCE_MBA :case RDT_RESOURCE_SMBA :return RFTYPE_RES_MB ; +case RDT_RESOURCE_PERF_PKG : +return RFTYPE_RES_PERF_PKG ; }return WARN_ON_ONCE (1 );
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 14/32] x86,fs/resctrl: Add and initialize rdt_resource for package scope monitor
Hi Tony,
in subject "rdt_resource" -> "struct rdt_resource"
fs/resctrl/internal.h struct rdtgroup { · line 259
Quoted 10 lines · Tony Luck
fs/resctrl/internal.h +2
-0@@ -255,6 +255,8 @@ struct rdtgroup {#define RFTYPE_ASSIGN_CONFIG BIT(11) +#define RFTYPE_RES_PERF_PKG BIT(11) +
This needs a new bit number after rebase on the assignable counter work.
Reinette
Tony Luck
maintainerPATCH v13 15/32 fs/resctrl: Cleanup as L3 is no longer the only monitor resource
In reply to Tony LuckThe feature to sum event data across multiple domains supports systems with Sub-NUMA Cluster (SNC) mode enabled. The top-level monitoring files in each "mon_L3_XX" directory provide the sum of data across all SNC nodes sharing an L3 cache instance while the "mon_sub_L3_YY" sub-directories provide the event data of the individual nodes.
SNC is only associated with the L3 resource and domains and as a result the flow handling the sum of event data implicitly assumes it is working with the L3 resource and domains.
Reading of telemetry events do not require to sum event data so this feature can remain dedicated to SNC and keep the implicit assumption of working with the L3 resource and domains.
Add a WARN to where the implicit assumption of working with the L3 resource is made and add comments on how the structure controlling the event sum feature is used.
--- fs/resctrl/internal.h | 4 ++-- fs/resctrl/ctrlmondata.c | 8 +++++++- fs/resctrl/rdtgroup.c | 3 ++- 3 files changed, 11 insertions(+), 4 deletions(-)
fs/resctrl/internal.h +2 -2
@@ -92,8 +92,8 @@ extern struct mon_evt mon_event_all[QOS_NUM_EVENTS];* @list: Member of the global @mon_data_kn_priv_list list. * @rid: Resource id associated with the event file. * @evt: Event structure associated with the event file. -* @sum: Set when event must be summed across multiple -* domains. +* @sum: Set for RDT_RESOURCE_L3 when event must be summed +* across multiple domains. * @domid: When @sum is zero this is the domain to which * the event file belongs. When @sum is one this * is the id of the L3 cache that all domains to be
fs/resctrl/ctrlmondata.c +7 -1
@@ -683,7 +683,6 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg) {struct kernfs_open_file *of = m->private;enum resctrl_res_level resid; -struct rdt_l3_mon_domain *d;struct rdt_domain_hdr *hdr;struct rmid_read rr = {0 };struct rdtgroup *rdtgrp;
@@ -711,6 +710,13 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg) r =resctrl_arch_get_resource (resid);if (md->sum) { +struct rdt_l3_mon_domain *d; + +if (WARN_ON_ONCE (resid !=RDT_RESOURCE_L3 )) { + ret = -EINVAL ; + goto out; + } +/* * This file requires summing across all domains that share * the L3 cache id that was provided in the "domid" field of the
fs/resctrl/rdtgroup.c +2 -1
@@ -3030,7 +3030,8 @@ static void rmdir_all_sub(void)* @rid: The resource id for the event file being created. * @domid: The domain id for the event file being created. * @mevt: The type of event file being created. -* @do_sum: Whether SNC summing monitors are being created. +* @do_sum: Whether SNC summing monitors are being created. Only set +* when @rid == RDT_RESOURCE_L3. */ static struct mon_data *mon_get_kn_priv(enum resctrl_res_level rid, int domid, struct mon_evt *mevt,
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 15/32] fs/resctrl: Cleanup as L3 is no longer the only monitor resource
Hi Tony,
I do not see how the subject matches this patch. How about something like:
"fs/resctrl: Emphasize that L3 monitoring resource is required for summing domains"
Quoted 14 lines · Tony Luck
The feature to sum event data across multiple domains supports systems with Sub-NUMA Cluster (SNC) mode enabled. The top-level monitoring files in each "
mon_L3_XX" directory provide the sum of data across all SNC nodes sharing an L3 cache instance while the "mon_sub_L3_YY" sub-directories provide the event data of the individual nodes.SNC is only associated with the L3 resource and domains and as a result the flow handling the sum of event data implicitly assumes it is working with the L3 resource and domains.
Reading of telemetry events do not require to sum event data so this feature can remain dedicated to SNC and keep the implicit assumption of working with the L3 resource and domains.
Quoted 7 lines
Add a WARN to where the implicit assumption of working with the L3 resource is made and add comments on how the structure controlling the event sum feature is used.
Suggested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
| Reviewed-by: Reinette Chatre <[email protected]>
Reinette
Tony Luck
maintainerPATCH v13 16/32 x86/resctrl: Discover hardware telemetry events
In reply to Tony LuckEach CPU collects data for telemetry events that it sends to the nearest telemetry event aggregator either when the value of MSR_IA32_PQR_ASSOC.RMID changes, or when a two millisecond timer expires.
There is a guid and an MMIO region associated with each aggregator. The combination of the guid and the size of the MMIO region link to an XML description of the set of telemetry events tracked by the aggregator. XML files are published by Intel in a GitHub repository [1].
The telemetry event aggregators maintain per-RMID per-event counts of the total seen for all the CPUs. There may be multiple telemetry event aggregators per package.
There are separate sets of aggregators for each type of event, but all aggregators with the same guid are symmetric keeping counts for the same set of events for the CPUs that provide data to them.
The XML file for each aggregator provides the following information:
1) Which telemetry events are included in the group.
2) The order in which the event counters appear for each RMID.
3) The value type of each event counter (integer or fixed-point).
4) The number of RMIDs supported.
5) Which additional aggregator status registers are included.
6) The total size of the MMIO region for an aggregator.
The resctrl implementation condenses the relevant information from the XML file into some of the fields of struct event_group.
The INTEL_PMT_TELEMETRY driver enumerates support for telemetry events. This driver provides intel_pmt_get_regions_by_feature() to list all available telemetry event aggregators of a given enum pmt_feature_id type. The list includes the "guid", the base address in MMIO space for the region where the event counters are exposed, and the package id where the all the CPUs that report to this aggregator are located.
A theoretical example struct pmt_feature_group returned from the INTEL_PMT_TELEMETRY driver for events of type FEATURE_PER_RMID_PERF_TELEM could look like this:
+-------------------------------+ | count = 6 | +-------------------------------+ | [0] guid_1 size_1 pkg1 addr_1 | +-------------------------------+ | [1] guid_1 size_1 pkg2 addr_2 | +-------------------------------+ | [2] guid_2 size_2 pkg1 addr_3 | +-------------------------------+ | [3] guid_2 size_2 pkg1 addr_4 | +-------------------------------+ | [4] guid_2 size_2 pkg2 addr_5 | +-------------------------------+ | [5] guid_2 size_2 pkg2 addr_6 | +-------------------------------+
This provides details for "perf" aggregators with two guids. If resctrl has an event_group for both of these guids it will get two copies of this struct pmt_feature_group by calling intel_pmt_get_regions_by_feature() once for each. event_group::pfg will point to the copy acquired from each call.
On the call for guid1 it will see there is just one aggregator per package for guid_1. So resctrl can read event counts from the MMIO addr_1 on package 1 and addr_2 on package 2.
There are two aggregators listed on each package for guid_2. So resctrl must read counters from addr_3 and addr_4 and sum them to provide result for package
1. Similarly addr_5 and addr_6 must be read and summed for event counts on package 2.
resctrl will silently ignore unknown guid values.
Add a new Kconfig option CONFIG_X86_CPU_RESCTRL_INTEL_AET for the Intel specific parts of telemetry code. This depends on the INTEL_PMT_TELEMETRY and INTEL_TPMI drivers being built-in to the kernel for enumeration of telemetry features.
Call INTEL_PMT_TELEMETRY's intel_pmt_get_regions_by_feature() for each guid known to resctrl (using the appropriate enum pmt_feature_id argument for that guid) to obtain a private copy of struct pmt_feature_group that contains all discovered/enumerated telemetry aggregator data for all event groups (known and unknown to resctrl) of that pmt_feature_id. Further processing on this structure will enable all supported events in resctrl.
Return the struct pmt_feature_group to INTEL_PMT_TELEMETRY at resctrl exit time.
--- arch/x86/kernel/cpu/resctrl/internal.h | 8 ++ arch/x86/kernel/cpu/resctrl/core.c | 5 + arch/x86/kernel/cpu/resctrl/intel_aet.c | 122 ++++++++++++++++++++++++ arch/x86/Kconfig | 13 +++ arch/x86/kernel/cpu/resctrl/Makefile | 1 + 5 files changed, 149 insertions(+) create mode 100644 arch/x86/kernel/cpu/resctrl/intel_aet.c
arch/x86/kernel/cpu/resctrl/internal.h +8 -0
@@ -217,4 +217,12 @@ void __init intel_rdt_mbm_apply_quirk(void);void rdt_domain_reconfigure_cdp (struct rdt_resource *r);void resctrl_arch_mbm_cntr_assign_set_one (struct rdt_resource *r); +#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET +bool intel_aet_get_events (void ); +void __exit intel_aet_exit(void); +#else +static inline bool intel_aet_get_events (void ) {return false; } +static inline void __exit intel_aet_exit(void) { } +#endif +#endif /* _ASM_X86_RESCTRL_INTERNAL_H */
arch/x86/kernel/cpu/resctrl/core.c +5 -0
@@ -738,6 +738,9 @@ void resctrl_arch_pre_mount(void)if (!atomic_try_cmpxchg (&only_once, &old,1 ))return ; + +if (!intel_aet_get_events ()) +return ; }enum {
@@ -1095,6 +1098,8 @@ late_initcall(resctrl_arch_late_init); static void __exit resctrl_arch_exit(void) { +intel_aet_exit (); +cpuhp_remove_state (rdt_online);resctrl_exit ();
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +122 -0
122 lines not on this page · raw message
arch/x86/Kconfig +13 -0
@@ -536,6 +536,19 @@ config X86_CPU_RESCTRL Say N if unsure. +config X86_CPU_RESCTRL_INTEL_AET + bool "Intel Application Energy Telemetry" + depends on X86_CPU_RESCTRL && CPU_SUP_INTEL && INTEL_PMT_TELEMETRY=y && INTEL_TPMI=y + help + Enable per-RMID telemetry events in resctrl. + + Intel feature that collects per-RMID execution data + about energy consumption, measure of frequency independent + activity and other performance metrics. Data is aggregated + per package. + + Say N if unsure. + config X86_FRED bool "Flexible Return and Event Delivery" depends on X86_64
arch/x86/kernel/cpu/resctrl/Makefile +1 -0
@@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_X86_CPU_RESCTRL) += core.o rdtgroup.o monitor.o obj-$(CONFIG_X86_CPU_RESCTRL) += ctrlmondata.o +obj-$(CONFIG_X86_CPU_RESCTRL_INTEL_AET) += intel_aet.o obj-$(CONFIG_RESCTRL_FS_PSEUDO_LOCK) += pseudo_lock.o # To allow define_trace.h's recursive include:
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 16/32] x86/resctrl: Discover hardware telemetry events
Hi Tony,
Quoted 5 lines · Tony Luck
Each CPU collects data for telemetry events that it sends to the nearest telemetry event aggregator either when the value of MSR_IA32_PQR_ASSOC.RMID changes, or when a two millisecond timer expires.
There is a guid and an MMIO region associated with each aggregator. The
Could this be:
There is a feature type ("energy" or "perf"), guid, and MMIO region associated with each aggregator. This combination links to an XML ...
Quoted 9 lines
combination of the guid and the size of the MMIO region link to an XML description of the set of telemetry events tracked by the aggregator. XML files are published by Intel in a GitHub repository [1].
The telemetry event aggregators maintain per-RMID per-event counts of the total seen for all the CPUs. There may be multiple telemetry event aggregators per package.
There are separate sets of aggregators for each type of event, but all
"type of event" -> "feature type, for example "perf" or "energy". All ..."
Would this be accurate:
There are separate sets of aggregators for each feature type. Aggregators in a set may have different guids. All aggregators with the same feature type and guid are symmetric ...
Quoted 4 lines
aggregators with the same guid are symmetric keeping counts for the same set of events for the CPUs that provide data to them.
The XML file for each aggregator provides the following information:
Would this be accurate?
"0) Feature type of the events ("perf" or "energy")"?
Quoted 1 line
1) Which telemetry events are included in the group.
"included in the group" -> "tracked by the aggregator"?
Quoted 8 lines
2) The order in which the event counters appear for each RMID.
3) The value type of each event counter (integer or fixed-point).
4) The number of RMIDs supported.
5) Which additional aggregator status registers are included.
6) The total size of the MMIO region for an aggregator.The resctrl implementation condenses the relevant information from the XML file into some of the fields of struct
event_group.
(above implies struct event_group already exists)
How about:
"Introduce struct event_group that condenses the relevant information from an XML file. Hereafter an "event group" refers to a group of events of a particular feature type ("energy" or "perf") with a particular guid."
(Above also tries to give definition to "event group" mentioned in v12, please do correct and feel free to improve)
Quoted 3 lines
The
INTEL_PMT_TELEMETRYdriver enumerates support for telemetry events. This driver providesintel_pmt_get_regions_by_feature()to list all available telemetry event aggregators of a given enumpmt_feature_idtype. The list includes the
(at this point it should be clear what "feature type" means). "enum pmt_feature_id type" -> "feature type"
Quoted 4 lines
"guid", the base address in MMIO space for the region where the event counters are exposed, and the package id where the all the CPUs that report to this aggregator are located.
The example below describes behavior of implementation in a particular scenario before introducing the implementation self. I think the general changelog can help to explain that such a scenario is possible and I tried to do so with the earlier sample text. If you feel that this example is still helpful then I would propose it be placed at the end of the changelog, after general description of implementation, with a heading that reader can use to decide whether to read or skip what follows. Placing it in maintainer notes is also an option.
Quoted 34 lines
A theoretical example struct
pmt_feature_groupreturned from theINTEL_PMT_TELEMETRYdriver for events of typeFEATURE_PER_RMID_PERF_TELEMcould look like this:+-------------------------------+ | count = 6 | +-------------------------------+ | [0] guid_1 size_1 pkg1 addr_1 | +-------------------------------+ | [1] guid_1 size_1 pkg2 addr_2 | +-------------------------------+ | [2] guid_2 size_2 pkg1 addr_3 | +-------------------------------+ | [3] guid_2 size_2 pkg1 addr_4 | +-------------------------------+ | [4] guid_2 size_2 pkg2 addr_5 | +-------------------------------+ | [5] guid_2 size_2 pkg2 addr_6 | +-------------------------------+This provides details for "perf" aggregators with two guids. If resctrl has an
event_groupfor both of these guids it will get two copies of this structpmt_feature_groupby callingintel_pmt_get_regions_by_feature()once for each.event_group::pfgwill point to the copy acquired from each call.On the call for guid1 it will see there is just one aggregator per package for
guid_1. So resctrl can read event counts from the MMIOaddr_1on package 1 andaddr_2on package 2.There are two aggregators listed on each package for
guid_2. So resctrl must read counters fromaddr_3andaddr_4and sum them to provide result for package" t
1. Similarlyaddr_5andaddr_6must be read and summed for event counts on package 2.
Quoted 6 lines
resctrl will silently ignore unknown guid values.
Add a new
KconfigoptionCONFIG_X86_CPU_RESCTRL_INTEL_AETfor the Intel specific parts of telemetry code. This depends on theINTEL_PMT_TELEMETRYandINTEL_TPMIdrivers being built-in to the kernel for enumeration of telemetry features.
The paragraph below seems better suited to follow right after the "The INTEL_PMT_TELEMETRY driver enumerates support ..." paragraph.
Quoted 3 lines
Call INTEL_PMT_TELEMETRY's
intel_pmt_get_regions_by_feature()for each guid known to resctrl (using the appropriate enumpmt_feature_idargument for that guid) to obtain a private copy of structpmt_feature_groupthat contains all
"each guid known to resctrl (using the appropriate enum pmt_feature_id argument for that guid)" -> "each event group"?
Quoted 3 lines
discovered/enumerated telemetry aggregator data for all event groups (known and unknown to resctrl) of that
pmt_feature_id. Further processing on this structure will enable all supported events in resctrl.
I think the above tries to be too specific in what the code does while also trying to explain the flow at a high level. I find the result difficult to parse. Consider something like:
Call INTEL_PMT_TELEMETRY's intel_pmt_get_regions_by_feature() for each event group to obtain a private copy of that event group's aggregator data. Duplicate the aggregator data between event groups that have the same feature type but different guid. Further processing on this private copy will be unique to the event group.
Return the aggregator data to INTEL_PMT_TELEMETRY at resctrl exit time.
Quoted 79 lines
Return the struct
pmt_feature_grouptoINTEL_PMT_TELEMETRYat resctrl exit time.Signed-off-by Tony Luck <[email protected]>Link https://github.com/intel/Intel-PMT # [1]--- arch/x86/kernel/cpu/resctrl/internal.h | 8 ++ arch/x86/kernel/cpu/resctrl/core.c | 5 + arch/x86/kernel/cpu/resctrl/intel_aet.c | 122 ++++++++++++++++++++++++ arch/x86/Kconfig | 13 +++ arch/x86/kernel/cpu/resctrl/Makefile | 1 + 5 files changed, 149 insertions(+) create mode 100644 arch/x86/kernel/cpu/resctrl/intel_aet.carch/x86/kernel/cpu/resctrl/internal.h +8
-0@@ -217,4 +217,12 @@ void __init intel_rdt_mbm_apply_quirk(void);void rdt_domain_reconfigure_cdp (struct rdt_resource *r);void resctrl_arch_mbm_cntr_assign_set_one (struct rdt_resource *r); +#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET +bool intel_aet_get_events (void ); +void __exit intel_aet_exit(void); +#else +static inline bool intel_aet_get_events (void ) {return false; } +static inline void __exit intel_aet_exit(void) { } +#endif +#endif /* _ASM_X86_RESCTRL_INTERNAL_H */ arch/x86/kernel/cpu/resctrl/core.c +5
-0@@ -738,6 +738,9 @@ void resctrl_arch_pre_mount(void)if (!atomic_try_cmpxchg (&only_once, &old,1 ))return ; + +if (!intel_aet_get_events ()) +return ; }enum {@@ -1095,6 +1098,8 @@ late_initcall(resctrl_arch_late_init); static void __exit resctrl_arch_exit(void) { +intel_aet_exit (); +cpuhp_remove_state (rdt_online);resctrl_exit ();arch/x86/kernel/cpu/resctrl/intel_aet.c new file +19
-0@@ -0,0 +1,122 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* Resource Director Technology(RDT) +* - Intel Application Energy Telemetry +* +* Copyright (C) 2025 Intel Corporation +* +* Author: +* Tony Luck <[email protected]> +*/ + +#define pr_fmt (fmt) "resctrl: " fmt + +#include <linux/array_size.h> +#include <linux/cleanup.h> +#include <linux/cpu.h> +#include <linux/err.h> +#include <linux/init.h> +#include <linux/intel_pmt_features.h>
arch/x86/kernel/cpu/resctrl/intel_aet.c line 29
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +10
-0+#include <linux/intel_vsec.h> +#include <linux/overflow.h> +#include <linux/resctrl.h> +#include <linux/stddef.h> +#include <linux/types.h> + +#include "internal.h" + +/** +* struct event_group - All information about a group of telemetry events.
Trying to answer my own question from v12. How about:
"Events with the same feature type ("energy" or "perf") and guid"
arch/x86/kernel/cpu/resctrl/intel_aet.c line 31
Quoted 2 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +2
-0+* @feature: Argument to intel_pmt_get_regions_by_feature() to +* discover if this event_group is supported.
"discover if this event_group is supported" - this does not seem accurate (and
contradicts the @pfg description)
How about just:
"Type of events, for example FEATURE_PER_RMID_PERF_TELEM or FEATURE_PER_RMID_ENERGY_TELEM, in this group."
arch/x86/kernel/cpu/resctrl/intel_aet.c line 35
Quoted 4 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +4
-0+* @pfg: Points to the aggregated telemetry space information +* returned by the intel_pmt_get_regions_by_feature() +* call to the INTEL_PMT_TELEMETRY driver that contains +* data for all telemetry regions of a specific type.
"of a specific type" -> "of type @feature"
Quoted 25 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +25
-0+* Valid if the system supports the event group. +* NULL otherwise. +* @guid: Unique number per XML description file. +*/ +struct event_group { +/* Data fields for additional structures to manage this group. */ +enum pmt_feature_id feature; +struct pmt_feature_group *pfg; + +/* Remaining fields initialized from XML file. */ +u32 guid; +}; + +/* +* Link: https://github.com/intel/Intel-PMT +* File: xml/CWF/OOBMSM/RMID-ENERGY/cwf_aggregator.xml +*/ +static struct event_group energy_0x26696143 = { + .feature =FEATURE_PER_RMID_ENERGY_TELEM , + .guid =0x26696143 , +}; + +/* +* Link: https://github.com/intel/Intel-PMT +* File: xml/CWF/OOBMSM/RMID-PERF/cwf_aggregator.xml
arch/x86/kernel/cpu/resctrl/intel_aet.c line 70
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +10
-0+*/ +static struct event_group perf_0x26557651 = { + .feature =FEATURE_PER_RMID_PERF_TELEM , + .guid =0x26557651 , +}; + +static struct event_group *known_event_groups[] = { + &energy_0x26696143, + &perf_0x26557651, +};
Placing all event groups in same array is a great enhancement.
Quoted 9 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +9
-0+ +#define for_each_event_group (_peg) \ + for (_peg = known_event_groups; \ + _peg < &known_event_groups[ARRAY_SIZE(known_event_groups)]; \ + _peg++) + +/* Stub for now */ +static bool enable_events (struct event_group *e,struct pmt_feature_group *p) +{
arch/x86/kernel/cpu/resctrl/intel_aet.c line 89
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +10
-0+return false; +} + +/* +* Make a request to the INTEL_PMT_TELEMETRY driver for a copy of the +* pmt_feature_group for each known feature. If there is one, the returned +* structure has an array of telemetry_region structures, each element of +* the array describes one telemetry aggregator. +* A single pmt_feature_group may include multiple different guids. +* Try to use every telemetry aggregator with a known guid.
Same feedback as v12.
arch/x86/kernel/cpu/resctrl/intel_aet.c line 92
Quoted 3 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c new file +3
-0+*/ +bool intel_aet_get_events (void ) +{
Reinette
Tony Luck
maintainerPATCH v13 17/32 x86,fs/resctrl: Fill in details of events for guid 0x26696143 and 0x26557651
In reply to Tony LuckThe Intel Clearwater Forest CPU supports two RMID-based PMT feature groups documented in the xml/CWF/OOBMSM/RMID-ENERGY/cwf_aggregator.xml and xml/CWF/OOBMSM/RMID-PERF/cwf_aggregator.xml files in the Intel PMT GIT repository [1].
The struct pmt_feature_group provided by the INTEL_PMT_TELEMETRY driver lists the guid and other information for each aggregator of a given type (energy or perf) present on the system.
resctrl has a condensed form of the XML description in struct event_group. An event group is enabled if the pfg field points to a struct pmt_feature_group.
The counter offsets in MMIO space are arranged in groups for each RMID.
E.g the "energy" counters for guid 0x26696143 are arranged like this:
MMIO offset:0x0000 Counter for RMID 0 PMT_EVENT_ENERGY
MMIO offset:0x0008 Counter for RMID 0 PMT_EVENT_ACTIVITY
MMIO offset:0x0010 Counter for RMID 1 PMT_EVENT_ENERGY
MMIO offset:0x0018 Counter for RMID 1 PMT_EVENT_ACTIVITY
...
MMIO offset:0x23F0 Counter for RMID 575 PMT_EVENT_ENERGY
MMIO offset:0x23F8 Counter for RMID 575 PMT_EVENT_ACTIVITYAfter all counters there are three status registers that provide indications of how many times an aggregator was unable to process event counts, the time stamp for the most recent loss of data, and the time stamp of the most recent successful update.
MMIO offset:0x2400 AGG_DATA_LOSS_COUNT MMIO offset:0x2408 AGG_DATA_LOSS_TIMESTAMP MMIO offset:0x2410 LAST_UPDATE_TIMESTAMP
Define these events in the file system code and add the events to the event_group structures.
PMT_EVENT_ENERGY and PMT_EVENT_ACTIVITY are produced in fixed point format. File system code must output as floating point values.
--- include/linux/resctrl_types.h | 11 +++++++ arch/x86/kernel/cpu/resctrl/intel_aet.c | 43 +++++++++++++++++++++++++ fs/resctrl/monitor.c | 35 +++++++++++--------- 3 files changed, 74 insertions(+), 15 deletions(-)
include/linux/resctrl_types.h +11 -0
@@ -50,6 +50,17 @@ enum resctrl_event_id {QOS_L3_MBM_TOTAL_EVENT_ID =0x02 ,QOS_L3_MBM_LOCAL_EVENT_ID =0x03 , +/* Intel Telemetry Events */ +PMT_EVENT_ENERGY , +PMT_EVENT_ACTIVITY , +PMT_EVENT_STALLS_LLC_HIT , +PMT_EVENT_C1_RES , +PMT_EVENT_UNHALTED_CORE_CYCLES , +PMT_EVENT_STALLS_LLC_MISS , +PMT_EVENT_AUTO_C6_RES , +PMT_EVENT_UNHALTED_REF_CYCLES , +PMT_EVENT_UOPS_RETIRED , +/* Must be the last */ QOS_NUM_EVENTS, };
arch/x86/kernel/cpu/resctrl/intel_aet.c +43 -0
86 lines not on this page · raw message
fs/resctrl/monitor.c +20 -15
@@ -952,27 +952,32 @@ static void dom_data_exit(struct rdt_resource *r)mutex_unlock (&rdtgroup_mutex); } +#define MON_EVENT (_eventid, _name, _res, _fp) \ + [_eventid] = { \ + .name = _name, \ + .evtid = _eventid, \ + .rid = _res, \ + .is_floating_point = _fp, \ +} +/* * All available events. Architecture code marks the ones that * are supported by a system using resctrl_enable_mon_event() * to set .enabled. */ struct mon_evt mon_event_all[QOS_NUM_EVENTS ] = { - [QOS_L3_OCCUP_EVENT_ID ] = { - .name ="llc_occupancy" , - .evtid =QOS_L3_OCCUP_EVENT_ID , - .rid =RDT_RESOURCE_L3 , - }, - [QOS_L3_MBM_TOTAL_EVENT_ID ] = { - .name ="mbm_total_bytes" , - .evtid =QOS_L3_MBM_TOTAL_EVENT_ID , - .rid =RDT_RESOURCE_L3 , - }, - [QOS_L3_MBM_LOCAL_EVENT_ID ] = { - .name ="mbm_local_bytes" , - .evtid =QOS_L3_MBM_LOCAL_EVENT_ID , - .rid =RDT_RESOURCE_L3 , - }, +MON_EVENT (QOS_L3_OCCUP_EVENT_ID ,"llc_occupancy" ,RDT_RESOURCE_L3 , false), +MON_EVENT (QOS_L3_MBM_TOTAL_EVENT_ID ,"mbm_total_bytes" ,RDT_RESOURCE_L3 , false), +MON_EVENT (QOS_L3_MBM_LOCAL_EVENT_ID ,"mbm_local_bytes" ,RDT_RESOURCE_L3 , false), +MON_EVENT (PMT_EVENT_ENERGY ,"core_energy" ,RDT_RESOURCE_PERF_PKG , true), +MON_EVENT (PMT_EVENT_ACTIVITY ,"activity" ,RDT_RESOURCE_PERF_PKG , true), +MON_EVENT (PMT_EVENT_STALLS_LLC_HIT ,"stalls_llc_hit" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_C1_RES ,"c1_res" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_UNHALTED_CORE_CYCLES ,"unhalted_core_cycles" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_STALLS_LLC_MISS ,"stalls_llc_miss" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_AUTO_C6_RES ,"c6_res" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_UNHALTED_REF_CYCLES ,"unhalted_ref_cycles" ,RDT_RESOURCE_PERF_PKG , false), +MON_EVENT (PMT_EVENT_UOPS_RETIRED ,"uops_retired" ,RDT_RESOURCE_PERF_PKG , false), };void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu,unsigned int binary_bits)
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 17/32] x86,fs/resctrl: Fill in details of events for guid 0x26696143 and 0x26557651
Hi Tony,
Quoted 2 lines · Tony Luck
The Intel Clearwater Forest CPU supports two RMID-based PMT feature groups documented in the
xml/CWF/OOBMSM/RMID-ENERGY/cwf_aggregator.xmland
It makes the series easier to read when it uses consistent terms throughout and avoids needing to keep redefining things. With "feature type" defined in previous patch I think "PMT feature group" can be replaced with "feature type" and then the second and third paragraph can be dropped?
To help keep things consistent this could be something like below that also gives users a link that works since, for example, appending the provided "xml/CWF/OOBMSM/RMID-ENERGY/cwf_aggregator.xml" to provided
https://github.com/intel/Intel-PMT results in a "Not Found".
The telemetry event aggregators of the Intel Clearwater Forest CPU support two RMID-based feature types: "energy" with guid 0x26696143 [1], and "perf" with guid 0x26557651 [2].
Quoted 2 lines
xml/CWF/OOBMSM/RMID-PERF/cwf_aggregator.xmlfiles in the Intel PMT GIT repository [1].
Taking a step back there seems to be an ordering issue since the previous patch already uses the two guid "introduced" here.
Quoted 8 lines
The struct
pmt_feature_groupprovided by theINTEL_PMT_TELEMETRYdriver lists the guid and other information for each aggregator of a given type (energy or perf) present on the system.resctrl has a condensed form of the XML description in struct
event_group. An event group is enabled if the pfg field points to a structpmt_feature_group.
Above two paragraphs can be dropped. (They anyway were just pasted in without maintaining style nor connection with rest of changelog.)
Quoted 2 lines
The counter offsets in MMIO space are arranged in groups for each RMID.
(to remind reader the context)
"The counter offsets in MMIO space" -> "The event counter offsets in an aggregator's MMIO space"
Quoted 16 lines
E.g the "energy" counters for guid
0x26696143are arranged like this:MMIO offset:0x0000 Counter for RMID 0 PMT_EVENT_ENERGY MMIO offset:0x0008 Counter for RMID 0 PMT_EVENT_ACTIVITY MMIO offset:0x0010 Counter for RMID 1 PMT_EVENT_ENERGY MMIO offset:0x0018 Counter for RMID 1 PMT_EVENT_ACTIVITY ... MMIO offset:0x23F0 Counter for RMID 575 PMT_EVENT_ENERGY MMIO offset:0x23F8 Counter for RMID 575 PMT_EVENT_ACTIVITYAfter all counters there are three status registers that provide indications of how many times an aggregator was unable to process event counts, the time stamp for the most recent loss of data, and the time stamp of the most recent successful update.
Quoted 5 lines
MMIO offset:0x2400 AGG_DATA_LOSS_COUNT MMIO offset:0x2408 AGG_DATA_LOSS_TIMESTAMP MMIO offset:0x2410 LAST_UPDATE_TIMESTAMPDefine these events in the file system code and add the events
(to be specific about which events)
"these events" -> "the events tracked by the aggregators"?
Quoted 8 lines
to the
event_groupstructures.
PMT_EVENT_ENERGYandPMT_EVENT_ACTIVITYare produced in fixed point format. File system code must output as floating point values.Signed-off-by Tony Luck <[email protected]>Link https://github.com/intel/Intel-PMT # [1]---
I think it will be more appropriate if the event groups initialized here, for example "static struct event_group energy_0x26696143", are defined as part of this patch also.
Reinette
Tony Luck
maintainerPATCH v13 18/32 x86,fs/resctrl: Add architectural event pointer
In reply to Tony LuckThe resctrl file system layer passes the domain, RMID, and event id to the architecture to fetch an event counter.
Fetching a telemetry event counter requires additional information that is private to the architecture, for example, the offset into MMIO space from where the counter should be read.
Add mon_evt::arch_priv that architecture can use for any private data related to the event. resctrl filesystem initializes mon_evt::arch_priv when the architecture enables the event and passes it back to architecture when needing to fetch an event counter.
--- include/linux/resctrl.h | 7 +++++-- fs/resctrl/internal.h | 4 ++++ arch/x86/kernel/cpu/resctrl/core.c | 6 +++--- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- fs/resctrl/monitor.c | 14 ++++++++++---- 5 files changed, 23 insertions(+), 10 deletions(-)
include/linux/resctrl.h +5 -2
@@ -412,7 +412,7 @@ u32 resctrl_arch_system_num_rmid_idx(void);int resctrl_arch_update_domains (struct rdt_resource *r,u32 closid);void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, -unsigned int binary_bits); +unsigned int binary_bits,void *arch_priv);bool resctrl_is_mon_event_enabled (enum resctrl_event_id eventid);
@@ -529,6 +529,9 @@ void resctrl_arch_pre_mount(void);* only. * @rmid: rmid of the counter to read. * @eventid: eventid to read, e.g. L3 occupancy. +* @arch_priv: Architecture private data for this event. +* The @arch_priv provided by the architecture via +* resctrl_enable_mon_event(). * @val: result of the counter read in bytes. * @arch_mon_ctx: An architecture specific value from * resctrl_arch_mon_ctx_alloc(), for MPAM this identifies
@@ -546,7 +549,7 @@ void resctrl_arch_pre_mount(void);*/ int resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_domain_hdr *hdr,u32 closid,u32 rmid,enum resctrl_event_id eventid, -u64 *val,void *arch_mon_ctx); +void *arch_priv,u64 *val,void *arch_mon_ctx);/** * resctrl_arch_rmid_read_context_check() - warn about invalid contexts
fs/resctrl/internal.h +4 -0
@@ -66,6 +66,9 @@ static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)* @binary_bits: number of fixed-point binary bits from architecture, * only valid if @is_floating_point is true * @enabled: true if the event is enabled +* @arch_priv: Architecture private data for this event. +* The @arch_priv provided by the architecture via +* resctrl_enable_mon_event(). */ struct mon_evt {enum resctrl_event_id evtid;
@@ -77,6 +80,7 @@ struct mon_evt {bool is_floating_point;unsigned int binary_bits;bool enabled; +void *arch_priv; };extern struct mon_evt mon_event_all[QOS_NUM_EVENTS ];
arch/x86/kernel/cpu/resctrl/core.c +3 -3
@@ -915,15 +915,15 @@ static __init bool get_rdt_mon_resources(void)bool ret = false;if (rdt_cpu_has (X86_FEATURE_CQM_OCCUP_LLC )) { -resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false,0 ); +resctrl_enable_mon_event (QOS_L3_OCCUP_EVENT_ID , false,0 ,NULL ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_TOTAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false,0 ); +resctrl_enable_mon_event (QOS_L3_MBM_TOTAL_EVENT_ID , false,0 ,NULL ); ret = true; }if (rdt_cpu_has (X86_FEATURE_CQM_MBM_LOCAL )) { -resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false,0 ); +resctrl_enable_mon_event (QOS_L3_MBM_LOCAL_EVENT_ID , false,0 ,NULL ); ret = true; }if (rdt_cpu_has (X86_FEATURE_ABMC ))
arch/x86/kernel/cpu/resctrl/monitor.c +1 -1
@@ -240,7 +240,7 @@ static u64 get_corrected_val(struct rdt_resource *r, struct rdt_l3_mon_domain *dint resctrl_arch_rmid_read (struct rdt_resource *r,struct rdt_domain_hdr *hdr,u32 unused,u32 rmid,enum resctrl_event_id eventid, -u64 *val,void *ignored) +void *arch_priv,u64 *val,void *ignored) {struct rdt_hw_l3_mon_domain *hw_dom;struct rdt_l3_mon_domain *d;
fs/resctrl/monitor.c +10 -4
@@ -137,9 +137,11 @@ void __check_limbo(struct rdt_l3_mon_domain *d, bool force_free)struct rmid_entry *entry;u32 idx, cur_idx =1 ;void *arch_mon_ctx; +void *arch_priv;bool rmid_dirty;u64 val =0 ; + arch_priv = mon_event_all[QOS_L3_OCCUP_EVENT_ID ].arch_priv; arch_mon_ctx =resctrl_arch_mon_ctx_alloc (r,QOS_L3_OCCUP_EVENT_ID );if (IS_ERR (arch_mon_ctx)) { pr_warn_ratelimited("Failed to allocate monitor context: %ld",
@@ -160,7 +162,7 @@ void __check_limbo(struct rdt_l3_mon_domain *d, bool force_free) entry =__rmid_entry (idx);if (resctrl_arch_rmid_read (r, &d->hdr, entry->closid, entry->rmid, -QOS_L3_OCCUP_EVENT_ID , &val, +QOS_L3_OCCUP_EVENT_ID , arch_priv, &val, arch_mon_ctx)) { rmid_dirty = true; }else {
@@ -452,7 +454,8 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr, rr->evt->evtid, &tval); else rr->err = resctrl_arch_rmid_read(rr->r, rr->hdr, closid, rmid, - rr->evt->evtid, &tval, rr->arch_mon_ctx); + rr->evt->evtid, rr->evt->arch_priv, + &tval, rr->arch_mon_ctx);if (rr->err)return rr->err;
@@ -481,7 +484,8 @@ static int __l3_mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr, rr->evt->evtid, &tval); else err =resctrl_arch_rmid_read (rr->r, &d->hdr, closid, rmid, - rr->evt->evtid, &tval, rr->arch_mon_ctx); + rr->evt->evtid, rr->evt->arch_priv, + &tval, rr->arch_mon_ctx);if (!err) { rr->val += tval; ret =0 ;
@@ -980,7 +984,8 @@ struct mon_evt mon_event_all[QOS_NUM_EVENTS] = { MON_EVENT(PMT_EVENT_UOPS_RETIRED, "uops_retired", RDT_RESOURCE_PERF_PKG, false), }; -void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu,unsigned int binary_bits) +void resctrl_enable_mon_event (enum resctrl_event_id eventid,bool any_cpu, +unsigned int binary_bits,void *arch_priv) {if (WARN_ON_ONCE (eventid <QOS_FIRST_EVENT || eventid >=QOS_NUM_EVENTS || binary_bits >MAX_BINARY_BITS ))
@@ -996,6 +1001,7 @@ void resctrl_enable_mon_event(enum resctrl_event_id eventid, bool any_cpu, unsig mon_event_all[eventid].any_cpu = any_cpu; mon_event_all[eventid].binary_bits = binary_bits; + mon_event_all[eventid].arch_priv = arch_priv; mon_event_all[eventid].enabled = true; }
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 19/32 x86/resctrl: Find and enable usable telemetry events
In reply to Tony Luckresctrl requests a copy of struct pmt_feature_group from the INTEL_PMT_TELEMETRY driver for each event_group known to resctrl.
Scan pmt_feature_group::regions[] and mark those that fail the following tests:
1) guid does not match the guid for the event_group.
2) Package ID is invalid.
3) The enumerated size of the MMIO region does not match the expected value from the XML description file.
If there are any regions that pass all of these checks enable each of the telemetry events in event_group::evts[].
Note that it is architecturally possible that some telemetry events are only supported by a subset of the packages in the system. It is not expected that systems will ever do this. If they do the user will see event files in resctrl that always return "Unavailable".
--- arch/x86/kernel/cpu/resctrl/intel_aet.c | 58 ++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/resctrl/intel_aet.c +56 -2
@@ -20,9 +20,11 @@#include <linux/intel_pmt_features.h> #include <linux/intel_vsec.h> #include <linux/overflow.h> +#include <linux/printk.h> #include <linux/resctrl.h> #include <linux/resctrl_types.h> #include <linux/stddef.h> +#include <linux/topology.h> #include <linux/types.h> #include "internal.h"
@@ -117,12 +119,64 @@ static struct event_group *known_event_groups[] = { _peg < &known_event_groups[ARRAY_SIZE (known_event_groups)]; \ _peg++) -/* Stub for now */ -static bool enable_events (struct event_group *e,struct pmt_feature_group *p) +/* +* Clear the address field of regions that did not pass the checks in +* skip_telem_region() so they will not be used by intel_aet_read_event(). +* This is safe to do because intel_pmt_get_regions_by_feature() allocates +* a new pmt_feature_group structure to return to each caller and only makes +* use of the pmt_feature_group::kref field when intel_pmt_put_feature_group() +* returns the structure. +*/ +static void mark_telem_region_unusable (struct telemetry_region *tr) +{ + tr->addr =NULL ; +} + +static bool skip_telem_region (struct telemetry_region *tr,struct event_group *e) { +if (tr->guid != e->guid) +return true; +if (tr->plat_info.package_id >=topology_max_packages ()) { +pr_warn ("Bad package %u in guid 0x%x\n" , tr->plat_info.package_id, + tr->guid); +return true; + } +if (tr->size != e->mmio_size) { +pr_warn ("MMIO space wrong size (%zu bytes) for guid 0x%x. Expected %zu bytes.\n" , + tr->size, e->guid, e->mmio_size); +return true; + } +return false; } +static bool group_has_usable_regions (struct event_group *e,struct pmt_feature_group *p) +{ +bool usable_regions = false; + +for (int i =0 ; i < p->count; i++) { +if (skip_telem_region (&p->regions[i], e)) { +mark_telem_region_unusable (&p->regions[i]); +continue ; + } + usable_regions = true; + } + +return usable_regions; +} + +static bool enable_events (struct event_group *e,struct pmt_feature_group *p) +{ +if (!group_has_usable_regions (e, p)) +return false; + +for (int j =0 ; j < e->num_events; j++) +resctrl_enable_mon_event (e->evts[j].id, true, + e->evts[j].bin_bits, &e->evts[j]); + +return true; +} +/* * Make a request to the INTEL_PMT_TELEMETRY driver for a copy of the * pmt_feature_group for each known feature. If there is one, the returned
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 19/32] x86/resctrl: Find and enable usable telemetry events
Hi Tony,
Quoted 5 lines · Tony Luck
resctrl requests a copy of struct
pmt_feature_groupfrom theINTEL_PMT_TELEMETRYdriver for eachevent_groupknown to resctrl.Scan pmt_feature_group::regions[] and mark those that fail the following tests:
Quoted 7 lines
1) guid does not match the guid for the
event_group.
2) Package ID is invalid.
3) The enumerated size of the MMIO region does not match the expected value from the XML description file.If there are any regions that pass all of these checks enable each of the telemetry events in event_group::evts[].
Above mostly just describes what can be seen from the patch. Below is a draft of an attempt to change this:
Every event group has a private copy of the data of all telemetry event aggregators (aka "telemetry regions") tracking its feature type. Included may be regions that have the same feature type but tracking different guid from the event group's.
Traverse the event group's telemetry region data and mark all regions that are not usable by the event group as unusable by clearing those regions' MMIO addresses. A region is considered unusable if:
1) guid does not match the guid of the event group.
2) Package ID is invalid.
3) The enumerated size of the MMIO region does not match the expected value from the XML description file.
Hereafter any telemetry region with an MMIO address is considered valid for the event group it is associated with.
Enable all the event group's events as long as there is at least one usable region from where data for its events can be read.
Quoted 8 lines
Note that it is architecturally possible that some telemetry events are only supported by a subset of the packages in the system. It is not expected that systems will ever do this. If they do the user will see event files in resctrl that always return "Unavailable".
Signed-off-by Tony Luck <[email protected]>---
Patch looks good to me.
Reinette
Tony Luck
maintainerPATCH v13 20/32 x86/resctrl: Read telemetry events
In reply to Tony LuckIntroduce intel_aet_read_event() to read telemetry events for resource RDT_RESOURCE_PERF_PKG. There may be multiple aggregators tracking each package, so scan all of them and add up all counters. Aggregators may return an invalid data indication if they have received no records for a given RMID. User will see "Unavailable" if none of the aggregators on a package provide valid counts.
Resctrl now uses readq() so depends on X86_64. Update Kconfig.
--- arch/x86/kernel/cpu/resctrl/internal.h | 7 ++++ arch/x86/kernel/cpu/resctrl/intel_aet.c | 52 +++++++++++++++++++++++++ arch/x86/kernel/cpu/resctrl/monitor.c | 4 ++ fs/resctrl/monitor.c | 14 +++++++ arch/x86/Kconfig | 2 +- 5 files changed, 78 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/internal.h +7 -0
@@ -220,9 +220,16 @@ void resctrl_arch_mbm_cntr_assign_set_one(struct rdt_resource *r);#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET bool intel_aet_get_events (void ); void __exit intel_aet_exit(void); +int intel_aet_read_event (int domid,u32 rmid,enum resctrl_event_id evtid, +void *arch_priv,u64 *val);#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { } +static inline int intel_aet_read_event (int domid,u32 rmid,enum resctrl_event_id evtid, +void *arch_priv,u64 *val) +{ +return -EINVAL ; +}#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */
arch/x86/kernel/cpu/resctrl/intel_aet.c +52 -0
68 lines not on this page · raw message
arch/x86/kernel/cpu/resctrl/monitor.c +4 -0
@@ -251,6 +251,10 @@ int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain_hdr *hdr,int ret;resctrl_arch_rmid_read_context_check (); + +if (r->rid ==RDT_RESOURCE_PERF_PKG ) +return intel_aet_read_event (hdr->id, rmid, eventid, arch_priv, val); +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return -EINVAL ;
fs/resctrl/monitor.c +14 -0
@@ -514,6 +514,20 @@ static int __mon_event_count(struct rdtgroup *rdtgrp, struct rmid_read *rr)return __l3_mon_event_count (rdtgrp, rr, d); } +case RDT_RESOURCE_PERF_PKG : { +u64 tval =0 ; + + rr->err =resctrl_arch_rmid_read (rr->r, rr->hdr, rdtgrp->closid, + rdtgrp->mon.rmid, rr->evt->evtid, + rr->evt->arch_priv, + &tval, rr->arch_mon_ctx); +if (rr->err) +return rr->err; + + rr->val += tval; + +return 0 ; + }default : rr->err = -EINVAL ;return -EINVAL ;
arch/x86/Kconfig +1 -1
@@ -538,7 +538,7 @@ config X86_CPU_RESCTRL config X86_CPU_RESCTRL_INTEL_AET bool "Intel Application Energy Telemetry" - depends on X86_CPU_RESCTRL && CPU_SUP_INTEL && INTEL_PMT_TELEMETRY=y && INTEL_TPMI=y + depends on X86_64 && X86_CPU_RESCTRL && CPU_SUP_INTEL && INTEL_PMT_TELEMETRY=y && INTEL_TPMI=y help Enable per-RMID telemetry events in resctrl.
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 20/32] x86/resctrl: Read telemetry events
Hi Tony,
Quoted 6 lines · Tony Luck
arch/x86/kernel/cpu/resctrl/intel_aet.c +2
-0@@ -217,3 +221,51 @@ void __exit intel_aet_exit(void) } } } + +#define DATA_VALID BIT_ULL(63)
arch/x86/kernel/cpu/resctrl/intel_aet.c void __exit intel_aet_exit(void) · line 235
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +10
-0+#define DATA_BITS GENMASK_ULL(62, 0) + +/* +* Read counter for an event on a domain (summing all aggregators +* on the domain). If an aggregator hasn't received any data for a +* specific RMID, the MMIO read indicates that data is not valid. +* Return success if at least one aggregator has valid data. +*/ +int intel_aet_read_event (int domid,u32 rmid,enum resctrl_event_id eventid, +void *arch_priv,u64 *val)
Is eventid needed? It could perhaps be used as a sanity check of pevt->id but if it is not used then it can be dropped.
Reinette
Tony Luck
maintainerPATCH v13 21/32 fs/resctrl: Refactor mkdir_mondata_subdir()
In reply to Tony LuckPopulation of a monitor group's mon_data directory is unreasonably complicated because of the support for Sub-NUMA Cluster (SNC) mode.
Split out the SNC code into a helper function to make it easier to add support for a new telemetry resource.
Move all the duplicated code to make and set owner of domain directories into the mon_add_all_files() helper and rename to _mkdir_mondata_subdir().
--- fs/resctrl/rdtgroup.c | 108 +++++++++++++++++++++++------------------- 1 file changed, 58 insertions(+), 50 deletions(-)
fs/resctrl/rdtgroup.c +58 -50
@@ -3194,57 +3194,65 @@ static void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, } } -static int mon_add_all_files (struct kernfs_node *kn,struct rdt_domain_hdr *hdr, -struct rdt_resource *r,struct rdtgroup *prgrp, -bool do_sum) +/* +* Create a directory for a domain and populate it with monitor files. Create +* summing monitors when @hdr is NULL. No need to initialize summing monitors. +*/ +static struct kernfs_node *_mkdir_mondata_subdir (struct kernfs_node *parent_kn,char *name, +struct rdt_domain_hdr *hdr, +struct rdt_resource *r, +struct rdtgroup *prgrp,int domid) { -struct rdt_l3_mon_domain *d;struct rmid_read rr = {0 }; +struct kernfs_node *kn;struct mon_data *priv;struct mon_evt *mevt; -int ret, domid; +int ret; -if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) -return -EINVAL ; + kn =kernfs_create_dir (parent_kn, name, parent_kn->mode, prgrp); +if (IS_ERR (kn)) +return kn; + + ret =rdtgroup_kn_set_ugid (kn); +if (ret) + goto out_destroy; - d = container_of(hdr, struct rdt_l3_mon_domain, hdr);for_each_mon_event (mevt) {if (mevt->rid != r->rid || !mevt->enabled)continue ; - domid = do_sum ? d->ci_id : d->hdr.id; - priv =mon_get_kn_priv (r->rid, domid, mevt, do_sum); -if (WARN_ON_ONCE (!priv)) -return -EINVAL ; + priv =mon_get_kn_priv (r->rid, domid, mevt, !hdr); +if (WARN_ON_ONCE (!priv)) { + ret = -EINVAL ; + goto out_destroy; + } ret =mon_addfile (kn, mevt->name, priv);if (ret) -return ret; + goto out_destroy; -if (!do_sum &&resctrl_is_mbm_event (mevt->evtid)) +if (hdr &&resctrl_is_mbm_event (mevt->evtid))mon_event_read (&rr, r, hdr, prgrp, &hdr->cpu_mask, mevt, true); } -return 0 ; +return kn; +out_destroy: +kernfs_remove (kn); +return ERR_PTR (ret); } -static int mkdir_mondata_subdir (struct kernfs_node *parent_kn, -struct rdt_domain_hdr *hdr, -struct rdt_resource *r,struct rdtgroup *prgrp) +static int mkdir_mondata_subdir_snc (struct kernfs_node *parent_kn, +struct rdt_domain_hdr *hdr, +struct rdt_resource *r,struct rdtgroup *prgrp) { -struct kernfs_node *kn, *ckn; +struct kernfs_node *ckn, *kn;struct rdt_l3_mon_domain *d;char name[32 ]; -bool snc_mode; -int ret =0 ; - -lockdep_assert_held (&rdtgroup_mutex);if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return -EINVAL ; d = container_of(hdr, struct rdt_l3_mon_domain, hdr); - snc_mode = r->mon_scope ==RESCTRL_L3_NODE ; -sprintf (name,"mon_%s_%02d" , r->name, snc_mode ? d->ci_id : d->hdr.id); +sprintf (name,"mon_%s_%02d" , r->name, d->ci_id); kn =kernfs_find_and_get (parent_kn, name);if (kn) {/*
@@ -3253,41 +3261,41 @@ static int mkdir_mondata_subdir(struct kernfs_node *parent_kn,*/ kernfs_put (kn); }else { - kn =kernfs_create_dir (parent_kn, name, parent_kn->mode, prgrp); + kn =_mkdir_mondata_subdir (parent_kn, name,NULL , r, prgrp, d->ci_id);if (IS_ERR (kn))return PTR_ERR (kn); + } - ret =rdtgroup_kn_set_ugid (kn); -if (ret) - goto out_destroy; - ret =mon_add_all_files (kn, hdr, r, prgrp, snc_mode); -if (ret) - goto out_destroy; +sprintf (name,"mon_sub_%s_%02d" , r->name, hdr->id); + ckn =_mkdir_mondata_subdir (kn, name, hdr, r, prgrp, hdr->id); +if (IS_ERR (ckn)) { +kernfs_remove (kn); +return PTR_ERR (ckn); } -if (snc_mode) { -sprintf (name,"mon_sub_%s_%02d" , r->name, hdr->id); - ckn =kernfs_create_dir (kn, name, parent_kn->mode, prgrp); -if (IS_ERR (ckn)) { - ret = -EINVAL ; - goto out_destroy; - } +kernfs_activate (kn); +return 0 ; +} - ret =rdtgroup_kn_set_ugid (ckn); -if (ret) - goto out_destroy; +static int mkdir_mondata_subdir (struct kernfs_node *parent_kn, +struct rdt_domain_hdr *hdr, +struct rdt_resource *r,struct rdtgroup *prgrp) +{ +struct kernfs_node *kn; +char name[32 ]; - ret =mon_add_all_files (ckn, hdr, r, prgrp, false); -if (ret) - goto out_destroy; - } +lockdep_assert_held (&rdtgroup_mutex); + +if (r->rid ==RDT_RESOURCE_L3 && r->mon_scope ==RESCTRL_L3_NODE ) +return mkdir_mondata_subdir_snc (parent_kn, hdr, r, prgrp); + +sprintf (name,"mon_%s_%02d" , r->name, hdr->id); + kn =_mkdir_mondata_subdir (parent_kn, name, hdr, r, prgrp, hdr->id); +if (IS_ERR (kn)) +return PTR_ERR (kn);kernfs_activate (kn);return 0 ; - -out_destroy: -kernfs_remove (kn); -return ret; }/*
Signature · 1 line
2.51.0
Re: [PATCH v13 21/32] fs/resctrl: Refactor mkdir_mondata_subdir()
Hi Tony,
Quoted 6 lines · Tony Luck
Population of a monitor group's
mon_datadirectory is unreasonably complicated because of the support for Sub-NUMA Cluster (SNC) mode.Split out the SNC code into a helper function to make it easier to add support for a new telemetry resource.
Quoted 6 lines
Move all the duplicated code to make and set owner of domain directories into the
mon_add_all_files()helper and rename to_mkdir_mondata_subdir().Suggested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
Reinette
Tony Luck
maintainerPATCH v13 22/32 fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp()
In reply to Tony LuckClearing a monitor group's mon_data directory is complicated because of the support for Sub-NUMA Cluster (SNC) mode.
Refactor the SNC case into a helper function to make it easier to add support for a new telemetry resource.
--- fs/resctrl/rdtgroup.c | 42 +++++++++++++++++++++++++++++++----------- 1 file changed, 31 insertions(+), 11 deletions(-)
fs/resctrl/rdtgroup.c +31 -11
@@ -3163,28 +3163,24 @@ static void mon_rmdir_one_subdir(struct kernfs_node *pkn, char *name, char *subn }/* -* Remove all subdirectories of mon_data of ctrl_mon groups -* and monitor groups for the given domain. -* Remove files and directories containing "sum" of domain data -* when last domain being summed is removed. +* Remove files and directories for one SNC node. If it is the last node +* sharing an L3 cache, then remove the upper level directory containing +* the "sum" files too. */ -static void rmdir_mondata_subdir_allrdtgrp (struct rdt_resource *r, -struct rdt_domain_hdr *hdr) +static void rmdir_mondata_subdir_allrdtgrp_snc (struct rdt_resource *r, +struct rdt_domain_hdr *hdr) {struct rdtgroup *prgrp, *crgrp;struct rdt_l3_mon_domain *d;char subname[32 ]; -bool snc_mode;char name[32 ];if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 ))return ; d = container_of(hdr, struct rdt_l3_mon_domain, hdr); - snc_mode = r->mon_scope ==RESCTRL_L3_NODE ; -sprintf (name,"mon_%s_%02d" , r->name, snc_mode ? d->ci_id : d->hdr.id); -if (snc_mode) -sprintf (subname,"mon_sub_%s_%02d" , r->name, d->hdr.id); +sprintf (name,"mon_%s_%02d" , r->name, d->ci_id); +sprintf (subname,"mon_sub_%s_%02d" , r->name, hdr->id);list_for_each_entry (prgrp, &rdt_all_groups, rdtgroup_list) {mon_rmdir_one_subdir (prgrp->mon.mon_data_kn, name, subname);
@@ -3194,6 +3190,30 @@ static void rmdir_mondata_subdir_allrdtgrp(struct rdt_resource *r, } } +/* +* Remove all subdirectories of mon_data of ctrl_mon groups +* and monitor groups for the given domain. +*/ +static void rmdir_mondata_subdir_allrdtgrp (struct rdt_resource *r, +struct rdt_domain_hdr *hdr) +{ +struct rdtgroup *prgrp, *crgrp; +char name[32 ]; + +if (r->rid ==RDT_RESOURCE_L3 && r->mon_scope ==RESCTRL_L3_NODE ) { +rmdir_mondata_subdir_allrdtgrp_snc (r, hdr); +return ; + } + +sprintf (name,"mon_%s_%02d" , r->name, hdr->id); +list_for_each_entry (prgrp, &rdt_all_groups, rdtgroup_list) { +kernfs_remove_by_name (prgrp->mon.mon_data_kn, name); + +list_for_each_entry (crgrp, &prgrp->mon.crdtgrp_list, mon.crdtgrp_list) +kernfs_remove_by_name (crgrp->mon.mon_data_kn, name); + } +} +/* * Create a directory for a domain and populate it with monitor files. Create * summing monitors when @hdr is NULL. No need to initialize summing monitors.
Signature · 1 line
2.51.0
Re: [PATCH v13 22/32] fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp()
Hi Tony,
Quoted 9 lines · Tony Luck
Clearing a monitor group's
mon_datadirectory is complicated because of the support for Sub-NUMA Cluster (SNC) mode.Refactor the SNC case into a helper function to make it easier to add support for a new telemetry resource.
Suggested-by Reinette Chatre <[email protected]>Signed-off-by Tony Luck <[email protected]>---
Reinette
Tony Luck
maintainerPATCH v13 23/32 x86,fs/resctrl: Handle domain creation/deletion for RDT_RESOURCE_PERF_PKG
In reply to Tony LuckThe L3 resource has several requirements for domains. There are per-domain structures that hold the 64-bit values of counters, and elements to keep track of the overflow and limbo threads.
None of these are needed for the PERF_PKG resource. The hardware counters are wide enough that they do not wrap around for decades.
Define a new rdt_perf_pkg_mon_domain structure which just consists of the standard rdt_domain_hdr to keep track of domain id and CPU mask.
Update resctrl_online_mon_domain() for RDT_RESOURCE_PERF_PKG. The only action needed for this resource is to create and populate domain directories if a domain is added while resctrl is mounted.
Similarly resctrl_offline_mon_domain() only needs to remove domain directories.
--- arch/x86/kernel/cpu/resctrl/internal.h | 13 +++++++++++ arch/x86/kernel/cpu/resctrl/core.c | 17 +++++++++++++++ arch/x86/kernel/cpu/resctrl/intel_aet.c | 29 +++++++++++++++++++++++++ fs/resctrl/rdtgroup.c | 17 ++++++++++----- 4 files changed, 71 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/resctrl/internal.h +13 -0
@@ -84,6 +84,14 @@ static inline struct rdt_hw_l3_mon_domain *resctrl_to_arch_mon_dom(struct rdt_l3 return container_of(r, struct rdt_hw_l3_mon_domain, d_resctrl); } +/** +* struct rdt_perf_pkg_mon_domain - CPUs sharing an package scoped resctrl monitor resource +* @hdr: common header for different domain types +*/ +struct rdt_perf_pkg_mon_domain { +struct rdt_domain_hdr hdr; +}; +/** * struct msr_param - set a range of MSRs from a domain * @res: The resource to use
@@ -222,6 +230,8 @@ bool intel_aet_get_events(void); void __exit intel_aet_exit(void);int intel_aet_read_event (int domid,u32 rmid,enum resctrl_event_id evtid,void *arch_priv,u64 *val); +void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r, +struct list_head *add_pos);#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { }
@@ -230,6 +240,9 @@ static inline int intel_aet_read_event(int domid, u32 rmid, enum resctrl_event_i {return -EINVAL ; } + +static inline void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r, +struct list_head *add_pos) { }#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */
arch/x86/kernel/cpu/resctrl/core.c +17 -0
@@ -575,6 +575,10 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r)if (!hdr)l3_mon_domain_setup (cpu, id, r, add_pos);break ; +case RDT_RESOURCE_PERF_PKG : +if (!hdr) +intel_aet_mon_domain_setup (cpu, id, r, add_pos); +break ;default :pr_warn_once ("Unknown resource rid=%d\n" , r->rid);break ;
@@ -674,6 +678,19 @@ static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r)l3_mon_domain_free (hw_dom);break ; } +case RDT_RESOURCE_PERF_PKG : { +struct rdt_perf_pkg_mon_domain *pkgd; + +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_PERF_PKG )) +return ; + + pkgd = container_of(hdr, struct rdt_perf_pkg_mon_domain, hdr); +resctrl_offline_mon_domain (r, hdr); +list_del_rcu (&hdr->list); +synchronize_rcu (); +kfree (pkgd); +break ; + }default :pr_warn_once ("Unknown resource rid=%d\n" , r->rid);break ;
arch/x86/kernel/cpu/resctrl/intel_aet.c +29 -0
@@ -17,16 +17,21 @@#include <linux/compiler_types.h> #include <linux/container_of.h> #include <linux/cpu.h> +#include <linux/cpumask.h> #include <linux/err.h> #include <linux/errno.h> +#include <linux/gfp_types.h> #include <linux/init.h> #include <linux/intel_pmt_features.h> #include <linux/intel_vsec.h> #include <linux/io.h> #include <linux/overflow.h> #include <linux/printk.h> +#include <linux/rculist.h> +#include <linux/rcupdate.h> #include <linux/resctrl.h> #include <linux/resctrl_types.h> +#include <linux/slab.h> #include <linux/stddef.h> #include <linux/topology.h> #include <linux/types.h>
@@ -269,3 +274,27 @@ int intel_aet_read_event(int domid, u32 rmid, enum resctrl_event_id eventid,return valid ?0 : -EINVAL ; } + +void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r, +struct list_head *add_pos) +{ +struct rdt_perf_pkg_mon_domain *d; +int err; + + d =kzalloc_node (sizeof (*d),GFP_KERNEL ,cpu_to_node (cpu)); +if (!d) +return ; + + d->hdr.id = id; + d->hdr.type =RESCTRL_MON_DOMAIN ; + d->hdr.rid =RDT_RESOURCE_PERF_PKG ; +cpumask_set_cpu (cpu, &d->hdr.cpu_mask); +list_add_tail_rcu (&d->hdr.list, add_pos); + + err =resctrl_online_mon_domain (r, &d->hdr); +if (err) { +list_del_rcu (&d->hdr.list); +synchronize_rcu (); +kfree (d); + } +}
fs/resctrl/rdtgroup.c +12 -5
@@ -4241,11 +4241,6 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hmutex_lock (&rdtgroup_mutex); -if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) - goto out_unlock; - - d = container_of(hdr, struct rdt_l3_mon_domain, hdr); -/* * If resctrl is mounted, remove all the * per domain monitor data directories.
@@ -4253,6 +4248,13 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hif (resctrl_mounted &&resctrl_arch_mon_capable ())rmdir_mondata_subdir_allrdtgrp (r, hdr); +if (r->rid !=RDT_RESOURCE_L3 ) + goto out_unlock; + +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) + goto out_unlock; + + d = container_of(hdr, struct rdt_l3_mon_domain, hdr);if (resctrl_is_mbm_enabled ())cancel_delayed_work (&d->mbm_over);if (resctrl_is_mon_event_enabled (QOS_L3_OCCUP_EVENT_ID ) &&has_busy_rmid (d)) {
@@ -4349,6 +4351,9 @@ int resctrl_online_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hdrmutex_lock (&rdtgroup_mutex); +if (r->rid !=RDT_RESOURCE_L3 ) + goto mkdir; +if (!domain_header_is_valid (hdr,RESCTRL_MON_DOMAIN ,RDT_RESOURCE_L3 )) goto out_unlock;
@@ -4366,6 +4371,8 @@ int resctrl_online_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *hdrif (resctrl_is_mon_event_enabled (QOS_L3_OCCUP_EVENT_ID ))INIT_DELAYED_WORK (&d->cqm_limbo, cqm_handle_limbo); +mkdir: + err =0 ;/* * If the filesystem is not mounted then only the default resource group * exists. Creation of its directories is deferred until mount time
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 24/32 x86/resctrl: Add energy/perf choices to rdt boot option
In reply to Tony LuckLegacy resctrl features are enumerated by X86_FEATURE_* flags. These may be overridden by quirks to disable features in the case of errata. Users can use kernel command line options to either disable a feature, or to force enable a feature that was disabled by a quirk.
Provide similar functionality for hardware features that do not have an X86_FEATURE_* flag. Unlike other features that are tied to X86_FEATURE_* flags, these must be queried by name. Add rdt_is_feature_enabled() to check whether quirks or kernel command line have disabled a feature.
Users may force a feature to be disabled. E.g. "rdt=!perf" will ensure that none of the perf telemetry events are enabled.
Resctrl architecture code may disable a feature that does not provide full functionality. Users may override that decision. E.g. "rdt=energy" will enable any available energy telemetry events even if they do not provide full functionality.
--- .../admin-guide/kernel-parameters.txt | 2 +- arch/x86/kernel/cpu/resctrl/internal.h | 2 ++ arch/x86/kernel/cpu/resctrl/core.c | 29 +++++++++++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-)
Documentation/admin-guide/kernel-parameters.txt +1 -1
@@ -6207,7 +6207,7 @@ rdt= [HW,X86,RDT] Turn on/off individual RDT features. List is: cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp, - mba, smba, bmec, abmc. + mba, smba, bmec, abmc, energy, perf. E.g. to turn on cmt and turn off mba use: rdt=cmt,!mba
arch/x86/kernel/cpu/resctrl/internal.h +2 -0
@@ -225,6 +225,8 @@ void __init intel_rdt_mbm_apply_quirk(void);void rdt_domain_reconfigure_cdp (struct rdt_resource *r);void resctrl_arch_mbm_cntr_assign_set_one (struct rdt_resource *r); +bool rdt_is_feature_enabled (char *name); +#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET bool intel_aet_get_events (void ); void __exit intel_aet_exit(void);
arch/x86/kernel/cpu/resctrl/core.c +29 -0
@@ -772,6 +772,8 @@ enum {RDT_FLAG_SMBA ,RDT_FLAG_BMEC ,RDT_FLAG_ABMC , +RDT_FLAG_ENERGY , + RDT_FLAG_PERF, };#define RDT_OPT (idx, n, f) \
@@ -798,6 +800,8 @@ static struct rdt_options rdt_options[] __ro_after_init = {RDT_OPT (RDT_FLAG_SMBA ,"smba" ,X86_FEATURE_SMBA ),RDT_OPT (RDT_FLAG_BMEC ,"bmec" ,X86_FEATURE_BMEC ),RDT_OPT (RDT_FLAG_ABMC ,"abmc" ,X86_FEATURE_ABMC ), +RDT_OPT (RDT_FLAG_ENERGY ,"energy" ,0 ), + RDT_OPT(RDT_FLAG_PERF, "perf", 0), };#define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
@@ -847,6 +851,31 @@ bool rdt_cpu_has(int flag)return ret; } +/* +* Hardware features that do not have X86_FEATURE_* bits. There is no +* "hardware does not support this at all" case. Assume that the caller +* has already determined that hardware support is present and just needs +* to check if the feature has been disabled by a quirk that has not been +* overridden by a command line option. +*/ +bool rdt_is_feature_enabled (char *name) +{ +struct rdt_options *o; +bool ret = true; + +for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS ]; o++) { +if (!strcmp (name, o->name)) { +if (o->force_off) + ret = false; +if (o->force_on) + ret = true; +break ; + } + } + +return ret; +} +bool resctrl_arch_is_evt_configurable (enum resctrl_event_id evt) {if (!rdt_cpu_has (X86_FEATURE_BMEC ))
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 25/32 x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
In reply to Tony LuckThere are now three meanings for "number of RMIDs":
1) The number for legacy features enumerated by CPUID leaf 0xF. This is the maximum number of distinct values that can be loaded into MSR_IA32_PQR_ASSOC. Note that systems with Sub-NUMA Cluster mode enabled will force scaling down the CPUID enumerated value by the number of SNC nodes per L3-cache.
2) The number of registers in MMIO space for each event. This is enumerated in the XML files and is the value initialized into event_group::num_rmids.
3) The number of "hardware counters" (this isn't a strictly accurate description of how things work, but serves as a useful analogy that does describe the limitations) feeding to those MMIO registers. This is enumerated in telemetry_region::num_rmids returned from the call to intel_pmt_get_regions_by_feature()
Event groups with insufficient "hardware counters" to track all RMIDs are difficult for users to use, since the system may reassign "hardware counters" at any time. This means that users cannot reliably collect two consecutive event counts to compute the rate at which events are occurring.
Introduce rdt_set_feature_disabled() to mark any under-resourced event groups (those with telemetry_region::num_rmids < event_group::num_rmids for any of the event group's telemetry regions) as unusable. Note that the rdt_options[] structure must now be writable at run-time.
Limit an under-resourced event group's number of possible monitor resource groups to the lowest number of "hardware counters" if the user explicitly requests to enable it.
Scan all enabled event groups and assign the RDT_RESOURCE_PERF_PKG resource "num_rmids" value to the smallest of these values as this value will be used later to compare against the number of RMIDs supported by other resources to determine how many monitoring resource groups are supported.
N.B. Change type of rdt_resource::num_rmid to u32 to match type of event_group::num_rmids so that min(r->num_rmid, e->num_rmids) won't complain about mixing signed and unsigned types.
--- include/linux/resctrl.h | 2 +- arch/x86/kernel/cpu/resctrl/internal.h | 2 + arch/x86/kernel/cpu/resctrl/core.c | 18 +++++++- arch/x86/kernel/cpu/resctrl/intel_aet.c | 55 +++++++++++++++++++++++++ fs/resctrl/rdtgroup.c | 2 +- 5 files changed, 76 insertions(+), 3 deletions(-)
include/linux/resctrl.h +1 -1
@@ -292,7 +292,7 @@ enum resctrl_schema_fmt {* events of monitor groups created via mkdir. */ struct resctrl_mon { -int num_rmid; +u32 num_rmid;unsigned int mbm_cfg_mask;int num_mbm_cntrs;bool mbm_cntr_assignable;
arch/x86/kernel/cpu/resctrl/internal.h +2 -0
@@ -227,6 +227,8 @@ void resctrl_arch_mbm_cntr_assign_set_one(struct rdt_resource *r);bool rdt_is_feature_enabled (char *name); +void rdt_set_feature_disabled (char *name); +#ifdef CONFIG_X86_CPU_RESCTRL_INTEL_AET bool intel_aet_get_events (void ); void __exit intel_aet_exit(void);
arch/x86/kernel/cpu/resctrl/core.c +17 -1
@@ -788,7 +788,7 @@ struct rdt_options {bool force_off, force_on; }; -static struct rdt_options rdt_options[]__ro_after_init = { +static struct rdt_options rdt_options[] = {RDT_OPT (RDT_FLAG_CMT ,"cmt" ,X86_FEATURE_CQM_OCCUP_LLC ),RDT_OPT (RDT_FLAG_MBM_TOTAL ,"mbmtotal" ,X86_FEATURE_CQM_MBM_TOTAL ),RDT_OPT (RDT_FLAG_MBM_LOCAL ,"mbmlocal" ,X86_FEATURE_CQM_MBM_LOCAL ),
@@ -851,6 +851,22 @@ bool rdt_cpu_has(int flag)return ret; } +/* +* Can be called during feature enumeration if sanity check of +* a feature's parameters indicates problems with the feature. +*/ +void rdt_set_feature_disabled (char *name) +{ +struct rdt_options *o; + +for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS ]; o++) { +if (!strcmp (name, o->name)) { + o->force_off = true; +return ; + } + } +} +/* * Hardware features that do not have X86_FEATURE_* bits. There is no * "hardware does not support this at all" case. Assume that the caller
arch/x86/kernel/cpu/resctrl/intel_aet.c +55 -0
108 lines not on this page · raw message
fs/resctrl/rdtgroup.c +1 -1
@@ -1135,7 +1135,7 @@ static int rdt_num_rmids_show(struct kernfs_open_file *of, {struct rdt_resource *r =rdt_kn_parent_priv (of->kn); -seq_printf (seq,"%d\n" , r->mon.num_rmid); +seq_printf (seq,"%u\n" , r->mon.num_rmid);return 0 ; }
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 18 lines · Tony Luck
There are now three meanings for "number of RMIDs":
1) The number for legacy features enumerated by CPUID leaf
0xF. This is the maximum number of distinct values that can be loaded intoMSR_IA32_PQR_ASSOC. Note that systems with Sub-NUMA Cluster mode enabled will force scaling down the CPUID enumerated value by the number of SNC nodes per L3-cache.2) The number of registers in MMIO space for each event. This is enumerated in the XML files and is the value initialized into
event_group::num_rmids.3) The number of "hardware counters" (this isn't a strictly accurate description of how things work, but serves as a useful analogy that does describe the limitations) feeding to those MMIO registers. This is enumerated in
telemetry_region::num_rmidsreturned from the call tointel_pmt_get_regions_by_feature()
Quoted 8 lines
Event groups with insufficient "hardware counters" to track all RMIDs are difficult for users to use, since the system may reassign "hardware counters" at any time. This means that users cannot reliably collect two consecutive event counts to compute the rate at which events are occurring.
Introduce
rdt_set_feature_disabled()to mark any under-resourced event groups (those withtelemetry_region::num_rmids<event_group::num_rmidsfor any of
Extra space above, also note how line lengths differ between paragraphs.
Quoted 7 lines
the event group's telemetry regions) as unusable. Note that the rdt_options[] structure must now be writable at run-time.
Limit an under-resourced event group's number of possible monitor resource groups to the lowest number of "hardware counters" if the user explicitly requests to enable it.
Quoted 7 lines
Scan all enabled event groups and assign the
RDT_RESOURCE_PERF_PKGresource "num_rmids" value to the smallest of these values as this value will be used later to compare against the number of RMIDs supported by other resources to determine how many monitoring resource groups are supported.N.B. Change type of
rdt_resource::num_rmidto u32 to match type of
resctrl_mon::num_rmid
Quoted 2 lines
event_group::num_rmidsso thatmin(r->num_rmid, e->num_rmids)won't complain about mixing signed and unsigned types.
May be worthwhile to highlight that resctrl_mon::num_rmid is already used as a u32 so changing its type does not need to cascade into all users. Something like "Change type of resctrl_mon::num_rmid to u32 to match its usage and the type of ..."
Quoted 32 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +6
-0@@ -25,6 +25,7 @@#include <linux/intel_pmt_features.h> #include <linux/intel_vsec.h> #include <linux/io.h> +#include <linux/minmax.h> #include <linux/overflow.h> #include <linux/printk.h> #include <linux/rculist.h> @@ -57,6 +58,7 @@ struct pmt_event {* struct event_group - All information about a group of telemetry events. * @feature: Argument to intel_pmt_get_regions_by_feature() to * discover if this event_group is supported. +* @name: Name for this group (used by boot rdt= option) * @pfg: Points to the aggregated telemetry space information * returned by the intel_pmt_get_regions_by_feature() * call to the INTEL_PMT_TELEMETRY driver that contains @@ -64,6 +66,10 @@ struct pmt_event {* Valid if the system supports the event group. * NULL otherwise. * @guid: Unique number per XML description file. +* @num_rmids: Number of RMIDs supported by this group. May be +* adjusted downwards if enumeration from +* intel_pmt_get_regions_by_feature() indicates fewer +* RMIDs can be tracked simultaneously. * @mmio_size: Number of bytes of MMIO registers for this group. * @num_events: Number of events in this group. * @evts: Array of event descriptors.
arch/x86/kernel/cpu/resctrl/intel_aet.c struct pmt_event { · line 85
Quoted 9 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +2
-0@@ -71,10 +77,12 @@ struct pmt_event {struct event_group {/* Data fields for additional structures to manage this group. */ enum pmt_feature_id feature; +char *name;struct pmt_feature_group *pfg;/* Remaining fields initialized from XML file. */ u32 guid; +u32 num_rmids;
This addition is to resctrl where there is already a resctrl_mon::num_rmid. Can this naming be made consistent with resctrl instead of INTEL_PMT_TELEMETRY?
Quoted 48 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +23
-0size_t mmio_size;unsigned int num_events; struct pmt_event evts[] __counted_by(num_events);@@ -89,7 +97,9 @@ struct event_group {*/ static struct event_group energy_0x26696143 = { .feature =FEATURE_PER_RMID_ENERGY_TELEM , + .name ="energy" , .guid =0x26696143 , + .num_rmids =576 , .mmio_size =XML_MMIO_SIZE (576 ,2 ,3 ), .num_events =2 , .evts = {@@ -104,7 +114,9 @@ static struct event_group energy_0x26696143 = {*/ static struct event_group perf_0x26557651 = { .feature =FEATURE_PER_RMID_PERF_TELEM , + .name ="perf" , .guid =0x26557651 , + .num_rmids =576 , .mmio_size =XML_MMIO_SIZE (576 ,7 ,3 ), .num_events =7 , .evts = {@@ -174,11 +186,54 @@ static bool group_has_usable_regions(struct event_group *e, struct pmt_feature_greturn usable_regions; } +static bool all_regions_have_sufficient_rmid (struct event_group *e,struct pmt_feature_group +*p) +{ +struct telemetry_region *tr; +bool ret = true; + +for (int i =0 ; i < p->count; i++) { +if (!p->regions[i].addr) +continue ; + tr = &p->regions[i]; +if (tr->num_rmids < e->num_rmids) + ret = false; + } + +return ret; +} +static bool enable_events (struct event_group *e,struct pmt_feature_group *p) { +struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl; +
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool group_has_usable_regions(struct event_group *e, struct pmt_feature_g · line 219
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +7
-0if (!group_has_usable_regions (e, p))return false; +/* Disable feature if insufficient RMIDs */ +if (!all_regions_have_sufficient_rmid (e, p)) +rdt_set_feature_disabled (e->name); + +/* User can override above disable from kernel command line */ +if (!rdt_is_feature_enabled (e->name)) +return false;
Considering this from the user's perspective I do not think there is an easy way for user space to know that the feature was force disabled and that there is an option to override this. What is the use case considered here? If I understand correctly there may be a way to deduce this by consulting files in /sys/class/intel_pmt/ where the telemetry regions' number of supported RMID is printed. A user can compare that to the XML files to determine that there is an issue that can explain resctrl not exposing the feature. Considering this difficulty I wonder if it may be helpful to print an error message here? This is of course not perfect since the kernel log cannot be guaranteed to forever contain it ... but it may help?
Reinette
Luck, Tony
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Quoted 7 lines · Reinette Chatre
Quoted 7 lines
static bool
enable_events(struct event_group *e, struct pmt_feature_group *p){arch/x86/kernel/cpu/resctrl/intel_aet.c +2
-0+struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl; +if (!group_has_usable_regions (e, p))return false;
Quoted 16 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool group_has_usable_regions(struct event_group *e, struct pmt_feature_g · line 219
Quoted 7 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +7
-0+/* Disable feature if insufficient RMIDs */ +if (!all_regions_have_sufficient_rmid (e, p)) +rdt_set_feature_disabled (e->name); + +/* User can override above disable from kernel command line */ +if (!rdt_is_feature_enabled (e->name)) +return false;Considering this from the user's perspective I do not think there is an easy way for user space to know that the feature was force disabled and that there is an option to override this. What is the use case considered here? If I understand correctly there may be a way to deduce this by consulting files in
/sys/class/intel_pmt/where the telemetry regions' number of supported RMID is printed. A user can compare that to the XML files to determine that there is an issue that can explain resctrl not exposing the feature. Considering this difficulty I wonder if it may be helpful to print an error message here? This is of course not perfect since the kernel log cannot be guaranteed to forever contain it ... but it may help?
Reinette,
Good idea. Here's a draft. Comments welcome to improve the user message that would look like:
resctrl: Feature energy guid=0x26696143 not enabled due to insufficient RMIDs
static bool enable_events(struct event_group *e, struct pmt_feature_group *p)
{
struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl;
bool warn_disable = false;
if (!group_has_usable_regions(e, p))
return false;
/* Disable feature if insufficient RMIDs */
if (!all_regions_have_sufficient_rmid(e, p)) {
warn_disable = true;
rdt_set_feature_disabled(e->name);
}
/* User can override above disable from kernel command line */
if (!rdt_is_feature_enabled(e->name)) {
if (warn_disable)
pr_info("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n",
e->name, e->guid);
return false;
}
...
}-Tony
Reinette Chatre
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 19 lines · Tony
resctrl: Feature energy guid=0x26696143 not enabled due to insufficient RMIDs
static bool
enable_events(struct event_group *e, struct pmt_feature_group *p){ struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl; bool warn_disable = false; if (!group_has_usable_regions(e, p)) return false; /* Disable feature if insufficient RMIDs */ if (!all_regions_have_sufficient_rmid(e, p)) { warn_disable = true; rdt_set_feature_disabled(e->name); } /* User can override above disable from kernel command line */
Quoted 8 lines
if (!rdt_is_feature_enabled(e->name)) {
if (warn_disable)
pr_info("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n",
e->name, e->guid);
return false;
}
...
}Thank you for considering. This looks good to me.
I now realize that if a system supports, for example, two energy guid and only one has insufficient RMID then one or both may be disabled by default depending on which resctrl attempts to enable first. This is arbitrary based on where the event group appears in the array.
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a struct pmt_event that can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.
I think the resctrl_enable_mon_event() warnings were added to support enabling of new features so that the WARNs can catch issues during development ... now it may encounter issues when a kernel with this implementation is run on a system that supports a single feature with
multiple guid. Do you have more insight in how the "single feature with multiple guid" may look to better prepare resctrl to handle them?
Should "enable_events" be split so that a feature can be disabled for all its event groups if any of them cannot be enabled due to insufficient RMIDs?
Perhaps resctrl_enable_mon_event() should also now return success/fail so that an event group cannot be enabled if its events cannot be enabled?
Finally, a system with two guid of the same feature type will end up printing duplicate "<feature type> monitoring detected" that could be more descriptive?
Reinette
Luck, Tony
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Quoted 31 lines · Reinette Chatre
Hi Tony,
Quoted 19 lines · Tony
resctrl: Feature energy guid=0x26696143 not enabled due to insufficient RMIDs
static bool
enable_events(struct event_group *e, struct pmt_feature_group *p){ struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl; bool warn_disable = false; if (!group_has_usable_regions(e, p)) return false; /* Disable feature if insufficient RMIDs */ if (!all_regions_have_sufficient_rmid(e, p)) { warn_disable = true; rdt_set_feature_disabled(e->name); } /* User can override above disable from kernel command line */Quoted 8 lines
if (!rdt_is_feature_enabled(e->name)) { if (warn_disable) pr_info("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n", e->name, e->guid); return false; } ... }
Quoted 5 lines
Thank you for considering. This looks good to me.
I now realize that if a system supports, for example, two energy guid and only one has insufficient RMID then one or both may be disabled by default depending on which resctrl attempts to enable first. This is arbitrary based on where the event group appears in the array.
intel_pmt_get_regions_by_feature() does return arrays of telemetry_region with different guids today, but not currently for the "RMID" features. So this could be a problem in the future.
I think I need to drop the "rdt=perf,!energy" command line control as being too coarse. Instead add a new boot argument. E.g.
rdtguid=0x26696143,!0x26557651
to give the user control per-guid instead of per-pmt_feature_id. Users can discover which guids are supported on a system by looking in /sys/bus/auxiliary/devices/intel_vsec.discovery.*/intel_pmt/features*/per_rmid* where there are "guids" and "num_rmids" files.
Quoted 4 lines
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a struct
pmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.
I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
Quoted 6 lines
I think the
resctrl_enable_mon_event()warnings were added to support enabling of new features so that the WARNs can catch issues during development ... now it may encounter issues when a kernel with this implementation is run on a system that supports a single feature with multiple guid. Do you have more insight in how the "single feature with multiple guid" may look to better prepare resctrl to handle them?
Quoted 6 lines
Should "
enable_events" be split so that a feature can be disabled for all its event groups if any of them cannot be enabled due to insufficient RMIDs?
Perhapsresctrl_enable_mon_event()should also now return success/fail so that an event group cannot be enabled if its events cannot be enabled?
Finally, a system with two guid of the same feature type will end up printing duplicate "<feature type> monitoring detected" that could be more descriptive?
I need to add the guid to that message.
Quoted 2 lines
Reinette
-Tony
Reinette Chatre
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 45 lines · Tony
Quoted 31 lines · Reinette Chatre
Hi Tony,
Quoted 19 lines · Tony
resctrl: Feature energy guid=0x26696143 not enabled due to insufficient RMIDs
static bool
enable_events(struct event_group *e, struct pmt_feature_group *p){ struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl; bool warn_disable = false; if (!group_has_usable_regions(e, p)) return false; /* Disable feature if insufficient RMIDs */ if (!all_regions_have_sufficient_rmid(e, p)) { warn_disable = true; rdt_set_feature_disabled(e->name); } /* User can override above disable from kernel command line */Quoted 8 lines
if (!rdt_is_feature_enabled(e->name)) { if (warn_disable) pr_info("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n", e->name, e->guid); return false; } ... }Quoted 5 lines
Thank you for considering. This looks good to me.
I now realize that if a system supports, for example, two energy guid and only one has insufficient RMID then one or both may be disabled by default depending on which resctrl attempts to enable first. This is arbitrary based on where the event group appears in the array.
intel_pmt_get_regions_by_feature()does return arrays oftelemetry_regionwith different guids today, but not currently for the "RMID" features. So this could be a problem in the future.I think I need to drop the "rdt=perf,!energy" command line control as being too coarse. Instead add a new boot argument. E.g.
Quoted 6 lines
rdtguid=0x26696143,!0x26557651to give the user control per-guid instead of per-pmt_feature_id. Users can discover which guids are supported on a system by looking in
/sys/bus/auxiliary/devices/intel_vsec.discovery.*/intel_pmt/features*/per_rmid*where there are "guids" and "num_rmids" files.
Should disable/enable be per RMID telemetry feature? I do not see anything preventing a system from using the same guid for different RMID telemetry features.
I think it will be useful to look at how other kernel parameters distinguish different categories of parameters so that resctrl can be consistent here. Looks like an underscore is most useful and also flexible since it allows both a dash and underscore to be used.
Another alternative that is common in kernel parameters is to use ":". For example,
rdt=energy:0x26696143
With something like above user can, for example, use just "energy" to disable all RMID energy telemetry or be specific to which guid should be disabled. This seems to fit well with existing rdt parameters and be quite flexible.
Quoted 9 lines
Quoted 5 lines
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a struct
pmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
This would be difficult to handle at that time, no? From what I can tell this would enable an unusable event group to actually be enabled resulting in untested and invalid flows. I think it will be safer to not enable an event group in this scenario and seems to math your expectation that this would be unexpected. The "Duplicate enable for event" message will still appear and we can still revisit those assumptions when they do, but the systems encountering them will not be running with enabled event groups that are not actually fully enabled.
Quoted 7 lines
Quoted 7 lines
I think the
resctrl_enable_mon_event()warnings were added to support enabling of new features so that the WARNs can catch issues during development ... now it may encounter issues when a kernel with this implementation is run on a system that supports a single feature with multiple guid. Do you have more insight in how the "single feature with multiple guid" may look to better prepare resctrl to handle them?
Quoted 8 lines
Quoted 6 lines
Should "
enable_events" be split so that a feature can be disabled for all its event groups if any of them cannot be enabled due to insufficient RMIDs?
Perhapsresctrl_enable_mon_event()should also now return success/fail so that an event group cannot be enabled if its events cannot be enabled?
Finally, a system with two guid of the same feature type will end up printing duplicate "<feature type> monitoring detected" that could be more descriptive?I need to add the guid to that message.
Sounds good. Thank you.
Reinette
Luck, Tony
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Quoted 62 lines · Reinette Chatre
Hi Tony,
Quoted 45 lines · Tony
Quoted 31 lines · Reinette Chatre
Hi Tony,
Quoted 19 lines · Tony
resctrl: Feature energy guid=0x26696143 not enabled due to insufficient RMIDs
static bool
enable_events(struct event_group *e, struct pmt_feature_group *p){ struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG].r_resctrl; bool warn_disable = false; if (!group_has_usable_regions(e, p)) return false; /* Disable feature if insufficient RMIDs */ if (!all_regions_have_sufficient_rmid(e, p)) { warn_disable = true; rdt_set_feature_disabled(e->name); } /* User can override above disable from kernel command line */Quoted 8 lines
if (!rdt_is_feature_enabled(e->name)) { if (warn_disable) pr_info("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n", e->name, e->guid); return false; } ... }Quoted 5 lines
Thank you for considering. This looks good to me.
I now realize that if a system supports, for example, two energy guid and only one has insufficient RMID then one or both may be disabled by default depending on which resctrl attempts to enable first. This is arbitrary based on where the event group appears in the array.
intel_pmt_get_regions_by_feature()does return arrays oftelemetry_regionwith different guids today, but not currently for the "RMID" features. So this could be a problem in the future.I think I need to drop the "rdt=perf,!energy" command line control as being too coarse. Instead add a new boot argument. E.g.
Quoted 6 lines
rdtguid=0x26696143,!0x26557651to give the user control per-guid instead of per-pmt_feature_id. Users can discover which guids are supported on a system by looking in
/sys/bus/auxiliary/devices/intel_vsec.discovery.*/intel_pmt/features*/per_rmid*where there are "guids" and "num_rmids" files.Should disable/enable be per RMID telemetry feature? I do not see anything preventing a system from using the same guid for different RMID telemetry features.
I think it will be useful to look at how other kernel parameters distinguish different categories of parameters so that resctrl can be consistent here. Looks like an underscore is most useful and also flexible since it allows both a dash and underscore to be used.
Quoted 6 lines
Another alternative that is common in kernel parameters is to use ":". For example,
rdt=energy:0x26696143With something like above user can, for example, use just "energy" to disable all RMID energy telemetry or be specific to which guid should be disabled. This seems to fit well with existing rdt parameters and be quite flexible.
See rough patch at foot of this e-mail. It's just on top of my WIP v14, but if it looks like the right direction I will merge it into the series in the patch that adds the energy/perf options.
Quoted 10 lines
Quoted 9 lines
Quoted 5 lines
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a struct
pmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
Quoted 6 lines
This would be difficult to handle at that time, no? From what I can tell this would enable an unusable event group to actually be enabled resulting in untested and invalid flows. I think it will be safer to not enable an event group in this scenario and seems to math your expectation that this would be unexpected. The "Duplicate enable for event" message will still appear and we can still revisit those assumptions when they do, but the systems encountering them will not be running with enabled event groups that are not actually fully enabled.
There's a hardware cost to including an event in an aggregator. Inclusing the same event in mutliple aggregators described by different guids is really something that should never happen. Just printing a warning and skipping the event seems an adequate defense.
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
I think the
resctrl_enable_mon_event()warnings were added to support enabling of new features so that the WARNs can catch issues during development ... now it may encounter issues when a kernel with this implementation is run on a system that supports a single feature with multiple guid. Do you have more insight in how the "single feature with multiple guid" may look to better prepare resctrl to handle them?Should "
enable_events" be split so that a feature can be disabled for all its event groups if any of them cannot be enabled due to insufficient RMIDs?
Perhapsresctrl_enable_mon_event()should also now return success/fail so that an event group cannot be enabled if its events cannot be enabled?
Finally, a system with two guid of the same feature type will end up printing duplicate "<feature type> monitoring detected" that could be more descriptive?
Quoted 5 lines
Quoted 1 line
I need to add the guid to that message.
Sounds good. Thank you.
Reinette
-Tony
---
arch/x86/kernel/cpu/resctrl/internal.h +2 -0
@@ -241,6 +241,7 @@ int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 *val);void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos);void intel_aet_add_debugfs (void ); +void intel_aet_option (bool force_off,const char *option,const char *suboption);#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { }
@@ -252,6 +253,7 @@ static inline int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64static inline void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { }static inline void intel_aet_add_debugfs (void ) { } +static inline void intel_aet_option (bool force_off,const char *option,const char *suboption) { };#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */
arch/x86/kernel/cpu/resctrl/core.c +6 -0
@@ -842,6 +842,7 @@ static struct rdt_options rdt_options[] = {static int __init set_rdt_options (char *str) {struct rdt_options *o; +char *suboption;bool force_off;char *tok;
@@ -851,6 +852,11 @@ static int __init set_rdt_options(char *str) force_off = *tok =='!' ;if (force_off) tok++; + suboption =strpbrk (tok,":" ); +if (suboption) { + *suboption++ ='\0' ; +intel_aet_option (force_off, tok, suboption); + }for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS ]; o++) {if (strcmp (tok, o->name) ==0 ) {if (force_off)
arch/x86/kernel/cpu/resctrl/intel_aet.c +28 -1
@@ -69,6 +69,9 @@ struct pmt_event {* data for all telemetry regions type @feature. * Valid if the system supports the event group. * NULL otherwise. +* @force_off: Set true when "rdt" command line disables this @guid. +* @force_on: Set true when "rdt" command line overrides disable of +* this @guid due to insufficeint @num_rmid. * @guid: Unique number per XML description file. * @num_rmid: Number of RMIDs supported by this group. May be * adjusted downwards if enumeration from
@@ -83,6 +86,7 @@ struct event_group {enum pmt_feature_id feature;char *name;struct pmt_feature_group *pfg; +bool force_off, force_on;/* Remaining fields initialized from XML file. */ u32 guid;
@@ -144,6 +148,26 @@ static struct event_group *known_event_groups[] = { _peg < &known_event_groups[ARRAY_SIZE (known_event_groups)]; \ _peg++) +void intel_aet_option (bool force_off,const char *option,const char *suboption) +{ +struct event_group **peg; +u32 guid; + +if (kstrtou32 (suboption,16 , &guid)) +return ; + +for_each_event_group (peg) { +if (!strcmp (option, (*peg)->name)) +continue ; +if ((*peg)->guid != guid) +continue ; +if (force_off) + (*peg)->force_off = true; +else + (*peg)->force_on = true; + } +} +/* * Clear the address field of regions that did not pass the checks in * skip_telem_region() so they will not be used by intel_aet_read_event().
@@ -252,6 +276,9 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p)struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl;bool warn_disable = false; +if (e->force_off) +return false; +if (!group_has_usable_regions (e, p))return false;
@@ -262,7 +289,7 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p) }/* User can override above disable from kernel command line */ -if (!rdt_is_feature_enabled (e->name)) { +if (!rdt_is_feature_enabled (e->name) && !e->force_on) {if (warn_disable)pr_info ("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n" , e->name, e->guid);
Reinette Chatre
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 20 lines · Tony
Quoted 12 lines · Reinette Chatre
Quoted 10 lines · Tony
Quoted 5 lines · Reinette Chatre
On 11/14/25 1:55 PM, Luck, Tony wrote:
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a structpmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
Quoted 6 lines
This would be difficult to handle at that time, no? From what I can tell this would enable an unusable event group to actually be enabled resulting in untested and invalid flows. I think it will be safer to not enable an event group in this scenario and seems to math your expectation that this would be unexpected. The "Duplicate enable for event" message will still appear and we can still revisit those assumptions when they do, but the systems encountering them will not be running with enabled event groups that are not actually fully enabled.
Quoted 5 lines
There's a hardware cost to including an event in an aggregator. Inclusing the same event in mutliple aggregators described by different guids is really something that should never happen. Just printing a warning and skipping the event seems an adequate defense.
My concern is that after skipping the event there is a deceiving message that the event group was enabled successfully.
...
Quoted 15 lines
---
arch/x86/kernel/cpu/resctrl/internal.h +1
-0@@ -241,6 +241,7 @@ int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 *val);void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos);void intel_aet_add_debugfs (void ); +void intel_aet_option (bool force_off,const char *option,const char *suboption);#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { }
arch/x86/kernel/cpu/resctrl/internal.h static inline int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 · line 256
Quoted 4 lines
arch/x86/kernel/cpu/resctrl/internal.h +1
-0@@ -252,6 +253,7 @@ static inline int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64static inline void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { }static inline void intel_aet_add_debugfs (void ) { } +static inline void intel_aet_option (bool force_off,const char *option,const char *suboption) { };
(nit: stray semicolon)
Quoted 16 lines
arch/x86/kernel/cpu/resctrl/internal.h +0
-0#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */ arch/x86/kernel/cpu/resctrl/core.c +1
-0@@ -842,6 +842,7 @@ static struct rdt_options rdt_options[] = {static int __init set_rdt_options (char *str) {struct rdt_options *o; +char *suboption;bool force_off;char *tok;
arch/x86/kernel/cpu/resctrl/core.c static int __init set_rdt_options(char *str) · line 857
Quoted 6 lines
arch/x86/kernel/cpu/resctrl/core.c +3
-0@@ -851,6 +852,11 @@ static int __init set_rdt_options(char *str) force_off = *tok =='!' ;if (force_off) tok++; + suboption =strpbrk (tok,":" ); +if (suboption) { + *suboption++ ='\0' ;
This looks like an open code of strsep()?
arch/x86/kernel/cpu/resctrl/core.c static int __init set_rdt_options(char *str) · line 859
Quoted 2 lines
arch/x86/kernel/cpu/resctrl/core.c +2
-0+intel_aet_option (force_off, tok, suboption); + }
I think this can be simplified. It also looks possible to follow some patterns of existing option handling.
By adding the force_on/force_off members to struct event_group I do not see the perf and energy options needed in rdt_options[] anymore. rdt_set_feature_disabled() and rdt_is_feature_enabled() now also seems unnecessary because the event_group::force_on and event_group::force_off are sufficient.
It looks to me that the entire token can be passed here to intel_aet_option() and it returns 1 to indicate that it was able to "handle" the token, 0 otherwise. If intel_aet_option() was able to handle the option then it is not necessary to do further parsing. "handle" means that it could successfully initialize the new members of struct event_group.
So instead, how about something like:
if (intel_aet_option(force_off, tok)) continue;
arch/x86/kernel/cpu/resctrl/intel_aet.c struct pmt_event { · line 72
Quoted 12 lines
arch/x86/kernel/cpu/resctrl/core.c +0
-0for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS ]; o++) {if (strcmp (tok, o->name) ==0 ) {if (force_off)arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-0@@ -69,6 +69,9 @@ struct pmt_event {* data for all telemetry regions type @feature. * Valid if the system supports the event group. * NULL otherwise. +* @force_off: Set true when "rdt" command line disables this @guid.
To be consistent, can also be true if event group was found to have insufficient RMID.
arch/x86/kernel/cpu/resctrl/intel_aet.c struct pmt_event { · line 74
Quoted 2 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +2
-0+* @force_on: Set true when "rdt" command line overrides disable of +* this @guid due to insufficeint @num_rmid.
"Set" can be dropped to be explicit of state instead of potentially confusing "Set" to be a verb.
insufficeint -> insufficient
Quoted 12 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-0* @guid: Unique number per XML description file. * @num_rmid: Number of RMIDs supported by this group. May be * adjusted downwards if enumeration from @@ -83,6 +86,7 @@ struct event_group {enum pmt_feature_id feature;char *name;struct pmt_feature_group *pfg; +bool force_off, force_on;/* Remaining fields initialized from XML file. */ u32 guid;
arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 155
Quoted 8 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +5
-0@@ -144,6 +148,26 @@ static struct event_group *known_event_groups[] = { _peg < &known_event_groups[ARRAY_SIZE (known_event_groups)]; \ _peg++) +void intel_aet_option (bool force_off,const char *option,const char *suboption) +{ +struct event_group **peg; +u32 guid; +
Can use strsep() here to split provided token into name and guid. Take care to check if guid NULL before attempting kstrtou32().
arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 160
Quoted 5 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +5
-0+if (kstrtou32 (suboption,16 , &guid)) +return ; + +for_each_event_group (peg) { +if (!strcmp (option, (*peg)->name))
!strcmp() -> strcmp()?
arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 163
Quoted 3 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +3
-0+continue ; +if ((*peg)->guid != guid) +continue ;
If no guid provided then all event groups with matching name can have force_on/force_off member set to support user providing, for example: "!perf" to disable all perf event groups.
Quoted 11 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +7
-0+if (force_off) + (*peg)->force_off = true; +else + (*peg)->force_on = true; + } +} +/* * Clear the address field of regions that did not pass the checks in * skip_telem_region() so they will not be used by intel_aet_read_event().
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 284
Quoted 9 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +3
-0@@ -252,6 +276,9 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p)struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl;bool warn_disable = false; +if (e->force_off) +return false; +if (!group_has_usable_regions (e, p))return false;
rdt_set_feature_disabled() that is around here can be replaced with setting event_group::force_off
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 292
Quoted 6 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-1@@ -262,7 +289,7 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p) }/* User can override above disable from kernel command line */ -if (!rdt_is_feature_enabled (e->name)) { +if (!rdt_is_feature_enabled (e->name) && !e->force_on) {
rdt_is_feature_enabled() can be replaced with check of event_group::force_off
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 295
Quoted 5 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +0
-0if (warn_disable)pr_info ("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n" , e->name, e->guid);
I believe changes I mention would simplify the implementation a lot while making it more powerful to support the, for example, "!perf" use case. What do you think?
Reinette
Luck, Tony
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Quoted 23 lines · Reinette Chatre
Hi Tony,
Quoted 20 lines · Tony
Quoted 18 lines · Reinette Chatre
Quoted 10 lines · Tony
Quoted 5 lines · Reinette Chatre
On 11/14/25 1:55 PM, Luck, Tony wrote:
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a structpmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
This would be difficult to handle at that time, no? From what I can tell this would enable an unusable event group to actually be enabled resulting in untested and invalid flows. I think it will be safer to not enable an event group in this scenario and seems to math your expectation that this would be unexpected. The "Duplicate enable for event" message will still appear and we can still revisit those assumptions when they do, but the systems encountering them will not be running with enabled event groups that are not actually fully enabled.
Quoted 8 lines
Quoted 5 lines
There's a hardware cost to including an event in an aggregator. Inclusing the same event in mutliple aggregators described by different guids is really something that should never happen. Just printing a warning and skipping the event seems an adequate defense.
My concern is that after skipping the event there is a deceiving message that the event group was enabled successfully.
I can change resctrl_enable_mon_event() to return a "bool" to say whether each event was successfully enabled.
Then change to:
int skipped_events = 0;
for (int j = 0; j < e->num_events; j++) {
if (!resctrl_enable_mon_event(e->evts[j].id, true,
e->evts[j].bin_bits, &e->evts[j]))
skipped_events++;
}
if (e->num_events == skipped_events) {
pr_info("No events enabled in %s %s:0x%x\n", r->name, e->name, e->guid);
return false;
}
if (skipped_events)
pr_info("%s %s:0x%x monitoring detected (skipped %d events)\n", r->name,
r->name, e->name, e->guid, skipped_events);
else
pr_info("%s %s:0x%x monitoring detected\n", r->name, e->name, e->guid);Quoted 166 lines
...
Quoted 15 lines
---
arch/x86/kernel/cpu/resctrl/internal.h +1
-0@@ -241,6 +241,7 @@ int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 *val);void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos);void intel_aet_add_debugfs (void ); +void intel_aet_option (bool force_off,const char *option,const char *suboption);#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { }arch/x86/kernel/cpu/resctrl/internal.h static inline int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64 · line 256
Quoted 4 lines
arch/x86/kernel/cpu/resctrl/internal.h +1
-0@@ -252,6 +253,7 @@ static inline int intel_aet_read_event(int domid, u32 rmid, void *arch_priv, u64static inline void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { }static inline void intel_aet_add_debugfs (void ) { } +static inline void intel_aet_option (bool force_off,const char *option,const char *suboption) { };(nit: stray semicolon)
Quoted 16 lines
arch/x86/kernel/cpu/resctrl/internal.h +0
-0#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */ arch/x86/kernel/cpu/resctrl/core.c +1
-0@@ -842,6 +842,7 @@ static struct rdt_options rdt_options[] = {static int __init set_rdt_options (char *str) {struct rdt_options *o; +char *suboption;bool force_off;char *tok;arch/x86/kernel/cpu/resctrl/core.c static int __init set_rdt_options(char *str) · line 857
Quoted 6 lines
arch/x86/kernel/cpu/resctrl/core.c +3
-0@@ -851,6 +852,11 @@ static int __init set_rdt_options(char *str) force_off = *tok =='!' ;if (force_off) tok++; + suboption =strpbrk (tok,":" ); +if (suboption) { + *suboption++ ='\0' ;This looks like an open code of
strsep()?arch/x86/kernel/cpu/resctrl/core.c static int __init set_rdt_options(char *str) · line 859
Quoted 2 lines
arch/x86/kernel/cpu/resctrl/core.c +2
-0+intel_aet_option (force_off, tok, suboption); + }I think this can be simplified. It also looks possible to follow some patterns of existing option handling.
By adding the force_on/force_off members to struct
event_groupI do not see the perf and energy options needed in rdt_options[] anymore.rdt_set_feature_disabled()andrdt_is_feature_enabled()now also seems unnecessary because theevent_group::force_onandevent_group::force_offare sufficient.It looks to me that the entire token can be passed here to
intel_aet_option()and it returns 1 to indicate that it was able to "handle" the token, 0 otherwise. Ifintel_aet_option()was able to handle the option then it is not necessary to do further parsing. "handle" means that it could successfully initialize the new members of structevent_group.So instead, how about something like:
if (intel_aet_option(force_off, tok)) continue;arch/x86/kernel/cpu/resctrl/intel_aet.c struct pmt_event { · line 72
Quoted 12 lines
arch/x86/kernel/cpu/resctrl/core.c +0
-0for (o = rdt_options; o < &rdt_options[NUM_RDT_OPTIONS ]; o++) {if (strcmp (tok, o->name) ==0 ) {if (force_off)arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-0@@ -69,6 +69,9 @@ struct pmt_event {* data for all telemetry regions type @feature. * Valid if the system supports the event group. * NULL otherwise. +* @force_off: Set true when "rdt" command line disables this @guid. To be consistent, can also be true if event group was found to have insufficient RMID.
arch/x86/kernel/cpu/resctrl/intel_aet.c struct pmt_event { · line 74
Quoted 2 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +2
-0+* @force_on: Set true when "rdt" command line overrides disable of +* this @guid due to insufficeint @num_rmid. "Set" can be dropped to be explicit of state instead of potentially confusing "Set" to be a verb.
insufficeint -> insufficient
Quoted 12 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-0* @guid: Unique number per XML description file. * @num_rmid: Number of RMIDs supported by this group. May be * adjusted downwards if enumeration from @@ -83,6 +86,7 @@ struct event_group {enum pmt_feature_id feature;char *name;struct pmt_feature_group *pfg; +bool force_off, force_on;/* Remaining fields initialized from XML file. */ u32 guid;arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 155
Quoted 8 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +5
-0@@ -144,6 +148,26 @@ static struct event_group *known_event_groups[] = { _peg < &known_event_groups[ARRAY_SIZE (known_event_groups)]; \ _peg++) +void intel_aet_option (bool force_off,const char *option,const char *suboption) +{ +struct event_group **peg; +u32 guid; +Can use
strsep()here to split provided token into name and guid. Take care to check if guid NULL before attemptingkstrtou32().arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 160
Quoted 5 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +5
-0+if (kstrtou32 (suboption,16 , &guid)) +return ; + +for_each_event_group (peg) { +if (!strcmp (option, (*peg)->name))!strcmp() ->
strcmp()?arch/x86/kernel/cpu/resctrl/intel_aet.c static struct event_group *known_event_groups[] = { · line 163
Quoted 3 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +3
-0+continue ; +if ((*peg)->guid != guid) +continue ;If no guid provided then all event groups with matching name can have force_on/force_off member set to support user providing, for example: "!perf" to disable all perf event groups.
Quoted 11 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +7
-0+if (force_off) + (*peg)->force_off = true; +else + (*peg)->force_on = true; + } +} +/* * Clear the address field of regions that did not pass the checks in * skip_telem_region() so they will not be used by intel_aet_read_event(). arch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 284
Quoted 9 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +3
-0@@ -252,6 +276,9 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p)struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl;bool warn_disable = false; +if (e->force_off) +return false; +if (!group_has_usable_regions (e, p))return false;
rdt_set_feature_disabled()that is around here can be replaced with settingevent_group::force_offarch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 292
Quoted 6 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +1
-1@@ -262,7 +289,7 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p) }/* User can override above disable from kernel command line */ -if (!rdt_is_feature_enabled (e->name)) { +if (!rdt_is_feature_enabled (e->name) && !e->force_on) {
rdt_is_feature_enabled()can be replaced with check ofevent_group::force_off
Quoted 8 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c static bool enable_events(struct event_group *e, struct pmt_feature_group *p) · line 295
Quoted 5 lines
arch/x86/kernel/cpu/resctrl/intel_aet.c +0
-0if (warn_disable)pr_info ("Feature %s guid=0x%x not enabled due to insufficient RMIDs\n" , e->name, e->guid);I believe changes I mention would simplify the implementation a lot while making it more powerful to support the, for example, "!perf" use case. What do you think?
Agreed. Simpler and more flexible. I'll make these changes.
Quoted 2 lines
Reinette
-Tony
Reinette Chatre
maintainerRe: [PATCH v13 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 48 lines · Tony
Quoted 23 lines · Reinette Chatre
Hi Tony,
Quoted 20 lines · Tony
Quoted 18 lines · Reinette Chatre
Quoted 10 lines · Tony
Quoted 5 lines · Reinette Chatre
On 11/14/25 1:55 PM, Luck, Tony wrote:
How a system with two guid of the same feature type would work is not clear to me though. Looks like they cannot share events at all since an event is uniquely associated with a structpmt_eventthat can belong to only one event group. If they may share events then enable_events()->resctrl_enable_mon_event() will complain loudly but still proceed and allow the event group to be enabled.I can't see a good reason why the same event would be enabled under different guids present on the same system. We can revisit my assumption if the "Duplicate enable for event" message shows up.
This would be difficult to handle at that time, no? From what I can tell this would enable an unusable event group to actually be enabled resulting in untested and invalid flows. I think it will be safer to not enable an event group in this scenario and seems to math your expectation that this would be unexpected. The "Duplicate enable for event" message will still appear and we can still revisit those assumptions when they do, but the systems encountering them will not be running with enabled event groups that are not actually fully enabled.
Quoted 8 lines
Quoted 5 lines
There's a hardware cost to including an event in an aggregator. Inclusing the same event in mutliple aggregators described by different guids is really something that should never happen. Just printing a warning and skipping the event seems an adequate defense.
My concern is that after skipping the event there is a deceiving message that the event group was enabled successfully.
I can change
resctrl_enable_mon_event()to return a "bool" to say whether each event was successfully enabled.Then change to:
int skipped_events = 0; for (int j = 0; j < e->num_events; j++) { if (!resctrl_enable_mon_event(e->evts[j].id, true, e->evts[j].bin_bits, &e->evts[j])) skipped_events++; } if (e->num_events == skipped_events) { pr_info("No events enabled in %s %s:0x%x\n", r->name, e->name, e->guid);
Quoted 8 lines
return false;
}
if (skipped_events)
pr_info("%s %s:0x%x monitoring detected (skipped %d events)\n", r->name,
r->name, e->name, e->guid, skipped_events);
else
pr_info("%s %s:0x%x monitoring detected\n", r->name, e->name, e->guid);This looks good to me. Thank you. I am not able to tell from this snippet but since enabling of an event group can fail at this point I think the r->mon.num_rmid initialization should now be moved later so that a failing event group will not impact the number of RMIDs the resource can use.
Reinette
Tony Luck
maintainerPATCH v13 26/32 fs/resctrl: Move allocation/free of closid_num_dirty_rmid[]
In reply to Tony Luckclosid_num_dirty_rmid[] and rmid_ptrs[] are allocated together during resctrl initialization and freed together during resctrl exit.
Telemetry events are enumerated on resctrl mount so only at resctrl mount will the number of RMID supported by all monitoring resources and needed as size for rmid_ptrs[] be known.
Separate closid_num_dirty_rmid[] and rmid_ptrs[] allocation and free in preparation for rmid_ptrs[] to be allocated on resctrl mount.
Keep the rdtgroup_mutex protection around the allocation and free of closid_num_dirty_rmid[] as ARM needs this to guarantee memory ordering.
--- fs/resctrl/monitor.c | 79 ++++++++++++++++++++++++++++---------------- 1 file changed, 51 insertions(+), 28 deletions(-)
fs/resctrl/monitor.c +51 -28
@@ -893,36 +893,14 @@ void mbm_setup_overflow_handler(struct rdt_l3_mon_domain *dom, unsigned long delstatic int dom_data_init (struct rdt_resource *r) {u32 idx_limit =resctrl_arch_system_num_rmid_idx (); -u32 num_closid =resctrl_arch_get_num_closid (r);struct rmid_entry *entry =NULL ;int err =0 , i;u32 idx;mutex_lock (&rdtgroup_mutex); -if (IS_ENABLED (CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID )) { -u32 *tmp; - -/* -* If the architecture hasn't provided a sanitised value here, -* this may result in larger arrays than necessary. Resctrl will -* use a smaller system wide value based on the resources in -* use. -*/ - tmp =kcalloc (num_closid,sizeof (*tmp),GFP_KERNEL ); -if (!tmp) { - err = -ENOMEM ; - goto out_unlock; - } - - closid_num_dirty_rmid = tmp; - } rmid_ptrs =kcalloc (idx_limit,sizeof (struct rmid_entry ),GFP_KERNEL );if (!rmid_ptrs) { -if (IS_ENABLED (CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID )) { -kfree (closid_num_dirty_rmid); - closid_num_dirty_rmid =NULL ; - } err = -ENOMEM ; goto out_unlock; }
@@ -958,11 +936,6 @@ static void dom_data_exit(struct rdt_resource *r)if (!r->mon_capable) goto out_unlock; -if (IS_ENABLED (CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID )) { -kfree (closid_num_dirty_rmid); - closid_num_dirty_rmid =NULL ; - } -kfree (rmid_ptrs); rmid_ptrs =NULL ;
@@ -1799,6 +1772,45 @@ ssize_t mbm_L3_assignments_write(struct kernfs_open_file *of, char *buf,return ret ?: nbytes; } +static int closid_num_dirty_rmid_alloc (struct rdt_resource *r) +{ +if (IS_ENABLED (CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID )) { +u32 num_closid =resctrl_arch_get_num_closid (r); +u32 *tmp; + +/* For ARM memory ordering access to closid_num_dirty_rmid */ +mutex_lock (&rdtgroup_mutex); + +/* +* If the architecture hasn't provided a sanitised value here, +* this may result in larger arrays than necessary. Resctrl will +* use a smaller system wide value based on the resources in +* use. +*/ + tmp =kcalloc (num_closid,sizeof (*tmp),GFP_KERNEL ); +if (!tmp) { +mutex_unlock (&rdtgroup_mutex); +return -ENOMEM ; + } + + closid_num_dirty_rmid = tmp; + +mutex_unlock (&rdtgroup_mutex); + } + +return 0 ; +} + +static void closid_num_dirty_rmid_free (void ) +{ +if (IS_ENABLED (CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID )) { +mutex_lock (&rdtgroup_mutex); +kfree (closid_num_dirty_rmid); + closid_num_dirty_rmid =NULL ; +mutex_unlock (&rdtgroup_mutex); + } +} +/** * resctrl_l3_mon_resource_init() - Initialise global monitoring structures. *
@@ -1819,10 +1831,16 @@ int resctrl_l3_mon_resource_init(void)if (!r->mon_capable)return 0 ; - ret =dom_data_init (r); + ret =closid_num_dirty_rmid_alloc (r);if (ret)return ret; + ret =dom_data_init (r); +if (ret) { +closid_num_dirty_rmid_free (); +return ret; + } +if (resctrl_arch_is_evt_configurable (QOS_L3_MBM_TOTAL_EVENT_ID )) { mon_event_all[QOS_L3_MBM_TOTAL_EVENT_ID ].configurable = true; resctrl_file_fflags_init("mbm_total_bytes_config",
@@ -1865,5 +1883,10 @@ void resctrl_l3_mon_resource_exit(void) {struct rdt_resource *r =resctrl_arch_get_resource (RDT_RESOURCE_L3 ); +if (!r->mon_capable) +return ; + +closid_num_dirty_rmid_free (); +dom_data_exit (r); }
Signature · 1 line
2.51.0
Re: [PATCH v13 26/32] fs/resctrl: Move allocation/free of closid_num_dirty_rmid[]
Hi Tony,
Quoted 7 lines · Tony Luck
closid_num_dirty_rmid[] and rmid_ptrs[] are allocated together during resctrl initialization and freed together during resctrl exit.
Telemetry events are enumerated on resctrl mount so only at resctrl mount will the number of RMID supported by all monitoring resources and needed as size for rmid_ptrs[] be known.
Quoted 8 lines
Separate closid_num_dirty_rmid[] and rmid_ptrs[] allocation and free in preparation for rmid_ptrs[] to be allocated on resctrl mount.
Keep the
rdtgroup_mutexprotection around the allocation and free of closid_num_dirty_rmid[] as ARM needs this to guarantee memory ordering.Signed-off-by Tony Luck <[email protected]>---
Reinette
Tony Luck
maintainerPATCH v13 27/32 x86,fs/resctrl: Compute number of RMIDs as minimum across resources
In reply to Tony Luckresctrl assumes that only the L3 resource supports monitor events, so it simply takes the rdt_resource::num_rmid from RDT_RESOURCE_L3 as the system's number of RMIDs.
The addition of telemetry events in a different resource breaks that assumption.
Compute the number of available RMIDs as the minimum value across all mon_capable resources (analogous to how the number of CLOSIDs is computed across alloc_capable resources).
Note that mount time enumeration of the telemetry resource means that this number can be reduced. If this happens, then some memory will be wasted as the allocations for rdt_l3_mon_domain::mbm_states[] and rdt_l3_mon_domain::rmid_busy_llc created during resctrl initialization will be larger than needed.
--- arch/x86/kernel/cpu/resctrl/core.c | 15 +++++++++++++-- fs/resctrl/rdtgroup.c | 6 ++++++ 2 files changed, 19 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/resctrl/core.c +13 -2
@@ -110,12 +110,23 @@ struct rdt_hw_resource rdt_resources_all[RDT_NUM_RESOURCES] = { }, }; +/** +* resctrl_arch_system_num_rmid_idx - Compute number of supported RMIDs +* (minimum across all mon_capable resource) +* +* Return: Number of supported RMIDs at time of call. Note that mount time +* enumeration of resources may reduce the number. +*/ u32 resctrl_arch_system_num_rmid_idx (void ) { -struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3 ].r_resctrl; +u32 num_rmids =U32_MAX ; +struct rdt_resource *r; + +for_each_mon_capable_rdt_resource (r) + num_rmids =min (num_rmids, r->mon.num_rmid);/* RMID are independent numbers for x86. num_rmid_idx == num_rmid */ -return r->mon.num_rmid; +return num_rmids ==U32_MAX ?0 : num_rmids; }struct rdt_resource *resctrl_arch_get_resource (enum resctrl_res_level l)
fs/resctrl/rdtgroup.c +6 -0
@@ -4286,6 +4286,12 @@ void resctrl_offline_mon_domain(struct rdt_resource *r, struct rdt_domain_hdr *h* During boot this may be called before global allocations have been made by * resctrl_l3_mon_resource_init(). * +* Called during CPU online that may run as soon as CPU online callbacks +* are set up during resctrl initialization. The number of supported RMIDs +* may be reduced if additional mon_capable resources are enumerated +* at mount time. This means the rdt_l3_mon_domain::mbm_states[] and +* rdt_l3_mon_domain::rmid_busy_llc allocations may be larger than needed. +* * Return: 0 for success, or -ENOMEM. */ static int domain_setup_l3_mon_state (struct rdt_resource *r,struct rdt_l3_mon_domain *d)
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 28/32 fs/resctrl: Move RMID initialization to first mount
In reply to Tony LuckL3 monitor features are enumerated during resctrl initialization and rmid_ptrs[] that tracks all RMIDs and depends on the number of supported RMIDs is allocated during this time.
Telemetry monitor features are enumerated during first resctrl mount and may support a different number of RMIDs compared to L3 monitor features.
Delay allocation and initialization of rmid_ptrs[] until first mount. Since the number of RMIDs cannot change on later mounts, keep the same set of rmid_ptrs[] until resctrl_exit(). This is required because the limbo handler keeps running after resctrl is unmounted and needs to access rmid_ptrs[] as it keeps tracking busy RMIDs after unmount.
Rename routines to match what they now do:dom_data_init() -> setup_rmid_lru_list()dom_data_exit() -> free_rmid_lru_list()
--- fs/resctrl/internal.h | 4 ++++ fs/resctrl/monitor.c | 54 ++++++++++++++++++++----------------------- fs/resctrl/rdtgroup.c | 5 ++++ 3 files changed, 34 insertions(+), 29 deletions(-)
fs/resctrl/internal.h +4 -0
@@ -369,6 +369,10 @@ int closids_supported(void);void closid_free (int closid); +int setup_rmid_lru_list (void ); + +void free_rmid_lru_list (void ); +int alloc_rmid (u32 closid);void free_rmid (u32 closid,u32 rmid);
fs/resctrl/monitor.c +25 -29
100 lines not on this page · raw message
fs/resctrl/rdtgroup.c +5 -0
@@ -2734,6 +2734,10 @@ static int rdt_get_tree(struct fs_context *fc) goto out; } + ret =setup_rmid_lru_list (); +if (ret) + goto out; + ret =rdtgroup_setup_root (ctx);if (ret) goto out;
@@ -4586,4 +4590,5 @@ void resctrl_exit(void)*/ resctrl_l3_mon_resource_exit (); +free_rmid_lru_list (); }
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 29/32 x86/resctrl: Enable RDT_RESOURCE_PERF_PKG
In reply to Tony LuckSince telemetry events are enumerated on resctrl mount the RDT_RESOURCE_PERF_PKG resource is not considered "monitoring capable" during early resctrl initialization. This means that the domain list for RDT_RESOURCE_PERF_PKG is not built when the CPU hot plug notifiers are registered and run for the first time right after resctrl initialization.
Mark the RDT_RESOURCE_PERF_PKG as "monitoring capable" upon successful telemetry event enumeration to ensure future CPU hotplug events include this resource and initialize its domain list for CPUs that are already online.
Print to console log announcing the name of the telemetry feature detected.
--- arch/x86/kernel/cpu/resctrl/core.c | 16 +++++++++++++++- arch/x86/kernel/cpu/resctrl/intel_aet.c | 2 ++ 2 files changed, 17 insertions(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/core.c +15 -1
@@ -761,14 +761,28 @@ static int resctrl_arch_offline_cpu(unsigned int cpu)void resctrl_arch_pre_mount (void ) { +struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_PERF_PKG ].r_resctrl;static atomic_t only_once =ATOMIC_INIT (0 ); -int old =0 ; +int cpu, old =0 ;if (!atomic_try_cmpxchg (&only_once, &old,1 ))return ;if (!intel_aet_get_events ())return ; + +/* +* Late discovery of telemetry events means the domains for the +* resource were not built. Do that now. +*/ +cpus_read_lock (); +mutex_lock (&domain_list_lock); + r->mon_capable = true; + rdt_mon_capable = true; +for_each_online_cpu (cpu) +domain_add_cpu_mon (cpu, r); +mutex_unlock (&domain_list_lock); +cpus_read_unlock (); }enum {
arch/x86/kernel/cpu/resctrl/intel_aet.c +2 -0
@@ -238,6 +238,8 @@ static bool enable_events(struct event_group *e, struct pmt_feature_group *p)resctrl_enable_mon_event (e->evts[j].id, true, e->evts[j].bin_bits, &e->evts[j]); +pr_info ("%s %s monitoring detected\n" , r->name, e->name); +return true; }
Signature · 1 line
2.51.0
Re: [PATCH v13 29/32] x86/resctrl: Enable RDT_RESOURCE_PERF_PKG
Hi Tony,
Quoted 6 lines · Tony Luck
Since telemetry events are enumerated on resctrl mount the
RDT_RESOURCE_PERF_PKGresource is not considered "monitoring capable" during early resctrl initialization. This means that the domain list forRDT_RESOURCE_PERF_PKGis not built when the CPU hot plug notifiers are registered and run for the first time right after resctrl initialization.
Quoted 8 lines
Mark the
RDT_RESOURCE_PERF_PKGas "monitoring capable" upon successful telemetry event enumeration to ensure future CPU hotplug events include this resource and initialize its domain list for CPUs that are already online.Print to console log announcing the name of the telemetry feature detected.
Signed-off-by Tony Luck <[email protected]>---
Reinette
Tony Luck
maintainerPATCH v13 30/32 fs/resctrl: Provide interface to create architecture specific debugfs area
In reply to Tony LuckAll files below /sys/fs/resctrl are considered user ABI.
This leaves no place for architectures to provide additional interfaces.
Add resctrl_debugfs_mon_info_arch_mkdir() which creates a directory in the debugfs file system for a monitoring resource. Naming follows the layout of the main resctrl hierarchy:
/sys/kernel/debug/resctrl/info/{resource}_MON/{arch}The {arch} last level directory name matches the output of the user level "uname -m" command.
Architecture code may use this directory for debug information, or for minor tuning of features. It must not be used for basic feature enabling as debugfs may not be configured/mounted on production systems.
--- include/linux/resctrl.h | 10 ++++++++++ fs/resctrl/rdtgroup.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+)
include/linux/resctrl.h +10 -0
@@ -678,6 +678,16 @@ void resctrl_arch_reset_cntr(struct rdt_resource *r, struct rdt_l3_mon_domain *dextern unsigned int resctrl_rmid_realloc_threshold;extern unsigned int resctrl_rmid_realloc_limit; +/** +* resctrl_debugfs_mon_info_arch_mkdir() - Create a debugfs info directory. +* Removed by resctrl_exit(). +* @r: Resource (must be mon_capable). +* +* Return: NULL if resource is not monitoring capable, +* dentry pointer on success, or ERR_PTR(-ERROR) on failure. +*/ +struct dentry *resctrl_debugfs_mon_info_arch_mkdir (struct rdt_resource *r); +int resctrl_init (void );void resctrl_exit (void );
fs/resctrl/rdtgroup.c +29 -0
@@ -24,6 +24,7 @@#include <linux/sched/task.h> #include <linux/slab.h> #include <linux/user_namespace.h> +#include <linux/utsname.h> #include <uapi/linux/magic.h>
@@ -75,6 +76,8 @@ static void rdtgroup_destroy_root(void);struct dentry *debugfs_resctrl; +static struct dentry *debugfs_resctrl_info; +/* * Memory bandwidth monitoring event to use for the default CTRL_MON group * and each new CTRL_MON group created by the user. Only relevant when
@@ -4531,6 +4534,31 @@ int resctrl_init(void)return ret; } +/* +* Create /sys/kernel/debug/resctrl/info/{r->name}_MON/{arch} directory +* by request for architecture to use for debugging or minor tuning. +* Basic functionality of features must not be controlled by files +* added to this directory as debugfs may not be configured/mounted +* on production systems. +*/ +struct dentry *resctrl_debugfs_mon_info_arch_mkdir (struct rdt_resource *r) +{ +struct dentry *moninfodir; +char name[32 ]; + +if (!r->mon_capable) +return NULL ; + +if (!debugfs_resctrl_info) + debugfs_resctrl_info =debugfs_create_dir ("info" , debugfs_resctrl); + +sprintf (name,"%s_MON" , r->name); + + moninfodir =debugfs_create_dir (name, debugfs_resctrl_info); + +return debugfs_create_dir (utsname ()->machine, moninfodir); +} +static bool resctrl_online_domains_exist (void ) {struct rdt_resource *r;
@@ -4582,6 +4610,7 @@ void resctrl_exit(void)debugfs_remove_recursive (debugfs_resctrl); debugfs_resctrl =NULL ; + debugfs_resctrl_info =NULL ;unregister_filesystem (&rdt_fs_type);/*
Signature · 1 line
2.51.0
Tony Luck
maintainerPATCH v13 31/32 x86/resctrl: Add debugfs files to show telemetry aggregator status
In reply to Tony LuckEach telemetry aggregator provides three status registers at the top end of MMIO space after all the per-RMID per-event counters:
data_loss_count: This counts the number of times that this aggregator failed to accumulate a counter value supplied by a CPU core.
data_loss_timestamp: This is a "timestamp" from a free running 25MHz uncore timer indicating when the most recent data loss occurred.
last_update_timestamp: Another 25MHz timestamp indicating when the most recent counter update was successfully applied.
Create files in /sys/kernel/debug/resctrl/info/PERF_PKG_MON/x86_64/ to display the value of each of these status registers for each aggregator in each enabled event group. The prefix for each file name describes the type of aggregator, which package it is located on, and an opaque instance number to provide a unique file name when there are multiple aggregators on a package.
The suffix is one of the three strings listed above. An example name is:
energy_pkg0_agg2_data_loss_count
These files are removed along with all other debugfs entries by the call to debugfs_remove_recursive() in resctrl_exit().
--- arch/x86/kernel/cpu/resctrl/internal.h | 2 + arch/x86/kernel/cpu/resctrl/core.c | 2 + arch/x86/kernel/cpu/resctrl/intel_aet.c | 60 +++++++++++++++++++++++++ 3 files changed, 64 insertions(+)
arch/x86/kernel/cpu/resctrl/internal.h +2 -0
@@ -236,6 +236,7 @@ int intel_aet_read_event(int domid, u32 rmid, enum resctrl_event_id evtid, void *arch_priv, u64 *val);void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos); +void intel_aet_add_debugfs (void );#else static inline bool intel_aet_get_events (void ) {return false; } static inline void __exit intel_aet_exit(void) { }
@@ -247,6 +248,7 @@ static inline int intel_aet_read_event(int domid, u32 rmid, enum resctrl_event_istatic inline void intel_aet_mon_domain_setup (int cpu,int id,struct rdt_resource *r,struct list_head *add_pos) { } +static inline void intel_aet_add_debugfs (void ) { }#endif #endif /* _ASM_X86_RESCTRL_INTERNAL_H */
arch/x86/kernel/cpu/resctrl/core.c +2 -0
@@ -783,6 +783,8 @@ void resctrl_arch_pre_mount(void)domain_add_cpu_mon (cpu, r);mutex_unlock (&domain_list_lock);cpus_read_unlock (); + +intel_aet_add_debugfs (); }enum {
arch/x86/kernel/cpu/resctrl/intel_aet.c +60 -0
83 lines not on this page · raw message
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 31/32] x86/resctrl: Add debugfs files to show telemetry aggregator status
Hi Tony,
Quoted 19 lines · Tony Luck
Each telemetry aggregator provides three status registers at the top end of MMIO space after all the per-RMID per-event counters:
data_loss_count: This counts the number of times that this aggregator failed to accumulate a counter value supplied by a CPU core.
data_loss_timestamp: This is a "timestamp" from a free running 25MHz uncore timer indicating when the most recent data loss occurred.
last_update_timestamp: Another 25MHz timestamp indicating when the most recent counter update was successfully applied.Create files in
/sys/kernel/debug/resctrl/info/PERF_PKG_MON/x86_64/to display the value of each of these status registers for each aggregator in each enabled event group. The prefix for each file name describes the type of aggregator, which package it is located on, and an opaque instance number to provide a unique file name when there are multiple aggregators on a package.
Quoted 3 lines
The suffix is one of the three strings listed above. An example name is:
energy_pkg0_agg2_data_loss_count
Would files named like above have enough information when considering the theoretical struct pmt_feature_group from patch #16? In that example there are perf aggregators with two guids. As mentioned above the aggregator instance is opaque so a user may not know which guid a file like above may refer to.
Reinette
Tony Luck
maintainerPATCH v13 32/32 x86,fs/resctrl: Update documentation for telemetry events
In reply to Tony LuckUpdate resctrl filesystem documentation with the details about the resctrl files that support telemetry events.
--- Documentation/filesystems/resctrl.rst | 102 +++++++++++++++++++++++--- 1 file changed, 90 insertions(+), 12 deletions(-)
Documentation/filesystems/resctrl.rst +90 -12
@@ -168,13 +168,12 @@ with respect to allocation: bandwidth percentages are directly applied to the threads running on the core -If RDT monitoring is available there will be an "L3_MON" directory +If L3 monitoring is available there will be an "L3_MON" directory with the following files: "num_rmids": - The number of RMIDs available. This is the - upper bound for how many "CTRL_MON" + "MON" - groups can be created. + The number of RMIDs supported by hardware for + L3 monitoring events. "mon_features": Lists the monitoring events if
@@ -400,6 +399,24 @@ with the following files: bytes) at which a previously used LLC_occupancy counter can be considered for re-use. +If telemetry monitoring is available there will be an "PERF_PKG_MON" directory +with the following files: + +"num_rmids": + The number of RMIDs for telemetry monitoring events. By default, + resctrl will not enable telemetry events of a particular type + ("perf" or "energy") if the number of RMIDs supported for that + type is lower than the number of RMIDs supported by hardware + for L3 monitoring events. The user can force-enable each type + of telemetry events with the "rdt=" boot command line option, + but this may reduce the number of "MON" groups that can be created. + +"mon_features": + Lists the telemetry monitoring events that are enabled on this system. + +The upper bound for how many "CTRL_MON" + "MON" can be created +is the smaller of the L3_MON and PERF_PKG_MON "num_rmids" values. + Finally, in the top level of the "info" directory there is a file named "last_cmd_status". This is reset with every "command" issued via the file system (making new directories or writing to any of the
@@ -505,15 +522,40 @@ When control is enabled all CTRL_MON groups will also contain: When monitoring is enabled all MON groups will also contain: "mon_data": - This contains a set of files organized by L3 domain and by - RDT event. E.g. on a system with two L3 domains there will - be subdirectories "mon_L3_00" and "mon_L3_01". Each of these - directories have one file per event (e.g. "llc_occupancy", - "mbm_total_bytes", and "mbm_local_bytes"). In a MON group these - files provide a read out of the current value of the event for - all tasks in the group. In CTRL_MON groups these files provide - the sum for all tasks in the CTRL_MON group and all tasks in + This contains directories for each monitor domain. + + If L3 monitoring is enabled, there will be a "mon_L3_XX" directory for + each instance of an L3 cache. Each directory contains files for the enabled + L3 events (e.g. "llc_occupancy", "mbm_total_bytes", and "mbm_local_bytes"). + + If telemetry monitoring is enabled, there will be a "mon_PERF_PKG_YY" + directory for each physical processor package. Each directory contains + files for the enabled telemetry events (e.g. "core_energy". "activity", + "uops_retired", etc.) + + The info/`*`/mon_features files provide the full list of enabled + event/file names. + + "core energy" reports a floating point number for the energy (in Joules) + consumed by cores (registers, arithmetic units, TLB and L1/L2 caches) + during execution of instructions summed across all logical CPUs on a + package for the current monitoring group. + + "activity" also reports a floating point value (in Farads). This provides + an estimate of work done independent of the frequency that the CPUs used + for execution. + + Note that "core energy" and "activity" only measure energy/activity in the + "core" of the CPU (arithmetic units, TLB, L1 and L2 caches, etc.). They + do not include L3 cache, memory, I/O devices etc. + + All other events report decimal integer values. + + In a MON group these files provide a read out of the current value of + the event for all tasks in the group. In CTRL_MON groups these files + provide the sum for all tasks in the CTRL_MON group and all tasks in MON groups. Please see example section for more details on usage. + On systems with Sub-NUMA Cluster (SNC) enabled there are extra directories for each node (located within the "mon_L3_XX" directory for the L3 cache they occupy). These are named "mon_sub_L3_YY"
@@ -1506,6 +1548,42 @@ Example with C:: resctrl_release_lock(fd); } +Debugfs +======= +In addition to the use of debugfs for tracing of pseudo-locking performance, +architecture code may create debugfs directories associated with monitoring +features for a specific resource. + +The full pathname for these is in the form: + + /sys/kernel/debug/resctrl/info/{resource_name}_MON/{arch}/ + +The presence, names, and format of these files may vary between architectures +even if the same resource is present. + +PERF_PKG_MON/x86_64 +------------------- +Three files are present per telemetry aggregator instance that show status. +The prefix of each file name describes the type ("energy" or "perf") which +processor package it belongs to, and the instance number of the aggregator. +For example: "energy_pkg1_agg2". + +The suffix describes which data is reported in the file and +is one of: + +data_loss_count: + This counts the number of times that this aggregator + failed to accumulate a counter value supplied by a CPU. + +data_loss_timestamp: + This is a "timestamp" from a free running 25MHz uncore + timer indicating when the most recent data loss occurred. + +last_update_timestamp: + Another 25MHz timestamp indicating when the + most recent counter update was successfully applied. + + Examples for RDT Monitoring along with allocation usage ======================================================= Reading monitored data
Signature · 1 line
2.51.0
Reinette Chatre
maintainerRe: [PATCH v13 32/32] x86,fs/resctrl: Update documentation for telemetry events
Hi Tony,
Documentation/filesystems/resctrl.rst with the following files: · line 402
Quoted 5 lines · Tony Luck
Documentation/filesystems/resctrl.rst +1
-0@@ -400,6 +399,24 @@ with the following files: bytes) at which a previously used LLC_occupancy counter can be considered for re-use. +If telemetry monitoring is available there will be an "PERF_PKG_MON" directory
"an" -> "a"?
Documentation/filesystems/resctrl.rst with the following files: · line 410
Quoted 8 lines
Documentation/filesystems/resctrl.rst +8
-0+with the following files: + +"num_rmids": + The number of RMIDs for telemetry monitoring events. By default, + resctrl will not enable telemetry events of a particular type + ("perf" or "energy") if the number of RMIDs supported for that + type is lower than the number of RMIDs supported by hardware + for L3 monitoring events. The user can force-enable each type
It is not clear to me how the number of L3 monitoring events is relevant here. This is addressed later with the "The upper bound for how many "CTRL_MON" + "MON" can be created ...", no?
How about something like: "if the number of RMIDs that can be tracked concurrently for that type is lower than the total number of RMIDs supported by that type."? (I am sure it can be improved)
Documentation/filesystems/resctrl.rst with the following files: · line 412
Quoted 2 lines
Documentation/filesystems/resctrl.rst +2
-0+ of telemetry events with the "rdt=" boot command line option, + but this may reduce the number of "MON" groups that can be created.
Since this includes "CTRL_MON" and "MON" groups it may be simpler to just say "monitoring groups".
> +
Quoted 9 lines
Documentation/filesystems/resctrl.rst +6
-0+"mon_features": + Lists the telemetry monitoring events that are enabled on this system. + +The upper bound for how many "CTRL_MON" + "MON" can be created +is the smaller of the L3_MON and PERF_PKG_MON "num_rmids" values. + Finally, in the top level of the "info" directory there is a file named "last_cmd_status". This is reset with every "command" issued via the file system (making new directories or writing to any of the
...
Quoted 12 lines
Documentation/filesystems/resctrl.rst +12
-0+Debugfs +======= +In addition to the use of debugfs for tracing of pseudo-locking performance, +architecture code may create debugfs directories associated with monitoring +features for a specific resource. + +The full pathname for these is in the form: + + /sys/kernel/debug/resctrl/info/{resource_name}_MON/{arch}/ + +The presence, names, and format of these files may vary between architectures +even if the same resource is present.
Documentation/filesystems/resctrl.rst Example with C:: · line 1572
Quoted 10 lines
Documentation/filesystems/resctrl.rst +10
-0+ +PERF_PKG_MON/x86_64 +------------------- +Three files are present per telemetry aggregator instance that show status. +The prefix of each file name describes the type ("energy" or "perf") which +processor package it belongs to, and the instance number of the aggregator. +For example: "energy_pkg1_agg2". + +The suffix describes which data is reported in the file and +is one of:
(nit: unnecessary line break)
Quoted 7 lines
Documentation/filesystems/resctrl.rst +7
-0+ +data_loss_count: + This counts the number of times that this aggregator + failed to accumulate a counter value supplied by a CPU. + +data_loss_timestamp: + This is a "timestamp" from a free running 25MHz uncore
Documentation/filesystems/resctrl.rst Example with C:: · line 1589
Quoted 10 lines
Documentation/filesystems/resctrl.rst +7
-0+ timer indicating when the most recent data loss occurred. + +last_update_timestamp: + Another 25MHz timestamp indicating when the + most recent counter update was successfully applied. + + Examples for RDT Monitoring along with allocation usage ======================================================= Reading monitored data
Reinette
Luck, Tony
maintainerI took a stab at applying the AET patches on tob of Babu's v10
SDCIAE series https://lore.kernel.org/all/[email protected]/
There are only a couple of easy to resolve conflicts.
I pushed a branch with v6.18-rc3 + SDCIAE + AET here:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git sdciae-aet
-Tony
Hi Tony,
Quoted 9 lines · Tony
I took a stab at applying the AET patches on tob of Babu's v10
SDCIAE series https://lore.kernel.org/all/[email protected]/There are only a couple of easy to resolve conflicts.
I pushed a branch with v6.18-rc3 + SDCIAE + AET here:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.gitsdciae-aet
I ran your code on my AMD system. It appears to be working fine.
I don't have the hardware that supports these features. It would be helpful to list the resctrl interface files (files in info directory and files each group) and give an example of how it looks in the system that supports these features. It can be in cover letter or resctrl.rst file as well. It will also help to review the code.
thanks
Babu
Luck, Tony
maintainerQuoted 10 lines
Quoted 9 lines
I took a stab at applying the AET patches on tob of Babu's v10
SDCIAE series https://lore.kernel.org/all/[email protected]/There are only a couple of easy to resolve conflicts.
I pushed a branch with v6.18-rc3 + SDCIAE + AET here:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.gitsdciae-aet
Quoted 6 lines
I ran your code on my AMD system. It appears to be working fine. I don't have the hardware that supports these features. It would be helpful to list the resctrl interface files (files in info directory and files each group) and give an example of how it looks in the system that supports these features. It can be in cover letter or
resctrl.rstfile as well. It will also help to review the code.
Babu,
Thanks for testing. Good to know that I didn't break your code while merging mine on top.
Good suggestion. I'll add some examples to the cover letter when I spin v14 after I get feedback on this series.
-Tony
Luck, Tony
maintainerQuoted 13 lines · Babu
Hi Tony,
Quoted 9 lines · Tony
I took a stab at applying the AET patches on tob of Babu's v10
SDCIAE series https://lore.kernel.org/all/[email protected]/There are only a couple of easy to resolve conflicts.
I pushed a branch with v6.18-rc3 + SDCIAE + AET here:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.gitsdciae-aet
Quoted 6 lines
I ran your code on my AMD system. It appears to be working fine. I don't have the hardware that supports these features. It would be helpful to list the resctrl interface files (files in info directory and files each group) and give an example of how it looks in the system that supports these features. It can be in cover letter or
resctrl.rstfile as well. It will also help to review the code.
Reinette reminded me that I didn't provide the examples that I promised.
Here's what I plan to add to the v17 cover letter. Is this enough detail?
-Tony
Examples:
--------
As with other resctrl monitoring features first create CTRL_MON or MON directories and assign the tasks of interest to the group.
Energy events:
-------------
There are two events associated with energy consumption in the core. The "core_energy" event reports out directly in Joules. To compute power just take the difference between two samples and divide by the time between them. E.g.
$ cat core_energy; sleep 10; cat core_energy 94499439.510380 94499607.019680 $ bc -q scale=3 (94499607.019680 - 94499439.510380) / 10 16.750
So 16.75 Watts in this example.
Note that different runs of the same workload may report different energy consumption. This happens when cores shift to different voltage/frequency profiles due to overall system load.
The "activity" event reports energy usage in a manner independent of voltage and frequency. This may be useful for developers to assess how modifications to a program (e.g. attaching to a library optimized to use AVX instructions) affect energy consumption. So read the "activity" at the start and end of program execution and compute the difference.
Perf events:
-----------
The other telemetry events largely duplicate events available using "perf", but avoid of reading the perf counters on every context switch. This may be a significant improvement when monitoring highly multi-threaded applications. E.g. to find the ratio of core cycles to reference cycles:
$ cat unhalted_core_cycles unhalted_ref_cycles
1312249223146571
1660157011698276
$ { run application here }
$ cat unhalted_core_cycles unhalted_ref_cycles
1313573565617233
1661511224019444
$ bc -q
scale = 3
(1661511224019444 - 1660157011698276) / (1313573565617233 - 1312249223146571)
1.022Hi Tony,
Quoted 39 lines · Tony
Quoted 13 lines · Babu
Hi Tony,
Quoted 9 lines · Tony
I took a stab at applying the AET patches on tob of Babu's v10
SDCIAE series https://lore.kernel.org/all/[email protected]/There are only a couple of easy to resolve conflicts.
I pushed a branch with v6.18-rc3 + SDCIAE + AET here:
git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.gitsdciae-aetQuoted 6 lines
I ran your code on my AMD system. It appears to be working fine. I don't have the hardware that supports these features. It would be helpful to list the resctrl interface files (files in info directory and files each group) and give an example of how it looks in the system that supports these features. It can be in cover letter or
resctrl.rstfile as well. It will also help to review the code.Reinette reminded me that I didn't provide the examples that I promised.
Here's what I plan to add to the v17 cover letter. Is this enough detail?
-Tony
Examples:
--------As with other resctrl monitoring features first create
CTRL_MONor MON directories and assign the tasks of interest to the group.Energy events:
-------------
Quoted 6 lines
There are two events associated with energy consumption in the core. The "
core_energy" event reports out directly in Joules. To compute power just take the difference between two samples and divide by the time between them. E.g.$ cat core_energy; sleep 10; cat core_energy
Please use the full path (/sys/fs/resctrl/test/mon_data/xx/<file_name>).
Otherwise looks good to me.
Thanks
Babu
Quoted 41 lines
94499439.510380
94499607.019680$ bc -q scale=3 (94499607.019680 - 94499439.510380) / 10 16.750So 16.75 Watts in this example.
Note that different runs of the same workload may report different energy consumption. This happens when cores shift to different voltage/frequency profiles due to overall system load.
The "activity" event reports energy usage in a manner independent of voltage and frequency. This may be useful for developers to assess how modifications to a program (e.g. attaching to a library optimized to use AVX instructions) affect energy consumption. So read the "activity" at the start and end of program execution and compute the difference.
Perf events:
-----------The other telemetry events largely duplicate events available using "perf", but avoid of reading the perf counters on every context switch. This may be a significant improvement when monitoring highly multi-threaded applications. E.g. to find the ratio of core cycles to reference cycles:
$ cat unhalted_core_cycles unhalted_ref_cycles 1312249223146571 1660157011698276 $ { run application here } $ cat unhalted_core_cycles unhalted_ref_cycles 1313573565617233 1661511224019444 $ bc -q scale = 3 (1661511224019444 - 1660157011698276) / (1313573565617233 - 1312249223146571) 1.022
Luck, Tony
maintainerQuoted 3 lines
Quoted 1 line
$ cat core_energy; sleep 10; cat core_energyPlease use the full path (/sys/fs/resctrl/test/mon_data/xx/<file_name>).
I'll add to the intro paragraph to set a shell variable and use that in the example to keep the line lengths reasonable like this:
$ cat $dir/core_energy; sleep 10; cat $dir/core_energy
Quoted 1 line
Otherwise looks good to me.
Thanks
-Tony
Quoted 1 line · Tony Luck
Patches based on v6.18-rc3
[snip]
Quoted 10 lines
Background
----------
On Intel systems that support per-RMID telemetry monitoring each logical processor keeps a local count for various events. When the MSR_IA32_PQR_ASSOC.RMID value for the logical processor changes (or when a two millisecond counter expires) these event counts are transmitted to an event aggregator on the same package as the processor together with the current RMID value. The event counters are reset to zero to begin counting again.
Do you have any suggestion of which Xeon parts I should be looking for if I want to try out this feature?
I'm looking at bare metal hosting providers for an Intel server that I can try out features like SNC and this. I look up the parts on ARK but it shows yes/no for RDT which is not very specific. I'm hoping to do something better than just hoping cpuinfo has what I want once the machine is provisioned :)
Thanks,
Drew
Luck, Tony
maintainerQuoted 8 lines
Quoted 7 lines
On Intel systems that support per-RMID telemetry monitoring each logical processor keeps a local count for various events. When the MSR_IA32_PQR_ASSOC.RMID value for the logical processor changes (or when a two millisecond counter expires) these event counts are transmitted to an event aggregator on the same package as the processor together with the current RMID value. The event counters are reset to zero to begin counting again.
Quoted 9 lines
Do you have any suggestion of which Xeon parts I should be looking for if I want to try out this feature?
I'm looking at bare metal hosting providers for an Intel server that I can try out features like SNC and this. I look up the parts on ARK but it shows yes/no for RDT which is not very specific. I'm hoping to do something better than just hoping cpuinfo has what I want once the machine is provisioned :)
Drew,
Telemetry monitoring based on RMIDs is only present on Clearwater Forest systems today. Those haven't been released into the wild yet.
-Tony
Quoted 6 lines · Tony
Drew,
Telemetry monitoring based on RMIDs is only present on Clearwater Forest systems today. Those haven't been released into the wild yet.
-Tony
Thanks for letting me know. Do you know what Xeon parts I should look for if I want to try out the SNC support?
Drew
Luck, Tony
maintainerQuoted 2 lines
Thanks for letting me know. Do you know what Xeon parts I should look for if I want to try out the SNC support?
Drew
Granite Rapids (a.k.a. "Intel(R) Xeon(R) 6" (with P-cores ... there's also a Xeon 6 with E-cores called Sierra Forest)
-Tony