Skip to contentSkip to conversation

da8xx-fb: add missing FB_BLANK operations

PATCH Superseded yegorslists at googlemail.com 2 participants 3 messages Jul 6, 2012 – Jul 29, 2012 Framebuffer layer

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH v2 1/1 da8xx-fb: add missing FB_BLANK operations

From: Yegor Yefremov <[email protected]>

add FB_BLANK_NORMAL, FB_BLANK_VSYNC_SUSPEND and FB_BLANK_HSYNC_SUSPEND modes (copy drivers/video/omap2/omapfb/omapfb-main.c implementation). Otherwise X-server will complain about invalid parameter.

Signed-off-by Yegor Yefremov <[email protected]>

---
v2: add linux-fbdev as recipient

 drivers/video/da8xx-fb.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/da8xx-fb.c +3 -0
index 47118c7..8d745bf 100644
@@ -1026,6 +1026,9 @@ static int cfb_blank(int blank, struct fb_info *info)
 
 		lcd_enable_raster();
 		break;
+	case FB_BLANK_NORMAL:
+	case FB_BLANK_VSYNC_SUSPEND:
+	case FB_BLANK_HSYNC_SUSPEND:
 	case FB_BLANK_POWERDOWN:
 		if (par->panel_power_ctrl)
 			par->panel_power_ctrl(0);
Signature · 1 line
1.7.7
author
#1 lore raw

PATCH v2 1/1 da8xx-fb: add missing FB_BLANK operations

Quoted 28 lines · On Fri, Jul 6, 2012 at 4:01 PM, <[email protected]> wrote:

From: Yegor Yefremov <[email protected]>

add FB_BLANK_NORMAL, FB_BLANK_VSYNC_SUSPEND and FB_BLANK_HSYNC_SUSPEND modes (copy drivers/video/omap2/omapfb/omapfb-main.c implementation). Otherwise X-server will complain about invalid parameter.

Signed-off-by Yegor Yefremov <[email protected]>

---
v2: add linux-fbdev as recipient

 drivers/video/da8xx-fb.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/da8xx-fb.c +3 -1
index 47118c7..8d745bf 100644
@@ -1026,6 +1026,9 @@ static int cfb_blank(int blank, struct fb_info *info)
 
                lcd_enable_raster();
                break;
+       case FB_BLANK_NORMAL:
+       case FB_BLANK_VSYNC_SUSPEND:
+       case FB_BLANK_HSYNC_SUSPEND:
        case FB_BLANK_POWERDOWN:
                if (par->panel_power_ctrl)
                        par->panel_power_ctrl(0);
--
Quoted 2 lines

1.7.7

Were is possible to get this patch into 3.6?

Thanks.

Yegor

Applied
#2 lore raw

PATCH v2 1/1 da8xx-fb: add missing FB_BLANK operations

In reply to yegorslists at googlemail.com
Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

add FB_BLANK_NORMAL, FB_BLANK_VSYNC_SUSPEND and FB_BLANK_HSYNC_SUSPEND modes (copy drivers/video/omap2/omapfb/omapfb-main.c implementation). Otherwise X-server will complain about invalid parameter.

Signed-off-by Yegor Yefremov <[email protected]>

Applied.

Thanks,

Florian Tobias Schandinat

Quoted 20 lines

---
v2: add linux-fbdev as recipient

 drivers/video/da8xx-fb.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/da8xx-fb.c +3 -0
index 47118c7..8d745bf 100644
@@ -1026,6 +1026,9 @@ static int cfb_blank(int blank, struct fb_info *info)
 
 		lcd_enable_raster();
 		break;
+	case FB_BLANK_NORMAL:
+	case FB_BLANK_VSYNC_SUSPEND:
+	case FB_BLANK_HSYNC_SUSPEND:
 	case FB_BLANK_POWERDOWN:
 		if (par->panel_power_ctrl)
 			par->panel_power_ctrl(0);