Skip to contentSkip to conversation

km/common: remove printfs for i2c deblocking code

PATCH New Gerlando Falauto 3 participants 4 messages Jul 27, 2012 – Jul 30, 2012

lore
Share & tools
lore

Gerlando Falauto

author
#0 lore raw

PATCH 1/1 km/common: remove printfs for i2c deblocking code

From: Holger Brunck <[email protected]>

This code will also be used before reallocation and during this time we are not allowed to do these printings.

Signed-off-by Holger Brunck <[email protected]>
---
 board/keymile/common/common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
board/keymile/common/common.c +0 -3
index 1013f42..a90f112 100644
@@ -151,7 +151,6 @@ int i2c_make_abort(void)
 			sda_state = get_sda();
 			if (scl_state && sda_state) {
 				ret = 0;
-				printf("[INFO] i2c abort after %d clocks\n", i);
 				break;
 			}
 		}

@@ -159,8 +158,6 @@ int i2c_make_abort(void)
 	if (ret == 0)
 		for (i = 0; i < 5; i++)
 			i2c_write_start_seq();
-	else
-		printf("[ERROR] i2c abort failed\n");
 
 	/* respect stop setup time */
 	udelay(DELAY_ABORT_SEQ);
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 km/common: remove printfs for i2c deblocking code

Quoted 36 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Gerlando Falauto
Sent: 27 July 2012 20:28
To: u-boot at lists.denx.de
Cc: Holger Brunck
Subject: [U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

From: Holger Brunck <[email protected]>

This code will also be used before reallocation and during this time we
are not allowed to do these printings.

Signed-off-by Holger Brunck <[email protected]>
---
 board/keymile/common/common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
board/keymile/common/common.c +0 -1
index 1013f42..a90f112 100644
@@ -151,7 +151,6 @@ int i2c_make_abort(void)
 			sda_state = get_sda();
 			if (scl_state && sda_state) {
 				ret = 0;
-				printf("[INFO] i2c abort after %d clocks\n", i);
 				break;
 			}
 		}

board/keymile/common/common.c int i2c_make_abort(void)

Quoted 9 lines
board/keymile/common/common.c +0 -3
@@ -159,8 +158,6 @@ int i2c_make_abort(void)
 	if (ret == 0)
 		for (i = 0; i < 5; i++)
 			i2c_write_start_seq();
-	else
-		printf("[ERROR] i2c abort failed\n");
 
 	/* respect stop setup time */
 	udelay(DELAY_ABORT_SEQ);
--
Acked-by Prafulla Wadaskar <[email protected]>

Regards...
Prafulla . . .

#2 lore raw

PATCH 1/1 km/common: remove printfs for i2c deblocking code

In reply to Gerlando Falauto

Hello Gerlando,

Quoted 9 lines · Gerlando Falauto

From: Holger Brunck<[email protected]>

This code will also be used before reallocation and during this time we are not allowed to do these printings.

Signed-off-by Holger Brunck<[email protected]>
---
  board/keymile/common/common.c |    3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)
Acked-by Heiko Schocher<[email protected]>

@Prafulla: Is it OK for you, if I pick this patch up to my i2c tree?

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 km/common: remove printfs for i2c deblocking code

Quoted 19 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: 30 July 2012 14:53
To: Gerlando Falauto
Cc: u-boot at lists.denx.de; Holger Brunck; Prafulla Wadaskar
Subject: Re: [U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

Hello Gerlando,

Quoted 3 lines · Gerlando Falauto

From: Holger Brunck<[email protected]>

This code will also be used before reallocation and during this time

we

Quoted 2 lines

are not allowed to do these printings.

Quoted 9 lines
Quoted 4 lines
Signed-off-by Holger Brunck<[email protected]>
---
  board/keymile/common/common.c |    3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)
Acked-by Heiko Schocher<[email protected]>

@Prafulla: Is it OK for you, if I pick this patch up to my i2c tree?

Hi Heiko
Yes, I am okay with it, please pick it.

Regards...
Prafulla . . .