Skip to contentSkip to conversation

arm: mmp&dove: modify tauros2_init call

PATCH New Andrew Lunn 4 participants 5 messages Jul 31, 2012 – Aug 4, 2012

lore
Share & tools
lore

Andrew Lunn

author
#0 lore raw

PATCH 6/7 arm: mmp&dove: modify tauros2_init call

Hi Chao

When making changes to Dove, or any other Orion system, please could you CC: the orion maintainers:

ARM/Marvell Dove/Kirkwood/MV78xx0/Orion SOC support

M:      Jason Cooper <[email protected]>
M:      Andrew Lunn <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-dove/
F:      arch/arm/mach-kirkwood/
F:      arch/arm/mach-mv78xx0/
F:      arch/arm/mach-orion5x/
F:      arch/arm/plat-orion/

Does this also affect Armada 370 and Armada XP SOC? I've no idea what cache it uses.

Thanks
Andrew

#1 lore raw

PATCH 6/7 arm: mmp&dove: modify tauros2_init call

Quoted 16 lines · Andrew Lunn

Hi Chao

When making changes to Dove, or any other Orion system, please could you CC: the orion maintainers:

ARM/Marvell Dove/Kirkwood/MV78xx0/Orion SOC support

M:      Jason Cooper <[email protected]>
M:      Andrew Lunn <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-dove/
F:      arch/arm/mach-kirkwood/
F:      arch/arm/mach-mv78xx0/
F:      arch/arm/mach-orion5x/
F:      arch/arm/plat-orion/
Quoted 5 lines

Does this also affect Armada 370 and Armada XP SOC? I've no idea what cache it uses.

Thanks
Andrew

It will impact Armada 370. The patch will make the user has choice to enable extra features of tauros2
I have searched the code, only dove will use tauros2_init, and the tauros2 default has its extra features off, so i directly pass 0x0 for dove

author
#2 lore raw

PATCH 6/7 arm: mmp&dove: modify tauros2_init call

Quoted 17 lines · Chao Xie
Quoted 16 lines · Andrew Lunn

Hi Chao

When making changes to Dove, or any other Orion system, please could you CC: the orion maintainers:

ARM/Marvell Dove/Kirkwood/MV78xx0/Orion SOC support

M:      Jason Cooper <[email protected]>
M:      Andrew Lunn <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-dove/
F:      arch/arm/mach-kirkwood/
F:      arch/arm/mach-mv78xx0/
F:      arch/arm/mach-orion5x/
F:      arch/arm/plat-orion/
Quoted 6 lines
Quoted 5 lines

Does this also affect Armada 370 and Armada XP SOC? I've no idea what cache it uses.

Thanks
Andrew

It will impact Armada 370.

Then please keep Gregory Clement <[email protected]> in the loop as well.

Quoted 5 lines

The patch will make the user has choice to
enable extra features of tauros2
I have searched the code, only dove will use tauros2_init, and the tauros2 default has its extra features off, so i directly pass 0x0 for dove

Can you recommend any benchmark tools, to see if its worth turning on these features? Sebastian Hesselbarth is doing a lot of work on Dove at the moment, so might be interested in investigating this.

Thanks
Andrew

#3 lore raw

PATCH 6/7 arm: mmp&dove: modify tauros2_init call

In reply to Chao Xie
Quoted 17 lines · Chao Xie
Quoted 16 lines · Andrew Lunn

Hi Chao

When making changes to Dove, or any other Orion system, please could you CC: the orion maintainers:

ARM/Marvell Dove/Kirkwood/MV78xx0/Orion SOC support

M:      Jason Cooper <[email protected]>
M:      Andrew Lunn <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-dove/
F:      arch/arm/mach-kirkwood/
F:      arch/arm/mach-mv78xx0/
F:      arch/arm/mach-orion5x/
F:      arch/arm/plat-orion/
Quoted 7 lines
Quoted 5 lines

Does this also affect Armada 370 and Armada XP SOC? I've no idea what cache it uses.

Thanks
Andrew

It will impact Armada 370. The patch will make the user has choice to enable extra features of tauros2

As far as I know it wouldn't impact the Armada370 as it use an other L2 called Aurora. We are currently working on it to submit it really soon. The ArmadaXP also use the Aurora L2 cache controller.

Quoted 4 lines

I have searched the code, only dove will use tauros2_init, and the tauros2 default has its extra features off, so i directly pass 0x0 for dove

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 6/7 arm: mmp&dove: modify tauros2_init call

Quoted 21 lines · Gregory CLEMENT
Quoted 20 lines · Chao Xie
Quoted 19 lines · Andrew Lunn

Hi Chao

When making changes to Dove, or any other Orion system, please could you CC: the orion maintainers:

ARM/Marvell Dove/Kirkwood/MV78xx0/Orion SOC support

M:      Jason Cooper <[email protected]>
M:      Andrew Lunn <[email protected]>
L:      linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S:      Maintained
F:      arch/arm/mach-dove/
F:      arch/arm/mach-kirkwood/
F:      arch/arm/mach-mv78xx0/
F:      arch/arm/mach-orion5x/
F:      arch/arm/plat-orion/

Does this also affect Armada 370 and Armada XP SOC? I've no idea what cache it uses.

Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

Thanks
Andrew

It will impact Armada 370. The patch will make the user has choice to enable extra features of tauros2

As far as I know it wouldn't impact the Armada370 as it use an other L2 called Aurora. We are currently working on it to submit it really soon. The ArmadaXP also use the Aurora L2 cache controller.

OK. I'll merge these patches.

Regards
Haojian