Skip to contentSkip to conversation

ti-test-extras: add package group for large tests

PATCH In review [email protected] 3 participants 4 messages Jun 15, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-test-extras: add package group for large tests

From: Randolph Sapp <[email protected]>

This is required for images that expect ti-test to be installed but actually use a ramdisk for primary storage. Piglit and the corresponding cts tests are the real problems at the moment so we're moving those first. Other tests may follow.

---
 .../recipes-core/images/tisdk-default-image.bb   |  1 +
 .../recipes-core/packagegroups/ti-test-extras.bb | 16 ++++++++++++++++
 .../recipes-core/packagegroups/ti-test.bb        |  3 ---
 3 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index 3b9747c1..bb825e09 100644
@@ -12,6 +12,7 @@ IMAGE_INSTALL += "\
     packagegroup-arago-console \
     packagegroup-arago-base-tisdk \
     ti-test \
+    ti-test-extras \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-qte','',d)} \
meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb new file +16 -0
new file mode 100644
index 00000000..6d69b165
@@ -0,0 +1,16 @@
+SUMMARY = "TI Testing packagegroup for big tests"
+LICENSE = "MIT"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+ARAGO_TEST_EXTRAS = "\
+    piglit \
+    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
+"
+
+RDEPENDS:${PN} = "\
+    ${ARAGO_TEST_EXTRAS} \
+"
meta-arago-distro/recipes-core/packagegroups/ti-test.bb +0 -3
index 210bc5a9..3e45077b 100644
@@ -38,9 +38,6 @@ ARAGO_TEST = "\
     nbench-byte \
     stream \
     cryptodev-tests \
-    piglit \
-    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
 "
 
 ARAGO_TEST:append:armv7a = " \
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · On Thu, Jun 15, 2023 at 12:28:07PM -0500, [email protected] wrote:

From: Randolph Sapp <[email protected]>

This is required for images that expect ti-test to be installed but actually use a ramdisk for primary storage. Piglit and the corresponding cts tests are the real problems at the moment so we're moving those first. Other tests may follow.

Why not make it a single packagegroup recipe producing 2 packages? Other packagegroups already doing it - tisdk-matrix, tisdk-addons, tisdk-opencl.

Quoted 58 lines
---
 .../recipes-core/images/tisdk-default-image.bb   |  1 +
 .../recipes-core/packagegroups/ti-test-extras.bb | 16 ++++++++++++++++
 .../recipes-core/packagegroups/ti-test.bb        |  3 ---
 3 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb
meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index 3b9747c1..bb825e09 100644
@@ -12,6 +12,7 @@ IMAGE_INSTALL += "\
     packagegroup-arago-console \
     packagegroup-arago-base-tisdk \
     ti-test \
+    ti-test-extras \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
     ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-qte','',d)} \
meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb new file +16 -0
new file mode 100644
index 00000000..6d69b165
@@ -0,0 +1,16 @@
+SUMMARY = "TI Testing packagegroup for big tests"
+LICENSE = "MIT"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+ARAGO_TEST_EXTRAS = "\
+    piglit \
+    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
+"
+
+RDEPENDS:${PN} = "\
+    ${ARAGO_TEST_EXTRAS} \
+"
meta-arago-distro/recipes-core/packagegroups/ti-test.bb +0 -3
index 210bc5a9..3e45077b 100644
@@ -38,9 +38,6 @@ ARAGO_TEST = "\
     nbench-byte \
     stream \
     cryptodev-tests \
-    piglit \
-    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
 "
 
 ARAGO_TEST:append:armv7a = " \
Signature · 1 line
2.41.0
#2 lore raw
Quoted 10 lines · Denys Dmytriyenko
Quoted 6 lines · On Thu, Jun 15, 2023 at 12:28:07PM -0500, [email protected] wrote:

From: Randolph Sapp <[email protected]>

This is required for images that expect ti-test to be installed but actually use a ramdisk for primary storage. Piglit and the corresponding cts tests are the real problems at the moment so we're moving those first. Other tests may follow.

Why not make it a single packagegroup recipe producing 2 packages? Other packagegroups already doing it - tisdk-matrix, tisdk-addons, tisdk-opencl.

In the longer term, I want to move to this. But this is an "emergency" patch to try and fix a test issue for the CICD flow. I'll migrate this to that new style after we get a promotion.

Quoted 59 lines
Quoted 59 lines
---
  .../recipes-core/images/tisdk-default-image.bb   |  1 +
  .../recipes-core/packagegroups/ti-test-extras.bb | 16 ++++++++++++++++
  .../recipes-core/packagegroups/ti-test.bb        |  3 ---
  3 files changed, 17 insertions(+), 3 deletions(-)

create mode 100644 meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb

meta-arago-distro/recipes-core/images/tisdk-default-image.bb +1 -0
index 3b9747c1..bb825e09 100644
@@ -12,6 +12,7 @@ IMAGE_INSTALL += "\
      packagegroup-arago-console \
      packagegroup-arago-base-tisdk \
      ti-test \
+    ti-test-extras \
      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \
      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \
      ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-qte','',d)} \
meta-arago-distro/recipes-core/packagegroups/ti-test-extras.bb new file +16 -0
new file mode 100644
index 00000000..6d69b165
@@ -0,0 +1,16 @@
+SUMMARY = "TI Testing packagegroup for big tests"
+LICENSE = "MIT"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+ARAGO_TEST_EXTRAS = "\
+    piglit \
+    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
+"
+
+RDEPENDS:${PN} = "\
+    ${ARAGO_TEST_EXTRAS} \
+"
meta-arago-distro/recipes-core/packagegroups/ti-test.bb +0 -3
index 210bc5a9..3e45077b 100644
@@ -38,9 +38,6 @@ ARAGO_TEST = "\
      nbench-byte \
      stream \
      cryptodev-tests \
-    piglit \
-    ${@bb.utils.contains("DISTRO_FEATURES", "opengl", "opengl-es-cts", "", d)} \
-    ${@bb.utils.contains("DISTRO_FEATURES", "vulkan", "vulkan-cts", "", d)} \
  "
 
  ARAGO_TEST:append:armv7a = " \
Signature · 1 line
2.41.0
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#3 lore raw
Quoted 9 lines · Ryan Eatmon
Quoted 8 lines · Denys Dmytriyenko
Quoted 6 lines · On Thu, Jun 15, 2023 at 12:28:07PM -0500, [email protected] wrote:

From: Randolph Sapp <[email protected]>

This is required for images that expect ti-test to be installed but actually use a ramdisk for primary storage. Piglit and the corresponding cts tests are the real problems at the moment so we're moving those first. Other tests may follow.

Quoted 5 lines
Quoted 2 lines

Why not make it a single packagegroup recipe producing 2 packages? Other packagegroups already doing it - tisdk-matrix, tisdk-addons, tisdk-opencl.

In the longer term, I want to move to this.  But this is an "emergency" patch to try and fix a test issue for the CICD flow.  I'll migrate this to that new style after we get a promotion.

I assumed the standard was one file per package group. If that's incorrect then I'll fix it.