meta: New Crystal Forest Machine Branch

PATCH In review [email protected] 3 participants 8 messages Aug 2, 2012 – Aug 3, 2012

lore

Share & tools

lore

[email protected]

author

2012-08-02 18:35 UTC #0 lore raw

cover meta: New Crystal Forest Machine Branch

From: Kishore Bodke <[email protected]>

Hi,

This is a revised patch set is for creating the new Crystal Forest Machine. Crystal Forest Machine is Sandybridge CPU with Cave Creek Chipset.

This machine is based on standard/default/common-pc-64.

Please create a new branch called standard/default/common-pc-64/crystalforest for linux-yocto-3.4 kernel and push this new meta branch.

Thanks
Kishore.

The following changes since commit 459165c1dd61c4e843c36e6a1abeb30949a20ba7:

kconf: add 8250 Kconfig to hardware listing audit (2012-07-26 16:23:26 -0400)

are available in the git repository at:

git://git.pokylinux.org/linux-yocto-2.6.37-contrib kishore/meta-crystalforest
http://git.pokylinux.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=kishore/meta-crystalforest

Kishore Bodke (1):
meta: Crystal Forest Machine Created.

 .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
 .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
 .../bsp/crystalforest/crystalforest.cfg            |   32 ++++++++++++++++++++
 .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-preempt-rt.scc
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-standard.scc
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.cfg
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc

Signature · 1 line

1.7.9.5

[email protected]

author

2012-08-02 18:35 UTC #1 lore raw

PATCH 1/1 meta: Crystal Forest Machine Created.

From: Kishore Bodke <[email protected]>

Initial checkin for the new Crystal Forest Machine Branch. This Machine is based on Sandybridge CPU and Cave Creek Chipset.

Signed-off-by Kishore Bodke <[email protected]>

---
 .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
 .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
 .../bsp/crystalforest/crystalforest.cfg            |   32 ++++++++++++++++++++
 .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-preempt-rt.scc
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-standard.scc
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.cfg
 create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-preempt-rt.scc new file +9 -0

new file mode 100644
index 0000000..88e9b1a
@@ -0,0 +1,9 @@
+define KMACHINE crystalforest
+define KTYPE preempt-rt
+define KARCH x86_64
+
+# no new branch required, re-use the ktypes/preempt-rt branch
+include ktypes/preempt-rt
+include bsp/common-pc-64/common-pc-64.scc
+
+include crystalforest.scc

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-standard.scc new file +8 -0

new file mode 100644
index 0000000..2935387
@@ -0,0 +1,8 @@
+define KMACHINE crystalforest
+define KTYPE standard
+define KARCH x86_64
+
+include bsp/common-pc-64/common-pc-64-standard
+branch crystalforest
+
+include crystalforest.scc

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.cfg new file +32 -0

new file mode 100644
index 0000000..542f600
@@ -0,0 +1,32 @@
+CONFIG_PRINTK=y
+
+# Basic hardware support for the box - network, PCI, sound
+CONFIG_NETDEVICES=y
+CONFIG_ATA=y
+CONFIG_ATA_GENERIC=y
+CONFIG_ATA_SFF=y
+CONFIG_PCI=y
+CONFIG_MMC=y
+CONFIG_MMC_SDHCI=y
+CONFIG_R8169=y
+CONFIG_PATA_SCH=y
+CONFIG_MMC_SDHCI_PCI=y
+CONFIG_PCIEPORTBUS=y
+CONFIG_NET=y
+CONFIG_CHR_DEV_SG=y
+CONFIG_SOUND=y
+CONFIG_SND=y
+CONFIG_SND_HDA_INTEL=y
+
+# Make sure these are on, otherwise the bootup won't be fun
+CONFIG_UNIX=y
+CONFIG_INET=y
+CONFIG_MODULES=y
+CONFIG_SHMEM=y
+CONFIG_TMPFS=y
+CONFIG_PACKET=y
+
+CONFIG_I2C=y
+CONFIG_AGP=y
+CONFIG_PM=y
+CONFIG_INPUT=y

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc new file +23 -0

new file mode 100644
index 0000000..140a4d5
@@ -0,0 +1,23 @@
+kconf hardware crystalforest.cfg
+
+include cfg/x86_64.scc
+include cfg/8250.scc
+
+include features/i915/i915.scc
+include features/power/intel.scc
+
+#These are required features for Intel DPDK Support
+
+include features/uio/uio.scc
+include features/hugetlb/hugetlb.scc
+include features/ixgbe/ixgbe.scc
+include features/igb/igb.scc
+
+
+include features/latencytop/latencytop.scc
+include features/profiling/profiling.scc
+include features/usb/xhci-hcd.scc
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include cfg/usb-mass-storage.scc
+include cfg/boot-live.scc

Signature · 1 line

1.7.9.5

Darren Hart

2012-08-02 20:01 UTC #2 lore raw

Re: [PATCH 1/1] [KERNEL] meta: Crystal Forest Machine Created.

Looks a lot better. One question still pending from my previous review though:

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc line 6

Quoted 12 lines · On 08/02/2012 11:35 AM, [email protected] wrote:

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc new file +6 -0

new file mode 100644
index 0000000..140a4d5
@@ -0,0 +1,23 @@
+kconf hardware crystalforest.cfg
+
+include cfg/x86_64.scc
+include cfg/8250.scc
+
+include features/i915/i915.scc

Is this (i915) required for the Poulsbo graphics?

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Bodke, Kishore K

author

2012-08-02 20:36 UTC #3 lore raw

Re: [PATCH 1/1] [KERNEL] meta: Crystal Forest Machine Created.

Quoted 16 lines

-----Original Message-----
From: Darren Hart [mailto:[email protected]]
Sent: Thursday, August 02, 2012 1:00 PM
To: Bodke, Kishore K
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 1/1] [KERNEL] meta: Crystal Forest Machine Created.
Looks a lot better. One question still pending from my previous review though:
Review
Quoted 1 line · On 08/02/2012 11:35 AM, [email protected] wrote:
(quoted diff) +0 -0
b/meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc

Quoted 13 lines

meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc line 6
Quoted 11 lines
new file mode 100644
index 0000000..140a4d5
meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc new file +6 -0
@@ -0,0 +1,23 @@
+kconf hardware crystalforest.cfg
+
+include cfg/x86_64.scc
+include cfg/8250.scc
+
+include features/i915/i915.scc
Is this (i915) required for the Poulsbo graphics?

I am not quite sure on this.

Thanks
Kishore.

Quoted 5 lines

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Bruce Ashfield

2012-08-03 15:26 UTC #4 lore raw

In reply to [email protected]

Quoted 11 lines · On 12-08-02 02:35 PM, [email protected] wrote:

From: Kishore Bodke<[email protected]>
Hi,
This is a revised patch set is for creating the new Crystal Forest Machine. Crystal Forest Machine is Sandybridge CPU with Cave Creek Chipset.
This machine is based on standard/default/common-pc-64.
Please create a new branch called standard/default/common-pc-64/crystalforest for linux-yocto-3.4 kernel and push this new meta branch.

I'd rather not push this out right on the M3 pull request deadline, but there is very little risk to it .. so I'm not really opinionated on it.

Can this wait a few days, or do we want/need it in M3 ?

Cheers,

Bruce

Quoted 26 lines

Thanks
Kishore.
The following changes since commit 459165c1dd61c4e843c36e6a1abeb30949a20ba7:
kconf: add 8250 Kconfig to hardware listing audit (2012-07-26 16:23:26 -0400)
are available in the git repository at:
git://git.pokylinux.org/linux-yocto-2.6.37-contrib kishore/meta-crystalforest
http://git.pokylinux.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=kishore/meta-crystalforest
Kishore Bodke (1):
meta: Crystal Forest Machine Created.
  .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
  .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
  .../bsp/crystalforest/crystalforest.cfg            |   32 ++++++++++++++++++++
  .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
  4 files changed, 72 insertions(+)
create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-preempt-rt.scc create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-standard.scc create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.cfg create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc

Darren Hart

2012-08-03 15:57 UTC #5 lore raw

Quoted 10 lines · Bruce Ashfield

Quoted 9 lines · On 12-08-02 02:35 PM, [email protected] wrote:
From: Kishore Bodke<[email protected]>
Hi,
This is a revised patch set is for creating the new Crystal Forest Machine. Crystal Forest Machine is Sandybridge CPU with Cave Creek Chipset.
This machine is based on standard/default/common-pc-64.

Quoted 8 lines

Quoted 2 lines
Please create a new branch called standard/default/common-pc-64/crystalforest for linux-yocto-3.4 kernel and push this new meta branch.
I'd rather not push this out right on the M3 pull request deadline, but there is very little risk to it .. so I'm not really opinionated on it.
Can this wait a few days, or do we want/need it in M3 ?

Kishore still needs to address the i915 question.

--
Darren

Quoted 32 lines

Cheers,
Bruce
Quoted 26 lines
Thanks
Kishore.
The following changes since commit 459165c1dd61c4e843c36e6a1abeb30949a20ba7:
kconf: add 8250 Kconfig to hardware listing audit (2012-07-26 16:23:26 -0400)
are available in the git repository at:
git://git.pokylinux.org/linux-yocto-2.6.37-contrib kishore/meta-crystalforest
http://git.pokylinux.org/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=kishore/meta-crystalforest
Kishore Bodke (1):
meta: Crystal Forest Machine Created.
  .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
  .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
  .../bsp/crystalforest/crystalforest.cfg            |   32 ++++++++++++++++++++
  .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
  4 files changed, 72 insertions(+)
create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-preempt-rt.scc create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest-standard.scc create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.cfg create mode 100644 meta/cfg/kernel-cache/bsp/crystalforest/crystalforest.scc

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Bodke, Kishore K

author

2012-08-03 16:31 UTC #6 lore raw

Quoted 26 lines

-----Original Message-----
From: Darren Hart [mailto:[email protected]]
Sent: Friday, August 03, 2012 8:56 AM
To: Bruce Ashfield
Cc: Bodke, Kishore K; [email protected]
Subject: Re: [PATCH 0/1] [KERNEL] meta: New Crystal Forest Machine Branch
Quoted 11 lines · Bruce Ashfield
Quoted 10 lines · On 12-08-02 02:35 PM, [email protected] wrote:
From: Kishore Bodke<[email protected]>
Hi,
This is a revised patch set is for creating the new Crystal Forest Machine. Crystal Forest Machine is Sandybridge CPU with Cave Creek Chipset.
This machine is based on standard/default/common-pc-64.
Please create a new branch called standard/default/common-pc-
64/crystalforest
Quoted 2 lines
Quoted 1 line
for linux-yocto-3.4 kernel and push this new meta branch.

Quoted 8 lines

Quoted 5 lines
I'd rather not push this out right on the M3 pull request deadline, but there is very little risk to it .. so I'm not really opinionated on it.
Can this wait a few days, or do we want/need it in M3 ?
Kishore still needs to address the i915 question.

Hi Bruce,

This could wait until after M3, if it has to.

Hi Darren,

I have no idea if i915 is needed, I just derived from Romley since this is close to it.
I can try without this feature, but I would still keep it until I test with all the 4 different versions of Crystal Forest Boards and remove it if it is not needed.

Thanks
Kishore.

Quoted 50 lines

--
Darren
Quoted 10 lines
Cheers,
Bruce
Quoted 5 lines
Thanks
Kishore.
The following changes since commit
459165c1dd61c4e843c36e6a1abeb30949a20ba7:
Quoted 2 lines
Quoted 2 lines
kconf: add 8250 Kconfig to hardware listing audit (2012-07-26 16:23:26 -
0400)
Quoted 4 lines
Quoted 4 lines
are available in the git repository at:
   git://git.pokylinux.org/linux-yocto-2.6.37-contrib kishore/meta-
crystalforest
Quoted 1 line
Quoted 1 line
   http://git.pokylinux.org/cgit.cgi/linux-yocto-2.6.37-
contrib/log/?h=kishore/meta-crystalforest
Quoted 7 lines
Quoted 7 lines
Kishore Bodke (1):
meta: Crystal Forest Machine Created.
  .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
  .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
  .../bsp/crystalforest/crystalforest.cfg            |   32
++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
  .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
  4 files changed, 72 insertions(+)
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest-preempt-rt.scc
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest-standard.scc
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest.cfg
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest.scc
Quoted 2 lines
Quoted 1 line
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Darren Hart

2012-08-03 16:52 UTC #7 lore raw

Quoted 38 lines · Kishore K

Quoted 26 lines
-----Original Message-----
From: Darren Hart [mailto:[email protected]]
Sent: Friday, August 03, 2012 8:56 AM
To: Bruce Ashfield
Cc: Bodke, Kishore K; [email protected]
Subject: Re: [PATCH 0/1] [KERNEL] meta: New Crystal Forest Machine Branch
Quoted 11 lines · Bruce Ashfield
Quoted 10 lines · On 12-08-02 02:35 PM, [email protected] wrote:
From: Kishore Bodke<[email protected]>
Hi,
This is a revised patch set is for creating the new Crystal Forest Machine. Crystal Forest Machine is Sandybridge CPU with Cave Creek Chipset.
This machine is based on standard/default/common-pc-64.
Please create a new branch called standard/default/common-pc-
64/crystalforest
Quoted 2 lines
Quoted 1 line
for linux-yocto-3.4 kernel and push this new meta branch.
Quoted 8 lines
Quoted 5 lines
I'd rather not push this out right on the M3 pull request deadline, but there is very little risk to it .. so I'm not really opinionated on it.
Can this wait a few days, or do we want/need it in M3 ?
Kishore still needs to address the i915 question.
Hi Bruce,

Quoted 8 lines

This could wait until after M3, if it has to.
Hi Darren,
I have no idea if i915 is needed, I just derived from Romley since this is close to it. I can try without this feature, but I would still keep it until I test with all the 4 different versions of Crystal Forest Boards and remove it if it is not needed.

You should be able to determine if the i915 hardware is present in your hardware without relying on empirical testing. If you aren't sure, you'll have to dig up the hardware documentation. But we shouldn't get in the habit of enabling a feature because we don't know if it's needed.

--
Darren

Quoted 54 lines

Thanks
Kishore.
Quoted 50 lines
--
Darren
Quoted 10 lines
Cheers,
Bruce
Quoted 5 lines
Thanks
Kishore.
The following changes since commit
459165c1dd61c4e843c36e6a1abeb30949a20ba7:
Quoted 2 lines
Quoted 2 lines
kconf: add 8250 Kconfig to hardware listing audit (2012-07-26 16:23:26 -
0400)
Quoted 4 lines
Quoted 4 lines
are available in the git repository at:
   git://git.pokylinux.org/linux-yocto-2.6.37-contrib kishore/meta-
crystalforest
Quoted 1 line
Quoted 1 line
   http://git.pokylinux.org/cgit.cgi/linux-yocto-2.6.37-
contrib/log/?h=kishore/meta-crystalforest
Quoted 7 lines
Quoted 7 lines
Kishore Bodke (1):
meta: Crystal Forest Machine Created.
  .../bsp/crystalforest/crystalforest-preempt-rt.scc |    9 ++++++
  .../bsp/crystalforest/crystalforest-standard.scc   |    8 +++++
  .../bsp/crystalforest/crystalforest.cfg            |   32
++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
  .../bsp/crystalforest/crystalforest.scc            |   23 ++++++++++++++
  4 files changed, 72 insertions(+)
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest-preempt-rt.scc
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest-standard.scc
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest.cfg
Quoted 1 line
Quoted 1 line
create mode 100644 meta/cfg/kernel-
cache/bsp/crystalforest/crystalforest.scc
Quoted 2 lines
Quoted 1 line
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel