am33xx: default to status = "disabled"?
Hi,
currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by default. However, depending on the actual board dts, only some of the devices should actually be initialized, given that they only make sense if their pins are actually wired on the board.
On other platform, such devices are marked with status = "disabled", and the board files re-enable those they really use by overriding that status again. That approach seems to make sense - shouldn't the same be done in am33xx.dtsi or am I missing something?
Daniel
Quoted 9 lines · Daniel Mack
currently, all devices in
arch/arm/boot/dts/am33xx.dtsiare enabled by default. However, depending on the actual board dts, only some of the devices should actually be initialized, given that they only make sense if their pins are actually wired on the board.On other platform, such devices are marked with status = "disabled", and the board files re-enable those they really use by overriding that status again. That approach seems to make sense - shouldn't the same be done in
am33xx.dtsior am I missing something?
I agree, they should be disabled, at least the serial ports, and probably also the i2c controllers.
Arnd
Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · Daniel Mack
currently, all devices in
arch/arm/boot/dts/am33xx.dtsiare enabled by default. However, depending on the actual board dts, only some of the devices should actually be initialized, given that they only make sense if their pins are actually wired on the board.
Quoted 8 lines
Quoted 4 lines
On other platform, such devices are marked with status = "disabled", and the board files re-enable those they really use by overriding that status again. That approach seems to make sense - shouldn't the same be done in
am33xx.dtsior am I missing something?I agree, they should be disabled, at least the serial ports, and probably also the i2c controllers.
You are right, it needs to be disabled. I will create a patch and submit it.
Thanks,
Vaibhav