mtd: mxc_nand: Fix compiler warnings

PATCH New Dirk Behme 3 participants 7 messages Jul 28, 2012 – Aug 18, 2012

Subsystems (3)

Arm i.MX and Layerscape Memory technology devices (MTD) NAND flash

lore

Share & tools

lore

Dirk Behme

author

2012-07-28 09:05 UTC #0 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

From: Dirk Behme <[email protected]>

Fix the compiler warnings

drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type

Signed-off-by Dirk Behme <[email protected]>

---
 drivers/mtd/nand/mxc_nand.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/mtd/nand/mxc_nand.c +4 -4

index 6acc790..31b125a 100644
@@ -1264,16 +1264,16 @@ static const struct mxc_nand_devtype_data imx51_nand_devtype_data = {
 static const struct of_device_id mxcnd_dt_ids[] = {
 	{
 		.compatible = "fsl,imx21-nand",
-		.data = &imx21_nand_devtype_data,
+		.data = (void *)&imx21_nand_devtype_data,
 	}, {
 		.compatible = "fsl,imx27-nand",
-		.data = &imx27_nand_devtype_data,
+		.data = (void *)&imx27_nand_devtype_data,
 	}, {
 		.compatible = "fsl,imx25-nand",
-		.data = &imx25_nand_devtype_data,
+		.data = (void *)&imx25_nand_devtype_data,
 	}, {
 		.compatible = "fsl,imx51-nand",
-		.data = &imx51_nand_devtype_data,
+		.data = (void *)&imx51_nand_devtype_data,
 	},
 	{ /* sentinel */ }
 };

Signature · 1 line

1.7.7.4

Uwe Kleine-König

2012-07-30 07:34 UTC #1 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

Hello,

Quoted 8 lines · Dirk Behme

From: Dirk Behme <[email protected]>
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type

These should be gone in next already.

Best regards,
Uwe

Signature · 2 lines

Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Dirk Behme

2012-08-04 15:47 UTC #2 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

Quoted 5 lines · Uwe Kleine-K?nig

Hello,
Quoted 2 lines · Dirk Behme
From: Dirk Behme<[email protected]>

Quoted 7 lines

Quoted 6 lines
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type
These should be gone in next already.

Hmm, which next?

I tried linux-next [1] from today (next-20120803, 55fa9961f) and still get

Quoted 1 line

make drivers/mtd/nand/

...
CC drivers/mtd/nand/mxc_nand.o

drivers/mtd/nand/mxc_nand.c:1298: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1301: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1304: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1307: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1310: warning: initialization discards qualifiers from pointer target type
CC drivers/mtd/nand/gpmi-nand/gpmi-nand.o
...

Sorry if I missed something ;)

Best regards

Dirk

[1]
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=shortlog;h=refs/heads/master

Uwe Kleine-König

2012-08-05 08:39 UTC #3 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

Quoted 12 lines · Dirk Behme

Quoted 11 lines · Uwe Kleine-K?nig
Hello,
Quoted 8 lines · Dirk Behme
From: Dirk Behme<[email protected]>
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type

Quoted 5 lines

Quoted 1 line
These should be gone in next already.
Hmm, which next?
I tried linux-next [1] from today (next-20120803, 55fa9961f) and still get

next-20120725 contained 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17, don't konw why it isn't included in the newer next snapshorts.

Best regards
Uwe

Signature · 2 lines

Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Dirk Behme

2012-08-05 10:56 UTC #4 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

Quoted 13 lines · Uwe Kleine-K?nig

Quoted 12 lines · Dirk Behme
Quoted 11 lines · Uwe Kleine-K?nig
Hello,
Quoted 8 lines · Dirk Behme
From: Dirk Behme<[email protected]>
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
These should be gone in next already.
Hmm, which next?
I tried linux-next [1] from today (next-20120803, 55fa9961f) and still get
next-20120725 contained 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17, don't konw why it isn't included in the newer next snapshorts.

First, yes, it was part of next-20120725. Second, I can confirm that the patch [1] fixes the compiler warnings I reported above. So my patch is obsolete now.

And third, strange is the absence in next-20120803 and 3.6-rc1. Do we a chance to find out what's ongoing here? It would be a shame if your patch get lost.

Many thanks

Dirk

[1] https://patchwork.kernel.org/patch/1226851/

Dirk Behme

2012-08-18 09:58 UTC #5 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

In reply to Uwe Kleine-König

Quoted 13 lines · Uwe Kleine-K?nig

Quoted 12 lines · Dirk Behme
Quoted 11 lines · Uwe Kleine-K?nig
Hello,
Quoted 8 lines · Dirk Behme
From: Dirk Behme<[email protected]>
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
These should be gone in next already.
Hmm, which next?
I tried linux-next [1] from today (next-20120803, 55fa9961f) and still get
next-20120725 contained 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17, don't konw why it isn't included in the newer next snapshorts.

It seems to be in -next again:

http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=98d7bbb9929bcc14e11ac8a55245a4f2dc174e17

I'm not so familiar with -next: Do we have any chance to get that commit into 3.6-rcX to get this warning fixed for the final 3.6?

Best regards

Dirk

Uwe Kleine-König

2012-08-18 11:43 UTC #6 lore raw

PATCH 1/1 mtd: mxc_nand: Fix compiler warnings

Hi Dirk,

Quoted 22 lines · Dirk Behme

Quoted 13 lines · Uwe Kleine-K?nig
Quoted 12 lines · Dirk Behme
Quoted 11 lines · Uwe Kleine-K?nig
Hello,
Quoted 8 lines · Dirk Behme
From: Dirk Behme<[email protected]>
Fix the compiler warnings
drivers/mtd/nand/mxc_nand.c:1267: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1270: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1273: warning: initialization discards qualifiers from pointer target type drivers/mtd/nand/mxc_nand.c:1276: warning: initialization discards qualifiers from pointer target type
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
These should be gone in next already.
Hmm, which next?
I tried linux-next [1] from today (next-20120803, 55fa9961f) and still get
next-20120725 contained 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17, don't konw why it isn't included in the newer next snapshorts.

Quoted 6 lines

It seems to be in -next again:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
I'm not so familiar with -next: Do we have any chance to get that commit into 3.6-rcX to get this warning fixed for the final 3.6?

Arnd sent a pull request that Linus T. seems to have ignored so far.

Best regards
Uwe

Signature · 2 lines

Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |