Skip to contentSkip to conversation

brcmsmac: document firmware dependencies

PATCH In review Jeff Mahoney 2 participants 2 messages Aug 6, 2012 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 brcmsmac: document firmware dependencies

The brcmsmac driver requests firmware but doesn't document the dependency. This means that software that analyzes the modules to determine if firmware is needed won't detect it.

Specifically, (at least) openSUSE won't install the kernel-firmware package if no hardware requires it.

This patch adds the MODULE_FIRMWARE directives.

---
 drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c +3 -1
@@ -86,7 +86,9 @@ MODULE_AUTHOR("Broadcom Corporation");
 MODULE_DESCRIPTION("Broadcom 802.11n wireless LAN driver.");
 MODULE_SUPPORTED_DEVICE("Broadcom 802.11n WLAN cards");
 MODULE_LICENSE("Dual BSD/GPL");
-
+/* This needs to be adjusted when brcms_firmwares changes */
+MODULE_FIRMWARE("brcm/bcm43xx-0.fw");
+MODULE_FIRMWARE("brcm/bcm43xx_hdr-0.fw");
  /* recognized BCMA Core IDs */
 static struct bcma_device_id brcms_coreid_table[] = {
 
Signature · 2 lines
Jeff Mahoney
SUSE Labs
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Jeff Mahoney

The brcmsmac driver requests firmware but doesn't document the dependency. This means that software that analyzes the modules to determine if firmware is needed won't detect it.

Specifically, (at least) openSUSE won't install the kernel-firmware package if no hardware requires it.

This patch adds the MODULE_FIRMWARE directives.

Quoted 1 line

Gr. AvS