Skip to contentSkip to conversation

fuse: implement i_op->atomic_open() prevents writes to ntfs-3g filesystem

DISCUSSION Arthur Marsh 3 participants 4 messages Aug 12, 2012 VFS

lore
Share & tools
lore

Arthur Marsh

author
#0 lore raw

[repost, apologies if you see it twice]
I'm running Debian unstable on AMD64 (quad core) with Linus' github.com kernels.

Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started failing, and I bisected back to the following:

# git bisect good
c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
Author: Miklos Szeredi <[email protected]>
Date:   Tue Jun 5 15:10:22 2012 +0200
    fuse: implement i_op->atomic_open()

    Add an ->atomic_open implementation which replaces the atomic

open+create
operation implemented via ->create. No functionality is changed.

Signed-off-by Miklos Szeredi <[email protected]>
Signed-off-by Al Viro <[email protected]>

:040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56 38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs

Has this problem been seen by anyone else?

Is a fix already in the works?

Regards,

Arthur.

#1 lore raw
Quoted 22 lines · Arthur Marsh

[repost, apologies if you see it twice]
I'm running Debian unstable on AMD64 (quad core) with Linus' github.com kernels.

Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started failing, and I bisected back to the following:

# git bisect good
c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
Author: Miklos Szeredi <[email protected]>
Date:   Tue Jun 5 15:10:22 2012 +0200
    fuse: implement i_op->atomic_open()

    Add an ->atomic_open implementation which replaces the atomic

open+create
operation implemented via ->create. No functionality is changed.

Signed-off-by Miklos Szeredi <[email protected]>
Signed-off-by Al Viro <[email protected]>
Quoted 6 lines

:040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56
38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs

Has this problem been seen by anyone else?

Is a fix already in the works?

Adding some CCs.

Signature · 2 lines
Thanks,
//richard
#2 lore raw
In reply to Arthur Marsh
Quoted 19 lines · Arthur Marsh

[repost, apologies if you see it twice]
I'm running Debian unstable on AMD64 (quad core) with Linus' github.com kernels.

Recently (post 3.5.0 kernels) writes to an ntfs-3g filesystem started failing, and I bisected back to the following:

# git bisect good
c8ccbe032feb127a977c66865cb63d72d9a6e08b is the first bad commit
commit c8ccbe032feb127a977c66865cb63d72d9a6e08b
Author: Miklos Szeredi <[email protected]>
Date:   Tue Jun 5 15:10:22 2012 +0200
    fuse: implement i_op->atomic_open()

    Add an ->atomic_open implementation which replaces the atomic

open+create
operation implemented via ->create. No functionality is changed.

Quoted 7 lines
Signed-off-by Miklos Szeredi <[email protected]>
Signed-off-by Al Viro <[email protected]>

:040000 040000 7a000897ad0d1524a7e1cb187bc77d92b8397d56
38f02e55f70b009f8b1149cdd75f571c72406fe4 M fs

Has this problem been seen by anyone else?

Yep, it was reported in Fedora last week.

Quoted 1 line

Is a fix already in the works?

Miklos posted this patch series that fixed things:

http://thread.gmane.org/gmane.linux.file-systems/66445/focus=1339000

josh

author
#3 lore raw

Josh Boyer wrote, on 13/08/12 00:07:

Quoted 1 line

On Sun, Aug 12, 2012 at 9:59 AM, Arthur Marsh

...

Quoted 4 lines
Quoted 1 line

Has this problem been seen by anyone else?

Yep, it was reported in Fedora last week.

Quoted 8 lines
Quoted 1 line

Is a fix already in the works?

Miklos posted this patch series that fixed things:

http://thread.gmane.org/gmane.linux.file-systems/66445/focus=1339000

josh

Thanks, after applying these 4 patches to the current Linus git head, the resulting kernel has no problems creating files with ntfs-3g.

Arthur.