arm/dts: omap4-sdp: Add keypad data
PATCH v7 1/1 arm/dts: omap4-sdp: Add keypad data
Add keypad data node in omap4 device tree file. Also fill the device tree binding parameters with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
---
Changes since v6:
-remove address from the node since reg property is not used.
arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/omap4.dtsi | 5 +++ 2 files changed, 75 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap4-sdp.dts +70 -0
@@ -113,6 +113,76 @@ "DMic", "Digital Mic", "Digital Mic", "Digital Mic1 Bias"; }; + + keypad { + keypad,num-rows = <8>; + keypad,num-columns = <8>; + linux,keymap = < 0x00000012 + 0x00010013 + 0x00020014 + 0x00030066 + 0x0004003f + 0x000500f0 + 0x00060017 + 0x0007002a + 0x01000020 + 0x01010021 + 0x01020022 + 0x010300e7 + 0x01040040 + 0x010500f0 + 0x01060025 + 0x0107001c + 0x0200002d + 0x0201002e + 0x0202002f + 0x0203006b + 0x02040041 + 0x020500f0 + 0x02060034 + 0x0207003a + 0x0300002c + 0x0301004e + 0x03020030 + 0x0303003b + 0x03040042 + 0x030500f0 + 0x03060018 + 0x03070039 + 0x04000011 + 0x04010015 + 0x04020016 + 0x0403003c + 0x04040073 + 0x040500f0 + 0x04060026 + 0x04070069 + 0x0500001f + 0x05010023 + 0x05020024 + 0x0503003d + 0x05040043 + 0x05050072 + 0x05060032 + 0x0507006a + 0x06000010 + 0x0601001e + 0x06020031 + 0x0603009e + 0x0604000e + 0x060500f0 + 0x06060019 + 0x06070067 + 0x07000094 + 0x07010095 + 0x070200ca + 0x070300cb + 0x0704003e + 0x070500f0 + 0x07060160 + 0x0707006c >; + linux,input-no-autorepeat; + }; }; &i2c1 {
arch/arm/boot/dts/omap4.dtsi +5 -0
@@ -296,4 +296,9 @@ ti,hwmods = "dmic"; }; }; + + keypad { + compatible = "ti,omap4-keypad"; + ti,hwmods = "kbd"; + }; };
Signature · 1 line
1.7.1
PATCH v7 1/1 arm/dts: omap4-sdp: Add keypad data
Hi,
Quoted 115 lines · Sourav Poddar
Add keypad data node in omap4 device tree file. Also fill the device tree binding parameters with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
Cc Benoit Cousson <[email protected]>Cc Rob Herring <[email protected]>Cc Grant Likely <[email protected]>Cc Felipe Balbi <[email protected]>Signed-off-by Sourav Poddar <[email protected]>---
Changes since v6:
-remove address from the node since reg property is not used.arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/omap4.dtsi | 5 +++ 2 files changed, 75 insertions(+), 0 deletions(-)arch/arm/boot/dts/omap4-sdp.dts +70
-0@@ -113,6 +113,76 @@ "DMic", "Digital Mic", "Digital Mic", "Digital Mic1 Bias"; }; + + keypad { + keypad,num-rows = <8>; + keypad,num-columns = <8>; + linux,keymap = < 0x00000012 + 0x00010013 + 0x00020014 + 0x00030066 + 0x0004003f + 0x000500f0 + 0x00060017 + 0x0007002a + 0x01000020 + 0x01010021 + 0x01020022 + 0x010300e7 + 0x01040040 + 0x010500f0 + 0x01060025 + 0x0107001c + 0x0200002d + 0x0201002e + 0x0202002f + 0x0203006b + 0x02040041 + 0x020500f0 + 0x02060034 + 0x0207003a + 0x0300002c + 0x0301004e + 0x03020030 + 0x0303003b + 0x03040042 + 0x030500f0 + 0x03060018 + 0x03070039 + 0x04000011 + 0x04010015 + 0x04020016 + 0x0403003c + 0x04040073 + 0x040500f0 + 0x04060026 + 0x04070069 + 0x0500001f + 0x05010023 + 0x05020024 + 0x0503003d + 0x05040043 + 0x05050072 + 0x05060032 + 0x0507006a + 0x06000010 + 0x0601001e + 0x06020031 + 0x0603009e + 0x0604000e + 0x060500f0 + 0x06060019 + 0x06070067 + 0x07000094 + 0x07010095 + 0x070200ca + 0x070300cb + 0x0704003e + 0x070500f0 + 0x07060160 + 0x0707006c >; + linux,input-no-autorepeat; + }; }; &i2c1 {arch/arm/boot/dts/omap4.dtsi +5
-1@@ -296,4 +296,9 @@ ti,hwmods = "dmic"; }; }; + + keypad { + compatible = "ti,omap4-keypad"; + ti,hwmods = "kbd"; + }; }; --
Quoted 2 lines
1.7.1
Any more comments on this patch?
~Sourav
PATCH v7 1/1 arm/dts: omap4-sdp: Add keypad data
Hi Sourav
Quoted 90 lines · Sourav
Hi,
Quoted 87 lines · Sourav Poddar
Add keypad data node in omap4 device tree file. Also fill the device tree binding parameters with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
Cc Benoit Cousson <[email protected]>Cc Rob Herring <[email protected]>Cc Grant Likely <[email protected]>Cc Felipe Balbi <[email protected]>Signed-off-by Sourav Poddar <[email protected]>---
Changes since v6:
-remove address from the node since reg property is not used.arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/omap4.dtsi | 5 +++ 2 files changed, 75 insertions(+), 0 deletions(-)arch/arm/boot/dts/omap4-sdp.dts +60
-0@@ -113,6 +113,76 @@ "DMic", "Digital Mic", "Digital Mic", "Digital Mic1 Bias"; }; + + keypad { + keypad,num-rows = <8>; + keypad,num-columns = <8>; + linux,keymap = < 0x00000012 + 0x00010013 + 0x00020014 + 0x00030066 + 0x0004003f + 0x000500f0 + 0x00060017 + 0x0007002a + 0x01000020 + 0x01010021 + 0x01020022 + 0x010300e7 + 0x01040040 + 0x010500f0 + 0x01060025 + 0x0107001c + 0x0200002d + 0x0201002e + 0x0202002f + 0x0203006b + 0x02040041 + 0x020500f0 + 0x02060034 + 0x0207003a + 0x0300002c + 0x0301004e + 0x03020030 + 0x0303003b + 0x03040042 + 0x030500f0 + 0x03060018 + 0x03070039 + 0x04000011 + 0x04010015 + 0x04020016 + 0x0403003c + 0x04040073 + 0x040500f0 + 0x04060026 + 0x04070069 + 0x0500001f + 0x05010023 + 0x05020024 + 0x0503003d + 0x05040043 + 0x05050072 + 0x05060032 + 0x0507006a + 0x06000010 + 0x0601001e + 0x06020031 + 0x0603009e + 0x0604000e + 0x060500f0 + 0x06060019 + 0x06070067
Quoted 8 lines
arch/arm/boot/dts/omap4-sdp.dts line 183
Quoted 8 lines
arch/arm/boot/dts/omap4-sdp.dts +8
-0+ 0x07000094 + 0x07010095 + 0x070200ca + 0x070300cb + 0x0704003e + 0x070500f0 + 0x07060160 + 0x0707006c >;
I know that the hex value are faster to parse than the explicit information, but maybe you could at least comment each entry?
Otherwise is looks fine to me.
Thanks,
Benoit
Quoted 26 lines
Quoted 20 lines
arch/arm/boot/dts/omap4-sdp.dts +2
-0+ linux,input-no-autorepeat; + }; }; &i2c1 {arch/arm/boot/dts/omap4.dtsi +5
-1@@ -296,4 +296,9 @@ ti,hwmods = "dmic"; }; }; + + keypad { + compatible = "ti,omap4-keypad"; + ti,hwmods = "kbd"; + }; }; --Quoted 2 lines
1.7.1
Any more comments on this patch?
~Sourav
PATCH v7 1/1 arm/dts: omap4-sdp: Add keypad data
Hi Benoit,
Quoted 96 lines · Benoit Cousson
Hi Sourav
Quoted 93 lines · Sourav
Hi,
Quoted 90 lines · Sourav Poddar
Add keypad data node in omap4 device tree file. Also fill the device tree binding parameters with the required value in "omap4-sdp" dts file.
Tested on omap4430 sdp with 3.5-rc6 kernel.
Cc Benoit Cousson <[email protected]>Cc Rob Herring <[email protected]>Cc Grant Likely <[email protected]>Cc Felipe Balbi <[email protected]>Signed-off-by Sourav Poddar <[email protected]>---
Changes since v6:
-remove address from the node since reg property is not used.arch/arm/boot/dts/omap4-sdp.dts | 70 +++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/omap4.dtsi | 5 +++ 2 files changed, 75 insertions(+), 0 deletions(-)arch/arm/boot/dts/omap4-sdp.dts +63
-0@@ -113,6 +113,76 @@ "DMic", "Digital Mic", "Digital Mic", "Digital Mic1 Bias"; }; + + keypad { + keypad,num-rows = <8>; + keypad,num-columns = <8>; + linux,keymap = < 0x00000012 + 0x00010013 + 0x00020014 + 0x00030066 + 0x0004003f + 0x000500f0 + 0x00060017 + 0x0007002a + 0x01000020 + 0x01010021 + 0x01020022 + 0x010300e7 + 0x01040040 + 0x010500f0 + 0x01060025 + 0x0107001c + 0x0200002d + 0x0201002e + 0x0202002f + 0x0203006b + 0x02040041 + 0x020500f0 + 0x02060034 + 0x0207003a + 0x0300002c + 0x0301004e + 0x03020030 + 0x0303003b + 0x03040042 + 0x030500f0 + 0x03060018 + 0x03070039 + 0x04000011 + 0x04010015 + 0x04020016 + 0x0403003c + 0x04040073 + 0x040500f0 + 0x04060026 + 0x04070069 + 0x0500001f + 0x05010023 + 0x05020024 + 0x0503003d + 0x05040043 + 0x05050072 + 0x05060032 + 0x0507006a + 0x06000010 + 0x0601001e + 0x06020031 + 0x0603009e + 0x0604000e + 0x060500f0 + 0x06060019 + 0x06070067 + 0x07000094 + 0x07010095 + 0x070200ca
Quoted 9 lines
Quoted 5 lines
arch/arm/boot/dts/omap4-sdp.dts line 183
Quoted 5 lines
arch/arm/boot/dts/omap4-sdp.dts +5
-0+ 0x070300cb + 0x0704003e + 0x070500f0 + 0x07060160 + 0x0707006c >;I know that the hex value are faster to parse than the explicit information, but maybe you could at least comment each entry?
Yes, will add the comment and post a new version.
Thanks,
Sourav
Quoted 33 lines
Otherwise is looks fine to me.
Thanks,
BenoitQuoted 26 lines
Quoted 20 lines
arch/arm/boot/dts/omap4-sdp.dts +2
-0+ linux,input-no-autorepeat; + }; }; &i2c1 {arch/arm/boot/dts/omap4.dtsi +5
-1@@ -296,4 +296,9 @@ ti,hwmods = "dmic"; }; }; + + keypad { + compatible = "ti,omap4-keypad"; + ti,hwmods = "kbd"; + }; }; --Quoted 2 lines
1.7.1
Any more comments on this patch?
~Sourav